Closed #434.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/434#event-1886763269
New PR (https://github.com/jclouds/jclouds-labs/pull/447) created instead of
this one, as it's quite outdated
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
btrishkin commented on this pull request.
>
- @Nullable
- public abstract List deviceOrDisks();
Yes, AbstractDrive will help a lot in ServerToHardware function implementation
for a new ServerApi version. Gonna keep it then.
--
You are receiving this because you are subscribed to this
nacx commented on this pull request.
>
- @Nullable
- public abstract List deviceOrDisks();
Oh, I see now that inheritance here was there not only to reuse fields but
because the API returns collections with different object types in it.
To avoid having a `List`, which makes the API hard
@btrishkin pushed 1 commit.
904fcbd Server API 2.6 support
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/434/files/28a17e29e26ee710272e19c42d2bd9e2a6f5f1ee..904fcbdb9c8c305f7dd119169ce0eededcaf3599
nacx commented on this pull request.
> @@ -61,7 +61,7 @@
@RequestFilters({ BasicAuthentication.class, OrganisationIdFilter.class })
@Consumes(MediaType.APPLICATION_JSON)
-@Path("/{jclouds.api-version}/server")
+@Path("/2.6/server")
Understood. Let's leave it as-is then for now.
--
You
btrishkin commented on this pull request.
> @@ -61,7 +61,7 @@
@RequestFilters({ BasicAuthentication.class, OrganisationIdFilter.class })
@Consumes(MediaType.APPLICATION_JSON)
-@Path("/{jclouds.api-version}/server")
+@Path("/2.6/server")
Well, we implement them in chunks. This PR covers
nacx commented on this pull request.
> @@ -61,7 +61,7 @@
@RequestFilters({ BasicAuthentication.class, OrganisationIdFilter.class })
@Consumes(MediaType.APPLICATION_JSON)
-@Path("/{jclouds.api-version}/server")
+@Path("/2.6/server")
Do all APIs need to us ethe same version? If so, youd it
btrishkin commented on this pull request.
> @@ -61,7 +61,7 @@
@RequestFilters({ BasicAuthentication.class, OrganisationIdFilter.class })
@Consumes(MediaType.APPLICATION_JSON)
-@Path("/{jclouds.api-version}/server")
+@Path("/2.6/server")
Our API have different implementations for different
nacx requested changes on this pull request.
Some general comments:
* Prefer primitive types when non-nullable.
* Try to avoid null collections; initialize to empty.
* Avoid inheritance as Google Auto does not really support it.
* Declare the fields in the same order they appear in the factory
10 matches
Mail list logo
