Re: [jclouds] JCLOUDS-347 Implement a poor-mans rollback if static nat creation fails (#328)

2014-03-27 Thread Hugo Trippaers
+vm = client.getVirtualMachineApi().getVirtualMachine(vm.getId()); +ListInteger ports = Ints.asList(templateOptions.getInboundPorts()); +if (capabilities.getCloudStackVersion().startsWith(2)) { + logger.debug( setting up IP

Re: [jclouds] JCLOUDS-347 Implement a poor-mans rollback if static nat creation fails (#328)

2014-03-27 Thread Andrew Phillips
+vm = client.getVirtualMachineApi().getVirtualMachine(vm.getId()); +ListInteger ports = Ints.asList(templateOptions.getInboundPorts()); +if (capabilities.getCloudStackVersion().startsWith(2)) { + logger.debug( setting up IP

Re: [jclouds] JCLOUDS-347 Implement a poor-mans rollback if static nat creation fails (#328)

2014-03-27 Thread Andrew Phillips
+logger.trace( static NATed IPAddress(%s) to virtualMachine(%s), ip.getId(), vm.getId()); +vm = client.getVirtualMachineApi().getVirtualMachine(vm.getId()); +ListInteger ports = Ints.asList(templateOptions.getInboundPorts()); +

Re: [jclouds] JCLOUDS-347 Implement a poor-mans rollback if static nat creation fails (#328)

2014-03-27 Thread Hugo Trippaers
+vm = client.getVirtualMachineApi().getVirtualMachine(vm.getId()); +ListInteger ports = Ints.asList(templateOptions.getInboundPorts()); +if (capabilities.getCloudStackVersion().startsWith(2)) { + logger.debug( setting up IP

Re: [jclouds] JCLOUDS-347 Implement a poor-mans rollback if static nat creation fails (#328)

2014-03-27 Thread Hugo Trippaers
+logger.trace( static NATed IPAddress(%s) to virtualMachine(%s), ip.getId(), vm.getId()); +vm = client.getVirtualMachineApi().getVirtualMachine(vm.getId()); +ListInteger ports = Ints.asList(templateOptions.getInboundPorts()); +

Re: [jclouds] JCLOUDS-347 Implement a poor-mans rollback if static nat creation fails (#328)

2014-03-27 Thread Hugo Trippaers
+logger.trace( static NATed IPAddress(%s) to virtualMachine(%s), ip.getId(), vm.getId()); +vm = client.getVirtualMachineApi().getVirtualMachine(vm.getId()); +ListInteger ports = Ints.asList(templateOptions.getInboundPorts()); +

Re: [jclouds] JCLOUDS-347 Implement a poor-mans rollback if static nat creation fails (#328)

2014-03-27 Thread CloudBees pull request builder plugin
[jclouds-pull-requests #710](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/710/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/328#issuecomment-38786336

Re: [jclouds] JCLOUDS-347 Implement a poor-mans rollback if static nat creation fails (#328)

2014-03-27 Thread Andrew Phillips
jclouds-pull-requests #710 SUCCESS [Clean Checkstyle](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/710/violations/). +1 - good to go for me. @nacx @abayer: any open questions? Otherwise, please squash'n'rebase, and then we can merge! --- Reply to this email directly or view it

Re: [jclouds] JCLOUDS-347 Implement a poor-mans rollback if static nat creation fails (#328)

2014-03-27 Thread CloudBees pull request builder plugin
[jclouds-pull-requests #711](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/711/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/328#issuecomment-38786961

Re: [jclouds] JCLOUDS-347 Implement a poor-mans rollback if static nat creation fails (#328)

2014-03-27 Thread CloudBees pull request builder plugin
[jclouds-java-7-pull-requests #1181](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1181/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/328#issuecomment-38787331

Re: [jclouds] JCLOUDS-347 Implement a poor-mans rollback if static nat creation fails (#328)

2014-03-27 Thread Hugo Trippaers
pushed a squashed and rebased patch --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/328#issuecomment-38787615

Re: [jclouds] JCLOUDS-347 Implement a poor-mans rollback if static nat creation fails (#328)

2014-03-27 Thread CloudBees pull request builder plugin
[jclouds-pull-requests #713](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/713/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/328#issuecomment-38791689

Re: [jclouds] JCLOUDS-347 Implement a poor-mans rollback if static nat creation fails (#328)

2014-03-27 Thread CloudBees pull request builder plugin
[jclouds-java-7-pull-requests #1182](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1182/) UNSTABLE Looks like there's a problem with this pull request --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/328#issuecomment-38792131

Re: [jclouds] JCLOUDS-347 Implement a poor-mans rollback if static nat creation fails (#328)

2014-03-27 Thread CloudBees pull request builder plugin
[jclouds-java-7-pull-requests #1183](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1183/) UNSTABLE Looks like there's a problem with this pull request --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/328#issuecomment-38792151

Re: [jclouds] JCLOUDS-347 Implement a poor-mans rollback if static nat creation fails (#328)

2014-03-27 Thread Andrew Phillips
jclouds-java-7-pull-requests #1183 UNSTABLE [Spurious](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/org.apache.jclouds$jclouds-compute/1182/testReport/junit/org.jclouds.compute.util/ConcurrentOpenSocketFinderTest/testChecksSocketsConcurrently/) [test

Re: [jclouds] JCLOUDS-347 Implement a poor-mans rollback if static nat creation fails (#328)

2014-03-27 Thread Andrew Phillips
Committed to [master](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;h=0401959). Thanks, @spark404! @nacx: Do we want to backport this? If so, to which branch(es)? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/328#issuecomment-38794590

Re: [jclouds] JCLOUDS-347 Implement a poor-mans rollback if static nat creation fails (#328)

2014-03-27 Thread BuildHive
[jclouds » jclouds #967](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/967/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub:

Re: [jclouds] JCLOUDS-347 Implement a poor-mans rollback if static nat creation fails (#328)

2014-03-27 Thread Hugo Trippaers
Would be nice to have it backported to the 1.7.x branch. That would make it easier to get it in the next release for jenkins-jclouds i think, but thats up to @abayer. I'm using this patch with a jclouds 1.7.x build at the moment. --- Reply to this email directly or view it on GitHub:

Re: [jclouds] JCLOUDS-347 Implement a poor-mans rollback if static nat creation fails (#328)

2014-03-27 Thread BuildHive
[jclouds » jclouds #968](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/968/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub:

Re: [jclouds] JCLOUDS-347 Implement a poor-mans rollback if static nat creation fails (#328)

2014-03-27 Thread BuildHive
[jclouds » jclouds #969](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/969/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub:

Re: [jclouds] JCLOUDS-347 Implement a poor-mans rollback if static nat creation fails (#328)

2014-03-26 Thread BuildHive
[jclouds » jclouds #953](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/953/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub:

Re: [jclouds] JCLOUDS-347 Implement a poor-mans rollback if static nat creation fails (#328)

2014-03-26 Thread CloudBees pull request builder plugin
[jclouds-pull-requests #697](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/697/) UNSTABLE Looks like there's a problem with this pull request --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/328#issuecomment-38700999

Re: [jclouds] JCLOUDS-347 Implement a poor-mans rollback if static nat creation fails (#328)

2014-03-26 Thread Andrew Phillips
+vm = client.getVirtualMachineApi().getVirtualMachine(vm.getId()); +ListInteger ports = Ints.asList(templateOptions.getInboundPorts()); +if (capabilities.getCloudStackVersion().startsWith(2)) { + logger.debug( setting up IP

Re: [jclouds] JCLOUDS-347 Implement a poor-mans rollback if static nat creation fails (#328)

2014-03-26 Thread Andrew Bayer
+1 - seems saner to me. =) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/328#issuecomment-38753246