Re: [jclouds/jclouds-karaf] JCLOUDS-1156: Shade the jsch-agentproxy-jsch bundle (#77)

> @@ -468,11 +469,6 @@ limitations under the License. > > > > -org.apache.servicemix.bundles > - > org.apache.servicemix.bundles.jsch-agentproxy-jsch > -${jsch.agentproxy.bundle.version} > Nope. It is used here to import the dependency to shade. Ah, OK,

Re: [jclouds/jclouds-cli] Minor branding changes (#32)

Merged to master as [d7aba317](http://git-wip-us.apache.org/repos/asf/jclouds-cli/commit/d7aba317). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-cli/pull/32#issuecomment-245539044

Re: [jclouds/jclouds-cli] Minor branding changes (#32)

Closed #32. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-cli/pull/32#event-782094374

Re: [jclouds/jclouds-karaf] JCLOUDS-1156: Shade the jsch-agentproxy-jsch bundle (#77)

Closed #77. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/77#event-782069903

[jclouds/jclouds-karaf] Added motivation for the bundles module (#80)

We should try to be very clear about the need for these bundles and why we are providing them here. @demobox Can you have a look at the wording? You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-karaf/pull/80 -- Commit Summary -- * Added

[jira] [Commented] (JCLOUDS-1156) jclouds-cli fails to run compute service commands

[ https://issues.apache.org/jira/browse/JCLOUDS-1156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15473255#comment-15473255 ] ASF subversion and git services commented on JCLOUDS-1156: -- Commit

Re: [jclouds/jclouds-karaf] JCLOUDS-1156: Shade the jsch-agentproxy-jsch bundle (#77)

Squashed, rebased, addressed last minor comment and pushed to master as [00ff5d21](http://git-wip-us.apache.org/repos/asf/jclouds-karaf/commit/00ff5d21). Thanks for all the help @demobox! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view

[jira] [Commented] (JCLOUDS-1166) Remove uses of the 'com.google.gson.internal' package

[ https://issues.apache.org/jira/browse/JCLOUDS-1166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15473220#comment-15473220 ] Ignasi Barrera commented on JCLOUDS-1166: - Another option would be to re-create the bundle

[jira] [Resolved] (JCLOUDS-1156) jclouds-cli fails to run compute service commands

[ https://issues.apache.org/jira/browse/JCLOUDS-1156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera resolved JCLOUDS-1156. - Resolution: Fixed Fix Version/s: 2.0.0 > jclouds-cli fails to run compute

Re: [jclouds/jclouds-karaf] Try to use an OSGi-compliant way of loading JSR 223 script engines (#79)

> @@ -0,0 +1,79 @@ > +/* > Do you plan to re-style the classes to align them to our coding style and > change them to cleanup the code? I think we should certainly align the code style; not sure about more comprehensive re-writes, though. Agree that we should change the functionality (esp.

Re: [jclouds/jclouds-karaf] Try to use an OSGi-compliant way of loading JSR 223 script engines (#79)

>private final ScriptEngine scriptEngine; > >/** > * Constructor > * @param engine > */ > - public ScriptEngineShellTable(String engine) { > -this.engine = engine; > -this.scriptEngine = scriptEngineFactory.getEngineByName(engine); > + public

Re: [jclouds/jclouds-cli] Minor branding changes (#32)

> Good find. Agreed - looks good to me, too. Thanks for taking care of that, Ignasi! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-cli/pull/32#issuecomment-245503249

Re: [jclouds/jclouds-karaf] Try to use an OSGi-compliant way of loading JSR 223 script engines (#79)

> I've just tried a rebased version of this branch on top of the shade one and > everything works fine! :) @nacx Nice! Agree with most of your comments - please feel free to add commits to this branch with any changes you think would make sense. Thanks for taking a look, and for testing! --

Re: [jclouds/jclouds-karaf] Try to use an OSGi-compliant way of loading JSR 223 script engines (#79)

> @@ -51,9 +47,7 @@ public String evaluate(Object obj, String expression) { > try { >scriptEngine.put(getType(), obj); >result = String.valueOf(scriptEngine.eval(expression)); > -} catch (Exception ex) { > - //Ignore > -} > +} catch (Exception ignored) {} >

Re: [jclouds/jclouds-cli] Misc cleanup (#31)

> @@ -137,13 +137,13 @@ > > false > > - > +

Re: [jclouds/jclouds-karaf] JCLOUDS-1156: Shade the jsch-agentproxy-jsch bundle (#77)

Thanks for the updates, @nacx! [This minor comment](https://github.com/jclouds/jclouds-karaf/pull/77/files/c2ec97b044018464a713d89b65edb342703af918#r77740874) would be the only one I still have, but that could be taken care of during the merge, or ignored. Looks good to me! -- You are

Re: [jclouds/jclouds-karaf] Added motivation for the bundles module (#80)

> @@ -0,0 +1,10 @@ > +Apache jclouds-karaf bundles > + > + > +This module provides convenience bundles to let jclouds run properly in OSGi > environments. > +Some of the bundles contained here are not publicly available, and others > are just repackaged > +to make

Re: [jclouds/jclouds-karaf] Added motivation for the bundles module (#80)

@nacx pushed 1 commit. ac1671b Addressed review comments -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/80/files/8aef8a6f4def37a190a13238c7ec1856181d02df..ac1671bfca796992f2c83020f3e69d2bf0673b82

Re: [jclouds/jclouds-karaf] Try to use an OSGi-compliant way of loading JSR 223 script engines (#79)

> @@ -0,0 +1,79 @@ > +/* Regarding licensing, according to [this](http://www.apache.org/legal/src-headers.html#3party) and [this](http://www.apache.org/legal/src-headers.html#notice), we should be good to go. Although it is not the right header for software developed at Apache (that is a

Re: [jclouds/jclouds-karaf] Added motivation for the bundles module (#80)

>where is this less likely to go out-of-date, do you think - in a README or as >comments in the respective POM files? Agree with the approach of putting the details in each pom.xml and keeping the README generic. Changes done! -- You are receiving this because you are subscribed to this

Re: [jclouds/jclouds-karaf] Try to use an OSGi-compliant way of loading JSR 223 script engines (#79)

> @@ -51,9 +47,7 @@ public String evaluate(Object obj, String expression) { > try { >scriptEngine.put(getType(), obj); >result = String.valueOf(scriptEngine.eval(expression)); > -} catch (Exception ex) { > - //Ignore > -} > +} catch (Exception ignored) {} >

Re: [jclouds/jclouds] JCLOUDS-1122: Support subnetworks definitions in Google Compute. (#1006)

> @@ -82,6 +83,10 @@ > @Path("/stop") > Operation stopInstance(@EndpointParam URI selfLink); > > + @Named("Subnetworks:get") > + @GET > + @Fallback(NullOnNotFoundOr404.class) @Nullable Subnetwork > subnetwork(@EndpointParam URI selfLink); This method is not used. Remove it? --

Re: [jclouds/jclouds] JCLOUDS-1122: Support subnetworks definitions in Google Compute. (#1006)

> @@ -126,7 +124,7 @@ Operation createInIPv4Range(@PayloadParam("name") String > networkName, > @Transform(NetworkPages.class) > Iterator list(ListOptions options); > > - static final class NetworkPages extends BaseToIteratorOfListPage NetworkPages> { > + final

Re: [jclouds/jclouds] JCLOUDS-1122: Support subnetworks definitions in Google Compute. (#1006)

> > /** > * This must be within the range specified by IPv4Range, and is typically > the first usable address in that range. > * If not specified, the default value is the first usable address in > IPv4Range. > */ > @Nullable public abstract String gatewayIPv4(); > > -

Re: [jclouds/jclouds] JCLOUDS-1122: Support subnetworks definitions in Google Compute. (#1006)

>@SerializedNames({ "network", "accessConfigs" }) >static NetworkInterface create(URI network, List > accessConfigs) { > - return new AutoValue_NewInstance_NetworkInterface(network, > accessConfigs); > + return new AutoValue_NewInstance_NetworkInterface(network,

Re: [jclouds/jclouds] JCLOUDS-1122: Support subnetworks definitions in Google Compute. (#1006)

> @@ -136,11 +136,17 @@ >URI network = URI.create(networks.next()); >assert !networks.hasNext() : "Error: Options should specify only one > network"; > > + Iterator subnetworks = options.getSubnetworks().iterator(); > + > + URI subnetwork = subnetworks.hasNext() ? >

Re: [jclouds/jclouds] JCLOUDS-1122: Support subnetworks definitions in Google Compute. (#1006)

> + > + @Inject > + SubnetworkLoader(Resources resources) { > + this.resources = resources; > + } > + > + @Override > + public Subnetwork load(URI key) throws ExecutionException { > + try { > + return resources.subnetwork(key); > + } catch (Exception e) { > +

Re: [jclouds/jclouds] JCLOUDS-1122: Support subnetworks definitions in Google Compute. (#1006)

> +@Singleton > +public class SubnetworkLoader extends CacheLoader { > + @Resource > + protected Logger logger = Logger.NULL; > + > + private final Resources resources; > + > + @Inject > + SubnetworkLoader(Resources resources) { > + this.resources = resources; > +

Re: [jclouds/jclouds] JCLOUDS-1122: Support subnetworks definitions in Google Compute. (#1006)

> @@ -32,6 +35,7 @@ > private List serviceAccounts; > private String bootDiskType; > private boolean preemptible = false; > + private Set subnetworks; Change to just `URI subnetwork`, as mentioned above? -- You are receiving this because you are subscribed to this thread. Reply to

Re: [jclouds/jclouds] JCLOUDS-1122: Support subnetworks definitions in Google Compute. (#1006)

Thanks @nelsonjr! This looks great. Just a couple comments apart from the inline ones: * Add mock tests for the methods added to the aggregated list api. * Add live tests for the subnetworks api and the new methods in the aggregated list api. These ones are specially important, since they warn

Re: [jclouds/jclouds] JCLOUDS-1122: Support subnetworks definitions in Google Compute. (#1006)

> + assertSent(server, "DELETE", > "/projects/party/regions/someregion/subnetworks/jclouds-test"); > + } > + > + public void list() throws Exception { > + server.enqueue(jsonResponse("/subnetwork_list.json")); > + > + assertEquals(subnetworkApi().list().next(), new >

Re: [jclouds/jclouds] JCLOUDS-1122: Support subnetworks definitions in Google Compute. (#1006)

> + this.resources = resources; > + } > + > + @Override > + public Subnetwork load(URI key) throws ExecutionException { > + try { > + return resources.subnetwork(key); > + } catch (Exception e) { > + throw new ExecutionException(message(key, e), e); > + }

[jclouds/jclouds] JCLOUDS-1161: Make AWSS3BlobRequestSignerV4 the default signer. (#1008)

Fix unit tests accordingly. You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/1008 -- Commit Summary -- * JCLOUDS-1161: Make AWSS3BlobRequestSignerV4 the default signer. -- File Changes -- M

Re: [jclouds/jclouds-labs] Pb compute api (#292)

> +import org.jclouds.compute.domain.Hardware; > +import org.jclouds.compute.domain.Image; > +import org.jclouds.compute.domain.NodeMetadata; > +import org.jclouds.compute.domain.Volume; > +import org.jclouds.domain.Location; > +import org.jclouds.functions.IdentityFunction; > +import

Re: [jclouds/jclouds-karaf] Try to use an OSGi-compliant way of loading JSR 223 script engines (#79)

> @@ -0,0 +1,79 @@ > +/* +1! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/79/files/0b99dad1aa7786eaf11028bf91fc1d272c189f0b#r78129943

Re: [jclouds/jclouds-karaf] Try to use an OSGi-compliant way of loading JSR 223 script engines (#79)

> @@ -0,0 +1,79 @@ > +/* > No changes to the notice file should be required as the copyright owner of > the copied files is already the ASF. Ah, good to know. Then I think we should be OK just to reformat and perhaps tweak the style where applicable? -- You are receiving this because you are

Re: [jclouds/jclouds-karaf] Added motivation for the bundles module (#80)

+1 - looks good to me. Thanks, @nacx! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/80#issuecomment-245798899