@nacx Reformatted and added the ISE if the requested engine can't be loaded.
Please take a look to see there's anything that still needs to be changed!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@nacx Updated with some additional changes
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/79#issuecomment-246219889
Just two final comments, but LGTM!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/79#issuecomment-246199894
@nacx Good to close this?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/78#issuecomment-246185494
>private final ScriptEngine scriptEngine;
>
>/**
> * Constructor
> * @param engine
> */
> - public ScriptEngineShellTable(String engine) {
> -this.engine = engine;
> -this.scriptEngine = scriptEngineFactory.getEngineByName(engine);
> + public
> @@ -51,8 +52,9 @@ public String evaluate(Object obj, String expression) {
> try {
>scriptEngine.put(getType(), obj);
>result = String.valueOf(scriptEngine.eval(expression));
> -} catch (Exception ex) {
> - //Ignore
> +} catch (Exception exception) {
> +
>private final ScriptEngine scriptEngine;
>
>/**
> * Constructor
> * @param engine
> */
> - public ScriptEngineShellTable(String engine) {
> -this.engine = engine;
> -this.scriptEngine = scriptEngineFactory.getEngineByName(engine);
> + public
Do you think it makes sense to move the copied classes to their own package so
they are easy to reference (if that is needed or helps at some point)?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Closed #78.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/78#event-785275406
Absolutely! :)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/78#issuecomment-246199320
> @@ -51,8 +52,9 @@ public String evaluate(Object obj, String expression) {
> try {
>scriptEngine.put(getType(), obj);
>result = String.valueOf(scriptEngine.eval(expression));
> -} catch (Exception ex) {
> - //Ignore
> +} catch (Exception exception) {
> +
[
https://issues.apache.org/jira/browse/JCLOUDS-1175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15482288#comment-15482288
]
Ignasi Barrera commented on JCLOUDS-1175:
-
Thanks for reporting! Do you want to try opening a
12 matches
Mail list logo
