nacx approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1113#pullrequestreview-44230735
nacx commented on this pull request.
>
+ PublicKey userKey = readPublicKey(options.getPublicKey());
+ final String fingerprint = computeFingerprint(userKey);
+
+ synchronized (CreateSshKeysThenCreateNodes.class) {
To avoid race conditions on this "getOrCreate" method.
nacx commented on this pull request.
>
+ PublicKey userKey = readPublicKey(options.getPublicKey());
+ final String fingerprint = computeFingerprint(userKey);
+
+ synchronized (CreateSshKeysThenCreateNodes.class) {
+ boolean keyExists =
>why only against 2.0.x?
I developed it in 2.0.x, but will be merged to master too.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/397#issuecomment-308659972
[
https://issues.apache.org/jira/browse/JCLOUDS-1309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16050143#comment-16050143
]
Ignasi Barrera commented on JCLOUDS-1309:
-
See also the discussion thread in the jclouds-dev
andreaturli commented on this pull request.
>
+ PublicKey userKey = readPublicKey(options.getPublicKey());
+ final String fingerprint = computeFingerprint(userKey);
+
+ synchronized (CreateSshKeysThenCreateNodes.class) {
+ boolean keyExists =
lgtm, thanks @nacx
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/397#issuecomment-308673244
Closed #397.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/397#event-1124850801
Pushed to
[master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/b77ea069) and
[2.0,.x](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/c1fb7620).
Thanks @andreaturli!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view
[
https://issues.apache.org/jira/browse/JCLOUDS-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16050722#comment-16050722
]
Graeme Miller commented on JCLOUDS-1308:
hello, thank you both for your comments. I had a bash
nacx approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/#pullrequestreview-44230579
[
https://issues.apache.org/jira/browse/JCLOUDS-1310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16050972#comment-16050972
]
Paya Ashkan commented on JCLOUDS-1310:
--
[~nacx] any help would be appreciated.
> Use AWS S3
Paya Ashkan created JCLOUDS-1310:
Summary: Use AWS S3 Transfer Acceleration
Key: JCLOUDS-1310
URL: https://issues.apache.org/jira/browse/JCLOUDS-1310
Project: jclouds
Issue Type: Bug
[
https://issues.apache.org/jira/browse/JCLOUDS-1310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Paya Ashkan updated JCLOUDS-1310:
-
Description:
When I enabled S3 Transfer Acceleration on my bucket, it gave me the following
[
https://issues.apache.org/jira/browse/JCLOUDS-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16050753#comment-16050753
]
Andrea Turli commented on JCLOUDS-1308:
---
I think jclouds should mimic as much as possible the UI
15 matches
Mail list logo
