H I think it is still not the right fix. And I see two different issues
here:
1. We shouldn't rely on naming validation to identify something as "created by
jclouds".
2. The current validator does not match the Azure naming restrictions, so we'd
better change it.
For the second point, we
Go to
http://d6762342ecf65bd47950-3e336ecb7f68d8dda5e5d435de17b0ef.r3.cf5.rackcdn.com/
to review your changes.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
andreaturli requested changes on this pull request.
thanks @axel3rd it is super useful!
I've left some comments mainly on the snippets: please address them and edit
the document accordingly, i.e. if you replace `Some.class` with
`NovaApi.class` make sure you do it all over the places.
Thanks
axel3rd commented on this pull request.
> +
+Openstack Keystone (aka: [OpenStack Identity
Service](https://docs.openstack.org/keystone/latest/)) has major changes
between v2 and v3 (detail. [Identity API v2.0 and v3
> Perhaps a consensus could be to add a comment before ContextBuilder like
> [...]:
> One minor comment, but it would help readability if you format the generated
> json auth example.
Done (without new-line-comma for json, to reduce lines number). Last proposal:
[Keystone v2-v3 authentication
The DNS one is just a naming convention known to work for most providers. Being
restrictive works fine for portability but conflicts when you're trying to use
it with pre-existing stuff. In this case I'd say it makes sense to have a
custom one for Azure, since it is only used to name things:
Go to
http://44ce6b87f08c84c4a336-587a4214cfc62e403204a0b0eced474e.r98.cf5.rackcdn.com/
to review your changes.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
> pointing maybe the reader to the authentication section above instead of using
I have hesitate to do that ... but the current snippet explicits how to
retrieve an API (nova, swift, ...) even if v2 is deprecated (v3 needs more
code).
So keystone considerations was writted before (hoping that
[
https://issues.apache.org/jira/browse/JCLOUDS-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16465927#comment-16465927
]
Ignasi Barrera commented on JCLOUDS-1414:
-
{quote}
Sorry for my answer delay, but no way to use
For the first point, i supposed it made sense to delete only those "implicit"
orphaned groups created by jclouds, but it's true it'd delete groups from the
subscription so adding a tag would make this process indeed more robust.
For the validator, i thought there was maybe a reason to use a
Some tries about code & list typo, the last looks fine: Openstack [Keystone
v2-v3
authentication](https://d6762342ecf65bd47950-3e336ecb7f68d8dda5e5d435de17b0ef.ssl.cf5.rackcdn.com/guides/openstack/#keystone)
--
You are receiving this because you are subscribed to this thread.
Reply to this
[
https://issues.apache.org/jira/browse/JCLOUDS-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16465819#comment-16465819
]
Alix Lourme edited comment on JCLOUDS-1414 at 5/7/18 11:55 AM:
---
andreaturli commented on this pull request.
> +
+Openstack Keystone (aka: [OpenStack Identity
Service](https://docs.openstack.org/keystone/latest/)) has major changes
between v2 and v3 (detail. [Identity API v2.0 and v3
nacx approved this pull request.
Thanks! LGTM.
Since you reference a new keystone property I'd hold this and merge once the
changes in Keystone are merged and the new property exists.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it
See [JCLOUDS-1414](https://issues.apache.org/jira/browse/JCLOUDS-1414),
documentation about Openstack keystone v2/v3 usage
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-site/pull/214
-- Commit Summary --
* #JCLOUDS-1414: Documentation
Go to
http://e8a2320cb8ee7328bc9a-98112aaa434232edc359e0c94cafc2fa.r90.cf5.rackcdn.com/
to review your changes.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Go to
http://4c17ddefb1e1845a6081-9bb6552a57750bbb30de030b38a1ebcc.r36.cf5.rackcdn.com/
to review your changes.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
[
https://issues.apache.org/jira/browse/JCLOUDS-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16465819#comment-16465819
]
Alix Lourme commented on JCLOUDS-1414:
--
{quote}
Looks good to me, although I'd rather name it
Go to
http://393f4caa8037a748294f-756fd4e7d22e69a6f0ff4346cb78ae2b.r35.cf5.rackcdn.com/
to review your changes.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Actually @axel3rd I think we should somehow edit `List Servers` and `Swift: Use
Containers` paragraphs as well pointing maybe the reader to the authentication
section above instead of using
```
novaApi = ContextBuilder.newBuilder(provider)
One minor comment, but it would help readability if you format the generated
json auth example.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/214#issuecomment-387061588
Go to
http://ae4404efef77109c76ca-bf5e3651b7ed971bf54720901bab17d5.r49.cf5.rackcdn.com/
to review your changes.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@andreaturli : Thanks for grammar fix & suggestions. Fixed in [Keystone v2-v3
authentication](https://393f4caa8037a748294f-756fd4e7d22e69a6f0ff4346cb78ae2b.ssl.cf5.rackcdn.com/guides/openstack/#keystone).
Except about `KeystoneProperties.KEYSTONE_VERSION` ... not sure about that.
--
You are
nacx commented on this pull request.
> +
+Openstack Keystone (aka: [OpenStack Identity
Service](https://docs.openstack.org/keystone/latest/)) has major changes
between v2 and v3 (detail. [Identity API v2.0 and v3
Go to
http://eb3572d47d95412306ae-9ba5d3580b14e830c75c09652bfd2f59.r53.cf5.rackcdn.com/
to review your changes.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Timothy Anyona created JCLOUDS-1416:
---
Summary: Cache-Control header is not supported or allowed with B2
upload
Key: JCLOUDS-1416
URL: https://issues.apache.org/jira/browse/JCLOUDS-1416
Project:
[
https://issues.apache.org/jira/browse/JCLOUDS-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16465952#comment-16465952
]
Alix Lourme commented on JCLOUDS-1414:
--
After reviewing
[
https://issues.apache.org/jira/browse/JCLOUDS-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16466030#comment-16466030
]
Alix Lourme commented on JCLOUDS-1414:
--
{quote}
I've tried to create a wiki page with a default
> Since you reference a new keystone property I'd hold this and merge once the
> changes in Keystone are merged and the new property exists.
Yes ... and perhaps some minor change on properties name in progress ...
--
You are receiving this because you are subscribed to this thread.
Reply to
> andreaturli commented on Feb 14
Not familiar with the oneandone API but looks like baremetal is another
servertype for server creation.
>
> If this is correct, then we could either introduce a OneAndOneTemplateOption
> for serverType or try to infer it from hardwareProfiles if this
> Yes ... and perhaps some minor change on properties name in progress ...
Done, 1 line changed:
overrides.put(KeystoneProperties.PROJECT_DOMAIN_NAME, "default"); // Since
jclouds v2.2.0 (see PROJECT_DOMAIN_ID as complement)
Linked with
@alibazlamit pushed 1 commit.
8a97c6e removed id
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/431/files/f69b3d2ac50234c0b71e7fd8e3357d4c83440659..8a97c6e2bc03de788bc9ea5bed4fa5d3d428e51d
alibazlamit commented on this pull request.
>
@Inject
OneandoneComputeServiceAdapter(OneAndOneApi api, CleanupResources
cleanupResources,
+ GenerateHardwareRequest generateHardwareRequest,
@Named(POLL_PREDICATE_SERVER) Predicate
waitServerUntilAvailable,
alibazlamit commented on this pull request.
> }
@Override
public NodeAndInitialCredentials
createNodeWithGroupEncodedIntoName(String group, String name, Template
template) {
- final String dataCenterId = template.getLocation().getId();
+ final String dataCenterId
alibazlamit commented on this pull request.
> - ram = ram / 1024;
+ //configuring Firewall rules
+ Map portsRange = getPortRangesFromList(inboundPorts);
+ List rules = new
ArrayList();
+
+ for (Map.Entry range :
Go to
http://ad99be29f1570e3a80bb-ec8c9f9fa769d9cd6f2ad277a7469fe8.r48.cf5.rackcdn.com/
to review your changes.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
alibazlamit commented on this pull request.
> @@ -143,23 +160,6 @@
updateServer = api.serverApi().get(server.id());
- Map portsRange =
getPortRangesFromList(inboundPorts);
This bulk of code was moved up
--
You are receiving this because you are
alibazlamit commented on this pull request.
> - SingleServerAppliance appliance =
> api.serverApplianceApi().get(image.getId());
- if (appliance.minHddSize() > volume.getSize()) {
- minHddSize = appliance.minHddSize();
- }
-
Cf. [JCLOUDS-1414](https://issues.apache.org/jira/browse/JCLOUDS-1414)
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/1204
-- Commit Summary --
* OpenStack Keystone V3 - different auth "domains" support (JCLOUDS-1414)
-- File Changes
thanks @axel3rd
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/214#issuecomment-387117770
andreaturli approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/214#pullrequestreview-118055261
[
https://issues.apache.org/jira/browse/JCLOUDS-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16466093#comment-16466093
]
Alix Lourme commented on JCLOUDS-1414:
--
PR reference:
alibazlamit commented on this pull request.
> }
@Override
public NodeAndInitialCredentials
createNodeWithGroupEncodedIntoName(String group, String name, Template
template) {
- final String dataCenterId = template.getLocation().getId();
+ final String dataCenterId
alibazlamit commented on this pull request.
> -float minHddSize = volume.getSize();
-if (volume.isBootDevice()) {
- SingleServerAppliance appliance =
api.serverApplianceApi().get(image.getId());
- if (appliance.minHddSize() >
alibazlamit commented on this pull request.
> }
}
- // provision server
- Server server = null;
- Double cores = ComputeServiceUtils.getCores(hardware);
- Double ram = (double) hardware.getRam();
- if (ram < 1024) {
- ram = 0.5;
- } else
Reopened #431.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/431#event-1613377500
Closed #431.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/431#event-1613377382
47 matches
Mail list logo