[jclouds/jclouds] Mark srouceImage as Nullable to avoid NullPointerException while attaching local-ssd disk in GCE (#1242)

You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/1242 -- Commit Summary -- * Mark srouceImage as Nullable -- File Changes -- M providers/google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/domain/AttachDisk.java

[jclouds/jclouds] JCLOUDS-1460: Add support for aws ec2 t3 instance types (#1244)

You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/1244 -- Commit Summary -- * Add support for aws ec2 t3 instance types -- File Changes -- M apis/ec2/src/main/java/org/jclouds/ec2/compute/domain/EC2HardwareBuilder.java (69)

Re: [jclouds/jclouds] JCLOUDS-1460: Add support for aws ec2 t3 instance types (#1244)

@pimuzzo pushed 1 commit. 9a3c172 Add CPU speed -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds/pull/1244/files/31c2831cb6db734a355f70aa2b191f6452f9a383..9a3c172b1b2ffbfab7d1c5290077b0f8b065b432

Re: [jclouds/jclouds] JCLOUDS-1460: Add support for aws ec2 t3 instance types (#1244)

I'm confused guys, does #1245 supersede this one? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1244#issuecomment-430414297

Re: [jclouds/jclouds] Mark srouceImage as Nullable to avoid NullPointerException while attaching local-ssd disk in GCE (#1242)

@maismail Could you fix the srouceImage typo in the commit message? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1242#issuecomment-430213378

Re: [jclouds/jclouds] JCLOUDS-1460: Feat/adding aws instances (#1245)

Looking at the build failure, I'm not understanding how my PR affected the Nova API. Mine changes should be local to AWS only. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[jclouds/jclouds] JCLOUDS-1460: Feat/adding aws instances (#1245)

PR #1244 also does this feature. Slightly different approach to the problem. [Jira 1460](https://issues.apache.org/jira/browse/JCLOUDS-1460) Added support for: t2.nano t2.xlarge t2.2xlarge t3.nano t3.micro t3.small t3.medium t3.large t3.xlarge t3.2xlarge m4.16xlarge AWS Instance Type reference

Re: [jclouds/jclouds] Mark srouceImage as Nullable to avoid NullPointerException while attaching local-ssd disk in GCE (#1242)

It's just a null check in a domain model that was not hit in a path reachable from the portable abstraction... I'm fine with the path as-is. @demobox? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds] JCLOUDS-1460: Add support for aws ec2 t3 instance types (#1244)

pimuzzo commented on this pull request. > @@ -429,6 +435,69 @@ public static EC2HardwareBuilder t2_large() { .processors(ImmutableList.of(new Processor(1.0, 0.4))).rootDeviceType(RootDeviceType.EBS); } + /** +* @see InstanceType#T3_NANO +*/ + public static

[jira] [Commented] (JCLOUDS-1460) Add support for t3 instance types in AWS ec2

[ https://issues.apache.org/jira/browse/JCLOUDS-1460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16652370#comment-16652370 ] Simone commented on JCLOUDS-1460: - Opened on [github|https://github.com/jclouds/jclouds/pull/1244] >

Re: [jclouds/jclouds] JCLOUDS-1460: Add support for aws ec2 t3 instance types (#1244)

We did our work separately. The code in PR #1245 is slightly different than this. I do think that #1245 supersedes this, but that PR is current blocked because of a build error. The `t3()` method in this PR is slightly different as well. -- You are receiving this because you are subscribed

Re: [jclouds/jclouds] JCLOUDS-1460: Add support for aws ec2 t3 instance types (#1244)

trentontrees commented on this pull request. > @@ -429,6 +435,69 @@ public static EC2HardwareBuilder t2_large() { .processors(ImmutableList.of(new Processor(1.0, 0.4))).rootDeviceType(RootDeviceType.EBS); } + /** +* @see InstanceType#T3_NANO +*/ + public static

Jenkins build is unstable: jclouds #4

See

Jenkins build is unstable: 2.1.x branch » jclouds-2.1.x #1

See

Jenkins build is back to normal : 2.1.x branch » jclouds-labs-2.1.x #2

See

Re: [jclouds/jclouds] Mark srouceImage as Nullable to avoid NullPointerException while attaching local-ssd disk in GCE (#1242)

@nacx Should we consider adding any kinds of test(s) for this? Also, would a JIRA issue for tracking make sense here? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Build failed in Jenkins: jclouds #3

See -- [...truncated 9.59 KB...] [INFO] jclouds compute core .. SKIPPED [INFO] jclouds Log4J Logging Module .. SKIPPED [INFO] jclouds loadbalancer

[jclouds/jclouds] Make NovaErrorHandler logging of sensitive information configurable (#1243)

While figuring out how to get jclouds to use keystone v3 api to work, it refused to provide any info as, for some reason, it run into the problem while talking to nova and not keystone. Making it configurable here as well. You can view, comment on, or merge this pull request online at:

Re: [jclouds/jclouds] Make NovaErrorHandler logging of sensitive information configurable (#1243)

@olivergondza pushed 1 commit. 664ba53 Make logSensitiveInformation private -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Jenkins build is back to normal : jclouds-labs #2

See

[jira] [Commented] (JCLOUDS-1460) Add support for t3 instance types in AWS ec2

[ https://issues.apache.org/jira/browse/JCLOUDS-1460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16651804#comment-16651804 ] Simone commented on JCLOUDS-1460: - [~nacx] Ok, I am in, I'll open a PR, if I will have any trouble I'll