[jira] [Commented] (JCLOUDS-468) Nova needs to handle key pair creation better in the ComputeService

[ https://issues.apache.org/jira/browse/JCLOUDS-468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13901196#comment-13901196 ] Ignasi Barrera commented on JCLOUDS-468: The DigitalOcean provider also needs a b

[jira] [Created] (JCLOUDS-468) Nova needs to handle key pair creation better in the ComputeService

Everett Toews created JCLOUDS-468: - Summary: Nova needs to handle key pair creation better in the ComputeService Key: JCLOUDS-468 URL: https://issues.apache.org/jira/browse/JCLOUDS-468 Project: jcloud

Re: [jclouds] Add keystone user add and delete methods. (#290)

[jclouds-java-7-pull-requests #1072](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1072/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/290#issuecomment-35023639

Re: [jclouds] Add keystone user add and delete methods. (#290)

[jclouds-pull-requests #601](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/601/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/290#issuecomment-35023554

Re: [jclouds] Add keystone user add and delete methods. (#290)

[jclouds » jclouds #842](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/842/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/290#issuecomment

Re: [jclouds] Add keystone user add and delete methods. (#290)

> @@ -86,4 +88,37 @@ public void testUsersByName() { >} > > } > + > + public void testAddDeleteUser() { > + UserApi userApi = api.getUserApi().get(); > + Set initialUsers = userApi.list().concat().toSet(); > + > + // generate credentials for a random new use

Re: [jclouds] Add keystone user add and delete methods. (#290)

> @@ -86,4 +88,37 @@ public void testUsersByName() { >} > > } > + > + public void testAddDeleteUser() { > We should be able to figure out which operation failed by looking at which > assert failed. Sure, but if you're looking at test results in Jenkins or whatever, it's nice

Re: [jclouds] Add keystone user add and delete methods. (#290)

> @@ -86,4 +88,37 @@ public void testUsersByName() { >} > > } > + > + public void testAddDeleteUser() { I wrote this as one test because the test for the delete operation requires that the add operation succeed, and that we know the ID of the user that was created. We should

Re: [jclouds] Add keystone user add and delete methods. (#290)

Fixed javadoc style comments. I'm not particularly tied to the fallback behavior on user deletion; I'm open to other options. Once we figure out what behavior we want, I'll update the javadoc so that it better describes the behavior. --- Reply to this email directly or view it on GitHub: https:

Re: [jclouds] Add keystone user add and delete methods. (#290)

> + > + User newUser = userApi.add(randUser, email, true, password); > + > + // validate that our new user exists > + Set newUsers = userApi.list().concat().toSet(); > + assertTrue(newUsers.contains(newUser)); > + > + // validate that we can delete our use

Re: [jclouds] Add keystone user add and delete methods. (#290)

> @@ -86,4 +88,37 @@ public void testUsersByName() { >} > > } > + > + public void testAddDeleteUser() { Split this out into two tests, one depending on the other? Like this, if the test fails, we don't know which of the operations broke... --- Reply to this email directly or v

Re: [jclouds] Add keystone user add and delete methods. (#290)

> + @Path("/users") > + @RequestFilters(AuthenticateRequest.class) > + @Fallback(NullOnNotFoundOr404.class) > + ListenableFuture add(@PayloadParam("username") String > userName, > +@PayloadParam("email") String > userEmail, > +

Re: [jclouds] Add keystone user add and delete methods. (#290)

> @@ -81,4 +81,21 @@ > */ > Set listRolesOfUserOnTenant(String userId, String > tenantId); > > + /** > +* Create a new user in keystone. "Creates" (per Javadoc style guide - descriptive over imperative) --- Reply to this email directly or view it on GitHub: https://github.com/jc

Re: [jclouds] Add keystone user add and delete methods. (#290)

> @@ -81,4 +81,21 @@ > */ > Set listRolesOfUserOnTenant(String userId, String > tenantId); > > + /** > +* Create a new user in keystone. > +* > +* @param userName the name for the new user > +* @param userEmail the email address for the new user > +* @param enable

Re: [jclouds] Implement a poor-mans rollback if static nat creation fails (#184)

> I'll give it a go and test this with the master branch. Thanks, @spark404! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/184#issuecomment-34985369

[jira] [Commented] (JCLOUDS-467) nameNodes only taking first name with AWS

[ https://issues.apache.org/jira/browse/JCLOUDS-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13900119#comment-13900119 ] Ignasi Barrera commented on JCLOUDS-467: Maybe just taking the nodeNames iterator

Re: [jclouds] Add keystone user add and delete methods. (#290)

> @@ -123,4 +137,29 @@ > @Fallback(EmptySetOnNotFoundOr404.class) > ListenableFuture> > listRolesOfUserOnTenant(@PathParam("userId") String userId, > @PathParam("tenantId") String tenantId); > + > + /** > +* @see UserApi#add(String, String, Boolean, String) > +*/