nacx commented on this pull request.
> @@ -123,6 +123,8 @@ public Image call() throws Exception {
Image image =
resourceDefinitionToImage.create(cloneTemplate.getSourceNodeId(),
cloneTemplate.getName())
.apply(definitions.get(0));
+
nacx commented on this pull request.
> @@ -123,6 +123,9 @@
ResourceGroup resourceGroup =
resourceGroupMap.getUnchecked(regionAndId.region());
VirtualMachine vm =
api.getVirtualMachineApi(resourceGroup.name()).get(regionAndId.id());
I'd say it is ok as-is? taht check would
@danielestevez pushed 1 commit.
a79e560 Returns null image if node not found
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
andreaturli commented on this pull request.
> @@ -123,6 +123,9 @@
ResourceGroup resourceGroup =
resourceGroupMap.getUnchecked(regionAndId.region());
VirtualMachine vm =
api.getVirtualMachineApi(resourceGroup.name()).get(regionAndId.id());
Can you use checkNotNull, maybe?
>
+1 to keep the current approach. Thanks @geomacy! I'll have a detailed look at
the PR in a while :)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1059#issuecomment-278747054
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-labs/pull/360
-- Commit Summary --
* Checks existence of node before getting SecurityGroups and Images
-- File Changes --
M
Fair points @geomacy I'm in favor of keeping the implementation as-is which
already optimize a lot!
if further optimizations will be required we could always revisit it again
using @nacx suggestions as starting point. Wdyt?
--
You are receiving this because you are subscribed to this thread.
