minor comment, not tested, but looks good to me
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/387#issuecomment-297547130
andreaturli commented on this pull request.
> + deleteJobs.add(deleteManagedDisk(osDisk.managedDiskParameters()));
+
+ for (DataDisk dataDisk :
virtualMachine.properties().storageProfile().dataDisks()) {
+ deleteJobs.add(deleteManagedDisk(dataDisk.managedDiskParameters()));
+
andreaturli commented on this pull request.
> @@ -383,39 +391,94 @@ private OSProfile createOsProfile(String computerName,
> Template template) {
return builder.build();
}
- private NetworkInterfaceCard createNetworkInterfaceCard(String subnetId,
String name, String
thanks @nacx I really like the kind of flexibility jclouds azurecompute-arm can
gain with that!
couple of minor inital comments:
1. don't we need to deprecate `subnetId` and `virtualNetworkName` before
removing them, maybe?
2. with the second option `options.networks(subnetId2, subnetId2,
/cc @andreaturli @danielestevez
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/387#issuecomment-297519617
https://issues.apache.org/jira/browse/JCLOUDS-1274
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-labs/pull/387
-- Commit Summary --
* JCLOUDS-1274: Delete managed disks when cleaning up VM resources
-- File Changes --
M
[
https://issues.apache.org/jira/browse/JCLOUDS-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignasi Barrera reassigned JCLOUDS-1274:
---
Assignee: Ignasi Barrera
> Azure ARM managed disks are not deleted when destroying
@nacx pushed 1 commit.
4820129 Use the right resource group to retrieve the public IP of a VM
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://issues.apache.org/jira/browse/JCLOUDS-1278
Allows to configure the NIC layout of a virtual machine using the template
options. This PR removes the `virtualnetworkName` and `subnetId` from the
`AzureTemplateOptions` class and leverages a more flexible way to configure
networking for
[
https://issues.apache.org/jira/browse/JCLOUDS-1280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15984807#comment-15984807
]
Andrew Gaul commented on JCLOUDS-1280:
--
I do not plan to work on this issue.
> Allow configuration
[
https://issues.apache.org/jira/browse/JCLOUDS-114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15984526#comment-15984526
]
Siddarth Rai commented on JCLOUDS-114:
--
Is there any update on this? Keystone v3 Support is almost
[
https://issues.apache.org/jira/browse/JCLOUDS-1278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignasi Barrera reassigned JCLOUDS-1278:
---
Assignee: Ignasi Barrera
> Implement the TemplateOptions.networks option in Azure
[
https://issues.apache.org/jira/browse/JCLOUDS-1281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15984313#comment-15984313
]
Archana Chinnaiah edited comment on JCLOUDS-1281 at 4/26/17 8:44 AM:
-
[
https://issues.apache.org/jira/browse/JCLOUDS-1280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15984376#comment-15984376
]
Rishika commented on JCLOUDS-1280:
--
Will you be working on it or you want my help on this
> Allow
[
https://issues.apache.org/jira/browse/JCLOUDS-1281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15984313#comment-15984313
]
Archana Chinnaiah commented on JCLOUDS-1281:
Sure Andrew.
It will be sufficient if we add
[
https://issues.apache.org/jira/browse/JCLOUDS-1281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15984313#comment-15984313
]
Archana Chinnaiah edited comment on JCLOUDS-1281 at 4/26/17 7:42 AM:
-
[
https://issues.apache.org/jira/browse/JCLOUDS-1281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15984309#comment-15984309
]
Andrew Gaul commented on JCLOUDS-1281:
--
One workaround is for users to update their DLOs to SLOs.
[
https://issues.apache.org/jira/browse/JCLOUDS-1281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15984306#comment-15984306
]
Andrew Gaul commented on JCLOUDS-1281:
--
Static Large Objects have a number of benefits over Dynamic
[
https://issues.apache.org/jira/browse/JCLOUDS-1281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15984301#comment-15984301
]
Archana Chinnaiah commented on JCLOUDS-1281:
I have implementation for swift DLO support.
[
https://issues.apache.org/jira/browse/JCLOUDS-1279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15984275#comment-15984275
]
Andrew Gaul commented on JCLOUDS-1279:
--
I opened JCLOUDS-1280 to track this feature request. This
Andrew Gaul created JCLOUDS-1280:
Summary: Allow configuration of multi-part upload part sizes
Key: JCLOUDS-1280
URL: https://issues.apache.org/jira/browse/JCLOUDS-1280
Project: jclouds
[
https://issues.apache.org/jira/browse/JCLOUDS-1248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Gaul resolved JCLOUDS-1248.
--
Resolution: Invalid
> GetBlob Swift is returning the manifest content not the actual content
Archana Chinnaiah created JCLOUDS-1281:
--
Summary: Swift DLO Support
Key: JCLOUDS-1281
URL: https://issues.apache.org/jira/browse/JCLOUDS-1281
Project: jclouds
Issue Type: New Feature
[
https://issues.apache.org/jira/browse/JCLOUDS-1248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15984284#comment-15984284
]
Archana Chinnaiah commented on JCLOUDS-1248:
Local swift was configured to handle DLO
[
https://issues.apache.org/jira/browse/JCLOUDS-1280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Gaul updated JCLOUDS-1280:
-
Description: Presently {{BaseBlobStore}} instantiates
{{MultipartUploadSlicingAlgorithm}}
[
https://issues.apache.org/jira/browse/JCLOUDS-1279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15984259#comment-15984259
]
Rishika commented on JCLOUDS-1279:
--
ok, let me know how the underlying issue can be fixed.
> Extending
[
https://issues.apache.org/jira/browse/JCLOUDS-1279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15984236#comment-15984236
]
Andrew Gaul commented on JCLOUDS-1279:
--
Sorry I don't think we will accept this. Happy to help you
27 matches
Mail list logo
