danielestevez commented on this pull request.
> + // Otherwise fallback to the image default credentials strategy
+ if (template instanceof CloneImageTemplate) {
+ final CloneImageTemplate cloneImageTemplate = (CloneImageTemplate)
template;
+ future =
Tried and fixes the issues with the missing credentials in
_testSpawnNodeFromImage_ :+1:
However _testImageIsRemovedFromCacheAfterDeletion_ still fails it
_testSpawnNodeFromImage_ is enabled but that's a different issue.
--
You are receiving this because you are subscribed to this thread.
About this, i started to implement a custom validation for ARM here extending
current interfaces
https://github.com/danielestevez/jclouds/commits/groupNamingValidation
Still not sure about the implementation, and specially naming but there it is
if you want to take a look
--
You are receiving
Fail!... and fixed!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1209#issuecomment-389517489
[
https://issues.apache.org/jira/browse/JCLOUDS-1418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignasi Barrera resolved JCLOUDS-1418.
-
Resolution: Fixed
Fix Version/s: 2.1.1
2.2.0
> The Azure ARM
And cherry-picked to
[2.1.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/cce23c1f).
--
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1208#issuecomment-389475531
[
https://issues.apache.org/jira/browse/JCLOUDS-1418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477216#comment-16477216
]
ASF subversion and git services commented on JCLOUDS-1418:
--
Commit
[
https://issues.apache.org/jira/browse/JCLOUDS-1418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477215#comment-16477215
]
ASF subversion and git services commented on JCLOUDS-1418:
--
Commit
Thanks @danielestevez! Can you check and fix the checkstyle violations in the
ARM provider?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1209#issuecomment-389469592
By default, when listing images the ComputeServiceAdapter adds the default
credentials for each image. This is not done when images are created by the
image extension, and NPEs can appear in code that assumes the default
credentials are there, as the field is not nullable.
This change tries to
10 matches
Mail list logo
