> Adds minor improvements to readability
Looks good to me - many thanks, Daniel! Is this for 2.1.x only, or also for
master, incidentally?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
nacx approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1215#pullrequestreview-124173143
danielestevez commented on this pull request.
> @@ -54,7 +55,7 @@ private CharMatcher getAcceptableRange() {
protected IllegalArgumentException exception(String name, String reason) {
return new IllegalArgumentException(
-String.format("Object '%s' doesn't match Azure
@danielestevez pushed 1 commit.
2fd4f07 changes exception text for readability
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
nacx commented on this pull request.
> throw exception(name, "Should start with letter/number");
CharMatcher range = getAcceptableRange();
if (!range.matchesAllOf(name))
- throw exception(name, "Should have lowercase or uppercase ASCII
letters, numbers, or
nacx approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1214#pullrequestreview-124156894
Thanks for the suggestions @demobox, PR was already merged but i added those
improvements here https://github.com/jclouds/jclouds/pull/1215
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Based on suggestions by @demobox in original PR
https://github.com/jclouds/jclouds/pull/1213
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/1215
-- Commit Summary --
* Adds minor improvements to readability
-- File Changes --
M
This affected (at least)
[AzureComputeImageExtensionLiveTest](https://github.com/jclouds/jclouds/blob/master/providers/azurecompute-arm/src/test/java/org/jclouds/azurecompute/arm/compute/extensions/AzureComputeImageExtensionLiveTest.java)
running in some regions. (worked in North/West Europe but
jglick commented on this pull request.
> @@ -72,7 +72,7 @@ public void testListWithPrefix() {
blobStore.putBlob(containerName,
blobStore.blobBuilder("bar").payload("").build());
Iterable results =
concatter.execute(containerName,
-
[
https://issues.apache.org/jira/browse/JCLOUDS-1423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gunther Wiest updated JCLOUDS-1423:
---
Description:
When using the filesystem provider on a localized RUSSIAN Windows system
[
https://issues.apache.org/jira/browse/JCLOUDS-1423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gunther Wiest updated JCLOUDS-1423:
---
Description:
When using the filesystem provider on a localized RUSSIAN Windows system
[
https://issues.apache.org/jira/browse/JCLOUDS-1423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gunther Wiest updated JCLOUDS-1423:
---
Description:
When using the filesystem provider on a localized RUSSIAN Windows system
[
https://issues.apache.org/jira/browse/JCLOUDS-1423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gunther Wiest updated JCLOUDS-1423:
---
Summary: BlobStore.putBlob throws RuntimeException with filesystem provider
on RUSSIAN
[
https://issues.apache.org/jira/browse/JCLOUDS-1423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gunther Wiest updated JCLOUDS-1423:
---
Affects Version/s: (was: 1.9.1)
2.0.2
> BlobStore.putBlob
Gunther Wiest created JCLOUDS-1423:
--
Summary: CLONE - BlobStore.putBlob throws RuntimeException with
filesystem provider on localized Windows
Key: JCLOUDS-1423
URL:
16 matches
Mail list logo
