[
https://issues.apache.org/jira/browse/JCLOUDS-1401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537962#comment-16537962
]
Jesse Glick commented on JCLOUDS-1401:
--
I filed PR 1226 with a proposed fix.
> S3
[JCLOUDS-1401](https://jira.apache.org/jira/browse/JCLOUDS-1401)
I managed to write integration tests for this in Jenkins (which fail without
this patch and pass with it). I would have liked to add a test case for it to
`AWSS3ClientLiveTest` (or `S3ClientLiveTest`? not sure I grasp the
nacx commented on this pull request.
Thanks @danielestevez!
> @@ -105,6 +105,12 @@ public void listNetworkInterfaceCards() {
assertTrue(nicList.contains(api().get(nicName)));
}
+ @Test(dependsOnMethods = "createNetworkInterfaceCard")
+ public void listAllNetworkInterfaceCards()
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/1225
-- Commit Summary --
* Adds listAll to PublicIPAddressAPI
* Adds listAll to NetworkInterfaceCardApi
-- File Changes --
M
Pushed to
[master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/1bd3b8f9) and
[2.1.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/467501fd). Thanks
@danielestevez!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it
Closed #1220.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1220#event-1723703416
FTR: https://github.com/jclouds/jclouds/pull/1224 should fix this build once
merged.
There is one checkstyle violation in this branch though:
```
[WARNING]
src/test/java/org/jclouds/dimensiondata/cloudcontrol/features/ServerApiMockTest.java[31:8]
(imports) UnusedImports: Unused import -
There is already https://github.com/jclouds/jclouds/pull/1197, but while we
complete the work to properly support Java 8 in every project (just
jclouds-karaf pending) we should not block contributions from using Java 7
stuff.
You can view, comment on, or merge this pull request online at:
It's because the default build config. No need to close the PR. I'll bump the
source and target versions in the build config and it should be fine.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
build failed again after I committed the suggested change that needs at least
Java 7 to work:
"Undefined reference: void
java.util.ConcurrentModificationException.(String, Throwable)"
Reopened #439.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/439#event-1723645985
Closed #439.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/439#event-1723645736
nacx approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1220#pullrequestreview-135491806
alibazlamit commented on this pull request.
> +
+ @Named("sshkeys:create")
+ @POST
+ SshKey create(@BinderParam(BindToJsonPayload.class) SshKey.CreateSshKey
sshKey);
+
+ @Named("sshkeys:update")
+ @PUT
+ @Path("/{sshKeyId}")
+ SshKey update(@PathParam("sshKeyId") String sshKeyId,
@alibazlamit pushed 1 commit.
6c882ef Applied review changes
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/437/files/9ae6fe1066dca923129f6e3dde6a82565a6ee71b..6c882ef5aee3012666bc86793ca022bb1c6e80c5
alibazlamit commented on this pull request.
> +import org.apache.jclouds.oneandone.rest.domain.Server;
+import org.apache.jclouds.oneandone.rest.domain.BlockStorage;
+import org.apache.jclouds.oneandone.rest.domain.options.GenericQueryOptions;
+import
alibazlamit commented on this pull request.
> + @Path("/{blockStorageId}")
+ BlockStorage update(@PathParam("blockStorageId") String blockStorageId,
@BinderParam(BindToJsonPayload.class) BlockStorage.UpdateBlockStorage
blockStorage);
+
+ @Named("blockstorages:delete")
+ @DELETE
+
alibazlamit commented on this pull request.
> + @POST
+ BlockStorage create(@BinderParam(BindToJsonPayload.class)
BlockStorage.CreateBlockStorage blockStorage);
+
+ @Named("blockstorages:update")
+ @PUT
+ @Path("/{blockStorageId}")
+ BlockStorage update(@PathParam("blockStorageId")
Sorry i forgot about the mock test!
Also noticed i changed the returning HTTP codes for start/restart/stop to the
actual values returned by ARM API
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@danielestevez pushed 1 commit.
cb8881b Adds missing mock test
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds/pull/1220/files/b76a2b6ecf997e4214fa7990b3d58d1f1b095043..cb8881bbac7f8fc448acd59772c00891814d7cea
@FileIOUtility pushed 2 commits.
b13d0f8 JCLOUDS-1432 - review - use JDK7 and ConcurrentModificationException
6e076b3 JCLOUDS-1432 - review - fix test failure message
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
alibazlamit commented on this pull request.
> +
+@Path("/block_storages")
+@Produces("application/json")
+@Consumes("application/json")
+@RequestFilters(AuthenticateRequest.class)
+public interface BlockStorageApi extends Closeable {
+
+ @Named("blockstorages:list")
+ @GET
+
andreaturli commented on this pull request.
> +
+@Path("/block_storages")
+@Produces("application/json")
+@Consumes("application/json")
+@RequestFilters(AuthenticateRequest.class)
+public interface BlockStorageApi extends Closeable {
+
+ @Named("blockstorages:list")
+ @GET
+
alibazlamit commented on this pull request.
> +import javax.ws.rs.Produces;
+import org.jclouds.rest.annotations.BinderParam;
+import org.jclouds.rest.annotations.Fallback;
+import org.jclouds.rest.annotations.MapBinder;
+import org.jclouds.rest.annotations.RequestFilters;
+
+@Path("/ssh_keys")
alibazlamit commented on this pull request.
> +
+@Path("/block_storages")
+@Produces("application/json")
+@Consumes("application/json")
+@RequestFilters(AuthenticateRequest.class)
+public interface BlockStorageApi extends Closeable {
+
+ @Named("blockstorages:list")
+ @GET
+
rebuild please
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/439#issuecomment-403472574
nacx commented on this pull request.
> @@ -56,7 +57,7 @@ public void testDeployServerReturnsUnexpectedError() throws
> InterruptedException
serverApi().deployServer(ServerApiMockTest.class.getSimpleName(),
"imageId", true, networkInfo,
"administratorPassword");
FYI: build was aborted during "jclouds jdbc core" phase.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/439#issuecomment-403468803
FileIOUtility commented on this pull request.
> @@ -56,7 +57,7 @@ public void testDeployServerReturnsUnexpectedError() throws
> InterruptedException
serverApi().deployServer(ServerApiMockTest.class.getSimpleName(),
"imageId", true, networkInfo,
29 matches
Mail list logo
