Re: [jclouds/jclouds] Adds method checkIpAvailability to VirtualNetworkApi (#1231)

Squashed and ready to merge, thanks @nacx ! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1231#issuecomment-404673071

Re: [jclouds/jclouds] Adds method checkIpAvailability to VirtualNetworkApi (#1231)

nacx approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1231#pullrequestreview-136854963

Re: [jclouds/jclouds] Adds method checkIpAvailability to VirtualNetworkApi (#1231)

@danielestevez pushed 1 commit. e71ce96 Fixed formatter maximum line width. Removed redundantTest -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds] Adds method checkIpAvailability to VirtualNetworkApi (#1231)

nacx commented on this pull request. > + public void checkIpAvailable() throws InterruptedException { + server.enqueue(jsonResponse("/ipavailable.json")); + + final VirtualNetworkApi vnApi = api.getVirtualNetworkApi(resourcegroup); + IpAddressAvailabilityResult checkResult =

Re: [jclouds/jclouds] Adds method checkIpAvailability to VirtualNetworkApi (#1231)

danielestevez commented on this pull request. > + public void checkIpAvailable() throws InterruptedException { + server.enqueue(jsonResponse("/ipavailable.json")); + + final VirtualNetworkApi vnApi = api.getVirtualNetworkApi(resourcegroup); + IpAddressAvailabilityResult

Re: [jclouds/jclouds] Adds method checkIpAvailability to VirtualNetworkApi (#1231)

nacx commented on this pull request. > + public void checkIpAvailable() throws InterruptedException { + server.enqueue(jsonResponse("/ipavailable.json")); + + final VirtualNetworkApi vnApi = api.getVirtualNetworkApi(resourcegroup); + IpAddressAvailabilityResult checkResult =

Re: [jclouds/jclouds] Adds method checkIpAvailability to VirtualNetworkApi (#1231)

@danielestevez pushed 1 commit. 37ce4a7 Addresses @nacx comments -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds/pull/1231/files/427fcdb34f6e8698e2c0ad218f65aac4a8964ef8..37ce4a7d29ad54d9b9436e668336bed07a998a7f

Re: [jclouds/jclouds] Adds method checkIpAvailability to VirtualNetworkApi (#1231)

danielestevez commented on this pull request. > VirtualNetwork vn = api().createOrUpdate(virtualNetworkName, LOCATION, null, virtualNetworkProperties); + resourceAvailable.apply(new Supplier() { + @Override + public Provisionable get() { +

Re: [jclouds/jclouds] Adds method checkIpAvailability to VirtualNetworkApi (#1231)

danielestevez commented on this pull request. > + */ +package org.jclouds.azurecompute.arm.domain; + +import java.util.List; + +import org.jclouds.javax.annotation.Nullable; +import org.jclouds.json.SerializedNames; + +import com.google.auto.value.AutoValue; +import

Re: [jclouds/jclouds] Adds method checkIpAvailability to VirtualNetworkApi (#1231)

danielestevez commented on this pull request. > @@ -73,4 +74,11 @@ VirtualNetwork > createOrUpdate(@PathParam("virtualnetworkname") String virtualnet @DELETE @ResponseParser(FalseOn204.class) boolean delete(@PathParam("virtualnetworkname") String virtualnetworkname); + +

Re: [jclouds/jclouds] Adds method checkIpAvailability to VirtualNetworkApi (#1231)

nacx commented on this pull request. > + */ +package org.jclouds.azurecompute.arm.domain; + +import java.util.List; + +import org.jclouds.javax.annotation.Nullable; +import org.jclouds.json.SerializedNames; + +import com.google.auto.value.AutoValue; +import

[jclouds/jclouds] Adds method checkIpAvailability to VirtualNetworkApi (#1231)

https://docs.microsoft.com/en-us/rest/api/virtualnetwork/virtualnetworks/checkipaddressavailability You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/1231 -- Commit Summary -- * Adds method checkIpAvailability to VirtualNetworkApi --

Jenkins build became unstable: jclouds #3767

See

Jenkins build became unstable: jclouds » jclouds blobstore core #3767

See

Re: [jclouds/jclouds-labs] JCLOUDS-1432 - handle RESOURCE_NOT_FOUND, (#439)

No need for a new PR. Just squash and push+force here. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/439#issuecomment-404577707

Re: [jclouds/jclouds-labs] JCLOUDS-1432 - handle RESOURCE_NOT_FOUND, (#439)

Great to see that build, so far I had build failures resulting from different code quality validations applied for JDK7. I will squash and create a new PR. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds] Adds missing virtualMachine field to NetworkInterfaceCardProperties (#1229)

Closed #1229. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1229#event-1730749986

Re: [jclouds/jclouds] Adds missing virtualMachine field to NetworkInterfaceCardProperties (#1229)

Merged to [master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/e45c262f) and [2.1.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/cc3ad739). Thanks @danielestevez! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it

Re: [jclouds/jclouds] Adds listall methods to NetworkInterfaceCardApi and PublicIPAddressApi (#1225)

Merged to [master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/566ac233) and [2.1.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/2bddbd51). Thanks @danielestevez! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it

Re: [jclouds/jclouds] Adds listall methods to NetworkInterfaceCardApi and PublicIPAddressApi (#1225)

Closed #1225. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1225#event-1730748311

Re: [jclouds/jclouds] Adds missing virtualMachine field to NetworkInterfaceCardProperties (#1229)

nacx approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1229#pullrequestreview-136728682

Re: [jclouds/jclouds-labs] JCLOUDS-1432 - handle RESOURCE_NOT_FOUND, (#439)

And build is back to green!  @FileIOUtility mind squashing the commits so I can cleanly merge the PR? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/439#issuecomment-404567165

Re: [jclouds/jclouds] Configure Java 7 language level (#1224)

nacx commented on this pull request. > @@ -1280,7 +1280,10 @@ org.gaul modernizer-maven-plugin +

[jclouds/jclouds] Improve Jetty installation for live tests (#1230)

Notice `sudo` shouldn't be a problem as `AdminAccess` will add the `web` user to sudoers Fixes a failing test with `BaseComputeServiceLiveTest.testCreateAndRunAService` on a `CentOS 7.x` image You can view, comment on, or merge this pull request online at:

Re: [jclouds/jclouds] [JCLOUDS-1401] Properly URL-encode the CanonicalQueryString when it contains funny characters (#1226)

Thanks Ignasi! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1226#issuecomment-404406356