[
https://issues.apache.org/jira/browse/JCLOUDS-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignasi Barrera updated JCLOUDS-1436:
Fix Version/s: (was: 2.1.1)
2.2.0
> Add support for m5 instance
[
https://issues.apache.org/jira/browse/JCLOUDS-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignasi Barrera updated JCLOUDS-1387:
Fix Version/s: (was: 2.1.0)
2.2.0
> Add support for c5 instance
@VRanga000 pushed 1 commit.
97d37f7 fix: remove duplicate imports
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds/pull/1233/files/9ef582d31af1ea284c6020f80f6463c1c51bb266..97d37f74fb693e5f5f79c444208fac6cfb35aea1
Sorry! Got it now.
Please review the checkstyle since it seems to be breaking the build
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1233#issuecomment-409394722
@danielestevez thanks for the review.. no, this PR is for a different set of
instance types (m5) than #1232 (c5)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
danielestevez approved this pull request.
Thanks @VRanga000 the code looks good for those new profiles!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Isn't this the same PR as https://github.com/jclouds/jclouds/pull/1232 but with
wrong checkstyle?
If i'm right, could you please close this one?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
[
https://issues.apache.org/jira/browse/JCLOUDS-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564407#comment-16564407
]
Vikas Rangarajan commented on JCLOUDS-1436:
---
https://github.com/jclouds/jclouds/pull/1233
>
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/1233
-- Commit Summary --
* JCLOUDS-1436: Add support for aws ec2 m5 instance types
-- File Changes --
M
merged at
[master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/a5dbf006)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/441#issuecomment-409351737
Closed #441.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/441#event-1763661946
[
https://issues.apache.org/jira/browse/JCLOUDS-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564318#comment-16564318
]
ASF subversion and git services commented on JCLOUDS-1430:
--
Commit
merging now
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/441#issuecomment-409340097
Closed #442.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/442#event-1763379395
squashed and rebased. waiting for the builder to merge it. thanks @nacx
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/441#issuecomment-409311478
Squashed and merged to master as
[d74d7f62](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/d74d7f62).
There were conflicts when cherry-picking to 2.1.x. If you want it backported
there please, open a PR against that branch.
Thanks!
--
You are receiving this because you are
nacx approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/441#pullrequestreview-142069469
@alibazlamit I think there are still unaddressed issues. Can you please address
them first?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/431#issuecomment-409300125
@andreaturli pushed 1 commit.
4547b1b wip
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/441/files/f2e09f774d0d5236589bb1d2c075a887f2afaf43..4547b1b80cc47e1cfabac71e8c1747cd075cbc5b
nacx commented on this pull request.
> @@ -84,7 +84,7 @@ public static TagOptions keys(Set keys) {
private void validateInput(final String input, int maxLength) {
checkNotNull(input);
checkState(input.length() <= maxLength, String.format("input must be <=
%d chars",
20 matches
Mail list logo
