[
https://issues.apache.org/jira/browse/JCLOUDS-1428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16566172#comment-16566172
]
Andrew Gaul commented on JCLOUDS-1428:
--
jclouds implements SAS via the portable
[
https://issues.apache.org/jira/browse/JCLOUDS-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16566169#comment-16566169
]
Andrew Gaul commented on JCLOUDS-1416:
--
If you provide a self-contained test, e.g., run with {{mvn
[
https://issues.apache.org/jira/browse/JCLOUDS-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Estevez resolved JCLOUDS-1436.
-
Resolution: Fixed
> Add support for m5 instance types in AWS ec2
>
Closed #1233.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1233#event-1766308008
Pushed to
[2.1.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/e54312aa) and
[master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/cf672337) !!
Thanks @VRanga000 !!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on
Closed #1232.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1232#event-1766300928
[
https://issues.apache.org/jira/browse/JCLOUDS-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16566012#comment-16566012
]
ASF subversion and git services commented on JCLOUDS-1436:
--
Commit
[
https://issues.apache.org/jira/browse/JCLOUDS-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16566013#comment-16566013
]
ASF subversion and git services commented on JCLOUDS-1436:
--
Commit
[
https://issues.apache.org/jira/browse/JCLOUDS-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Estevez resolved JCLOUDS-1387.
-
Resolution: Fixed
> Add support for c5 instance types in AWS ec2
>
Pushed to
[master](https://github.com/jclouds/jclouds/commit/982c6bea0252689c23628079ab66998ac2a36aa9)
and
[2.1.x](https://github.com/jclouds/jclouds/commit/0ee68a5f836a654619a5bbf635e19e1d478f058e)!
Thanks @VRanga000 !!
--
You are receiving this because you are subscribed to this thread.
[
https://issues.apache.org/jira/browse/JCLOUDS-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565970#comment-16565970
]
ASF subversion and git services commented on JCLOUDS-1387:
--
Commit
[
https://issues.apache.org/jira/browse/JCLOUDS-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565968#comment-16565968
]
ASF subversion and git services commented on JCLOUDS-1387:
--
Commit
danielestevez approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1233#pullrequestreview-142542476
nacx commented on this pull request.
Thanks, @andreaturli!
There are many comments but in general, it looks pretty good.
Apart from the comments, we need proper tests for most of the things.
Basically, every class in the `compute/functions` package needs to have a
proper unit test.
Also, add
- add instance API
- add compute abstraction
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-labs/pull/443
-- Commit Summary --
* [JCLOUDS-1430] Aliyun ECS
-- File Changes --
A aliyun-ecs/README.md (47)
M
alibazlamit commented on this pull request.
> @@ -125,4 +126,28 @@ public boolean apply(Server server) {
|| server.status().percent() != 0);
}
}
+
+ @Provides
+ @Singleton
+ @Named(POLL_PREDICATE_SERVER_SUSPENDED)
I have changed it to `TIMEOUT_NODE_SUSPENDED`
@alibazlamit pushed 1 commit.
1903c2c Change POLL_PREDICATE_SERVER_SUSPENDED to TIMEOUT_NODE_SUSPENDED
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
@alibazlamit I've added a question to help the discussion. Can we start from
there?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/431#issuecomment-409595895
andreaturli commented on this pull request.
> @@ -125,4 +126,28 @@ public boolean apply(Server server) {
|| server.status().percent() != 0);
}
}
+
+ @Provides
+ @Singleton
+ @Named(POLL_PREDICATE_SERVER_SUSPENDED)
@alibazlamit why do we need this
@andreaturli Could you please let me know which issues are not addressed, i
replied to every you comment you had, some changes are applied the others are
explained as you can see.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on
[
https://issues.apache.org/jira/browse/JCLOUDS-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565110#comment-16565110
]
Timothy Anyona commented on JCLOUDS-1416:
-
Were you able to verify this from a web application?
alibazlamit commented on this pull request.
> @@ -19,6 +19,7 @@
public final class OneAndOneProperties {
public static final String POLL_PREDICATE_SERVER =
"jclouds.oneandone.rest.predicate.server";
+ public static final String POLL_PREDICATE_SERVER_SUSPENDED =
alibazlamit commented on this pull request.
>try {
- org.apache.jclouds.oneandone.rest.domain.Hardware.CreateHardware
hardwareRequest
- =
org.apache.jclouds.oneandone.rest.domain.Hardware.CreateHardware.create(cores,
1, ram, hdds);
+ if (hardwareModel
alibazlamit commented on this pull request.
> @@ -65,6 +66,7 @@
private final OneAndOneApi api;
private final Predicate waitServerUntilAvailable;
private final PasswordGenerator.Config passwordGenerator;
removed
--
You are receiving this because you are subscribed to this thread.
@alibazlamit pushed 1 commit.
7fbe8d9 minor commit
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/431/files/4b4172f6e6bc50fb3b4b023b05cb7822f9ca53d6..7fbe8d9331964a1d2b5c75918eb95abcd05cab44
25 matches
Mail list logo
