[GitHub] [jclouds] demobox commented on a change in pull request #38: Add OSGi exports to jclouds-gson
demobox commented on a change in pull request #38: Add OSGi exports to
jclouds-gson
URL: https://github.com/apache/jclouds/pull/38#discussion_r296431977
##
File path: gson/gson-bundle/pom.xml
##
@@ -0,0 +1,51 @@
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/maven-v4_0_0.xsd;>
+ 4.0.0
+
+jclouds-project
+org.apache.jclouds
+2.2.0-SNAPSHOT
+../../project/pom.xml
+
+
+ jclouds-gson
+ jclouds-gson OSGi bundle
+ jclouds-gson OSGi bundle with gson internal packages
relocated
+ bundle
+
+
+
+
org.jclouds.json.gson.internal*;version=${project.version};-noimport:=true,
+ !com.google.gson.internal*,
+ com.google.gson*;version=${project.version};-noimport:=true,
+
+*
+
+
+
Review comment:
Argh - this is what you meant by having to split the shading and the
bundling up. Grr. I guess it sort-of makes sense since the shading has to
happen before the bundle manifest generation.
Out of curiosity, did you try binding the shade plugin to a phase _before_
`package`, e.g.
[`prepare-package`](https://maven.apache.org/guides/introduction/introduction-to-the-lifecycle.html#Lifecycle_Reference)?
Definitely not important if this ends up working, I should add!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [jclouds] demobox commented on a change in pull request #38: Add OSGi exports to jclouds-gson
demobox commented on a change in pull request #38: Add OSGi exports to jclouds-gson URL: https://github.com/apache/jclouds/pull/38#discussion_r296431923 ## File path: gson/pom.xml ## @@ -26,56 +26,21 @@ ../project/pom.xml - - jclouds-gson - jclouds gson copy without internal packages - bundle + jclouds-gson-modules Review comment: [minor] Just curious what this aggregator POM does? I guess it's because we didn't want two gson-related bundles at the top level (if so, definitely agree that that)? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (JCLOUDS-1166) Remove uses of the 'com.google.gson.internal' package
[
https://issues.apache.org/jira/browse/JCLOUDS-1166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16869300#comment-16869300
]
Ignasi Barrera commented on JCLOUDS-1166:
-
The uses of the internal gson package have been relocated to a jclouds one and
using it in OSGi should no longer be an issue.
With these fixes in place we should be able to go ahead and upgrade Gson and
other dependencies that were blocking us.
> Remove uses of the 'com.google.gson.internal' package
> -
>
> Key: JCLOUDS-1166
> URL: https://issues.apache.org/jira/browse/JCLOUDS-1166
> Project: jclouds
> Issue Type: Bug
> Components: jclouds-chef, jclouds-core
>Affects Versions: 1.9.2
>Reporter: Ignasi Barrera
>Assignee: Ignasi Barrera
>Priority: Major
> Labels: gson
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Starting from Gson 2.6, the {{com.google.gson.internal}} packages are no
> longer exported in the OSGi bundles. This makes it impossible to use jclouds
> in an OSGi environment if upgrading to such versions of Gson.
> There is no change to add the exports back for that package (see [this
> discussion|https://github.com/google/gson/pull/916]), so we should stop using
> those classes.
> See also: http://markmail.org/message/olgebygfgdy3hwtm
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [jclouds] nacx merged pull request #38: Add OSGi exports to jclouds-gson
nacx merged pull request #38: Add OSGi exports to jclouds-gson URL: https://github.com/apache/jclouds/pull/38 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
