[jira] [Commented] (JCLOUDS-1558) Azureblob Azure AD OAuth2 authentication support

[Ignasi Barrera (Jira)]

[ 
https://issues.apache.org/jira/browse/JCLOUDS-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17240324#comment-17240324
 ] 

Ignasi Barrera commented on JCLOUDS-1558:
-

Also, if there is a significant amount of code copied between ARM and 
Azureblob, it would probably make sense to create and "azure" directory in: 
https://github.com/apache/jclouds/tree/master/common

> Azureblob Azure AD OAuth2 authentication support
> 
>
> Key: JCLOUDS-1558
> URL: https://issues.apache.org/jira/browse/JCLOUDS-1558
> Project: jclouds
>  Issue Type: New Feature
>  Components: jclouds-blobstore
>Affects Versions: 2.2.1
>Reporter: roded
>Priority: Major
>  Labels: azureblob
>
> We'd like to be able to access Azureblob via OAuth2 supplied by Azure AD.
> This might be similar to the OAuth2 implementation in azurecompute-arm.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (JCLOUDS-1558) Azureblob Azure AD OAuth2 authentication support

[Ignasi Barrera (Jira)]

[ 
https://issues.apache.org/jira/browse/JCLOUDS-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17240323#comment-17240323
 ] 

Ignasi Barrera commented on JCLOUDS-1558:
-

Something that comes to my mind would be to define a new property that 
configures the kind of authn to use ("oauth/sharedkey"), and based on that 
property configure the filter. You could do that in a Guice module, similar to 
what we do in the [OpenStack Keystone Auth module|http://example.com]. You'll 
have to define a provider method that returns an implementation of the 
HttpFilter. The filter is [loaded from the Guice injector based on the value of 
the 
annotation|https://github.com/apache/jclouds/blob/master/core/src/main/java/org/jclouds/rest/internal/RestAnnotationProcessor.java#L498],
 so probably you can just change the value there to just the HttpFilter 
interface, or a custom interface or base class you could define. I think that 
should work and could be clean. For backward-compatibility, the property should 
default to the current authn.

Regarding tests, it is OK if you can't test with the China region. I'll ping 
some folks I know there and see if we can get an account to try it. Apart from 
that, creating the corresponding Mock tests would be enough. Take some API 
methods and write a Mock test like the ones in the ARM provider. Mock tests use 
the mockwebserver test framework to assert the requests that are sent. This 
way, we can verify that for any given call, the requests that are generated are 
exactly the expected ones. I think adding a Mock test that verifies that the 
request is generated properly with the OAuth info is enough, as that code would 
be common to all methods.

> Azureblob Azure AD OAuth2 authentication support
> 
>
> Key: JCLOUDS-1558
> URL: https://issues.apache.org/jira/browse/JCLOUDS-1558
> Project: jclouds
>  Issue Type: New Feature
>  Components: jclouds-blobstore
>Affects Versions: 2.2.1
>Reporter: roded
>Priority: Major
>  Labels: azureblob
>
> We'd like to be able to access Azureblob via OAuth2 supplied by Azure AD.
> This might be similar to the OAuth2 implementation in azurecompute-arm.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (JCLOUDS-1558) Azureblob Azure AD OAuth2 authentication support

[roded (Jira)]

[ 
https://issues.apache.org/jira/browse/JCLOUDS-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17240275#comment-17240275
 ] 

roded commented on JCLOUDS-1558:


I've hacked the azureblob provider to support Azure AD OAuth2 by copying some 
functionality from azurecompute-arm.

I have some open points and questions though:
 # azurecompute-arm supports the v1 Azure AD endpoints. I expect azureblob to 
use the v1 endpoints as well to start with.
 # azureblob should continue to support authentication via 
SharedKeyLiteAuthentication. I'm not sure though how to allow both existing 
authentication and OAuthFilter usage (on AzureBlobClient). Are there any 
examples for modules providing multiple authentication types?
 # I don't think I'll be able to implement/test the Azure China endpoint.
 # What should the testing methodology look like for such a feature?
 # Any other relevant pointers/concerns would be appreciated.

 Thanks,

Roded

> Azureblob Azure AD OAuth2 authentication support
> 
>
> Key: JCLOUDS-1558
> URL: https://issues.apache.org/jira/browse/JCLOUDS-1558
> Project: jclouds
>  Issue Type: New Feature
>  Components: jclouds-blobstore
>Affects Versions: 2.2.1
>Reporter: roded
>Priority: Major
>  Labels: azureblob
>
> We'd like to be able to access Azureblob via OAuth2 supplied by Azure AD.
> This might be similar to the OAuth2 implementation in azurecompute-arm.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Build failed in Jenkins: JClouds » jclouds-with-credentials » jclouds-google-compute-engine-live-tests #15

[Apache Jenkins Server]

See 


Changes:


--
Started by timer
Running as SYSTEM
No JDK named ?JDK 1.8 (latest)? found
[EnvInject] - Loading node environment variables.
Building remotely on H27 (ubuntu) in workspace 

No JDK named ?JDK 1.8 (latest)? found
ERROR: A Maven installation needs to be available for this project to be 
built.Either your server has no Maven installations defined, or the requested 
Maven version does not exist.
No JDK named ?JDK 1.8 (latest)? found
No JDK named ?JDK 1.8 (latest)? found

[jira] [Updated] (JCLOUDS-1558) Azureblob Azure AD OAuth2 authentication support

[Andrew Gaul (Jira)]

 [ 
https://issues.apache.org/jira/browse/JCLOUDS-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Gaul updated JCLOUDS-1558:
-
Labels: azureblob  (was: AZURE)

> Azureblob Azure AD OAuth2 authentication support
> 
>
> Key: JCLOUDS-1558
> URL: https://issues.apache.org/jira/browse/JCLOUDS-1558
> Project: jclouds
>  Issue Type: New Feature
>  Components: jclouds-blobstore
>Reporter: roded
>Priority: Major
>  Labels: azureblob
>
> We'd like to be able to access Azureblob via OAuth2 supplied by Azure AD.
> This might be similar to the OAuth2 implementation in azurecompute-arm.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (JCLOUDS-1558) Azureblob Azure AD OAuth2 authentication support

[Andrew Gaul (Jira)]

 [ 
https://issues.apache.org/jira/browse/JCLOUDS-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Gaul updated JCLOUDS-1558:
-
Affects Version/s: 2.2.1

> Azureblob Azure AD OAuth2 authentication support
> 
>
> Key: JCLOUDS-1558
> URL: https://issues.apache.org/jira/browse/JCLOUDS-1558
> Project: jclouds
>  Issue Type: New Feature
>  Components: jclouds-blobstore
>Affects Versions: 2.2.1
>Reporter: roded
>Priority: Major
>  Labels: azureblob
>
> We'd like to be able to access Azureblob via OAuth2 supplied by Azure AD.
> This might be similar to the OAuth2 implementation in azurecompute-arm.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (JCLOUDS-1558) Azureblob Azure AD OAuth2 authentication support

[Andrew Gaul (Jira)]

[ 
https://issues.apache.org/jira/browse/JCLOUDS-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17240197#comment-17240197
 ] 

Andrew Gaul commented on JCLOUDS-1558:
--

We will happily accept pull requests which implement this feature.

> Azureblob Azure AD OAuth2 authentication support
> 
>
> Key: JCLOUDS-1558
> URL: https://issues.apache.org/jira/browse/JCLOUDS-1558
> Project: jclouds
>  Issue Type: New Feature
>  Components: jclouds-blobstore
>Reporter: roded
>Priority: Major
>  Labels: azureblob
>
> We'd like to be able to access Azureblob via OAuth2 supplied by Azure AD.
> This might be similar to the OAuth2 implementation in azurecompute-arm.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)