[jira] [Resolved] (JCLOUDS-1590) Promote glacier to core
[ https://issues.apache.org/jira/browse/JCLOUDS-1590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Gaul resolved JCLOUDS-1590. -- Fix Version/s: 2.5.0 Resolution: Fixed > Promote glacier to core > --- > > Key: JCLOUDS-1590 > URL: https://issues.apache.org/jira/browse/JCLOUDS-1590 > Project: jclouds > Issue Type: Improvement > Components: jclouds-blobstore >Affects Versions: 2.4.0 >Reporter: Andrew Gaul >Assignee: Andrew Gaul >Priority: Major > Labels: glacier > Fix For: 2.5.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > Maybe we can promote or jettison the other providers in jclouds-labs-aws as > well. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (JCLOUDS-1590) Promote glacier to core
[ https://issues.apache.org/jira/browse/JCLOUDS-1590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17461749#comment-17461749 ] ASF subversion and git services commented on JCLOUDS-1590: -- Commit a91eb7affaae71aa4a6fd71f3df45d0e9f6b520e in jclouds-labs-aws's branch refs/heads/master from Andrew Gaul [ https://gitbox.apache.org/repos/asf?p=jclouds-labs-aws.git;h=a91eb7a ] JCLOUDS-1590: Promote glacier to core > Promote glacier to core > --- > > Key: JCLOUDS-1590 > URL: https://issues.apache.org/jira/browse/JCLOUDS-1590 > Project: jclouds > Issue Type: Improvement > Components: jclouds-blobstore >Affects Versions: 2.4.0 >Reporter: Andrew Gaul >Assignee: Andrew Gaul >Priority: Major > Labels: glacier > Time Spent: 0.5h > Remaining Estimate: 0h > > Maybe we can promote or jettison the other providers in jclouds-labs-aws as > well. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (JCLOUDS-1590) Promote glacier to core
[ https://issues.apache.org/jira/browse/JCLOUDS-1590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17461742#comment-17461742 ] ASF subversion and git services commented on JCLOUDS-1590: -- Commit 3bbb0b446ac6945d18908e2009b203685738df75 in jclouds's branch refs/heads/master from Andrew Gaul [ https://gitbox.apache.org/repos/asf?p=jclouds.git;h=3bbb0b4 ] JCLOUDS-1590: Promote glacier to core > Promote glacier to core > --- > > Key: JCLOUDS-1590 > URL: https://issues.apache.org/jira/browse/JCLOUDS-1590 > Project: jclouds > Issue Type: Improvement > Components: jclouds-blobstore >Affects Versions: 2.4.0 >Reporter: Andrew Gaul >Assignee: Andrew Gaul >Priority: Major > Labels: glacier > Time Spent: 20m > Remaining Estimate: 0h > > Maybe we can promote or jettison the other providers in jclouds-labs-aws as > well. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (JCLOUDS-1333) Cannot compile jclouds with Guava 21+
[
https://issues.apache.org/jira/browse/JCLOUDS-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17461740#comment-17461740
]
ASF subversion and git services commented on JCLOUDS-1333:
--
Commit 3e25b835c6b9b3495a6435b16a3cfa9a1bc87249 in jclouds's branch
refs/heads/master from Andrew Gaul
[ https://gitbox.apache.org/repos/asf?p=jclouds.git;h=3e25b83 ]
JCLOUDS-1333: Fix Guava 21 issues
> Cannot compile jclouds with Guava 21+
> -
>
> Key: JCLOUDS-1333
> URL: https://issues.apache.org/jira/browse/JCLOUDS-1333
> Project: jclouds
> Issue Type: Improvement
> Components: jclouds-core
>Affects Versions: 2.1.0
>Reporter: Andrew Gaul
>Assignee: Andrew Gaul
>Priority: Major
> Labels: guava
> Fix For: 2.3.0
>
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> jclouds has compatibility with Guava 18-22 but we cannot compile using 21+
> due to some kind of Guava vs Java 8 Function class type error:
> {noformat}
> /home/gaul/work/jclouds/core/src/main/java/org/jclouds/rest/internal/TransformerForRequest.java:102:
> error: method compose in interface java.util.function.Function cannot
> be applied to given types;
> transformer = compose(Function.class.cast(wrappingTransformer),
> transformer);
>^
> required: java.util.function.Function
> found:
> com.google.common.base.Function,com.google.common.base.Function
> reason: cannot infer type-variable(s) V
> (actual and formal argument lists differ in length)
> where V,T,R are type-variables:
> V extends Object declared in method
> compose(java.util.function.Function)
> T extends Object declared in interface java.util.function.Function
> R extends Object declared in interface java.util.function.Function
> where CAP#1 is a fresh type-variable:
> CAP#1 extends Object from capture of ?
> /home/gaul/work/jclouds/core/src/main/java/org/jclouds/rest/internal/TransformerForRequest.java:189:
> error: method compose in interface java.util.function.Function cannot
> be applied to given types;
> transformer = compose(new OnlyElementOrNull(), transformer);
> ^
> required: java.util.function.Function
> found:
> OnlyElementOrNull,com.google.common.base.Function
> reason: cannot infer type-variable(s) V
> (actual and formal argument lists differ in length)
> where V,T,R are type-variables:
> V extends Object declared in method
> compose(java.util.function.Function)
> T extends Object declared in interface java.util.function.Function
> R extends Object declared in interface java.util.function.Function
> where CAP#1 is a fresh type-variable:
> CAP#1 extends Object from capture of ?
> {noformat}
> This does not affect applications from using Guava 21-22 but does impact our
> compatibility testing. Note that you need to set {{maven.compile.source}} to
> 1.8 to test Guava 21+.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (JCLOUDS-1589) Upgrade to Log4j 2.16.0
[ https://issues.apache.org/jira/browse/JCLOUDS-1589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17461741#comment-17461741 ] ASF subversion and git services commented on JCLOUDS-1589: -- Commit 66ef18c6ae9983f13a9c1402520598eb8a2fdf6e in jclouds's branch refs/heads/master from Andrew Gaul [ https://gitbox.apache.org/repos/asf?p=jclouds.git;h=66ef18c ] JCLOUDS-1589: Upgrade to log4j 2.16.0 This addresses a critical CVE: https://logging.apache.org/log4j/2.x/security.html > Upgrade to Log4j 2.16.0 > --- > > Key: JCLOUDS-1589 > URL: https://issues.apache.org/jira/browse/JCLOUDS-1589 > Project: jclouds > Issue Type: Improvement > Components: jclouds-drivers >Affects Versions: 2.4.0 >Reporter: Andrew Gaul >Assignee: Andrew Gaul >Priority: Major > Labels: log4j > Fix For: 2.5.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > 2.15.0 fixes a critical CVE: > [https://logging.apache.org/log4j/2.x/security.html] -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [jclouds] asfgit merged pull request #127: JCLOUDS-1590: Promote glacier to core
asfgit merged pull request #127: URL: https://github.com/apache/jclouds/pull/127 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@jclouds.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [jclouds] gaul commented on a change in pull request #127: JCLOUDS-1590: Promote glacier to core
gaul commented on a change in pull request #127:
URL: https://github.com/apache/jclouds/pull/127#discussion_r771469583
##
File path: apis/glacier/pom.xml
##
@@ -0,0 +1,249 @@
+
+
+http://www.w3.org/2001/XMLSchema-instance;
xmlns="http://maven.apache.org/POM/4.0.0;
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/maven-v4_0_0.xsd;>
+ 4.0.0
+
+org.apache.jclouds
+jclouds-project
+2.5.0-SNAPSHOT
+../../project/pom.xml
+
+
+ org.apache.jclouds.api
+ glacier
+ Apache jclouds :: AWS :: Glacier API
+ jclouds components to access an implementation of
glacier
+
+
+FIXME_IDENTITY
+FIXME_CREDENTIAL
+
https://glacier.us-east-1.amazonaws.com
+2012-06-01
+
+${test.aws.identity}
+${test.aws.credential}
+
+
+
+
+ apache-snapshots
+ https://repository.apache.org/content/repositories/snapshots
+
+false
+
+
+true
+
+
+
+
+
+
+
+ apache-snapshots
+ https://repository.apache.org/content/repositories/snapshots
+
+false
+
+
+true
+
+
+
Review comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@jclouds.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [jclouds] nacx commented on a change in pull request #127: JCLOUDS-1590: Promote glacier to core
nacx commented on a change in pull request #127:
URL: https://github.com/apache/jclouds/pull/127#discussion_r771314072
##
File path: apis/glacier/pom.xml
##
@@ -0,0 +1,249 @@
+
+
+http://www.w3.org/2001/XMLSchema-instance;
xmlns="http://maven.apache.org/POM/4.0.0;
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/maven-v4_0_0.xsd;>
+ 4.0.0
+
+org.apache.jclouds
+jclouds-project
+2.5.0-SNAPSHOT
+../../project/pom.xml
+
+
+ org.apache.jclouds.api
+ glacier
+ Apache jclouds :: AWS :: Glacier API
+ jclouds components to access an implementation of
glacier
+
+
+FIXME_IDENTITY
+FIXME_CREDENTIAL
+
https://glacier.us-east-1.amazonaws.com
+2012-06-01
+
+${test.aws.identity}
+${test.aws.credential}
+
+
+
+
+ apache-snapshots
+ https://repository.apache.org/content/repositories/snapshots
+
+false
+
+
+true
+
+
+
+
+
+
+
+ apache-snapshots
+ https://repository.apache.org/content/repositories/snapshots
+
+false
+
+
+true
+
+
+
Review comment:
We should probably remove this from here and just inherit these settings?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@jclouds.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [jclouds] gaul commented on a change in pull request #125: JCLOUDS-1587 S3 Blobstore: Support Bucket Configuration Options - Versioning, Lifecycle, Encryption
gaul commented on a change in pull request #125:
URL: https://github.com/apache/jclouds/pull/125#discussion_r746509476
##
File path:
apis/s3/src/main/java/org/jclouds/s3/domain/internal/ListVersionsResponseImpl.java
##
@@ -0,0 +1,208 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.jclouds.s3.domain.internal;
+
+import java.util.LinkedHashSet;
+import java.util.Set;
+
+import com.google.common.collect.Iterables;
+
+import org.jclouds.s3.domain.ListVersionsResponse;
+import org.jclouds.s3.domain.ObjectMetadata;
+
+public class ListVersionsResponseImpl extends LinkedHashSet
+implements ListVersionsResponse {
+
+protected final String name;
+protected final String prefix;
+protected final int maxKeys;
+protected final String delimiter;
+protected final String marker;
+protected final String nextMarker;
+protected final Set commonPrefixes;
+protected final boolean truncated;
+protected final String nextVersionIdMarker;
+protected final String versionIdMarker;
+
+public ListVersionsResponseImpl(String name,
+Iterable version,
+String prefix, String marker,
+String nextMarker, int maxKeys,
+String delimiter, boolean truncated,
+Set commonPrefixes
+) {
+Iterables.addAll(this, version);
+this.name = name;
+this.prefix = prefix;
+this.maxKeys = maxKeys;
+this.delimiter = delimiter;
+this.marker = marker;
+this.nextMarker = nextMarker;
+this.commonPrefixes = commonPrefixes;
+this.truncated = truncated;
+this.nextVersionIdMarker = null;
+this.versionIdMarker = null;
+}
+
+
+/**
+ * {@inheritDoc}
+ */
+@Override
+public Set getCommonPrefixes() {
+return commonPrefixes;
+}
+
+@Override
+public String getNextVersionIdMarker() {
+return null;
+}
+
+@Override
+public String getVersionIdMarker() {
+return null;
+}
+
+/**
+ * {@inheritDoc}
+ */
+@Override
+public String getDelimiter() {
+return delimiter;
+}
+
+/**
+ * {@inheritDoc}
+ */
+@Override
+public String getMarker() {
+return marker;
+}
+
+/**
+ * {@inheritDoc}
+ */
+@Override
+public String getNextMarker() {
+return nextMarker;
+}
+
+/**
+ * {@inheritDoc}
+ */
+@Override
+public int getMaxKeys() {
+return maxKeys;
+}
+
+/**
+ * {@inheritDoc}
+ */
+@Override
+public String getPrefix() {
+return prefix;
+}
+
+/**
+ * {@inheritDoc}
+ */
+@Override
+public boolean isTruncated() {
+return truncated;
+}
+
+/**
+ * {@inheritDoc}
+ */
+@Override
+public String getName() {
+return name;
+}
+
+@Override
+public int hashCode() {
+final int prime = 31;
+int result = super.hashCode();
+result = prime * result +
+((commonPrefixes == null) ? 0 : commonPrefixes.hashCode());
+result =
+prime * result + ((delimiter == null) ? 0 : delimiter.hashCode());
+result = prime * result + ((marker == null) ? 0 : marker.hashCode());
+result = prime * result + maxKeys;
+result = prime * result + ((name == null) ? 0 : name.hashCode());
+result = prime * result + ((prefix == null) ? 0 : prefix.hashCode());
+result = prime * result + (truncated ? 1231 : 1237);
+return result;
+}
+
+@Override
+public boolean equals(Object obj) {
Review comment:
Can you implement these in terms of `Objects.hash` and `Objects.equal`
as below?
##
File path: apis/s3/src/main/java/org/jclouds/s3/blobstore/S3BlobStore.java
##
@@ -174,7 +189,12 @@ public void setContainerAccess(String container,
ContainerAccess access) {
@Override
public PageSet list(String container,
ListContainerOptions options) {
ListBucketOptions
