@@ -70,7 +76,14 @@
public BaseGoogleComputeEngineApiLiveTest() {
- provider = google-compute-engine;
+ this.provider = google-compute-engine;
not sure why this happens, I'll revert as it seems more common on jclouds
---
Reply to this email directly or view it on GitHub:
@@ -56,7 +57,7 @@ public FirewallOptions addAllowedRule(Firewall.Rule
allowedRule) {
/**
* @see org.jclouds.googlecomputeengine.domain.Firewall#getAllowed()
*/
- public FirewallOptions allowedRules(SetFirewall.Rule allowedRules) {
+ public FirewallOptions
@demobox I think this PR needs to be applied first to 1.7.x and to `master` as
well. Are you suggesting a different workflow?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/296#issuecomment-36007673
Hi Ignasi,
I think you are right, a little of context could definitely ease the review.
Recently I've been working with SoftLayer and I tried to fix some blocking
issue (PR#200, PR#204) but unfortunately they didn't fix them all.
In particular VirtualGuestToNodeMetadata happens to be slow and
a VirtualGuest into a json string valid for creating a CCI via
softlayer api
+ * The string is set into the payload of the HttpRequest
+ *
+ * @author Andrea Turli
+ */
+public class VirtualGuestToJson implements Binder {
I agree with you but in the jclouds philosophy I think VirtualGuestApi
@@ -197,20 +181,4 @@ public SoftLayerTemplateOptions userMetadata(MapString,
String userMetadata) {
public SoftLayerTemplateOptions userMetadata(String key, String value) {
return SoftLayerTemplateOptions.class.cast(super.userMetadata(key,
value));
}
-
- /**
-*
@@ -135,100 +148,129 @@ public SoftLayerComputeServiceAdapter(SoftLayerApi
client,
checkState(orderInSystem, order for guest %s doesn't have login
details within %sms, result,
Long.toString(guestLoginDelay));
it is actually a good idea. Not sure if any other provider
Thank you very much for your review, Ignasi!
I think your comments make really sense to me and the summary is quite useful
Sorry for the missing (important!) tests but I'll add them while I address your
comments.
---
Reply to this email directly or view it on GitHub:
+ private final int statusId;
+ private final String mountType;
+ private final String mountMode;
+ private final int bootableFlag;
+ private final String device;
+ private final VirtualDiskImage virtualDiskImage;
+ private final VirtualGuest guest;
+
+
+ private final int statusId;
+ private final String mountType;
+ private final String mountMode;
+ private final int bootableFlag;
+ private final String device;
+ private final VirtualDiskImage virtualDiskImage;
+ private final VirtualGuest guest;
+
+
@Consumes(MediaType.APPLICATION_JSON)
- @Fallback(Fallbacks.NullOnNotFoundOr404.class)
- ProductPackage getProductPackage(@PathParam(id) long id);
+ @Fallback(Fallbacks.EmptySetOnNotFoundOr404.class)
+ SetSoftwareDescription getAllObjects();
@nacx this confuses me as well: the
* @see
org.jclouds.googlecomputeengine.features.FirewallApi#patch(String,
org.jclouds.googlecomputeengine.options.FirewallOptions)
*/
- private void getOrCreateFirewalls(GoogleComputeEngineTemplateOptions
templateOptions, Network network,
-
/**
* @author Adrian Cole
*/
@Test(groups = unit, testName = VirtualGuestToNodeMetadataTest)
public class VirtualGuestToNodeMetadataTest {
+
+ // TODO
+ /*
I think this test doesn't make sense anymore as the VirtualGuestToNodeMetadata
is now really simpler.
---
Reply to this
@nacx I've addressed all of your comments but the 'rename API methods' as we
are still waiting for opinions from @demobox
The LiveTests are quite ok but still not perfect
Results :
Tests run: 150, Failures: 18, Errors: 0, Skipped: 13
The failures come from `SoftLayerTemplateBuilderLiveTest`
You can merge this Pull Request by running:
git pull https://github.com/andreaturli/jclouds-labs master
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-labs/pull/57
-- Commit Summary --
* [JCLOUDS-500] Initial commit for docker
-- File Changes
+ @QueryParam(limit) String limit,
+ @QueryParam(since) String since,
+ @QueryParam(before) String before);
+
+ /**
+* List containers
+*
+* @return the running containers.
+*/
+ @Named(containers:list)
+ @GET
+
+ locationBuilder.description();
+ locationBuilder.id();
+ locationBuilder.scope(LocationScope.HOST);
+ nodeMetadataBuilder.location(locationBuilder.build());
+ // TODO setup hardware and hostname properly
+ if (container.getStatus() != null) {
+
+ }
+
+ private int getLoginPort(Container container) {
+ if (container.getNetworkSettings() != null) {
+ MapString, ListMapString,String ports =
container.getNetworkSettings().getPorts();
+ if(ports != null) {
+return
+ */
+@Singleton
+public class DockerComputeServiceAdapter implements
+ComputeServiceAdapterContainer, Hardware, Image, Location {
+
+ @Resource
+ @Named(ComputeServiceConstants.COMPUTE_LOGGER)
+ protected Logger logger = Logger.NULL;
+
+ private final DockerApi api;
+
+import com.google.common.base.Splitter;
+import com.google.common.collect.Iterables;
+
+import static com.google.common.collect.Iterables.getLast;
+
+/**
+ * @author Andrea Turli
+ */
+public class OperatingSystems {
+
+ public static FunctionString, Integer bits() {
+ return
Password pw = get(result.getOperatingSystem().getPasswords(), 0);
return new NodeAndInitialCredentialsVirtualGuest(result,
result.getId() + ,
LoginCredentials.builder().user(pw.getUsername()).password(
pw.getPassword()).build());
}
- private
+List? extends Volume volumes2 = h2.getVolumes();
+ComparisonChain comparisonChain =
ComparisonChain.start().compare(getCores(h1), getCores(h2))
+.compare(h1.getRam(), h2.getRam())
+.compare(getSpace(h1), getSpace(h2))
+
@@ -107,13 +176,30 @@ protected ConcreteBuilder self() {
private final String country;
private final String state;
private final String description;
+ private final int accountId;
+ private final String address;
good spot, thanks!
---
Reply to this email directly or view
}
@Override
public String toString() {
- return string().toString();
+ return OperatingSystem{ +
+ id=' + id + '\'' +
Stupid IDE :)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/296/files#r11151050
+ @Nullable
+ public SoftwareDescription getSoftwareDescription() {
+ return this.softwareDescription;
+ }
+
+ @Override
+ public int hashCode() {
+ return Objects.hashCode(id);
+ }
+
+ @Override
+ public boolean equals(Object obj) {
+ if (this == obj)
As per https://developers.google.com/compute/docs/operating-systems, I#39;ve
added the RHEL, SUSE and Windows support to listImages and getImage
You can merge this Pull Request by running:
git pull https://github.com/andreaturli/jclouds-labs-google
feature/add-operating-systems
Or you can
.build();
}
@Override
public Image getImage(String id) {
return
Objects.firstNonNull(api.getImageApiForProject(userProject.get()).get(id),
-
Objects.firstNonNull(api.getImageApiForProject(DEBIAN_PROJECT).get(id),
-
@imesh this provider is still at its early stage but it covers all of the
CRUD operations offerred by remote api for image management and container
management.
How do you plan to contribute?
---
Reply to this email directly or view it on GitHub:
return
Objects.firstNonNull(api.getImageApiForProject(userProject.get()).get(id),
-
Objects.firstNonNull(api.getImageApiForProject(DEBIAN_PROJECT).get(id),
-
Hi @imesh thanks for your presentation. If you cat test it that would be great!
Please let us know your result/experience/suggestion eithere here or (better)
on jclouds ml. Thanks!
---
Reply to this email directly or view it on GitHub:
Thanks @demobox I will.
Not sure about the latest 2 checkstyle violations: any hint?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/57#issuecomment-40726804
https://issues.apache.org/jira/browse/JCLOUDS-550
You can merge this Pull Request by running:
git pull https://github.com/andreaturli/jclouds-labs-google
fix/machineType-obsolete
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-labs-google/pull/24
@abayer @ignasi, do you mind to have a look and merge it if fine? thanks
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/24#issuecomment-41392055
Thanks @nacx, your first comment is a very good spot: maybe better to remove
the checkNotNull, ok?
For you second comment: would it make sense to add a tag to the hardware to
store the deprecated status, so that one can filter on it?
---
Reply to this email directly or view it on GitHub:
+dependency
+groupIdorg.apache.jclouds.driver/groupId
+artifactIdjclouds-sshj/artifactId
+version${project.version}/version
+scopetest/scope
+/dependency
+dependency
+
}
public Builder fromMachineType(MachineType in) {
return
super.fromResource(in).memoryMb(in.getMemoryMb()).imageSpaceGb(in.getImageSpaceGb()).scratchDisks(in
.getScratchDisks()).maximumPersistentDisks(in.getMaximumPersistentDisks())
-
+ api.getMachineTypeApiForProject(userProject.get())
+ .listInZone(DEFAULT_ZONE_NAME)
+ .concat()
+ .filter(new PredicateMachineType() {
+ @Override
+ public boolean
I've addressed your comments and test @mikolajz CreateServer. The example is
fine, but .smallest() doesn't return f1-micro but n1-standard-1 as it is the
first hardware that supports the image required. In fact
MachineTypeInZoneToHardware.apply has this logic where
```
+ .id()
+ .ram(container.getConfig().getMemory())
+ .processor(new
Processor(container.getConfig().getCpuShares(),
container.getConfig().getCpuShares()))
+ .build());
+ // TODO Set up location
+
builder.operatingSystem(OperatingSystem.builder().description(linux).family(OsFamily.LINUX).build());
+ return builder.build();
+ }
+
+ private String cleanUpName(String name) {
+ return name.startsWith(/) ? name.substring(1) : name;
+ }
+
+ private
+
+ @Inject
+ public DockerComputeServiceAdapter(DockerApi api) {
+ this.api = checkNotNull(api, api);
+ }
+
+ @Override
+ public NodeAndInitialCredentialsContainer
createNodeWithGroupEncodedIntoName(String group, String name,
+
+ @SuppressWarnings(unchecked)
+ @Override
+ public R extends HttpRequest R bindToRequest(R request, Object input) {
+ checkArgument(checkNotNull(input, input) instanceof File, this
binder is only valid for File!);
+ checkNotNull(request, request);
+
+ File dockerFile
+*/
+ @Named(images:list)
+ @GET
+ @Path(/images/json)
+ @Fallback(Fallbacks.EmptySetOnNotFoundOr404.class)
+ SetImage listImages(ListImageOptions options);
+
+ /**
+* Inspect an image
+*
+* @param imageId The id of the image to inspect.
+* @return
+ }
+
+ @Override
+ public IterableLocation listLocations() {
+ return ImmutableSet.of();
+ }
+
+ @Override
+ public Container getNode(String id) {
+ return api.getRemoteApi().inspectContainer(id);
+ }
+
+ @Override
+ public void destroyNode(String id) {
@imesh Thanks for your feedback.
That's odd because I can see
```
$ mvn dependency:tree|grep guava
[INFO] | \- com.google.guava:guava:jar:17.0:compile
```
and I can build jclouds docker master
Are you using jclouds-docker from another application as @andrewgaul was
guessing?
---
Reply to
@igreenfield Thanks for resuming my old work on jclouds-vsphere
(https://github.com/jclouds/legacy-jclouds/pull/910) with this refreshed PR.
I'd have appreciated to be in the loop to help.
Also, I think this PR should be issued against jclouds/jclouds-lab project.
@nacx @demobox wdyt?
---
+ destroyNode(container.getId());
+ throw new IllegalStateException(String.format(Container %s has not
started correctly, container.getId()));
+ }
+ return new NodeAndInitialCredentialsContainer(container,
container.getId(),
+
To simplify the extension of this Live test.
This don#39;t change the behavior of the test but it should simplify the
testing of some apis, like docker, that needs to inject a particular template
built with `buildTemplate` across all the tests in this class.
You can merge this Pull Request by
Here you can find the result of `mvn clean install -Plive`
https://gist.github.com/andreaturli/595ce6e44a987ed5be06
unfortunately there are still issue with the DockerComputeServiceLiveTest but I
think it is good to be accepted on jclouds-labs at least and fix liveTests
there, if you agree
@@ -47,17 +47,17 @@ public DatacenterToLocation(JustProvider provider) {
@Override
public Location apply(Datacenter datacenter) {
-return new LocationBuilder().scope(LocationScope.ZONE)
-.metadata(ImmutableMap.String,
Objectof())
+ String operatingSystemReferenceCode =
checkNotNull(virtualGuest.getOperatingSystem()
+ .getOperatingSystemReferenceCode(),
operatingSystemReferenceCode);
+ templateObject = new TemplateObject(hostname, domain, startCpus,
maxMemory, true,
+
It modernizes SoftLayer CCI support by re-using the same API calls used by
SoftLayer Python client.
The implementation should be not more easily maintainable and robust.
You can merge this Pull Request by running:
git pull https://github.com/andreaturli/jclouds new/softlayer-cci
Or you can
Closed #296.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/296#event-137605769
great @nacx! Thanks again for your valuable reviews
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/57#issuecomment-48165987
You can merge this Pull Request by running:
git pull https://github.com/andreaturli/jclouds-site feature/docker
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-site/pull/110
-- Commit Summary --
* add docker guide
-- File Changes --
M
@nacx could you merge it now?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/110#issuecomment-49020978
Thanks @nacx, not sure why I don't get notification from this repo :+1:
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/110#issuecomment-49040391
@nacx please find the result of `mvn clean install -Plive` on that
[gist](https://gist.github.com/andreaturli/ae37d84c446c5f0f182c)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/431#issuecomment-49044336
Lgtm :+1
Thanks @aledsage for taking care of it
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/69#issuecomment-49331519
The error reported by the builders is now for cdmi, similar issue
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/69#issuecomment-49332591
Hi @andrewgaul I'm not able to do that just now as I don't have access to my
laptop for next 2 weeks. Sorry about that.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/431#issuecomment-49499874
Sorry @ashmrtnz I still need to address them. I should have time next week,
though, if it is fine for you.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/22#issuecomment-50678291
Hi @andrewgaul I was looking now at the checkstyle violations but you already
fix them: thanks!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/431#issuecomment-51002371
Hi @Icheng61 I've documented an initial example at
http://jclouds.apache.org/guides/docker/. Please give it a go and let us know
the result.
---
Reply to this email directly or view it on GitHub:
By default, Docker assigns a NAT'ed IP to the created container which is parsed
in the Container domain class
If you need more advanced networking configuration you can try
http://jpetazzo.github.io/2013/10/16/configure-docker-bridge-network/ or
https://docs.docker.com/articles/networking/ but
You can merge this Pull Request by running:
git pull https://github.com/andreaturli/jclouds-site patch-1
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-site/pull/122
-- Commit Summary --
* Update docker.md
-- File Changes --
M
Hi @demobox I think it should be ok now with PR
https://github.com/jclouds/jclouds/pull/476
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/472#issuecomment-51773373
You can merge this Pull Request by running:
git pull https://github.com/andreaturli/jclouds fix/sl-checkstyle-violations
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/476
-- Commit Summary --
* fix ASF copyright headers on SoftLayer
--
+
+ /**
+* Returns the specified ForwardingRule resource.
+*
+* @param region the name of the region scoping this request.
+* @param forwardingRule the name of the ForwardingRule resource to
return.
+* @return a ForwardingRule resource.
+*/
+
You can merge this Pull Request by running:
git pull https://github.com/andreaturli/jclouds fix/JCLOUDS-662
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/479
-- Commit Summary --
* fix creation of blockDevices using
squashed and rebased! thanks @demobox!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/479#issuecomment-51922305
@@ -79,6 +80,15 @@
FirewallApi getFirewallApiForProject(@PathParam(project) String
projectName);
/**
+* Provides access to ForwardingRule features
+*
+* @param projectName the name of the project
+*/
+ @Delegate
+ @Path(/projects/{project})
@jdaggett
fix creation of blockDevices using SoftLayerTemplateOptions
You can merge this Pull Request by running:
git pull https://github.com/andreaturli/jclouds 1.8.x
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/484
-- Commit Summary --
* fix
Brilliant! So you can remove vijava dependency right now from pom.xml!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/61#issuecomment-54031325
+name: sampledb
+}
+],
+host: %,
+name: demouser
+}
+]
+}
+{% endhighlight %}
+
+To parse the response, jclouds uses [domain
Hi Jai,
To run live tests please have a look at
http://wiki.apache.org/jclouds/Testing
where for provider you need softlayer.
HTH,
Andrea
Il 28/set/2014 04:02 jaiganeshm notificati...@github.com ha scritto:
Pls find the stack trace in the below gist link
+
+ /**
+* Creates a ForwardingRule resource in the specified project and region
using the data included in the request.
+*
+* @param forwardingRuleName the name of the forwarding rule.
+* @param targetSelfLink the URL of the target resource to receive the
matched
+ @Transform(ParseTargetPools.ToPagedIterable.class)
+ @Fallback(EmptyPagedIterableOnNotFoundOr404.class)
+ PagedIterableTargetPool listInRegion(@PathParam(region) String
region);
+
+ @Named(TargetPools:list)
+ @GET
+ @Consumes(MediaType.APPLICATION_JSON)
+
org.testng.Assert.assertEquals;
+import static org.testng.Assert.assertTrue;
+import static org.testng.AssertJUnit.assertNull;
+
+/**
+ * @author Andrea Turli
+ */
+@Test(groups = unit)
+public class ForwardingRuleApiExpectTest extends
BaseGoogleComputeEngineApiExpectTest {
it is probably a good idea
+
+ /**
+* Creates a ForwardingRule resource in the specified project and region
using the data included in the request.
+*
+* @param forwardingRuleName the name of the forwarding rule.
+* @param targetSelfLink the URL of the target resource to receive the
matched
Thanks @jaiganeshm I'll review that asap, so that we can merge it soon.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/531#issuecomment-57944005
You can merge this Pull Request by running:
git pull https://github.com/andreaturli/jclouds fix/private-images
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/568
-- Commit Summary --
* fix support for private images in SoftLayer
-- File
thank @nacx I took the occasion to refactor listImages a bit more, now looks to
me simpler to read and maintain. Thoughts?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/568#issuecomment-58666540
Thanks @demobox Main reason for this cleanup is that the private image support
is currently `broken` so it would be nice to have that merged soon.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/568#issuecomment-58907317
Thanks @adriancole @demobox, I've addressed your comments and I've got a LGTM
so good to merge
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/568#issuecomment-59002034
@demobox, I've cherry-picked the commit onto master, shall I close the PR
manually?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/568#issuecomment-59170282
Closed #568.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/568#event-179079167
You can merge this Pull Request by running:
git pull https://github.com/andreaturli/jclouds-site feature/softlayer
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-site/pull/134
-- Commit Summary --
* add softlayer getting started
-- File
tdsoftlayer/td
-td/td
+tdSG,US-CA,US-TX,US-VA,US-WA,NL,HK,NSFTW-IL,AU,CA-ON,GB/td
great idea! thanks
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/134/files#r18943488
+
+{% highlight java %}
+// Get a context with softlayer that offers the portable BlobStore API
+BlobStoreContext context = ContextBuilder.newBuilder(swift)
+ .credentials(tenantName:accessKey, apiKey)
+
@jdaggett do you think it is good to merge it?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/134#issuecomment-59516058
@jdaggett yeah maybe it is less confusing, thanks!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/134#issuecomment-59572197
@jdaggett can we close that?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/134#issuecomment-60057592
thanks @danbroudy for your help. I've pushed my latest changes which address
most of the comments but probably need some more polish. Feel free to continue
from here, Happy to review your changes once finished with @ccustine
---
Reply to this email directly or view it on GitHub:
- add support for primaryNetworkComponent.networkVlan.id,
primaryBackendNetworkComponent.networkVlan.id, postInstallScriptUri, user-data,
privateNetworkOnly via SoftLayerTemplateOptions
You can merge this Pull Request by running:
git pull https://github.com/andreaturli/jclouds master
Or you
@demobox could you please have a look and merge it if ok
it is a simple commit but I need to apply it to master and 1.8.x asap. Thanks!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/582#issuecomment-60369268
merged
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/582#issuecomment-60394241
it backports to 1.8.x
-
https://github.com/jclouds/jclouds/commit/a563dd9fbb7fcca3ba0606ec548f655012bb2d4f
-
https://github.com/jclouds/jclouds/commit/f134367c692c70b560c7ba1d6408277725185361
You can merge this Pull Request by running:
git pull https://github.com/andreaturli/jclouds 1.8.x
lgtm :+1: thanks for this cleanup
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/65#issuecomment-60490322
public class DiskCreationBinder extends BindToJsonPayload {
- @Inject
- public DiskCreationBinder(Json jsonBinder) {
+ @Inject public DiskCreationBinder(Json jsonBinder) {
Is this style preferable? why?
---
Reply to this email directly or view it on GitHub:
1 - 100 of 1591 matches
Mail list logo
