Re: [jclouds/jclouds-karaf] Improvements to feature (#92)

andreaturli commented on this pull request. > jclouds-compute -mvn:org.apache.jclouds.api/oauth/${jclouds.version} -mvn:org.apache.jclouds.common/googlecloud/${jclouds.version} - mvn:org.apache.jclouds.provider/google-compute-engine/${jclouds.version} +

Re: [jclouds/jclouds-karaf] fix netty dependency (#96)

merged at [master](https://git1-us-west.apache.org/repos/asf?p=jclouds-karaf.git;a=commit;h=34e42d6e) and [2.0.x](http://git-wip-us.apache.org/repos/asf/jclouds-karaf/commit/e5f42e6d) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it

Re: [jclouds/jclouds-karaf] fix netty dependency (#96)

Closed #96. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/96#event-951023357

Re: [jclouds/jclouds-karaf] [DO NOT MERGE YET] Improvements to feature (#92)

andreaturli commented on this pull request. > + private static final String FEATURES_XML = "features.xml"; + + @Inject + FeaturesService featuresService; + + static File getFeaturesFile() throws URISyntaxException { + String featuresXml = System.getProperty(FEATURES_XML); +

Re: [jclouds/jclouds-karaf] [DO NOT MERGE YET] Improvements to feature (#92)

andreaturli commented on this pull request. > + dependency='true'>mvn:org.apache.jclouds.common/googlecloud/${jclouds.version} + mvn:org.apache.jclouds.labs/google-cloud-storage/${jclouds.version} + + + +jclouds-compute +

Re: [jclouds/jclouds-karaf] [DO NOT MERGE YET] Improvements to feature (#92)

@andreaturli pushed 1 commit. b729de9 marked ServiceTest as Ignore -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/92/files/cce384781721d6b62a669afb6e542d9a671f69d7..b729de9b8955d16a71c59f8ca04c83441b2ce99d

Re: [jclouds/jclouds-karaf] [DO NOT MERGE YET] Improvements to feature (#92)

@andreaturli pushed 1 commit. cce3847 use setUp() -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/92/files/2da76832a22dfc51bc84cd3f2f4024f8aafe2992..cce384781721d6b62a669afb6e542d9a671f69d7

Re: [jclouds/jclouds] [JCLOUDS-1233] bump jax-rs version (#1057)

thanks @zack-shoylev my fork was not in sync, sorry about that -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1057#issuecomment-277435074

Re: [jclouds/jclouds-karaf] [DO NOT MERGE] Improvements/feature (#92)

@andreaturli pushed 4 commits. 0d5f154 add drivers features 74294c9 add allcompute and allblobstore feature a22532c add FeatureLabsInstallationTest - wip 0303bad fix FeatureLabsInstallationTest -- You are receiving this because you are subscribed to this thread. View it on GitHub:

[jclouds/jclouds] update import packages for netty (#1058)

You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/1058 -- Commit Summary -- * update import packages for netty -- File Changes -- M drivers/netty/pom.xml (2) -- Patch Links -- https://github.com/jclouds/jclouds/pull/1058.patch

[jclouds/jclouds] [JCLOUDS-1233] bump jax-rs version (#1057)

/cc @nacx and @neykov You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/1057 -- Commit Summary -- * [JCLOUDS-1233] bump jax-rs version -- File Changes -- M core/pom.xml (4) -- Patch Links --

Re: [jclouds/jclouds-labs] Add Load Balancer APIs (#356)

andreaturli commented on this pull request. > +import com.google.common.base.Function; +import com.google.common.cache.LoadingCache; + +@Singleton +public class TemplateToAvailabilitySet implements Function { + + @Resource +

Re: [jclouds/jclouds-labs] Add Load Balancer APIs (#356)

excellent @nacx lgtm Thanks! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/356#issuecomment-277215550

Re: [jclouds/jclouds] [JCLOUDS-1233] bump jax-rs version (#1057)

agreed changed to `2.1.0`, also testing jclouds-labs-* with the new jclouds/jclouds -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1057#issuecomment-277255917

Re: [jclouds/jclouds-site] Added Packet and Vagrant (#194)

+1 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/194#issuecomment-276503644

Re: [jclouds/jclouds-labs-aws] Health check and Subnet API (#70)

Thanks @justinThompson great start! As you are adding `HealthCheckApi` and `SubnetApi` could you also add the `*ExpectTest`s for those APIs, along the `*LiveTest`s ? It could be interesting to know that the style of those `ExpectTest` is actually deprecated as jclouds is adopting a (simpler)

Re: [jclouds/jclouds-labs] add remaining features to support the abstraction (#345)

I've found that they have changed the createDevice and createSsh API that now returns domain objects rather than URI, so even easier! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds-labs-aws] Health check and Subnet API (#70)

andreaturli commented on this pull request. > +import javax.inject.Named; +import javax.ws.rs.FormParam; +import javax.ws.rs.POST; +import javax.ws.rs.Path; + +import org.jclouds.aws.filters.FormSigner; +import org.jclouds.elb.binders.BindSubnetIdsToIndexedFormParams; +import

Re: [jclouds/jclouds-labs] add remaining features to support the abstraction (#345)

@andreaturli pushed 1 commit. 3d7946f fix checkstyle -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/345/files/b6344958cae8d54fae211316800d85ae5d13ae8f..3d7946fde99e45efbab1788daf9d0b4e629bb5b4

Re: [jclouds/jclouds-labs] add remaining features to support the abstraction (#345)

squashing and merging -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/345#issuecomment-274751245

Re: [jclouds/jclouds-labs] add remaining features to support the abstraction (#345)

Closed #345. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/345#event-934203490

Re: [jclouds/jclouds-labs] add remaining features to support the abstraction (#345)

Merged at [master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/f749c88e) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/345#issuecomment-274756356

[jclouds/jclouds-labs] add compute functions (#346)

- fix Device and PaginatedCollection You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-labs/pull/346 -- Commit Summary -- * add compute functions -- File Changes -- A

Re: [jclouds/jclouds-labs-aws] Health check and Subnet API (#70)

thanks @justinThompson maybe I was unclear, but you don't need both expect tests and mock tests are they are supposed to tests the same things. As you wrote *MockTests, keep just them ;) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view

Re: [jclouds/jclouds-labs-aws] Health check and Subnet API (#70)

andreaturli commented on this pull request. > @@ -27,7 +27,7 @@ import org.jclouds.aws.filters.FormSigner; import org.jclouds.elb.binders.BindAvailabilityZonesToIndexedFormParams; -import org.jclouds.elb.xml.AvailabilityZonesResultHandler; +import org.jclouds.elb.xml.MemberResultHandler;

Re: [jclouds/jclouds-labs] JCLOUDS-1231: Implement the SecurityGroupExtension in ARM (#347)

andreaturli commented on this pull request. lgtm, some minor comments > @@ -114,7 +103,7 @@ public static Properties defaultProperties() { properties.put(API_VERSION_PREFIX + PublicIPAddressApi.class.getSimpleName(), "2015-06-15"); properties.put(API_VERSION_PREFIX +

Re: [jclouds/jclouds-labs] JCLODUS-1229: Enable the rate limit module by default (#348)

lgtm! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/348#issuecomment-275435492

Re: [jclouds/jclouds-labs] JCLOUDS-1231: Implement the SecurityGroupExtension in ARM (#347)

+1 @nacx, please merge it! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/347#issuecomment-275449554

Re: [jclouds/jclouds-labs-aws] Health check and Subnet API (#70)

Closed #70. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-aws/pull/70#event-939662456

Re: [jclouds/jclouds-labs-aws] Health check and Subnet API (#70)

merged at [master](http://git-wip-us.apache.org/repos/asf/jclouds-labs-aws/commit/e248c37d) and back-ported to [2.0.x](http://git-wip-us.apache.org/repos/asf/jclouds-labs-aws/commit/42b13e12) Very good, @justinThompson ! -- You are receiving this because you are subscribed to this thread.

Re: [jclouds/jclouds-labs] Feature/packet 5 (#354)

andreaturli commented on this pull request. > + } + } + + @Override + public void testOptionToNotBlock() throws Exception { + // Packet ComputeService implementation has to block until the node + // is provisioned, to be able to return it. + } + + @Override +

Re: [jclouds/jclouds-karaf] [DO NOT MERGE] Improvements/feature (#92)

@andreaturli pushed 3 commits. 8477274 add feature-labs.xml file 609e664 wip 0a37d2e wip -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds-labs] Feature/packet 5 (#354)

latest push has still, unit and live tests fine ``` Results : Tests run: 53, Failures: 0, Errors: 0, Skipped: 0 ``` thanks @nacx for the suggestion about not passing creds and for removing waitOn device, easier impl -- You are receiving this because you are subscribed to this thread. Reply to

Re: [jclouds/jclouds-labs] Feature/packet 5 (#354)

andreaturli commented on this pull request. > + } + } + + @Override + public void testOptionToNotBlock() throws Exception { + // Packet ComputeService implementation has to block until the node + // is provisioned, to be able to return it. + } + + @Override +

Re: [jclouds/jclouds-labs] Feature/packet 5 (#354)

@andreaturli pushed 1 commit. 50ff3c8 address review comments -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/354/files/0de7a600118cd3b9970a98efd6c62658f85e6970..50ff3c871b43ced16f848fc0dacc9cf8a64ab06c

[jclouds/jclouds] change hostname command to get the short form (#1056)

You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/1056 -- Commit Summary -- * change hostname command to get the short form -- File Changes -- M compute/src/test/java/org/jclouds/compute/internal/BaseComputeServiceLiveTest.java

Re: [jclouds/jclouds-karaf] [DO NOT MERGE] Improvements/feature (#92)

andreaturli commented on this pull request. > @@ -52,38 +52,56 @@ limitations under the License. mvn:org.apache.jclouds.api/atmos/${jclouds.version} not sure I follow your suggestion, is this for line 52? -- You are receiving this because you are subscribed to this thread. Reply to

Re: [jclouds/jclouds-karaf] [DO NOT MERGE] Improvements/feature (#92)

andreaturli commented on this pull request. > @@ -110,7 +110,6 @@ limitations under the License. jclouds-compute jclouds-api-atmos jclouds-api-byon -jclouds-api-cloudsigma2 I will try to add `super-features`, currently I'm

Re: [jclouds/jclouds-labs] add compute functions (#346)

andreaturli commented on this pull request. > + +private final JustProvider justProvider; + +// allow us to lazy discover the provider of a resource +@Inject +FacilityToLocation(JustProvider justProvider) { +this.justProvider = justProvider; +} + +@Override +

Re: [jclouds/jclouds-labs] add compute functions (#346)

andreaturli commented on this pull request. > + +private final JustProvider justProvider; + +// allow us to lazy discover the provider of a resource +@Inject +FacilityToLocation(JustProvider justProvider) { +this.justProvider = justProvider; +} + +@Override +

Re: [jclouds/jclouds-labs] Vagrant provider (#160)

YAY! congrats @neykov! Thanks @nacx for the great review! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/160#issuecomment-275069296

Re: [jclouds/jclouds-labs] add compute functions (#346)

merged at [master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/a91ff3bd) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/346#issuecomment-275139640

Re: [jclouds/jclouds-labs] add compute functions (#346)

Closed #346. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/346#event-936315783

[jclouds/jclouds-labs] [azurecompute-arm] performance improvements misc (#351)

- improve cleanup performances: by using resourceGroupApi.resources - improve list images performance: by avoiding to get image details /cc @nacx You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-labs/pull/351 -- Commit Summary -- *

Re: [jclouds/jclouds-labs] [azurecompute-arm] performance improvements misc (#351)

andreaturli commented on this pull request. > @@ -76,12 +78,20 @@ @Nullable ResourceGroup get(@PathParam("name") String name); + @Named("resourcegroup:resources") + @GET + @Path("/{name}/resources") + @SelectJson("value") + @Fallback(EmptyListOnNotFoundOr404.class) +

Re: [jclouds/jclouds-labs] [azurecompute-arm] performance improvements misc (#351)

andreaturli commented on this pull request. > + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND,

Re: [jclouds/jclouds-labs] [azurecompute-arm] performance improvements misc (#351)

I think it makes sense, I will revert that second commit -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/351#issuecomment-275663815

Re: [jclouds/jclouds-labs] [azurecompute-arm] performance improvements misc (#351)

rebuild please -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/351#issuecomment-275674731

Re: [jclouds/jclouds-labs] [azurecompute-arm] performance improvements misc (#351)

@nacx is it ok? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/351#issuecomment-275683932

Re: [jclouds/jclouds-labs] [azurecompute-arm] performance improvements misc (#351)

andreaturli commented on this pull request. > - family = > OsFamily.fromValue(image.versionProperties().osDiskImage().operatingSystem().toUpperCase()); +if (OsFamily.UNRECOGNIZED == family) { +// && +//} image.versionProperties() != null +//

Re: [jclouds/jclouds-labs-aws] Health check and Subnet API (#70)

@justinThompson are all the liveTests passing now? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-aws/pull/70#issuecomment-275695173

Re: [jclouds/jclouds-labs-aws] Health check and Subnet API (#70)

do you want that to be available on 2.0.x branch as well? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-aws/pull/70#issuecomment-275729163

Re: [jclouds/jclouds-labs-aws] Health check and Subnet API (#70)

thanks @justinThompson, merging! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-aws/pull/70#issuecomment-275728804

Re: [jclouds/jclouds-labs] add compute functions (#346)

@andreaturli pushed 1 commit. 3825f9a improve DeviceToNodeMetadata -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/346/files/d1074295696a9bac88a3a6e9bb1c7581e295ae40..3825f9aea216c127fb948e586a2291c0177af269

[jclouds/jclouds-labs] Feature/packet 5 (#354)

/cc @nacx unit and live tests are ok ``` --- T E S T S --- Running TestSuite Configuring TestNG with: TestNG652Configurator Starting test

Re: [jclouds/jclouds-karaf] Improvements to feature (#92)

andreaturli commented on this pull request. > +@RunWith(PaxExam.class) +@ExamReactorStrategy(PerMethod.class) +public class FeatureInstallationTest extends BasePaxExamTest { + + @Inject + FeaturesService featuresService; + + @Before + public void setUp() throws Exception { +

Re: [jclouds/jclouds-labs] Checks existence of node before getting SecurityGroups and Images (#360)

andreaturli commented on this pull request. > @@ -123,6 +123,9 @@ ResourceGroup resourceGroup = resourceGroupMap.getUnchecked(regionAndId.region()); VirtualMachine vm = api.getVirtualMachineApi(resourceGroup.name()).get(regionAndId.id()); Can you use checkNotNull, maybe? >

Re: [jclouds/jclouds] bump sshj version to 0.20.0 (#1060)

@nacx, I double-checked your questions at https://github.com/jclouds/jclouds/pull/1060#issuecomment-278970933 and they look under control. Good to merge? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds] [JCLOUDS-1233] bump jax-rs version (#1057)

@nacx, both @zack-shoylev and myself tested this change and it looks fine. Good to merge? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1057#issuecomment-279654127

Re: [jclouds/jclouds-karaf] [DO NOT MERGE YET] Improvements to feature (#92)

@andreaturli pushed 2 commits. 899110d use sshj 0.20.0 e91e490 re-add bundle jsch-agentproxy-jsch -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds] [JCLOUDS-1233] bump jax-rs version (#1057)

thanks @nacx -- do you think it is just for master or also 2.0.x? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1057#issuecomment-279970962

Re: [jclouds/jclouds] [JCLOUDS-1233] bump jax-rs version (#1057)

merged at [master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/38cb34e1) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1057#issuecomment-279976080

Re: [jclouds/jclouds] [JCLOUDS-1233] bump jax-rs version (#1057)

k thx -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1057#issuecomment-279981510

Re: [jclouds/jclouds] Fix O(n^2) response time for "list-security-groups" on openstack-nova. (#1059)

thanks @geomacy, merged at [master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/717b75a3) and back-ported to [2.0.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/c4245acd) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or

Re: [jclouds/jclouds] Fix O(n^2) response time for "list-security-groups" on openstack-nova. (#1059)

Closed #1059. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1059#event-959429952

Re: [jclouds/jclouds] Fix O(n^2) response time for "list-security-groups" on openstack-nova. (#1059)

@geomacy can you please squash (and rebase if needed) the 3 commits into one? Also do you need this commit ported to `2.0.x` as well? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds] Fix O(n^2) response time for "list-security-groups" on openstack-nova. (#1059)

Fair points @geomacy I'm in favor of keeping the implementation as-is which already optimize a lot! if further optimizations will be required we could always revisit it again using @nacx suggestions as starting point. Wdyt? -- You are receiving this because you are subscribed to this thread.

[jclouds/jclouds] bump sshj version to 0.20.0 (#1060)

- this version contains some new features and bug fixes especially useful for OSGi (see https://github.com/hierynomus/sshj/issues/300 for more details), in fact I've tested `jclouds-karaf` with this version and it works as well. /cc @nacx You can view, comment on, or merge this pull request

Re: [jclouds/jclouds-karaf] Improvements to feature (#92)

Closed #92. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/92#event-964971751

Re: [jclouds/jclouds-karaf] Improvements to feature (#92)

Reopened #92. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/92#event-964971783

Re: [jclouds/jclouds-karaf] Improvements to feature (#92)

rebuild please -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/92#issuecomment-280300366

Re: [jclouds/jclouds-karaf] Improvements to feature (#92)

Reopened #92. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/92#event-964796367

Re: [jclouds/jclouds-karaf] Improvements to feature (#92)

Closed #92. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/92#event-964796331

Re: [jclouds/jclouds-karaf] Improvements to feature (#92)

@nacx I think we had some issues with the builder, now the PR looks ok as it is from my workstation. Can you please double-check before merging it? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds-labs] Fix NPE in ARM VirtualMachineToNodeMetadata (#363)

Lgtm, thanks -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/363#issuecomment-280432809

Re: [jclouds/jclouds] bump sshj version to 0.20.0 (#1060)

ok I will do, notice https://github.com/jclouds/jclouds-karaf/pull/92 already references sshj `0.20.0` so we need this merged before that PR for jclouds-karaf. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds-karaf] Improvements to feature (#92)

@andreaturli pushed 1 commit. 10ab107 remove old itests; rename modern-itests to itests -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds-labs] add remaining features to support the abstraction (#345)

@andreaturli pushed 1 commit. b634495 add mock and live tests for device api actions -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds] bump sshj version to 0.20.0 (#1060)

in particular, sshj requires ``` org.bouncycastle:bcprov-jdk15on:1.51 org.bouncycastle:bcpkix-jdk15on:1.51 com.jcraft:jzlib:1.1.3 net.i2p.crypto:eddsa:0.1.0 ``` at compile time, so for bouncycastle jclouds is good. I've created an OSGi feature for `bouncycastle` driver which looks like the

Re: [jclouds/jclouds] bump sshj version to 0.20.0 (#1060)

I'm trying to address all hose relevant questions in the big still 'DO NOT MERGE' PR for jclouds-karaf -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1060#issuecomment-278971641

Re: [jclouds/jclouds-labs] add remaining features to support the abstraction (#345)

andreaturli commented on this pull request. > +@ConstructorProperties({ "devices", "meta" }) +public Devices(List items, Meta meta) { +super(items, meta); +} +} + +private static class ToPagedIterable extends

Re: [jclouds/jclouds-examples] update blobstore-basics to use 2.0.0 (#90)

thanks, merging! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-examples/pull/90#issuecomment-273050187

Re: [jclouds/jclouds-labs] add AddApiVersionToRequest filter (#343)

Closed #343. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/343#event-925344400

Re: [jclouds/jclouds-labs] add AddApiVersionToRequest filter (#343)

merged at [master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/dfd6804c) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/343#issuecomment-273050363

Re: [jclouds/jclouds-examples] update blobstore-basics to use 2.0.0 (#90)

merged at [master](http://git-wip-us.apache.org/repos/asf/jclouds-examples/commit/5662aae4) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-examples/pull/90#issuecomment-273051042

Re: [jclouds/jclouds-examples] update blobstore-basics to use 2.0.0 (#90)

Closed #90. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-examples/pull/90#event-925347966

[jclouds/jclouds-labs] add remaining features to support the abstraction (#345)

- add DeviceApi with Mock and Live Test - add FacilityApi with Mock and Live Test - add OperatingSystemApi with Mock and Live Test - add SshKeyApi with Mock and Live Test --- Notice this PR adds many files but because we carefully review already `ProjectApi` and I copied the same structure for

Re: [jclouds/jclouds-labs] add remaining features to support the abstraction (#345)

andreaturli commented on this pull request. > +@ConstructorProperties({ "devices", "meta" }) +public Devices(List items, Meta meta) { +super(items, meta); +} +} + +private static class ToPagedIterable extends

Re: [jclouds/jclouds-labs] add remaining features to support the abstraction (#345)

andreaturli commented on this pull request. > + assertEquals(size(devices), 5); + assertEquals(server.getRequestCount(), 1); + + assertSent(server, "GET", "/projects/93907f48-adfe-43ed-ad89-0e6e83721a54/devices?page=1_page=5"); + } + + public void

Re: [jclouds/jclouds-labs] add AddApiVersionToRequest filter (#343)

@nacx happy with that version? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/343#issuecomment-272909654

Re: [jclouds/jclouds-labs] add remaining features to support the abstraction (#345)

@andreaturli pushed 1 commit. adf0108 address @nacx comments -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/345/files/ae7c3142f1df1ae7e68274806dc52a2095bdcd24..adf01080394858560a645c8114b2bd085f35868c

Re: [jclouds/jclouds-labs] add remaining features to support the abstraction (#345)

@andreaturli pushed 1 commit. f47db43 make CreateDevice constructor private -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds-labs] [JCLOUDS-1157] fix networks in DockerComputeServiceAdapterLiveTest (#311)

thx @kwart merging -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/311#issuecomment-241056394

Re: [jclouds/jclouds-labs] Update Docker README.md (#312)

thanks @kwart looks useful. merging now -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/312#issuecomment-241055430

Re: [jclouds/jclouds-labs] Update Docker README.md (#312)

merged at [master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/acd382e5) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/312#issuecomment-241056161

Re: [jclouds/jclouds-labs] [JCLOUDS-1157] fix networks in DockerComputeServiceAdapterLiveTest (#311)

Closed #311. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/311#event-761447093

Re: [jclouds/jclouds-labs] Improve image lookup when getting node info (#359)

@nacx looks like the failures are valid https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/1694/org.apache.jclouds.labs$azurecompute-arm/testReport/junit/org.jclouds.azurecompute.arm.features/SubnetApiMockTest/start/ can you fix them so that we can merge it? -- You are receiving

Re: [jclouds/jclouds-labs] Improve image lookup when getting node info (#359)

cool! thanks @nacx -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/359#issuecomment-283293868

Re: [jclouds/jclouds-karaf] Use same bundle version as in jclouds/project/java-xmlbuilder.verison (#81)

Merged #81. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/81#event-785928303

Re: [jclouds/jclouds-karaf] Use same bundle version as in jclouds/project/java-xmlbuilder.verison (#81)

@demobox lgtm too -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/81#issuecomment-246342026

<    2   3   4   5   6   7   8   9   10   11   >