Re: [jclouds] Revert workaround for Guava issue 1635 (#281)

2014-02-10 Thread Andrew Gaul
I asked about a 15.0.1 release in the upstream Guava issue: https://code.google.com/p/guava-libraries/issues/detail?id=1635#c45 --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/281#issuecomment-34651577

Re: [jclouds] Delete objects in a container efficiently. (#214)

2014-02-10 Thread Andrew Gaul
Sorry for ignoring this. By default jclouds uses an unlimited number of user threads, set in ```BaseApiMetadata.defaultProperties```. I believe this will cause problems for users of Atmos blobstores. We can work around this by setting a lower number in

[jclouds] JCLOUDS-137: Retry on HTTP 500 AtmosError 1040 (#285)

2014-02-10 Thread Andrew Gaul
You can merge this Pull Request by running: git pull https://github.com/maginatics/jclouds atmos-500-1040 Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds/pull/285 -- Commit Summary -- * JCLOUDS-137: Retry on HTTP 500 AtmosError 1040 -- File

Re: [jclouds] JCLOUDS-137: Retry on HTTP 500 AtmosError 1040 (#285)

2014-02-10 Thread Andrew Gaul
@shrinandj relevant to your interests. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/285#issuecomment-34682671

Re: [jclouds] JCLOUDS-460: Add jitter to avoid thundering herd (#286)

2014-02-10 Thread Andrew Gaul
@shrinandj relevant to your interests. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/286#issuecomment-34686120

[jclouds] JCLOUDS-459: Limit maximum user threads (#287)

2014-02-10 Thread Andrew Gaul
Previously jclouds could use an unlimited number of threads on its user ExecutorService. While this ExecutorService will go away when we complete deasyncafication, we should prevent jclouds from misbehaving until that time. You can merge this Pull Request by running: git pull

Re: [jclouds] JCLOUDS-137: Retry on HTTP 500 AtmosError 1040 (#285)

2014-02-10 Thread Andrew Gaul
Spurious test failure, tracked by [JCLOUDS-429](https://issues.apache.org/jira/browse/JCLOUDS-429). --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/285#issuecomment-34688336

Re: [jclouds] JCLOUDS-137: Retry on HTTP 500 AtmosError 1040 (#285)

2014-02-10 Thread Andrew Gaul
+ private int retryCountLimit = 5; + @Resource + protected Logger logger = Logger.NULL; + + public boolean shouldRetryRequest(HttpCommand command, HttpResponse response) { + if (command.getFailureCount() retryCountLimit) { + return false; + } + if

Re: [jclouds] JCLOUDS-459: Limit maximum user threads (#287)

2014-02-11 Thread Andrew Gaul
@@ -66,7 +66,7 @@ public static Properties defaultProperties() { props.setProperty(PROPERTY_SO_TIMEOUT, 6 + ); props.setProperty(PROPERTY_CONNECTION_TIMEOUT, 6 + ); props.setProperty(PROPERTY_IO_WORKER_THREADS, 20 + ); -

Re: [jclouds] JCLOUDS-460: Add jitter to avoid thundering herd (#286)

2014-02-11 Thread Andrew Gaul
@@ -126,6 +127,9 @@ public void imposeBackoffExponentialDelay(long period, int pow, int failureCount public void imposeBackoffExponentialDelay(long period, long maxPeriod, int pow, int failureCount, int max, String commandDescription) { long delayMs = (long) (period

Re: [jclouds] JCLOUDS-137: Retry on HTTP 500 AtmosError 1040 (#285)

2014-02-11 Thread Andrew Gaul
Closed #285. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/285

Re: [jclouds] JCLOUDS-137: Retry on HTTP 500 AtmosError 1040 (#285)

2014-02-11 Thread Andrew Gaul
Committed to master and 1.7.x. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/285#issuecomment-34800494

[jclouds] JCLOUDS-473: Close FileInputStream in Wire.copy (#295)

2014-02-18 Thread Andrew Gaul
FileBackedOutputStream.asByteSource.getInput returns a FileInputStream which we do not close. We later call FileBackedOutputStream.reset which removes the underlying File. This fails on Windows which does not support deleting an open file and leaks resources on other platforms. Eagerly close to

[jclouds] Remove StreamingPayload (#297)

2014-02-19 Thread Andrew Gaul
Only two tests use this class. Callers should use ByteSourcePayload or InputStreamPayload instead. You can merge this Pull Request by running: git pull https://github.com/maginatics/jclouds remove-streaming-payload Or you can view, comment on it, or merge it online at:

Re: [jclouds] JCLOUDS-459: Limit maximum user threads (#287)

2014-02-19 Thread Andrew Gaul
@@ -66,7 +66,7 @@ public static Properties defaultProperties() { props.setProperty(PROPERTY_SO_TIMEOUT, 6 + ); props.setProperty(PROPERTY_CONNECTION_TIMEOUT, 6 + ); props.setProperty(PROPERTY_IO_WORKER_THREADS, 20 + ); -

Re: [jclouds] JCLOUDS-459: Limit maximum user threads (#287)

2014-02-19 Thread Andrew Gaul
Closed #287. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/287

Re: [jclouds] Remove StreamingPayload (#297)

2014-02-19 Thread Andrew Gaul
I believe ```StreamingPayload``` and ```WriteTo``` predate Guava alternatives like ```ByteSource```. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/297#issuecomment-35528928

[jclouds] Remove streaming payload 1.7.x (#298)

2014-02-19 Thread Andrew Gaul
You can merge this Pull Request by running: git pull https://github.com/maginatics/jclouds remove-streaming-payload-1.7.x Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds/pull/298 -- Commit Summary -- * JCLOUDS-459: Limit maximum user threads

[jclouds] Add ByteSource Payload support for Clojure (#299)

2014-02-19 Thread Andrew Gaul
You can merge this Pull Request by running: git pull https://github.com/maginatics/jclouds clojure-bytesource Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds/pull/299 -- Commit Summary -- * Add ByteSource Payload support for Clojure -- File

Re: [jclouds] Add ByteSource Payload support for Clojure (#299)

2014-02-19 Thread Andrew Gaul
Man, I don't even know; I am only adding this so I can remove the other deprecated Payloads. I am willing to do the minimum to allow me to evolve jclouds APIs/follow Guava changes, but honestly I would prefer to remove our fake Clojure support. Have been contemplating sending a mail to the

Re: [jclouds-labs-openstack] Adds support for multi-region implementation of Rackspace Cloud Files API (#79)

2014-02-19 Thread Andrew Gaul
Lots going on here; can we break this change into its component parts? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/79#issuecomment-35563095

Re: [jclouds] Add ByteSource Payload support for Clojure (#299)

2014-02-19 Thread Andrew Gaul
Pushed to master. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/299#issuecomment-35589860

Re: [jclouds] Remove streaming payload 1.7.x (#298)

2014-02-19 Thread Andrew Gaul
Pushed 1f828b4 to 1.7.x. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/298#issuecomment-35590014

Re: [jclouds] Remove streaming payload 1.7.x (#298)

2014-02-19 Thread Andrew Gaul
Closed #298. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/298

Re: [jclouds] Remove StreamingPayload (#297)

2014-02-19 Thread Andrew Gaul
Pushed to master. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/297#issuecomment-35590462

Re: [jclouds] Remove StreamingPayload (#297)

2014-02-19 Thread Andrew Gaul
Closed #297. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/297

[jclouds] JCLOUDS-410: Remove FilePayload (#300)

2014-02-19 Thread Andrew Gaul
Use ByteSourcePayload instead. You can merge this Pull Request by running: git pull https://github.com/maginatics/jclouds remove-file-payload Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds/pull/300 -- Commit Summary -- * JCLOUDS-410: Remove

[jclouds] Remove WriteTo (#301)

2014-02-19 Thread Andrew Gaul
Guava helpers capture this functionality in a more idiomatic way. You can merge this Pull Request by running: git pull https://github.com/maginatics/jclouds remove-write-to Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds/pull/301 -- Commit Summary

[jclouds] Deprecate WriteTo (#302)

2014-02-19 Thread Andrew Gaul
Use Payload.getInput and Guava helpers instead You can merge this Pull Request by running: git pull https://github.com/maginatics/jclouds remove-write-to-1.7.x Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds/pull/302 -- Commit Summary -- *

Re: [jclouds-karaf] [JCLOUDS-189] Upgrade to Karaf 2.3.2. Explicitly specify jclouds feature... (#24)

2014-02-21 Thread Andrew Gaul
I believe the karaf pom.xml is not using the correct checkstyle config -- it uses the default. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/24#issuecomment-35786008

Re: [jclouds] Deprecate WriteTo (#302)

2014-02-21 Thread Andrew Gaul
public interface WriteTo { /** * Writes the payload content to the output stream. * * @throws IOException +* @deprecated use Payload.getInput and Guava helpers instead Done. --- Reply to this email directly or view it on GitHub:

Re: [jclouds] Deprecate WriteTo (#302)

2014-02-21 Thread Andrew Gaul
Closed #302. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/302

Re: [jclouds] Deprecate WriteTo (#302)

2014-02-21 Thread Andrew Gaul
Pushed to 1.7.x. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/302#issuecomment-35789888

Re: [jclouds] Remove WriteTo (#301)

2014-02-21 Thread Andrew Gaul
@@ -158,9 +158,8 @@ private Blob createUpdatedCopyOfBlobInContainer(String containerName, Blob in) { try { if (payload == null || !(payload instanceof ByteArrayPayload)) { MutableContentMetadata oldMd = in.getPayload().getContentMetadata(); -

Re: [jclouds] Remove WriteTo (#301)

2014-02-21 Thread Andrew Gaul
Closed #301. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/301

Re: [jclouds] Remove WriteTo (#301)

2014-02-21 Thread Andrew Gaul
Pushed to master. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/301#issuecomment-35789978

Re: [jclouds-site] Rebranding proposal (#58)

2014-02-25 Thread Andrew Gaul
I like our current mission statement and I think it should be on the front page. My only change was to basically replace Java and Clojure with JVM. I'm on crazy about using an acronym in our mission statement but it should somehow reflect that it works with many Java technologies. Honestly

[jclouds-karaf] Add command to report blobstore clock skew (#37)

2014-02-25 Thread Andrew Gaul
Improperly configured private blobstores with sufficient clock skew can impact operations like signed URLs with timeouts. You can merge this Pull Request by running: git pull https://github.com/maginatics/jclouds-karaf clock-skew Or you can view, comment on it, or merge it online at:

Re: [jclouds-site] Rebranding proposal (#58)

2014-02-25 Thread Andrew Gaul
Regarding stand-alone application, jclouds-cli is arguably fills this, albeit poorly. Having an end-user example of how to take advantage of jclouds cross-provider functionality would give the project and our users a huge boost. I opened

Re: [jclouds] Backported missing amazon instance sizes from master to 1.5.x (#305)

2014-02-27 Thread Andrew Gaul
I suspect that we have Checkstyle enabled but misconfigured for 1.5.x. I will verify this PR locally then push to 1.5.x. @chemikadze any reason you cannot move forward to 1.7.1? --- Reply to this email directly or view it on GitHub:

Re: [jclouds] Backported missing amazon instance sizes from master to 1.5.x (#305)

2014-02-27 Thread Andrew Gaul
Verified locally, pushed to 1.5.x. Note that we do not currently plan another 1.5 release. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/305#issuecomment-36272966

Re: [jclouds] JCLOUDS-427: Avoiding Guava reflection code broken in Java 7u51 (#263)

2014-02-27 Thread Andrew Gaul
@splittingfield can you move forward to the 1.7.1 release? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/263#issuecomment-36276255

Re: [jclouds] JCLOUDS-342: Retry on HTTP 408 for swift (#306)

2014-02-27 Thread Andrew Gaul
:+1: tested commit locally. @zack-shoylev could you take a look at this since it increases the failure counter you added in 578a77d6313ce0945f8d29e82103e09787622c58? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/306#issuecomment-36281263

Re: [jclouds] JCLOUDS-342: Retry on HTTP 408 for swift (#306)

2014-02-27 Thread Andrew Gaul
@jaggett Sorry I misunderstood, thought you were referring to the new labs openstack-swift provider. I guess we could make similar changes to openstack-keystone. Do any of the public providers use the newer Keystone implementation? --- Reply to this email directly or view it on GitHub:

Re: [jclouds] Backported missing amazon instance sizes from master to 1.5.x (#305)

2014-02-27 Thread Andrew Gaul
Verified locally, pushed to 1.6.x. Note that we do no currently plan another 1.6 release. @chemikadze any reason you cannot move forward to 1.7.1? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/305#issuecomment-36304982

Re: [jclouds] JCLOUDS-342: Retry on HTTP 408 for swift (#306)

2014-03-01 Thread Andrew Gaul
@jdaggett I have credentials for several Swift providers and none of them seem to use the openstack-keystone/Keystone 2.0 functionality. If someone finds such a provider we can add this functionality in a subsequent commit, otherwise let's just patch known issues and move forward with the

Re: [jclouds] JCLOUDS-342: Retry on HTTP 408 for swift (#306)

2014-03-03 Thread Andrew Gaul
I ran the Swift unit tests and cloudfiles-us live tests locally, squashed commit, and pushed to master and 1.7.x. Thank you for your contribution @tdmanv! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/306#issuecomment-36580061

Re: [jclouds] JCLOUDS-342: Retry on HTTP 408 for swift (#306)

2014-03-03 Thread Andrew Gaul
Closed #306. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/306

Re: [jclouds] JCLOUDS-460: Add jitter to avoid thundering herd (#286)

2014-03-03 Thread Andrew Gaul
Let's go with the existing simpler delay for now. One we have more experience with timeouts we can increase them or the jitter as appropriate. Pushed to master and 1.7.x. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/286#issuecomment-36595957

Re: [jclouds] JCLOUDS-460: Add jitter to avoid thundering herd (#286)

2014-03-03 Thread Andrew Gaul
Closed #286. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/286

[jclouds-site] Modernize BlobStore examples (#59)

2014-03-04 Thread Andrew Gaul
Use ByteSource payloads, call contentMD5 instead of calculateMD5, and correct contentType calls. You can merge this Pull Request by running: git pull https://github.com/maginatics/jclouds-site modernize-blobstore-examples Or you can view, comment on it, or merge it online at:

Re: [jclouds-site] Show quick news in the home page (#61)

2014-03-05 Thread Andrew Gaul
:+1: should we add some kind of self-destruct mechanism which hides news after we expect that it will no longer be relevant? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/61#issuecomment-36823504

Re: [jclouds-site] Post about the 2014-03-04 Meetup (#62)

2014-03-06 Thread Andrew Gaul
://www.slideshare.net/phymata/introduction-to-apache-jclouds). + +Next up was Andrew Gaul from Maginatics with an informative presentation on [Apache jclouds at Maginatics](http://gaul.org/talks/jclouds-at-maginatics/). I personally learned a lot from Andrew's presentation like the wide variety of differences

Re: [jclouds-site] Post about the 2014-03-04 Meetup (#62)

2014-03-06 Thread Andrew Gaul
this presentation at ApacheCon on April 7, 2014 and wanted to take this opportunity to practice it in front of a captive audience. You can find my presentation slides at [Introduction to Apache jclouds](http://www.slideshare.net/phymata/introduction-to-apache-jclouds). + +Next up was Andrew Gaul

Re: [jclouds-site] Post about the 2014-03-04 Meetup (#62)

2014-03-06 Thread Andrew Gaul
+ +Next up was Andrew Gaul from Maginatics with an informative presentation at [0:40 of the meetup](http://www.youtube.com/watch?v=8nuON0zGVJIt=40m00s) on [Apache jclouds at Maginatics](http://gaul.org/talks/jclouds-at-maginatics/). I personally learned a lot from Andrew's presentation

[jclouds-site] Exit on failed commands (#63)

2014-03-06 Thread Andrew Gaul
Previously a failed jekyll command would continue to deploy the site with the older site content. You can merge this Pull Request by running: git pull https://github.com/maginatics/jclouds-site errexit Or you can view, comment on it, or merge it online at:

Re: [jclouds-site] Exit on failed commands (#63)

2014-03-06 Thread Andrew Gaul
@@ -1,5 +1,7 @@ #!/bin/sh +set -o errexit Strongly prefer verbose shell options! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/63/files#r10370516

Re: [jclouds-site] Exit on failed commands (#63)

2014-03-06 Thread Andrew Gaul
Pushed to master. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/63#issuecomment-36959754

Re: [jclouds-site] Exit on failed commands (#63)

2014-03-06 Thread Andrew Gaul
Closed #63. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/63

Re: [jclouds-karaf] Added missing DigitalOcean feature to features/pom.xml (#38)

2014-03-07 Thread Andrew Gaul
@@ -158,6 +158,7 @@ limitations under the License. featurejclouds-serverlove-z1-man/feature featurejclouds-skalicloud-sdg-my/feature featurejclouds-softlayer/feature +featurejclouds-digitalocean/feature Definitely prefer

[jclouds-examples] Compile examples with 1.7.1 and repair bit-rot (#33)

2014-03-11 Thread Andrew Gaul
You can merge this Pull Request by running: git pull https://github.com/maginatics/jclouds-examples compile-examples Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds-examples/pull/33 -- Commit Summary -- * Compile examples with 1.7.1 and repair

Re: [jclouds-examples] Compile examples with 1.7.1 and repair bit-rot (#33)

2014-03-11 Thread Andrew Gaul
@etoews @zack-shoylev the rackspace examples do not compile due to a missing ```NovaTemplateOptions.Builder.configDrive```. Can you update this example and add the rackspace module to pom.xml? --- Reply to this email directly or view it on GitHub:

Re: [jclouds-examples] Compile examples with 1.7.1 and repair bit-rot (#33)

2014-03-11 Thread Andrew Gaul
@zack-shoylev sorry I had a stale tree; I will update the pull request. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-examples/pull/33#issuecomment-37359857

Re: [jclouds] Fixing a couple of typos (#315)

2014-03-12 Thread Andrew Gaul
Closed #315. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/315

Re: [jclouds-examples] Compile examples with 1.7.1 and repair bit-rot (#33)

2014-03-12 Thread Andrew Gaul
Pushed to master. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-examples/pull/33#issuecomment-37472657

[jclouds] Retry on S3 HTTP 504 Gateway Timeout status codes (#317)

2014-03-13 Thread Andrew Gaul
RiakCS using the S3 interface occasionally surfaces these status codes. You can merge this Pull Request by running: git pull https://github.com/maginatics/jclouds s3-504-retry Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds/pull/317 -- Commit

Re: [jclouds-site] Modernize BlobStore examples (#59)

2014-03-13 Thread Andrew Gaul
@@ -96,8 +96,9 @@ h3 class=panel-titleBlobStore/h3 blobStore.createContainerInLocation(location, mycontainer); +ByteSource payload = ByteSource.wrap(blob-content.getBytes(Charsets.UTF_8)); Done. --- Reply to this email directly or view it on GitHub:

Re: [jclouds] Retry on S3 HTTP 504 Gateway Timeout status codes (#317)

2014-03-14 Thread Andrew Gaul
Closed #317. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/317

Re: [jclouds] Retry on S3 HTTP 504 Gateway Timeout status codes (#317)

2014-03-14 Thread Andrew Gaul
Pushed to master and 1.7.x. Thanks @tdmanv for the feedback! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/317#issuecomment-37685162

Re: [jclouds-site] Modernize BlobStore examples (#59)

2014-03-18 Thread Andrew Gaul
Pushed to master and deployed. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/59#issuecomment-37999805

[jclouds] JCLOUDS-505: Remove unused ObjectMD5 (#321)

2014-03-20 Thread Andrew Gaul
The only users of this seem to be org.jclouds.atmos.blobstore.strategy.FindMD5InUserMetadata and org.jclouds.azureblob.blobstore.strategy.FindMD5InBlobProperties which are themselves unused. You can merge this Pull Request by running: git pull https://github.com/maginatics/jclouds

Re: [jclouds] Delete objects in a container efficiently. (#214)

2014-03-21 Thread Andrew Gaul
import com.google.common.util.concurrent.ListenableFuture; import com.google.common.util.concurrent.ListeningExecutorService; import com.google.inject.Inject; /** * Deletes all keys in the container - * + * * @author Adrian Cole Add your name to since this is a large body of

Re: [jclouds] Delete objects in a container efficiently. (#214)

2014-03-21 Thread Andrew Gaul
Can you open a JIRA issue and reference it in the commit message? This will allow us to communicate this improvement in the release notes. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/214#issuecomment-38321551

Re: [jclouds] Delete objects in a container efficiently. (#214)

2014-03-21 Thread Andrew Gaul
+ * acquired in 'maxTime', a TimeoutException is thrown. Any outstanding + * futures at that time are cancelled. + */ + final Semaphore semaphore = new Semaphore(numOutStandingRequests); + /* + * When a future is created, a reference for that is added to the

Re: [jclouds] Delete objects in a container efficiently. (#214)

2014-03-21 Thread Andrew Gaul
+ * a timeout. Also, when the reference is removed from this list and when + * the executorService removes the reference that it has maintained, the + * future will be marked for GC since there should be no other references + * to it. This is important because

Re: [jclouds] Delete objects in a container efficiently. (#214)

2014-03-21 Thread Andrew Gaul
@shrinandj This commit represents a big improvement and I apologize for my delayed comments. Can you address some of these and add TODOs for the rest so we can commit this as soon as possible? Specifically we must address the O(n) behavior and I do not understand some of the synchronization.

Re: [jclouds] Add BlobStoreBench to jclouds. (#239)

2014-03-21 Thread Andrew Gaul
I will investigate creating a jclouds-tools repository to host this commit and future tools. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/239#issuecomment-38323342

Re: [jclouds] Delete objects in a container efficiently. (#214)

2014-03-21 Thread Andrew Gaul
+ listing = blobStore.list(containerName, options); + } catch (ContainerNotFoundException ce) { + return listing; + } + + // recurse on subdirectories + if (options.isRecursive()) { + for (StorageMetadata md : listing) { +String

Re: [jclouds] Delete objects in a container efficiently. (#214)

2014-03-24 Thread Andrew Gaul
+ switch (md.getType()) { + case BLOB: +blobDelFuture = executorService.submit(new CallableVoid() { + @Override + public Void call() { + blobStore.removeBlob(containerName, fullPath); + return

Re: [jclouds] Delete objects in a container efficiently. (#214)

2014-03-25 Thread Andrew Gaul
+ final String fullPath = parentIsFolder(options, md) ? options.getDir() + + / + md.getName() : md.getName(); + +// Attempt to acquire a semaphore within the time limit. At least +// one outstanding future should complete within this period for

Re: [jclouds] Delete objects in a container efficiently. (#214)

2014-03-26 Thread Andrew Gaul
} - private boolean parentIsFolder(final ListContainerOptions options, final StorageMetadata md) { - return options.getDir() != null md.getName().indexOf('/') == -1; + private void waitForCompletion(final Semaphore semaphore, + final SetListenableFutureVoid

Re: [jclouds] Delete objects in a container efficiently. (#214)

2014-03-26 Thread Andrew Gaul
I committed to master with some Checkstyle, Javadoc, and indentation fixes. Let's address some of the TODOs and test more before backporting to 1.7.x. Thank you for your contribution @shrinandj ! The previous implementation has troubled us for some years now. --- Reply to this email

Re: [jclouds] Delete objects in a container efficiently. (#214)

2014-03-26 Thread Andrew Gaul
Closed #214. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/214

Re: [jclouds-labs-openstack] Fixes checkstyle violations in neutron. (#86)

2014-03-27 Thread Andrew Gaul
:+1: --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/86#issuecomment-38878535

[jclouds] Mark Swift blobstores as eventually consistent (#343)

2014-04-09 Thread Andrew Gaul
This allows tests to retry correctly. Most blobstores, including Swift[1], offer eventual consistency, although Azure[2] and the jclouds test blobstores offer strong consistency. [1] https://lists.launchpad.net/openstack/msg06788.html [2]

Re: [jclouds] Mark Swift blobstores as eventually consistent (#343)

2014-04-09 Thread Andrew Gaul
@jdaggett This commit corrects all known consistency model inconsistencies. Should we undeprecate ```BlobStoreContext.getConsistencyModel``` since this information seems generally useful? --- Reply to this email directly or view it on GitHub:

Re: [jclouds] JCLOUDS-528 ability to disable public ips from open socket finder (#341)

2014-04-09 Thread Andrew Gaul
@@ -191,4 +204,22 @@ private static void blockOn(IterableListenableFuture? immutableList) { throw propagate(e); } } + + + @VisibleForTesting + enum AllowedInterfaces{ All Java enum are implicitly static. --- Reply to this email directly or view it on

Re: [jclouds] Fixing Jclouds-509 (#333)

2014-04-11 Thread Andrew Gaul
Can you also improve the commit message? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/333#issuecomment-40252083

Re: [jclouds] JCLOUDS-534: Upgrade to Guava 17.0-rc2 (#345)

2014-04-14 Thread Andrew Gaul
Closed #345. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/345

[jclouds] Consistency model remove deprecation (#347)

2014-04-14 Thread Andrew Gaul
You can merge this Pull Request by running: git pull https://github.com/andrewgaul/jclouds consistency-model-remove-deprecation Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds/pull/347 -- Commit Summary -- * JCLOUDS-534: Upgrade to Guava

Re: [jclouds] Mark Swift blobstores as eventually consistent (#343)

2014-04-14 Thread Andrew Gaul
Pushed to master. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/343#issuecomment-40440914

Re: [jclouds] Mark Swift blobstores as eventually consistent (#343)

2014-04-14 Thread Andrew Gaul
Let's keep this commit scoped to correcting the Swift consistency models. Let's continue discussion removing deprecation in #347. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/343#issuecomment-40440905

Re: [jclouds] Consistency model remove deprecation (#347)

2014-04-15 Thread Andrew Gaul
@demobox I believe I pushed this pull request before @jclouds-mirror had synchronized the most recent commits. Let's see if rebase and repush addresses this. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/347#issuecomment-40544484

Re: [jclouds] Consistency model remove deprecation (#347)

2014-04-15 Thread Andrew Gaul
Closed #347. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/347

Re: [jclouds] Remove deprecation from getConsistencyModel (#348)

2014-04-15 Thread Andrew Gaul
Follow-on from #347. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/348#issuecomment-40545628

Re: [jclouds] Enable whitespace around Checkstyle rule (#360)

2014-05-11 Thread Andrew Gaul
Committed to master. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/360#issuecomment-42625731

Re: [jclouds] Enforce that all commas have trailing whitespace (#359)

2014-05-11 Thread Andrew Gaul
Another timeout? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/359#issuecomment-42516260

Re: [jclouds] Enforce that all commas have trailing whitespace (#359)

2014-05-11 Thread Andrew Gaul
Reopened #359. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/359#event-119003175

[jclouds] Enforce that all commas have trailing whitespace (#359)

2014-05-11 Thread Andrew Gaul
You can merge this Pull Request by running: git pull https://github.com/andrewgaul/jclouds checkstyle-comma Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds/pull/359 -- Commit Summary -- * Enforce that all commas have trailing whitespace --

Re: [jclouds] Enforce that all commas have trailing whitespace (#359)

2014-05-11 Thread Andrew Gaul
Closed #359. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/359#event-119003171

  1   2   3   4   5   6   7   8   9   10   >