+serverId = createServer(zoneId, nova,
Server.Status.ACTIVE).getId();
+Server server = serverApi.get(serverId);
+assertEquals(server.getStatus(), Server.Status.ACTIVE);
+ } finally {
+serverApi.delete(serverId);
+ }
+ }
+ withImage(server.getImage().getId()).
+ name(newName).
+ adminPass(password).
+ ipv4Address(1.1.1.1).
+ ipv6Address(fe80::100);
+
+serverApi.rebuild(serverId, options);
+
+Server
-}
+ }
+ }
+ }
+
+ @Test
+ public void testCreateInWrongAvailabilityZone() {
+ String serverId = null;
+ for (String zoneId : zones) {
+ ServerApi serverApi = api.getServerApiForZone(zoneId);
+ try {
+serverId =
+serverApi.delete(serverId);
+ }
+ }
+ }
+
+ private Server createServer(String regionId, Server.Status serverStatus) {
+ ServerApi serverApi = api.getServerApiForZone(regionId);
+ CreateServerOptions options = new CreateServerOptions();
+
jclouds-pull-requests #679 UNSTABLE
Not sure if these are [real test
failures](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/org.apache.jclouds.api$s3/679/testReport/junit/org.jclouds.s3.filters/RequestAuthorizeSignatureTest/testIdempotent/)
or not...they're certainly not our
+limitations under the License.
+
+--
+project xmlns=http://maven.apache.org/POM/4.0.0;
xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance;
+ xsi:schemaLocation=http://maven.apache.org/POM/4.0.0
http://maven.apache.org/maven-v4_0_0.xsd;
+modelVersion4.0.0/modelVersion
+
jclouds » jclouds-labs #886 FAILURE
GitHub
[timeout](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs/886/console)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/57#issuecomment-38275658
jclouds » jclouds #934 FAILURE
Another [GitHub
timeout](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/934/console)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/312#issuecomment-38278954
jclouds-pull-requests #680 SUCCESS
jclouds-java-7-pull-requests #1150 SUCCESS
Bingo ;-)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/312#issuecomment-38286311
-}
+ }
+ }
+ }
+
+ @Test
+ public void testCreateInWrongAvailabilityZone() {
+ String serverId = null;
+ for (String zoneId : zones) {
+ ServerApi serverApi = api.getServerApiForZone(zoneId);
+ try {
+serverId =
@@ -88,7 +88,9 @@ public void testCreateInAvailabilityZone() {
Server server = serverApi.get(serverId);
assertEquals(server.getStatus(), Server.Status.ACTIVE);
} finally {
-serverApi.delete(serverId);
+if (serverId!=null) {
[minor]
+1 - good to go for me!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/323#issuecomment-38316357
@@ -31,7 +31,7 @@
interface Factory {
SshClient create(HostAndPort socket, LoginCredentials credentials);
-
+ boolean existsSshAgent();
`hasSshAgent`? Or is the SSH agent not really something the client _has_,
rather something it _talks to_?
---
Reply to this email
}
sessionConnection =
SessionConnection.builder().hostAndPort(HostAndPort.fromParts(host,
socket.getPort())).loginCredentials(
loginCredentials).proxy(checkNotNull(proxyConfig,
proxyConfig)).connectTimeout(timeout).sessionTimeout(timeout).build();
}
}
sessionConnection =
SessionConnection.builder().hostAndPort(HostAndPort.fromParts(host,
socket.getPort())).loginCredentials(
loginCredentials).proxy(checkNotNull(proxyConfig,
proxyConfig)).connectTimeout(timeout).sessionTimeout(timeout).build();
}
@@ -128,23 +132,44 @@ public JschSshClient(ProxyConfig proxyConfig,
BackoffLimitedRetryHandler backoff
this.user = checkNotNull(loginCredentials,
loginCredentials).getUser();
this.host = checkNotNull(socket, socket).getHostText();
checkArgument(socket.getPort() 0, ssh
}
sessionConnection =
SessionConnection.builder().hostAndPort(HostAndPort.fromParts(host,
socket.getPort())).loginCredentials(
loginCredentials).proxy(checkNotNull(proxyConfig,
proxyConfig)).connectTimeout(timeout).sessionTimeout(timeout).build();
}
}
sessionConnection =
SessionConnection.builder().hostAndPort(HostAndPort.fromParts(host,
socket.getPort())).loginCredentials(
loginCredentials).proxy(checkNotNull(proxyConfig,
proxyConfig)).connectTimeout(timeout).sessionTimeout(timeout).build();
}
+ !loginCredentials.getPrivateKey().isEmpty()
+ !loginCredentials.getPrivateKey().contains(Proc-Type:
4,ENCRYPTED);
+ }
+
+ static Connector getSSHAgentConnector() {
+ JSch.setConfig(PreferredAuthentications, publickey);
+ ConnectorFactory cf =
byte[] privateKey = loginCredentials.getPrivateKey().getBytes();
jsch.addIdentity(loginCredentials.getUser(), privateKey, null,
emptyPassPhrase);
+ } else {
+ Connector con = JschSshClient.getSSHAgentConnector();
If we go for an injectable factory/supplier
byte[] privateKey = loginCredentials.getPrivateKey().getBytes();
jsch.addIdentity(loginCredentials.getUser(), privateKey, null,
emptyPassPhrase);
+ } else {
+ Connector con = JschSshClient.getSSHAgentConnector();
+ if(con != null ){
[minor]
byte[] privateKey = loginCredentials.getPrivateKey().getBytes();
jsch.addIdentity(loginCredentials.getUser(), privateKey, null,
emptyPassPhrase);
+ } else {
+ Connector con = JschSshClient.getSSHAgentConnector();
+ if(con != null ){
+
@@ -67,5 +70,19 @@ public SshClient create(HostAndPort socket,
LoginCredentials credentials) {
injector.injectMembers(client);// add logger
return client;
}
+
+ @Override
+ public boolean existsSshAgent() {
+ try {
+
@@ -67,5 +70,19 @@ public SshClient create(HostAndPort socket,
LoginCredentials credentials) {
injector.injectMembers(client);// add logger
return client;
}
+
+ @Override
+ public boolean existsSshAgent() {
+ try {
Reuse
@@ -206,4 +217,13 @@ public String toString() {
sessionTimeout, sessionTimeout).toString();
}
+ private static ListAuthMethod getAuthMethods(AgentProxy agent) throws
Exception {
Narrow the list of exception types thrown here?
---
Reply to this email
OpenSSHKeyFile key = new OpenSSHKeyFile();
key.init(loginCredentials.getPrivateKey(), null);
ssh.authPublickey(loginCredentials.getUser(), key);
+ } else {
+ AgentProxy proxy= SshjSshClient.getSSHAgentProxy();
[minor] Space before `=`
---
Reply to
@@ -206,4 +217,13 @@ public String toString() {
sessionTimeout, sessionTimeout).toString();
}
+ private static ListAuthMethod getAuthMethods(AgentProxy agent) throws
Exception {
+ Identity[] identities = agent.getIdentities();
+ ListAuthMethod
+ !loginCredentials.getPrivateKey().isEmpty()
+ !loginCredentials.getPrivateKey().contains(Proc-Type:
4,ENCRYPTED);
+ }
+
+ static AgentProxy getSSHAgentProxy() {
+ ConnectorFactory cf = ConnectorFactory.getDefault();
+ try {
+ Connector con =
@@ -62,5 +65,19 @@ public SshClient create(HostAndPort socket,
LoginCredentials credentials) {
injector.injectMembers(client);// add logger
return client;
}
+
+ @Override
+ public boolean existsSshAgent() {
+ try {
+
@@ -86,6 +86,16 @@
artifactIdjsch/artifactId
scopecompile/scope
/dependency
+dependency
+ groupIdcom.jcraft/groupId
+ artifactIdjsch.agentproxy.jsch/artifactId
+ version0.0.7/version
+/dependency
Do we need this, since the sshj version only needs
+exception
+ conflictingDependencies
+dependency
+ groupIdcom.jcraft/groupId
+ artifactIdjsch.agentproxy.core/artifactId
+ version0.0.7/version
+/dependency
+
}
sessionConnection =
SessionConnection.builder().hostAndPort(HostAndPort.fromParts(host,
socket.getPort())).loginCredentials(
loginCredentials).proxy(checkNotNull(proxyConfig,
proxyConfig)).connectTimeout(timeout).sessionTimeout(timeout).build();
}
Hm...looks like we didn't have a test to verify the limitation anyway ;-) +1 -
looks good to me too.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/324#issuecomment-38337083
To destroy all nodes of the group *mygroup*:
java -jar target/compute-basics-jar-with-dependencies.jar provider
identity credential mygroup destroy
+To list the nodes: *groupname* parameter is not used
[minor] To list all nodes (the *groupname* parameter is not used):?
---
/dependency
dependency
groupIdorg.apache.jclouds.driver/groupId
artifactIdjclouds-enterprise/artifactId
- version1.7.1/version
+ version${jclouds.version}/version
Thanks for this cleanup!
---
Reply to this email directly or view it on GitHub:
@@ -202,6 +214,20 @@ public static void main(String[] args) {
Predicates.NodeMetadata and(not(TERMINATED),
inGroup(groupName)));
System.out.printf( destroyed nodes %s%n, destroyed);
break;
+ case LISTIMAGES:
+Set? extends
@@ -202,6 +214,20 @@ public static void main(String[] args) {
Predicates.NodeMetadata and(not(TERMINATED),
inGroup(groupName)));
System.out.printf( destroyed nodes %s%n, destroyed);
break;
+ case LISTIMAGES:
+Set? extends
@@ -202,6 +214,20 @@ public static void main(String[] args) {
Predicates.NodeMetadata and(not(TERMINATED),
inGroup(groupName)));
System.out.printf( destroyed nodes %s%n, destroyed);
break;
+ case LISTIMAGES:
+Set? extends
@@ -218,6 +244,16 @@ public static void main(String[] args) {
}
}
+ private static String getPrivateKeyFromFile(String filename) {
+ try {
+ return Strings2.toStringAndClose(new FileInputStream(filename));
+ } catch (java.io.IOException e) {
+
@@ -86,6 +86,16 @@
artifactIdjsch/artifactId
scopecompile/scope
/dependency
+dependency
+ groupIdcom.jcraft/groupId
+ artifactIdjsch.agentproxy.jsch/artifactId
+ version0.0.7/version
+/dependency
+dependency
+ groupIdcom.jcraft/groupId
@@ -34,6 +34,12 @@
}
+ interface SshAgentAvailable {
+
+ boolean isSshAgentAvailable();
+
+ }
[minor] Remove blank lines and rename to something like `SshAgentFeatureFlag`
or `SshClientFeatures` or so?
---
Reply to this email directly or view it on GitHub:
@@ -156,6 +157,15 @@ public String getPrivateKey() {
}
/**
+* @return true if there is a private key attached that is not encrypted
+*/
+ public boolean hasUnencryptedPrivateKey() {
+ return getPrivateKey() != null
+ !getPrivateKey().isEmpty()
+
@@ -160,11 +171,14 @@ public Session create() throws Exception {
session.setTimeout(sessionTimeout);
if (loginCredentials.getPrivateKey() == null) {
session.setPassword(loginCredentials.getPassword());
- } else {
-
byte[] privateKey = loginCredentials.getPrivateKey().getBytes();
jsch.addIdentity(loginCredentials.getUser(), privateKey, null,
emptyPassPhrase);
+ } else {
Simply `} else if {`?
---
Reply to this email directly or view it on GitHub:
injector.injectMembers(client);// add logger
return client;
}
}
+ private static class AgentProvider implements ProviderConnector,
SshClient.SshAgentAvailable {
+
+ @Override
+ public Connector get() {
+ try {
+return
+ }
+ @Override
+ public boolean isAvailable() {
+ return false;
+ }
+ @Override
+ public String
@@ -58,9 +65,40 @@ public Factory(BackoffLimitedRetryHandler
backoffLimitedRetryHandler, Injector i
@Override
public SshClient create(HostAndPort socket, LoginCredentials
credentials) {
- SshClient client = new SshjSshClient(backoffLimitedRetryHandler,
socket,
+ public boolean isAvailable() {
+ return false;
+ }
+ @Override
+ public String getName() {
+ return agent-unavailable;
+ }
+};
+ }
+ }
+
+ @Override
Also thanks from me for the cleanup, @psiniemi! Just a curiosity question: why
do we actually need the connector wrapper class? Could we configure Guice to
try to inject the JSch connector _directly_, or do we need a new instance for
every connection? In that case, perhaps make it a factory
@@ -43,6 +56,24 @@ public CloudFilesCDNApiLiveTest() {
super();
}
+ public void testEnable() throws Exception {
+ for (String regionId : regions) {
+ assertNotNull(api.cdnApiInRegion(regionId).enable(name));
+ }
+ }
+
+ public void
@@ -86,6 +117,45 @@ public void testGet() throws Exception {
}
}
+ /**
+* By default, this method is disabled due to daily purge limitations of
25 objects per day.
+*/
+ @Test(enabled = false)
+ public void testPurgeObject() throws Exception {
+ for
+ MockWebServer server = mockOpenStackServer();
+ server.enqueue(addCommonHeaders(new
MockResponse().setBody(stringFromResource(/access.json;
+ server.enqueue(addCommonHeaders(new
MockResponse().setResponseCode(404).setBody(stringFromResource(/cdn_container_list.json;
@@ -81,6 +77,28 @@ public void testList() throws Exception {
}
}
+ public void testListFail() throws Exception {
What failure exactly are we testing here?
---
Reply to this email directly or view it on GitHub:
assertAuthentication(server);
assertRequest(server.takeRequest(), PUT,
/v1/MossoCloudFS_5bcf396e-39dd-45ff-93a1-712b9aba90a9/container-1);
+ } finally {
+ server.shutdown();
+ }
+ }
+
+ public void testEnableFail() throws Exception {
Which
In general, thanks a lot for the cleanup, @jdaggett! Just some questions about
test naming: there are a lot of `...Fail()` tests that do not obviously seem to
fail (e.g. they don't expect an exception). Could we give them more specific
names to describe which kind of failure on the server they
+1 - thanks, @jdaggett!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/84#issuecomment-38634346
@@ -156,6 +157,15 @@ public String getPrivateKey() {
}
/**
+* @return true if there is a private key attached that is not encrypted
+*/
+ public boolean hasUnencryptedPrivateKey() {
+ return getPrivateKey() != null
+ !getPrivateKey().isEmpty()
+
Only the minor question about a possible case-insensitive check for the
encrypted header from me, otherwise +1 - looks good. @nacx: Any more
questions from you?
I guess we want want to backport this to 1.7.x? And we should probably create
an issue for this, just for housekeeping...
---
Reply
I made a comment that was more appropriate to be made over in the issue.
Good catch, @everett-toews. Thanks!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/327#issuecomment-38738453
@@ -102,6 +103,27 @@ public String toString() {
}
+ public static class BlockDevice{
+ @Named(volume_size)
+ String volumeSize = ;
+ @Named(volume_id)
+ String volumeId;
+ @Named(delete_on_termination)
+ int deleteOnTermination = 0;
+
+ String volumeSize = ;
+ @Named(volume_id)
+ String volumeId;
+ @Named(delete_on_termination)
+ int deleteOnTermination = 0;
+ @Named(device_name)
+ String deviceName;
+
+ public BlockDevice(String volumeId, String deviceName){
+
@@ -113,6 +135,7 @@ public String toString() {
private SetNetwork novaNetworks = ImmutableSet.of();
private String availabilityZone;
private boolean configDrive;
+ private ListBlockDevice blockDeviceMapping = Lists.newArrayList();
`ImmutableList.of()`?
---
Reply to this email
@@ -463,6 +494,21 @@ public CreateServerOptions networks(String... networks) {
return networks(ImmutableSet.copyOf(networks));
}
+ /**
+* Block volumes that should be attached to the instance at boot time
+*/
+ public ListBlockDevice getBlockDeviceMapping() {
+
@@ -463,6 +494,21 @@ public CreateServerOptions networks(String... networks) {
return networks(ImmutableSet.copyOf(networks));
}
+ /**
+* Block volumes that should be attached to the instance at boot time
+*/
+ public ListBlockDevice getBlockDeviceMapping() {
+
jclouds-labs-openstack-pull-requests #185 UNSTABLE
Glance tests [are
failing](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/org.apache.jclouds.labs$openstack-glance/185/testReport/)
- I guess you are expecting that, @zack-shoylev?
If I recall, we had a follow-up PR
so I'm ok with the current check being case sensitive
Thanks for checking the spec, @nacx. Lazy me :-( Good to go on this one - just
the usual squash'n'rebase, and an issue number!
---
Reply to this email directly or view it on GitHub:
+vm =
client.getVirtualMachineApi().getVirtualMachine(vm.getId());
+ListInteger ports =
Ints.asList(templateOptions.getInboundPorts());
+if (capabilities.getCloudStackVersion().startsWith(2)) {
+ logger.debug( setting up IP
jclouds-pull-requests #707 UNSTABLE
Spurious [test
failure](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/org.apache.jclouds$jclouds-compute/707/testReport/junit/org.jclouds.compute.util/ConcurrentOpenSocketFinderTest/testChecksSocketsConcurrently/)
---
Reply to this email
@nacx: Created [JCLOUDS-516](https://issues.apache.org/jira/browse/JCLOUDS-516)
and am about to merge this...
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/312#issuecomment-38777027
Finally! ;-) Committed to
[master](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commit;h=85a1a8c1dd3de5f107ddf8e66c22b2fb3410a4ba)
@nacx: Backport to 1.7.x? And many thanks for all your work, @psiniemi!
---
Reply to this email directly or view it on GitHub:
Closed #312.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/312
Will you backport it too?
I'll submit a PR just to check, yes...
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/312#issuecomment-38778047
Open for review...
You can merge this Pull Request by running:
git pull https://github.com/jclouds/jclouds JCLOUDS-509
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/329
-- Commit Summary --
* Support #39;AssociatePublicIpAddress#39; in
Backport of https://github.com/jclouds/jclouds/pull/312
You can merge this Pull Request by running:
git pull https://github.com/jclouds/jclouds JCLOUDS-516-1.7.x
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/330
-- Commit Summary --
*
Just checking to see if the PR builders are happy...
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/330#issuecomment-38779717
+vm =
client.getVirtualMachineApi().getVirtualMachine(vm.getId());
+ListInteger ports =
Ints.asList(templateOptions.getInboundPorts());
+if (capabilities.getCloudStackVersion().startsWith(2)) {
+ logger.debug( setting up IP
+logger.trace( static NATed IPAddress(%s) to
virtualMachine(%s), ip.getId(), vm.getId());
+vm =
client.getVirtualMachineApi().getVirtualMachine(vm.getId());
+ListInteger ports =
Ints.asList(templateOptions.getInboundPorts());
+
@@ -26,19 +39,6 @@
import static org.jclouds.reflect.Reflection2.typeToken;
import static org.jclouds.util.Throwables2.propagateIfPossible;
-import java.lang.reflect.Method;
-import java.lang.reflect.Proxy;
-import java.util.Arrays;
-import java.util.Collections;
-import
@@ -28,8 +25,10 @@
import org.jclouds.ec2.compute.config.EC2ResolveImagesModule;
import org.jclouds.rest.internal.BaseHttpApiMetadata;
-import com.google.common.collect.ImmutableSet;
-import com.google.inject.Module;
+import java.net.URI;
+import java.util.Properties;
+
+import
Haven't been able to review this properly, but one initial comment: could you
take the move import statements changes out of this PR? That should make the
PR smaller and easier to review.
Thanks, Lahiru!
---
Reply to this email directly or view it on GitHub:
jclouds-pull-requests #710 SUCCESS
[Clean
Checkstyle](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/710/violations/).
+1 - good to go for me.
@nacx @abayer: any open questions? Otherwise, please squash'n'rebase, and then
we can merge!
---
Reply to this email directly or view it
Closed #330.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/330
jclouds-java-7-pull-requests #1183 UNSTABLE
[Spurious](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/org.apache.jclouds$jclouds-compute/1182/testReport/junit/org.jclouds.compute.util/ConcurrentOpenSocketFinderTest/testChecksSocketsConcurrently/)
[test
Homepage looks fine:
+1 - good to go for me. Thanks, @nacx!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/66#issuecomment-38794389
Committed to
[master](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;h=0401959).
Thanks, @spark404!
@nacx: Do we want to backport this? If so, to which branch(es)?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/328#issuecomment-38794590
You can merge this Pull Request by running:
git pull https://github.com/jclouds/jclouds JCLOUDS-347-1.7.x
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/332
-- Commit Summary --
* JCLOUDS-347: Implement a poor-mans rollback if CloudStack
Let's see what the PR builders say...
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/332#issuecomment-38802961
Many thanks for the updates, @jdaggett! Checked links, all look good. +1 - good
to go for me.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/36#issuecomment-38881732
Will try to have a look at this soon, but could you in the meantime clean up
the four small [Checkstyle
violations](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/717/org.apache.jclouds.provider$aws-ec2/violations/)
that have been introduced?
Thanks, @lahirus!
---
Reply to this
Another thing that we will certainly want to do, by the way, is run the live
test suite against AWS EC2. See the [Running live tests
section](http://2bfcdbe0cc28b674f568-6e84ef02f7d038e5f4526bc5b8a12a51.r1.cf1.rackcdn.com/documentation/devguides/provider-testing/)
from this cached version of
@abayer: Want to backport this to 1.7.x?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/332#issuecomment-38999088
jclouds-labs-openstack-pull-requests #190 SUCCESS
[Happy
Checkstyle](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/190/violations/)!
Thanks, @zack-shoylev!
I will submit another PR to revert the changes to the Cloud Servers examples
for the time being.
Sound good?
Sounds good! Thanks, @jdaggett!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/35#issuecomment-39008301
@nacx: Status of this? Are we still trying to get this in for 1.7.2?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/331#issuecomment-39008500
This looks great - thanks, @jdaggett! +1 - good to go for me, after the
squash'n'rebase that you mentioned.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/37#issuecomment-39008704
I'm guessing this was a test or an accidental PR ;-)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/335#issuecomment-39008720
jclouds-karaf-pull-requests #52 UNSTABLE
No test failures, just a bunch of [Checkstyle
violations](https://jclouds.ci.cloudbees.com/job/jclouds-karaf-pull-requests/52/violations/).
None related to this PR, though, from what I can see.
---
Reply to this email directly or view it on GitHub:
Closed #40.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/40
+ throw Throwables.propagate(ex);
+ } catch (IOException ex) {
+ throw Throwables.propagate(ex);
+ }
+ throw new HttpException(Glance endpoint does not support
API version: + apiVersion);
+
+ public ListVersion versions;
+ }
+
+ private final SupplierMapString, SupplierURI zoneToEndpointSupplier;
+ private final String apiVersion;
+ private final LoadingCacheURI, URI endpointCache;
+
+ @Inject
+ public ZoneToEndpointNegotiateVersion(@Zone SupplierMapString,
301 - 400 of 4117 matches
Mail list logo
