Sorry i forgot about the mock test!
Also noticed i changed the returning HTTP codes for start/restart/stop to the
actual values returned by ARM API
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
danielestevez commented on this pull request.
> @@ -54,13 +54,17 @@
BRAZIL_SOUTH("Brazil South", "BR"),
AUSTRALIA_EAST("Australia East", "AU-NSW"),
AUSTRALIA_SOUTH_EAST("Australia Southeast", "AU-VIC"),
+ AUSTRALIA_CENTRAL("Australia Central", "AU-ACT"),
+
danielestevez approved this pull request.
It's time!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/449#pullrequestreview-164718408
rebuild please
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1245#issuecomment-430785426
danielestevez commented on this pull request.
> + /**
+* @see InstanceType#T3_MEDIUM
+*/
+ public static EC2HardwareBuilder t3_medium() {
+ return new EC2HardwareBuilder(InstanceType.T3_MEDIUM).t3()
+ .ram(4096)
+ .processors(ImmutableList.of(new
danielestevez commented on this pull request.
> @@ -429,6 +444,89 @@ public static EC2HardwareBuilder t2_large() {
.processors(ImmutableList.of(new Processor(1.0,
0.4))).rootDeviceType(RootDeviceType.EBS);
}
+ /**
+* @see InstanceType#T2_XLARGE
+*/
+ public
danielestevez commented on this pull request.
> @@ -429,6 +444,89 @@ public static EC2HardwareBuilder t2_large() {
.processors(ImmutableList.of(new Processor(1.0,
0.4))).rootDeviceType(RootDeviceType.EBS);
}
+ /**
+* @see InstanceType#T2_XLARGE
+*/
+ public
danielestevez approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1245#pullrequestreview-167903755
Pushed to
[master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/219e2958) and
[2.1.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/e4c99a07)!
Thanks @trentontrees for the contribution!!
--
You are receiving this because you are subscribed to this thread.
Reply to this email
Closed #1245.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1245#event-1924344216
Thanks @trentontrees CPU seem correct now but i'm looking at
```Processsors.speed`` and it don't see the right values.
In AWS doc these new instances have ```up to 3.3``` for t2 and 2.5 for t3
instead of 0.4. Could you check these values too?
Once done, just rebase it and it'll be merged!
That link looks useful, thanks!
Please squash the commits and we're done
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1245#issuecomment-432469002
Also updates API version for VirtualMachineApi
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/1257
-- Commit Summary --
* Adds method listAvailableSizes to VirtualMachineApi
-- File Changes --
M
Yes, a simple `isChina` is easily implementable as we can parse
`ContextBuilder.endpoint`
Thanks for the tip, i'll try that approach and update the PR since i think we
can suppose this will be the only exception and Microsoft won't be adding other
additional endpoints.
--
You are receiving
danielestevez commented on this pull request.
> @@ -110,6 +122,27 @@ protected VirtualMachineInStatePredicateFactory
> provideNodeSuspendedPredicate(fi
timeouts.nodeTerminated, pollPeriod.pollInitialPeriod,
pollPeriod.pollMaxPeriod);
}
+ @Provides
+
@danielestevez pushed 2 commits.
93356e726b3872c179310738439c4ddfcf3a3a66 Changes order in parameters to keep
properties as last parameter
888ad76b12ec86c180a4ad5d6054de556f9506c3 Moves LoadBalancer and PublicAddress
to new package with SKU as inner
--
You are receiving this because you
Thanks for the review @nacx !
Finally i added all SKU entities as inner classes so it's easier to reference
them in code.
Also both SKUs have a `SKUName` field similar to what we do at `AvailabilitySet`
I also noticed there is a generic `SKU` entity that should be under Vault and a
danielestevez approved this pull request.
Good!
I'm not sure if it'd be interesting to add a test to cover this issue of having
no region filter?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
danielestevez commented on this pull request.
> @@ -66,9 +67,9 @@
@MapBinder(BindToJsonPayload.class)
@PUT
PublicIPAddress createOrUpdate(@PathParam("publicipaddressname") String
publicipaddressname,
- @PayloadParam("location")
danielestevez commented on this pull request.
> + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.jclouds.azurecompute.arm.domain;
+
+import
danielestevez commented on this pull request.
> +import org.jclouds.json.SerializedNames;
+
+import com.google.auto.value.AutoValue;
+
+@AutoValue
+public abstract class PublicAddressSKU {
+
+ public static enum PublicIPAddressSkuName {
+ Basic, Standard, Unrecognized;
+
+ public
danielestevez commented on this pull request.
> + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.jclouds.azurecompute.arm.domain;
+
+import
danielestevez commented on this pull request.
> @@ -68,7 +69,7 @@
@MapBinder(BindToJsonPayload.class)
LoadBalancer createOrUpdate(@PathParam("loadbalancername") String lbName,
@PayloadParam("location") String location, @Nullable
@PayloadParam("tags") Map tags,
-
danielestevez commented on this pull request.
> @@ -0,0 +1,44 @@
+/*
Same concern as before keeping the original MS names, but embedding it seems a
good idea.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
danielestevez commented on this pull request.
> +import org.jclouds.json.SerializedNames;
+
+import com.google.auto.value.AutoValue;
+
+@AutoValue
+public abstract class LoadBalancerSKU {
+
+ public static enum LoadBalancerSKUName {
+ Basic, Standard, Unrecognized;
+
+ public static
danielestevez commented on this pull request.
> + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.jclouds.azurecompute.arm.domain;
+
+import
* Adds SKU field to PublicIPAddress and LoadBalancer
* Adds LiveTests to create these new type of entities
* Modifies existing calls to have default SKU null, which translates to Basic
in Azure deployments. Jclouds will keep creating these Basic SKU IPs when
deploying a VM
danielestevez approved this pull request.
Thanks @kazimazar
I noticed a small difference between here
https://aws.amazon.com/blogs/aws/ec2-instance-update-c5-instances-with-local-nvme-storage-c5d/
and some sizes for the c5d instances
Could you please check this info and fix it if needed?
I'll
Closed #1260.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1260#event-2002768423
Thanks again @kazimazar!
Merged to
[2.1.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/8dcfd862) and
[master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/5916059b)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it
danielestevez commented on this pull request.
> @@ -171,9 +216,12 @@ public boolean cleanupSecurityGroupIfOrphaned(String
> resourceGroup, String group
logger.debug(">> deleting orphaned security group %s from
%s...", name, resourceGroup);
try {
Merged to
[2.1.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/38e3535d) and
[master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/8e827d59)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Closed #1257.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1257#event-1978014074
@danielestevez pushed 1 commit.
ce752f83455c19385bc938e0d50c85979b67f5f2 Reorder parameters sku and properties
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
Closed #1265.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1265#event-2047729700
Thanks again @pimuzzo
Merged to
[2.1.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/4c18ca77) and
[master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/2d9bb934)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on
Merged to
[2.1.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/3d308560) and
[master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/d621edd7)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Closed #1264.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1264#event-2047757965
rebuild please
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1264#issuecomment-448626652
101 - 139 of 139 matches
Mail list logo
