[jira] [Created] (JCLOUDS-1544) Unable to build javadoc with JDK >= 8

2020-04-16 Thread Fritz Elfert (Jira)
Fritz Elfert created JCLOUDS-1544:
-

 Summary: Unable to build javadoc with JDK >= 8
 Key: JCLOUDS-1544
 URL: https://issues.apache.org/jira/browse/JCLOUDS-1544
 Project: jclouds
  Issue Type: Bug
  Components: docs
Affects Versions: 2.2.0
Reporter: Fritz Elfert


Subject says it all.

The following PR fixes this:
[https://github.com/apache/jclouds/pull/67|https://github.com/apache/jclouds/pull/67]

Cheers
 -Fritz



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (JCLOUDS-1300) Unable to launch gce in jenkins

2017-05-24 Thread Fritz Elfert (JIRA)

[ 
https://issues.apache.org/jira/browse/JCLOUDS-1300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16022434#comment-16022434
 ] 

Fritz Elfert commented on JCLOUDS-1300:
---

Will that be some new member of TemplateOptions resp. 
GoogleComputeEngineTemplateOptions or is it supposed to be handled by some 
existing member already?
In case of the latter: which one?

> Unable to launch gce in jenkins
> ---
>
> Key: JCLOUDS-1300
> URL: https://issues.apache.org/jira/browse/JCLOUDS-1300
> Project: jclouds
>  Issue Type: Bug
>  Components: jclouds-compute
>Affects Versions: 2.0.1
>Reporter: Utkarsh Sharma
>Priority: Blocker
>  Labels: google-compute-engine
> Attachments: Screen Shot 2017-05-16 at 12.44.31 PM.png, Screen Shot 
> 2017-05-16 at 12.58.41 PM.png
>
>
> Unable to launch GCE instance using jclouds plugin in Jenkins.
> Needt to launch GCE in custom network and subnetwork. The functionality is 
> currently under developement.
> We are excited about release of this feature, when can we expect its release.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (JCLOUDS-1300) Unable to launch gce in jenkins

2017-05-24 Thread Fritz Elfert (JIRA)

[ 
https://issues.apache.org/jira/browse/JCLOUDS-1300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16022425#comment-16022425
 ] 

Fritz Elfert commented on JCLOUDS-1300:
---

Further info at https://issues.jenkins-ci.org/browse/JENKINS-44292

> Unable to launch gce in jenkins
> ---
>
> Key: JCLOUDS-1300
> URL: https://issues.apache.org/jira/browse/JCLOUDS-1300
> Project: jclouds
>  Issue Type: Bug
>  Components: jclouds-compute
>Affects Versions: 2.0.1
>Reporter: Utkarsh Sharma
>Priority: Blocker
>  Labels: google-compute-engine
> Attachments: Screen Shot 2017-05-16 at 12.44.31 PM.png, Screen Shot 
> 2017-05-16 at 12.58.41 PM.png
>
>
> Unable to launch GCE instance using jclouds plugin in Jenkins.
> Needt to launch GCE in custom network and subnetwork. The functionality is 
> currently under developement.
> We are excited about release of this feature, when can we expect its release.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


Re: [jclouds/jclouds] Handle gzipped userdata in logging (#1062)

2017-02-15 Thread Fritz Elfert
@felfert pushed 2 commits.

c3d9a68  Conform to apache jclouds coding standards
5e7139b  Added unit test for CreateServerOptions.toString() behavior


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds/pull/1062/files/138484bd544dea7ede054740fa63ed7802cff03e..5e7139b001ac90794cd7741e579c22490bab7bb9


Re: [jclouds/jclouds] Handle gzipped userdata in logging (#1061)

2017-02-15 Thread Fritz Elfert
@felfert pushed 2 commits.

3dc075e  Conform to apache jclouds coding standards
21d247c  Added unit test for CreateServerOptions.toString() behavior


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds/pull/1061/files/55e96ac6e824efa03cad1319f508cdd808fa00d4..21d247c65e91f9ddc5fcb691302e5e31a416c578


Re: [jclouds/jclouds] Handle gzipped userdata in logging (#1061)

2017-02-15 Thread Fritz Elfert
Will do.

-Fritz

Am 15. Februar 2017 11:11:28 MEZ schrieb Ignasi Barrera 
:
>Thanks @felfert! Could you add a simple unit test that verifies the
>behaviour of that method with normal and gzipped inputs? This way we
>won't break this unintentionally in the future.
>
>-- 
>You are receiving this because you were mentioned.
>Reply to this email directly or view it on GitHub:
>https://github.com/jclouds/jclouds/pull/1061#issuecomment-27997

-- 
Diese Nachricht wurde von meinem Android-Mobiltelefon mit K-9 Mail gesendet.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1061#issuecomment-279979148

[jira] [Updated] (JCLOUDS-1239) Gzipped userdata not handled in openstack-nova debug logging

2017-02-14 Thread Fritz Elfert (JIRA)

 [ 
https://issues.apache.org/jira/browse/JCLOUDS-1239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Fritz Elfert updated JCLOUDS-1239:
--
Labels: openstack-nova  (was: )

> Gzipped userdata not handled in openstack-nova debug logging
> 
>
> Key: JCLOUDS-1239
> URL: https://issues.apache.org/jira/browse/JCLOUDS-1239
> Project: jclouds
>  Issue Type: Improvement
>  Components: jclouds-compute
>Affects Versions: 2.0.0
>Reporter: Fritz Elfert
>Priority: Minor
>  Labels: openstack-nova
>
> It is very common to gzip userdata on openstack to preserve space (when using 
> cloud-init for example).
> If debug logging is enabled, then this binary data is shown as is which 
> disrupts the log.
> Example output:
> {noformat}
> >> creating new server region(RegionOne) name(foo-f2e) 
> >> image(41c50bca-cb94-4dc4-b4ce-6c98242eaaa6) 
> >> flavor(08fbed24-7fcf-42e3-bc5a-cdd7a701ef0c) 
> >> options(CreateServerOptions{keyName=null, securityGroupNames=[default], 
> >> metadata={Name=foo, jclouds-group=foo}, userData=*lots of "garbage"*, 
> >> networks=[73cbec8a-f53d-41af-843b-1cd4a6afc025], availabilityZone=null, 
> >> configDrive=false})
> {noformat}
> See https://github.com/jclouds/jclouds/pull/1061 (master) and 
> https://github.com/jclouds/jclouds/pull/1062 (2.0.x branch)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Updated] (JCLOUDS-1239) Gzipped userdata not handled in openstack-nova debug logging

2017-02-14 Thread Fritz Elfert (JIRA)

 [ 
https://issues.apache.org/jira/browse/JCLOUDS-1239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Fritz Elfert updated JCLOUDS-1239:
--
Description: 
It is very common to gzip userdata on openstack to preserve space (when using 
cloud-init for example).
If debug logging is enabled, then this binary data is shown as is which 
disrupts the log.

Example output:
{noformat}
>> creating new server region(RegionOne) name(foo-f2e) 
>> image(41c50bca-cb94-4dc4-b4ce-6c98242eaaa6) 
>> flavor(08fbed24-7fcf-42e3-bc5a-cdd7a701ef0c) 
>> options(CreateServerOptions{keyName=null, securityGroupNames=[default], 
>> metadata={Name=foo, jclouds-group=foo}, userData=*lots of "garbage"*, 
>> networks=[73cbec8a-f53d-41af-843b-1cd4a6afc025], availabilityZone=null, 
>> configDrive=false})
{noformat}

See https://github.com/jclouds/jclouds/pull/1061 (master) and 
https://github.com/jclouds/jclouds/pull/1062 (2.0.x branch)

  was:
It is very common to gzip userdata on openstack to preserve space (when using 
cloud-init for example).
If debug logging is enabled, then this binary data is shown as is which 
disrupts the log.

Example output:
{noformat}
>> creating new server region(RegionOne) name(foo-f2e) 
>> image(41c50bca-cb94-4dc4-b4ce-6c98242eaaa6) 
>> flavor(08fbed24-7fcf-42e3-bc5a-cdd7a701ef0c) 
>> options(CreateServerOptions{keyName=null, securityGroupNames=[default], 
>> metadata={Name=foo, jclouds-group=foo}, userData=*lots of "garbage"*, 
>> networks=[73cbec8a-f53d-41af-843b-1cd4a6afc025], availabilityZone=null, 
>> configDrive=false})
{noformat}

See https://github.com/jclouds/jclouds/pull/1061 (master) and 
https://github.com/jclouds/jclouds/pull/1062


> Gzipped userdata not handled in openstack-nova debug logging
> 
>
> Key: JCLOUDS-1239
> URL: https://issues.apache.org/jira/browse/JCLOUDS-1239
> Project: jclouds
>  Issue Type: Improvement
>  Components: jclouds-compute
>Affects Versions: 2.0.0
>Reporter: Fritz Elfert
>Priority: Minor
>
> It is very common to gzip userdata on openstack to preserve space (when using 
> cloud-init for example).
> If debug logging is enabled, then this binary data is shown as is which 
> disrupts the log.
> Example output:
> {noformat}
> >> creating new server region(RegionOne) name(foo-f2e) 
> >> image(41c50bca-cb94-4dc4-b4ce-6c98242eaaa6) 
> >> flavor(08fbed24-7fcf-42e3-bc5a-cdd7a701ef0c) 
> >> options(CreateServerOptions{keyName=null, securityGroupNames=[default], 
> >> metadata={Name=foo, jclouds-group=foo}, userData=*lots of "garbage"*, 
> >> networks=[73cbec8a-f53d-41af-843b-1cd4a6afc025], availabilityZone=null, 
> >> configDrive=false})
> {noformat}
> See https://github.com/jclouds/jclouds/pull/1061 (master) and 
> https://github.com/jclouds/jclouds/pull/1062 (2.0.x branch)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Updated] (JCLOUDS-1239) Gzipped userdata not handled in openstack-nova debug logging

2017-02-14 Thread Fritz Elfert (JIRA)

 [ 
https://issues.apache.org/jira/browse/JCLOUDS-1239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Fritz Elfert updated JCLOUDS-1239:
--
Description: 
It is very common to gzip userdata on openstack to preserve space (when using 
cloud-init for example).
If debug logging is enabled, then this binary data is shown as is which 
disrupts the log.

Example output:
{noformat}
>> creating new server region(RegionOne) name(foo-f2e) 
>> image(41c50bca-cb94-4dc4-b4ce-6c98242eaaa6) 
>> flavor(08fbed24-7fcf-42e3-bc5a-cdd7a701ef0c) 
>> options(CreateServerOptions{keyName=null, securityGroupNames=[default], 
>> metadata={Name=foo, jclouds-group=foo}, userData=*lots of "garbage"*, 
>> networks=[73cbec8a-f53d-41af-843b-1cd4a6afc025], availabilityZone=null, 
>> configDrive=false})
{noformat}

See https://github.com/jclouds/jclouds/pull/1061 (master) and 
https://github.com/jclouds/jclouds/pull/1062

  was:
It is very common to gzip userdata on openstack to preserve space (when using 
cloud-init for example).
If debug logging is enabled, then this binary data is shown as is which 
disrupts the log.

Example output:
{noformat}
>> creating new server region(RegionOne) name(foo-f2e) 
>> image(41c50bca-cb94-4dc4-b4ce-6c98242eaaa6) 
>> flavor(08fbed24-7fcf-42e3-bc5a-cdd7a701ef0c) 
>> options(CreateServerOptions{keyName=null, securityGroupNames=[default], 
>> metadata={Name=foo, jclouds-group=foo}, userData=*lots of "garbage"*, 
>> networks=[73cbec8a-f53d-41af-843b-1cd4a6afc025], availabilityZone=null, 
>> configDrive=false})
{noformat}

Will provide a pull request on github (which provides a readable replacement) 
shortly.


> Gzipped userdata not handled in openstack-nova debug logging
> 
>
> Key: JCLOUDS-1239
> URL: https://issues.apache.org/jira/browse/JCLOUDS-1239
> Project: jclouds
>  Issue Type: Improvement
>  Components: jclouds-compute
>Affects Versions: 2.0.0
>Reporter: Fritz Elfert
>Priority: Minor
>
> It is very common to gzip userdata on openstack to preserve space (when using 
> cloud-init for example).
> If debug logging is enabled, then this binary data is shown as is which 
> disrupts the log.
> Example output:
> {noformat}
> >> creating new server region(RegionOne) name(foo-f2e) 
> >> image(41c50bca-cb94-4dc4-b4ce-6c98242eaaa6) 
> >> flavor(08fbed24-7fcf-42e3-bc5a-cdd7a701ef0c) 
> >> options(CreateServerOptions{keyName=null, securityGroupNames=[default], 
> >> metadata={Name=foo, jclouds-group=foo}, userData=*lots of "garbage"*, 
> >> networks=[73cbec8a-f53d-41af-843b-1cd4a6afc025], availabilityZone=null, 
> >> configDrive=false})
> {noformat}
> See https://github.com/jclouds/jclouds/pull/1061 (master) and 
> https://github.com/jclouds/jclouds/pull/1062



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jclouds/jclouds] Handle gzipped userdata in logging (#1062)

2017-02-14 Thread Fritz Elfert
Like #1061 , only against the 2.0.x branch.

Fixes: JCLOUDS-1239
You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds/pull/1062

-- Commit Summary --

  * Handle gzipped userdata in logging

-- File Changes --

M 
apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/options/CreateServerOptions.java
 (9)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/1062.patch
https://github.com/jclouds/jclouds/pull/1062.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1062


[jclouds/jclouds] Handle gzipped userdata in logging (#1061)

2017-02-14 Thread Fritz Elfert
This PR replaces gzipped binary "garbage" in openstack-nova debug-logging of 
userData

Fixes: JCLOUDS-1239
You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds/pull/1061

-- Commit Summary --

  * Handle gzipped userdata in logging

-- File Changes --

M 
apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/options/CreateServerOptions.java
 (9)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/1061.patch
https://github.com/jclouds/jclouds/pull/1061.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1061


[jira] [Updated] (JCLOUDS-1239) Gzipped userdata not handled in openstack-nova debug logging

2017-02-14 Thread Fritz Elfert (JIRA)

 [ 
https://issues.apache.org/jira/browse/JCLOUDS-1239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Fritz Elfert updated JCLOUDS-1239:
--
Description: 
It is very common to gzip userdata on openstack to preserve space (when using 
cloud-init for example).
If debug logging is enabled, then this binary data is shown as is which 
disrupts the log.

Example output:
{noformat}
>> creating new server region(RegionOne) name(foo-f2e) 
>> image(41c50bca-cb94-4dc4-b4ce-6c98242eaaa6) 
>> flavor(08fbed24-7fcf-42e3-bc5a-cdd7a701ef0c) 
>> options(CreateServerOptions{keyName=null, securityGroupNames=[default], 
>> metadata={Name=foo, jclouds-group=foo}, userData=*lots of "garbage"*, 
>> networks=[73cbec8a-f53d-41af-843b-1cd4a6afc025], availabilityZone=null, 
>> configDrive=false})
{noformat}

Will provide a pull request on github (which provides a readable replacement) 
shortly.

  was:
It is very common to gzip userdata on openstack to preserve space (when using 
cloud-init for example).
If debug logging is enabled, then this binary data is shown as is which 
disrupts the log.

Example output:
{{>> creating new server region(RegionOne) name(foo-f2e) 
image(41c50bca-cb94-4dc4-b4ce-6c98242eaaa6) 
flavor(08fbed24-7fcf-42e3-bc5a-cdd7a701ef0c) 
options(CreateServerOptions{keyName=null, securityGroupNames=[default], 
metadata={Name=foo, jclouds-group=foo}, userData=*lots of "garbage"*, 
networks=[73cbec8a-f53d-41af-843b-1cd4a6afc025], availabilityZone=null, 
configDrive=false})}}

Will provide a pull request on github (which provides a readable replacement) 
shortly.


> Gzipped userdata not handled in openstack-nova debug logging
> 
>
> Key: JCLOUDS-1239
> URL: https://issues.apache.org/jira/browse/JCLOUDS-1239
> Project: jclouds
>  Issue Type: Improvement
>      Components: jclouds-compute
>Affects Versions: 2.0.0
>Reporter: Fritz Elfert
>Priority: Minor
>
> It is very common to gzip userdata on openstack to preserve space (when using 
> cloud-init for example).
> If debug logging is enabled, then this binary data is shown as is which 
> disrupts the log.
> Example output:
> {noformat}
> >> creating new server region(RegionOne) name(foo-f2e) 
> >> image(41c50bca-cb94-4dc4-b4ce-6c98242eaaa6) 
> >> flavor(08fbed24-7fcf-42e3-bc5a-cdd7a701ef0c) 
> >> options(CreateServerOptions{keyName=null, securityGroupNames=[default], 
> >> metadata={Name=foo, jclouds-group=foo}, userData=*lots of "garbage"*, 
> >> networks=[73cbec8a-f53d-41af-843b-1cd4a6afc025], availabilityZone=null, 
> >> configDrive=false})
> {noformat}
> Will provide a pull request on github (which provides a readable replacement) 
> shortly.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Created] (JCLOUDS-1239) Gzipped userdata not handled in openstack-nova debug logging

2017-02-14 Thread Fritz Elfert (JIRA)
Fritz Elfert created JCLOUDS-1239:
-

 Summary: Gzipped userdata not handled in openstack-nova debug 
logging
 Key: JCLOUDS-1239
 URL: https://issues.apache.org/jira/browse/JCLOUDS-1239
 Project: jclouds
  Issue Type: Improvement
  Components: jclouds-compute
Affects Versions: 2.0.0
Reporter: Fritz Elfert
Priority: Minor


It is very common to gzip userdata on openstack to preserve space (when using 
cloud-init for example).
If debug logging is enabled, then this binary data is shown as is which 
disrupts the log.

Example output:
{{>> creating new server region(RegionOne) name(foo-f2e) 
image(41c50bca-cb94-4dc4-b4ce-6c98242eaaa6) 
flavor(08fbed24-7fcf-42e3-bc5a-cdd7a701ef0c) 
options(CreateServerOptions{keyName=null, securityGroupNames=[default], 
metadata={Name=foo, jclouds-group=foo}, userData=*lots of "garbage"*, 
networks=[73cbec8a-f53d-41af-843b-1cd4a6afc025], availabilityZone=null, 
configDrive=false})}}

Will provide a pull request on github (which provides a readable replacement) 
shortly.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


Re: [jclouds/jclouds] Fixes JCLOUDS-1206 (#1042)

2016-11-28 Thread Fritz Elfert
> Right. I think the use of user metadata here is wrong. It is meant for 
> providers like OpenStack that support key value pairs in the metadata, but 
> not for this. Mind changing it and add the userData field to the 
> DigitalOceanTemplateOptions, and also this comment to properly indicate user 
> metadata (in the form of arbitrary key value pairs) is not supported? Thanks!

Done. I intentionally left the old "wrong" variant via the userMetaData map in 
place in order to not break existing code.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1042#issuecomment-263345268

Re: [jclouds/jclouds] Fixes JCLOUDS-1206 (#1042)

2016-11-28 Thread Fritz Elfert
@felfert pushed 1 commit.

ec39127  Added byte[] userData according to code review


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds/pull/1042/files/730cecd174f6a769518ebf2d12125f78bc95068b..ec39127a001bea32d30e097877db4fefbc4223e9


Re: [jclouds/jclouds-site] Update index.md (#191)

2016-11-27 Thread Fritz Elfert
Looks just like your image here (index of various javadocs shown), but if I 
click on **any** of those links, I get the following message:

Web Listing Disabled

The owner of this web site has disabled web listing.

If you are the owner of this web site, you can enable web listing by setting 
X-Container-Meta-Web-Listings.
Index File Not Found

The owner of this web site has set X-Container-Meta-Web-Index: index.html. 
However, this file is not found.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/191#issuecomment-263154163

Re: [jclouds/jclouds-site] Update index.md (#191)

2016-11-27 Thread Fritz Elfert
> Go to 
> http://db28c6e508cc7c000f84-4fe8c41c25aa7c42c77a072c81d57bea.r78.cf5.rackcdn.com/
>  to review your changes.
That link does not work at all?! (Index shown, but nothing else)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/191#issuecomment-263118387

[jclouds/jclouds-site] Update index.md (#191)

2016-11-27 Thread Fritz Elfert
Add missing link to 2.0.x javadoc
You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds-site/pull/191

-- Commit Summary --

  * Update index.md

-- File Changes --

M reference/javadoc/index.md (1)

-- Patch Links --

https://github.com/jclouds/jclouds-site/pull/191.patch
https://github.com/jclouds/jclouds-site/pull/191.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/191


Re: [jclouds/jclouds] Fixes JCLOUDS-1206 (#1042)

2016-11-26 Thread Fritz Elfert
@felfert pushed 1 commit.

730cecd  Simplified code according to code review


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds/pull/1042/files/487f5e8be846745fd3ad182b3fe592f381643d1e..730cecd174f6a769518ebf2d12125f78bc95068b


Re: [jclouds/jclouds] Fixes JCLOUDS-1206 (#1042)

2016-11-26 Thread Fritz Elfert
Later: Just realized, that the tags are a Set and associated with a 
node so: Of course that makes sense :)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1042#issuecomment-263073020

Re: [jclouds/jclouds] Fixes JCLOUDS-1206 (#1042)

2016-11-26 Thread Fritz Elfert
@nacx I looked into the tag api documentation and I think, it does **not** fit 
the jclouds semantic. In jclouds, those are `Map`, but in 
DigitalOcean they have Map where Object is currently always a 
droplet. (Most likely, it's an Integer-Id, just like with their key API).

I'm going to change make the proposed change in the PR, but while we are here:

The private Json member is not needed anymore, but I did not remove it, because 
I am not shure about the implications of changing the signature of the 
constructor in line 75. Perhaps **you** can comment on that.

Also, Just out of curiosity:
The others (meaning: at least openstack-nova and aws-ec2) have a completely 
different API in jclouds: They implement a separate method in their 
TemplateOptions specializations: [userData(byte[] 
userData)](https://jclouds.apache.org/reference/javadoc/1.9.x/org/jclouds/openstack/nova/v2_0/compute/options/NovaTemplateOptions.html#userData(byte[])).
 So: why is it that the digitaloceans2 provider follows a different approach 
here? Resulting code in the jenkins plugin:
```java
if (!isNullOrEmpty(userData)) {
try {
if (options instanceof DigitalOcean2TemplateOptions) {
options.userMetadata("user_data", userData);
} else {
Method userDataMethod = options.getClass().getMethod("userData", 
new byte[0].getClass());
LOGGER.finest("Setting userData to " + userData);
userDataMethod.invoke(options, 
userData.getBytes(StandardCharsets.UTF_8));
}
} catch (Exception e) {
LOGGER.log(Level.WARNING, "userData is not supported by provider 
options class " + options.getClass().getName(), e);
}
}
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1042#issuecomment-263070203

[jira] [Commented] (JCLOUDS-1206) Handling of user_data in digitalocean2 provider is broken

2016-11-26 Thread Fritz Elfert (JIRA)

[ 
https://issues.apache.org/jira/browse/JCLOUDS-1206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15697770#comment-15697770
 ] 

Fritz Elfert commented on JCLOUDS-1206:
---

This pull request on github fixes the issue. (Tested with an yet unreleased 
version of the jenkins jclouds plugin):
https://github.com/jclouds/jclouds/pull/1042

> Handling of user_data in digitalocean2 provider is broken
> -
>
> Key: JCLOUDS-1206
> URL: https://issues.apache.org/jira/browse/JCLOUDS-1206
> Project: jclouds
>  Issue Type: Bug
>  Components: jclouds-compute, jclouds-drivers
>Affects Versions: 2.0.0
>Reporter: Fritz Elfert
>
> The handling of user_data in digitalocean2 is unfortunately completely 
> broken. The existing code assumes, that it is a string which contains a 
> json_encoded map of key-value-pairs (containing both tags and user_data). 
> This is wrong. According to their docs and easily verifyable, it is a SINGLE 
> string which simply contains cloud-init data or a shell-script.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jclouds/jclouds] Fixes JCLOUDS-1206 (#1042)

2016-11-26 Thread Fritz Elfert

You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds/pull/1042

-- Commit Summary --

  * Fixes JCLOUDS-1206

-- File Changes --

M 
providers/digitalocean2/src/main/java/org/jclouds/digitalocean2/compute/DigitalOcean2ComputeServiceAdapter.java
 (7)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/1042.patch
https://github.com/jclouds/jclouds/pull/1042.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1042


[jira] [Created] (JCLOUDS-1206) Handling of user_data in digitalocean2 provider is broken

2016-11-26 Thread Fritz Elfert (JIRA)
Fritz Elfert created JCLOUDS-1206:
-

 Summary: Handling of user_data in digitalocean2 provider is broken
 Key: JCLOUDS-1206
 URL: https://issues.apache.org/jira/browse/JCLOUDS-1206
 Project: jclouds
  Issue Type: Bug
  Components: jclouds-compute, jclouds-drivers
Affects Versions: 2.0.0
Reporter: Fritz Elfert


The handling of user_data in digitalocean2 is unfortunately completely broken. 
The existing code assumes, that it is a string which contains a json_encoded 
map of key-value-pairs (containing both tags and user_data). This is wrong. 
According to their docs and easily verifyable, it is a SINGLE string which 
simply contains cloud-init data or a shell-script.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)