Closed #1215.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1215#event-1700613144
Squashed and pushed to
[master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/39d770ff) and
[2.1.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/ff95137f). Thanks
@danielestevez!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly
I think so! I opened the PR against 2.1.x as in the previous one but @nacx will
surely merge it to 2.1.x and master
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
> Adds minor improvements to readability
Looks good to me - many thanks, Daniel! Is this for 2.1.x only, or also for
master, incidentally?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
nacx approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1215#pullrequestreview-124173143
danielestevez commented on this pull request.
> @@ -54,7 +55,7 @@ private CharMatcher getAcceptableRange() {
protected IllegalArgumentException exception(String name, String reason) {
return new IllegalArgumentException(
-String.format("Object '%s' doesn't match Azure
@danielestevez pushed 1 commit.
2fd4f07 changes exception text for readability
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
nacx commented on this pull request.
> throw exception(name, "Should start with letter/number");
CharMatcher range = getAcceptableRange();
if (!range.matchesAllOf(name))
- throw exception(name, "Should have lowercase or uppercase ASCII
letters, numbers, or
Based on suggestions by @demobox in original PR
https://github.com/jclouds/jclouds/pull/1213
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/1215
-- Commit Summary --
* Adds minor improvements to readability
-- File Changes --
M
