Added one minor comment - thanks for the contribution, Daniel!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1206#issuecomment-388558647
demobox commented on this pull request.
> @@ -90,6 +91,7 @@ public static Properties defaultProperties() {
properties.put(TIMEOUT_NODE_TERMINATED, 60 * 10 * 1000);
// Default max wait in rate limit: 5m30s
properties.put(PROPERTY_MAX_RATE_LIMIT_WAIT, 33);
+
Closed #1206.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1206#event-1622909006
>It should be safe to increase this value in the provider metadata. 5 minutes
>looks good but open to discuss
Looks like a sane default.
Merged to
[master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/a08de5b2) and
Sorry about that, fixed
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1206#issuecomment-388499413
The build failed. It looks like there's a missing static import.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1206#issuecomment-388498018
>Would be good to add this also to
>https://github.com/danielestevez/jclouds/blob/83c0a3c7b255ec744c6150ce76c40e8301280c79/providers/azurecompute-arm/src/test/java/org/jclouds/azurecompute/arm/internal/AzureLiveTestUtils.java
> ?
That class just adds *overrides* for default provider properties,
To avoid problems with the cache, and specifically running the
AzureComputeImageExtensionLiveTest suite.
ARM is quite slow and it takes usually more than one minute (default value) for
certain operations. The testImageIsCachedAfterBeingCreated in that suite fails
often since it takes longer
