>Is this change going to be included in jclouds 2.0
Yes!
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1008#issuecomment-254735506
Closed #1008.
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1008#event-828500622
Pushed to master as 7826d22d301b1a6accef2b7686700231ffba7e29.
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1008#issuecomment-254708068
Is this change going to be included in jclouds 2.0 ?
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1008#issuecomment-254653793
Thanks for fixing the tests on master @andrewgaul. I am able to run the tests
successfully on master and also able to reproduce the test failures with my
change. I'll fix them and upload a new commit.
--
You are receiving this because you commented.
Reply to this email directly or view it on
These four tests now succeed on master. You need to fix these two which fail
with your change:
```
AWSS3BlobSignerLiveTest>S3BlobSignerLiveTest.testSignGetUrlWithTimeExpired:55->BaseBlobSignerLiveTest.testSignGetUrlWithTimeExpired:115
ยป AWSResponse
Do the live tests run successfully on current master? The same 4 tests above
failed for me on current master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Tests show the following errors:
```
$ mvn integration-test -pl :aws-s3 -Plive
-Dtest.aws-s3.identity="${JCLOUDS_IDENTITY}"
-Dtest.aws-s3.credential="${JCLOUDS_CREDENTIAL}" -Dtest=AWSS3BlobSignerLiveTest
...
Failed tests:
Added a new live test, specifically run against eu-central-1 region.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1008#issuecomment-246511656
Does this address any particular issue, e.g., using signed requests in
eu-central-1 region? If so, please include an integration test.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Fix unit tests accordingly.
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/1008
-- Commit Summary --
* JCLOUDS-1161: Make AWSS3BlobRequestSignerV4 the default signer.
-- File Changes --
M
providers/aws-s3/src/main/java/org
11 matches
Mail list logo
