Thanks!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1203#issuecomment-386785419
Well, i can confirm it fixes the failing tests :clap:
I'll run the full suite of LiveTests to see if i find more problems
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Closed #1203.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1203#event-1609392221
Merged to
[master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/b29f716a) and
[2.1.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/b144d9f4).
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
andreaturli approved this pull request.
+1
thanks
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1203#pullrequestreview-117528611
@nacx pushed 1 commit.
72b76a4 Address review comments
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds/pull/1203/files/c0db82e6796fde2a2bcdd0e585b3bf9bec10c643..72b76a4e7daee5974e29fb89e1b7948ac3712acd
andreaturli approved this pull request.
looks good to me and very useful! Thanks!
`AzureRetryableErrorHandlerTest` suite is ok too
Please update https://issues.apache.org/jira/browse/JCLOUDS-1294 accordingly.
> + if (response.getStatusCode() != 429 || isRateLimitError(response)) {
+
this pull request online at:
https://github.com/jclouds/jclouds/pull/1203
-- Commit Summary --
* JCLOUDS-1294: Attempt to retry RetryableErrors in Azure ARM
* Cleanup unused variables
-- File Changes --
M core/src/main/java/org/jclouds/http/handlers/RateLimitRetryHandler.java
(2)
M
