Re: [jclouds/jclouds] JCLOUDS-1323: use security group names in openstack nova template options (#1128)

2017-08-09 Thread Andrea Turli
Closed #1128. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1128#event-1198830638

Re: [jclouds/jclouds] JCLOUDS-1323: use security group names in openstack nova template options (#1128)

2017-08-09 Thread Andrea Turli
merged at [master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/7c58f9d7) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1128#issuecomment-321216723

Re: [jclouds/jclouds] JCLOUDS-1323: use security group names in openstack nova template options (#1128)

2017-08-09 Thread Andrea Turli
thanks @neykov, merging now -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1128#issuecomment-321200716

Re: [jclouds/jclouds] JCLOUDS-1323: use security group names in openstack nova template options (#1128)

2017-08-09 Thread Svet
neykov approved this pull request. :+1: -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1128#pullrequestreview-55171544

Re: [jclouds/jclouds] JCLOUDS-1323: use security group names in openstack nova template options (#1128)

2017-08-09 Thread Andrea Turli
ok thanks guys, I've fixed an expected test, good to merge now? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1128#issuecomment-321174304

Re: [jclouds/jclouds] JCLOUDS-1323: use security group names in openstack nova template options (#1128)

2017-08-07 Thread Andrea Turli
@andreaturli pushed 1 commit. 9d7f729 fix NovaComputeServiceExpectTest -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds/pull/1128/files/69ded18e0f13f1b77d04d8d83225930561b11330..9d7f729be91d0973352ccbf758ccc30a38612001

Re: [jclouds/jclouds] JCLOUDS-1323: use security group names in openstack nova template options (#1128)

2017-08-07 Thread Andrea Turli
andreaturli commented on this pull request. > for (String securityGroupName : templateOptions.getGroups()) { - checkNotNull(novaApi.getSecurityGroupApi(region).get().get(securityGroupName), "security group %s doesn't exist", securityGroupName); +

Re: [jclouds/jclouds] JCLOUDS-1323: use security group names in openstack nova template options (#1128)

2017-08-07 Thread Svet
neykov commented on this pull request. > for (String securityGroupName : templateOptions.getGroups()) { - checkNotNull(novaApi.getSecurityGroupApi(region).get().get(securityGroupName), "security group %s doesn't exist", securityGroupName); +

Re: [jclouds/jclouds] JCLOUDS-1323: use security group names in openstack nova template options (#1128)

2017-08-07 Thread Ignasi Barrera
nacx approved this pull request. > for (String securityGroupName : templateOptions.getGroups()) { - checkNotNull(novaApi.getSecurityGroupApi(region).get().get(securityGroupName), "security group %s doesn't exist", securityGroupName); +

[jclouds/jclouds] JCLOUDS-1323: use security group names in openstack nova template options (#1128)

2017-08-06 Thread Andrea Turli
/jclouds/pull/1128 -- Commit Summary -- * JCLOUDS-1323: use security group names in openstack nova template options -- File Changes -- M apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/compute/strategy