Closed #1237.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1237#event-1830625159
Squashed and merged to
[2.1.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/951b6b44) and
[master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/a07ab5a9)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
nacx approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1237#pullrequestreview-152388787
nacx commented on this pull request.
> @@ -54,7 +54,12 @@
public class AzureComputeHttpApiModule extends HttpApiModule {
private static final Pattern OAUTH_TENANT_PATTERN = Pattern
-
.compile("https://login.microsoft(?:online)?.com/([^/]+)/oauth2/token");
+
@danielestevez pushed 1 commit.
4511cf1 Adds unit test for china oauth endpoint check
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
nacx commented on this pull request.
> @@ -92,7 +97,14 @@ protected final String
> provideTenant(@Named("oauth.endpoint") final String oauth
if (!m.matches()) {
throw new IllegalArgumentException("Could not parse tenantId from: "
+ oauthEndpoint);
}
- return
@danielestevez pushed 1 commit.
f1087b6 Adapted Endpoints for APIs GraphRBAC and Vault
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
Yes, a simple `isChina` is easily implementable as we can parse
`ContextBuilder.endpoint`
Thanks for the tip, i'll try that approach and update the PR since i think we
can suppose this will be the only exception and Microsoft won't be adding other
additional endpoints.
--
You are receiving
Thanks! A couple hints to do this properly:
Is there any way we can determine if the `ContextBuilder` was created for
China? (For example by looking at the `endpoint` that has been configured?
If we can determine that, then I'd suggest the following approach to make the
whole thing
with this and using the right credentials and oauth endpoint for the China
regions i could run all the livetests (see Jira)
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/1237
-- Commit Summary --
* JCLOUDS-1441: Enables support for ARM regions
10 matches
Mail list logo
