Re: [jclouds/jclouds-labs] [JCLOUDS-1257] Initial support ManagedDataDisks (#372)

Closed #372. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/372#event-1038008199

Re: [jclouds/jclouds-labs] [JCLOUDS-1257] Initial support ManagedDataDisks (#372)

ported to [2.0.x](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/f4771185) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/372#issuecomment-293214239

Re: [jclouds/jclouds-labs] [JCLOUDS-1257] Initial support ManagedDataDisks (#372)

pushed to [master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/51ddc26f) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/372#issuecomment-293207723

Re: [jclouds/jclouds-labs] [JCLOUDS-1257] Initial support ManagedDataDisks (#372)

cool @nacx, merging now -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/372#issuecomment-293206450

Re: [jclouds/jclouds-labs] [JCLOUDS-1257] Initial support ManagedDataDisks (#372)

nacx approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/372#pullrequestreview-32057381

Re: [jclouds/jclouds-labs] [JCLOUDS-1257] Initial support ManagedDataDisks (#372)

@andreaturli pushed 2 commits. 6c94353 comments addressed 89b947a fix VirtualMachineApiMockTest -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds-labs] [JCLOUDS-1257] Initial support ManagedDataDisks (#372)

nacx commented on this pull request. > @@ -76,12 +83,50 @@ public AzureTemplateOptions availabilitySet(String > availabilitySetName) { return this; } + public AzureTemplateOptions dataDisks(List> dataDisksAsMap) { The logic to build the DataDisk object from

Re: [jclouds/jclouds-labs] [JCLOUDS-1257] Initial support ManagedDataDisks (#372)

andreaturli commented on this pull request. > - toString.add("availabilitySet", availabilitySet); - toString.add("availabilitySetName", availabilitySetName); - return toString; + public int hashCode() { + int result = super.hashCode(); + result = 31 * result +

Re: [jclouds/jclouds-labs] [JCLOUDS-1257] Initial support ManagedDataDisks (#372)

andreaturli commented on this pull request. > @@ -76,12 +83,50 @@ public AzureTemplateOptions availabilitySet(String > availabilitySetName) { return this; } + public AzureTemplateOptions dataDisks(List> dataDisksAsMap) { I think it'd simplify the

Re: [jclouds/jclouds-labs] [JCLOUDS-1257] Initial support ManagedDataDisks (#372)

nacx requested changes on this pull request. Just a couple more comments. Most tests seem to be failing due to the change of the version in the VM api. > @@ -76,12 +83,50 @@ public AzureTemplateOptions availabilitySet(String > availabilitySetName) { return this; } + public

Re: [jclouds/jclouds-labs] [JCLOUDS-1257] Initial support ManagedDataDisks (#372)

@andreaturli pushed 1 commit. 78bee45 fix CreateOptions enum usage -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/372/files/88e4ac2274bc1e1879587afdad4c0fb5b00cca01..78bee45d867e0cbc93aaf881b7e86016760255fd

Re: [jclouds/jclouds-labs] [JCLOUDS-1257] Initial support ManagedDataDisks (#372)

sorry @nacx and @danielestevez for long radio silence, I'm having another look at this. I've addressed most of the comments and rebased, let's see if the builder is happier. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds-labs] [JCLOUDS-1257] Initial support ManagedDataDisks (#372)

Ok, there is a version of the ImageExtension implementation that uses the new Image API working [here](https://github.com/danielestevez/jclouds-labs/tree/fixGeneralizeImage). I'd pretty much like to progress on this PR (happy to help!) so that branch can be rebased on top of this one. This way

Re: [jclouds/jclouds-labs] [JCLOUDS-1257] Initial support ManagedDataDisks (#372)

danielestevez commented on this pull request. > + public void deleteImageResourceDoesNotExist() { + assertNull(api().delete(imageName)); + } + + @Test(dependsOnMethods = "deleteImageResourceDoesNotExist") + public void CreateVirtualMachineImageFromExistingVM() { + String id =

Re: [jclouds/jclouds-labs] [JCLOUDS-1257] Initial support ManagedDataDisks (#372)

danielestevez commented on this pull request. > +import org.jclouds.rest.annotations.ResponseParser; +import org.jclouds.rest.annotations.SelectJson; +import org.jclouds.rest.binders.BindToJsonPayload; + +@Path("/resourcegroups/{resourcegroup}/providers/Microsoft.Compute/images")

Re: [jclouds/jclouds-labs] [JCLOUDS-1257] Initial support ManagedDataDisks (#372)

Thanks @nacx for your review, the impl was a bit raw but I wanted to open the PR to start the discussion in the open, especially with @danielestevez As for the plan, yes it is exactly what I had in mind! -- You are receiving this because you are subscribed to this thread. Reply to this email

Re: [jclouds/jclouds-labs] [JCLOUDS-1257] Initial support ManagedDataDisks (#372)

nacx requested changes on this pull request. Looks like a great start, thanks @andreaturli! Once this is cleaned up and tests passing the next steps could be (if I'm not wrong): * Remove the method that creates an storage service in the base live test class and update the test methods

[jclouds/jclouds-labs] [JCLOUDS-1257] Initial support ManagedDataDisks (#372)

- add DiskApi + tests - add ImageApi + tests - add TemplateOptions.dataDisks - use dataDisks in adapter You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-labs/pull/372 -- Commit Summary -- * Initial support ManagedDataDisks -- File Changes