Open for review...
You can merge this Pull Request by running:
git pull https://github.com/jclouds/jclouds JCLOUDS-509
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/329
-- Commit Summary --
* Support #39;AssociatePublicIpAddress#39; in
[jclouds-pull-requests
#708](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/708/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/329#issuecomment-38783001
[jclouds-java-7-pull-requests
#1178](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1178/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/329#issuecomment-38783375
@@ -26,19 +39,6 @@
import static org.jclouds.reflect.Reflection2.typeToken;
import static org.jclouds.util.Throwables2.propagateIfPossible;
-import java.lang.reflect.Method;
-import java.lang.reflect.Proxy;
-import java.util.Arrays;
-import java.util.Collections;
-import
@@ -28,8 +25,10 @@
import org.jclouds.ec2.compute.config.EC2ResolveImagesModule;
import org.jclouds.rest.internal.BaseHttpApiMetadata;
-import com.google.common.collect.ImmutableSet;
-import com.google.inject.Module;
+import java.net.URI;
+import java.util.Properties;
+
+import
Haven't been able to review this properly, but one initial comment: could you
take the move import statements changes out of this PR? That should make the
PR smaller and easier to review.
Thanks, Lahiru!
---
Reply to this email directly or view it on GitHub:
Yes :)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/329#issuecomment-38876661
