Re: [jclouds-karaf] [JCLOUDS-511] Correcting features with dependency-only bundles (#40)

2014-03-30 Thread Ioannis Canellos
Yeah we need to back port it.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/40#issuecomment-39036307

Re: [jclouds-karaf] [JCLOUDS-511] Correcting features with dependency-only bundles (#40)

2014-03-29 Thread Andrew Phillips
 jclouds-karaf-pull-requests #52 UNSTABLE

No test failures, just a bunch of [Checkstyle 
violations](https://jclouds.ci.cloudbees.com/job/jclouds-karaf-pull-requests/52/violations/).
 None related to this PR, though, from what I can see.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/40#issuecomment-39008811

Re: [jclouds-karaf] [JCLOUDS-511] Correcting features with dependency-only bundles (#40)

2014-03-29 Thread Andrew Phillips
Closed #40.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/40

Re: [jclouds-karaf] [JCLOUDS-511] Correcting features with dependency-only bundles (#40)

2014-03-25 Thread Ioannis Canellos
Apparently, when I split the rackspace features into pieces I forgot to remove 
the dependency attribute from cloud identity/dns. Having a feature that only 
defines dependencies without defining anything else is wrong as it will fail 
to install the required stuff in an environment that is using a resolver.

So, here is my +1
 

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/40#issuecomment-38551896

[jclouds-karaf] [JCLOUDS-511] Correcting features with dependency-only bundles (#40)

2014-03-24 Thread Grzegorz Grzybek
Features which had only bundles with `dependency=#39;true#39;` (they 
wouldn#39;t install in Karaf):
* jclouds-api-rackspace-cloudidentity
* jclouds-api-rackspace-clouddns
You can merge this Pull Request by running:

  git pull https://github.com/grgrzybek/jclouds-karaf JCLOUDS-511

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds-karaf/pull/40

-- Commit Summary --

  * [JCLOUDS-511] Correcting features with dependency-only bundles

-- File Changes --

M feature/src/main/resources/feature.xml (5)

-- Patch Links --

https://github.com/jclouds/jclouds-karaf/pull/40.patch
https://github.com/jclouds/jclouds-karaf/pull/40.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/40


Re: [jclouds-karaf] [JCLOUDS-511] Correcting features with dependency-only bundles (#40)

2014-03-24 Thread BuildHive
[jclouds ยป jclouds-karaf 
#822](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-karaf/822/) 
SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/40#issuecomment-38469757

Re: [jclouds-karaf] [JCLOUDS-511] Correcting features with dependency-only bundles (#40)

2014-03-24 Thread CloudBees pull request builder plugin
[jclouds-karaf-pull-requests 
#52](https://jclouds.ci.cloudbees.com/job/jclouds-karaf-pull-requests/52/) 
UNSTABLE
Looks like there's a problem with this pull request

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/40#issuecomment-38470276

Re: [jclouds-karaf] [JCLOUDS-511] Correcting features with dependency-only bundles (#40)

2014-03-24 Thread Everett Toews
@iocanel @nacx Do either of you have an opinion on this?

I know zilch about Karaf.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/40#issuecomment-38491152