- /**
-* Specifies the name for the virtual machine. The name must be unique
-* within Windows Azure.
-*/
- private final String roleName;
+ /** Specifies the name for the virtual machine. The name must be unique
within Windows Azure. */
Actually this is not true.
- /**
-* Specifies the name for the virtual machine. The name must be unique
-* within Windows Azure.
-*/
- private final String roleName;
+ /** Specifies the name for the virtual machine. The name must be unique
within Windows Azure. */
Thanks! There are a lot of
}
- @Override
- public int hashCode() {
- return Objects.hashCode(name);
+ // TODO: Remove from here down with @AutoValue.
+ private Disk(String name, String location, String affinityGroup, String
description, OSType os, URI mediaLink,
+ Integer
}
- } else if (equalsOrSuffix(qName, Url)) {
- final String url = currentOrNull(currentText);
- if (url != null) {
-builder.deploymentURL(URI.create(url));
+ } else if (qName.equals(RoleName)) {
+ virtualMachineName =
- } else if (equalsOrSuffix(qName, ServiceName)) {
- builder.name(currentOrNull(currentText));
+ if (qName.equals(DateCreated)) {
+created =
dateService.iso8601SecondsDateParse(currentOrNull(currentText));
+ } else if (qName.equals(DateLastModified))
}
- } else if (equalsOrSuffix(qName, Url)) {
- final String url = currentOrNull(currentText);
- if (url != null) {
-builder.deploymentURL(URI.create(url));
+ } else if (qName.equals(RoleName)) {
+ virtualMachineName =
/**
* @see a href=http://msdn.microsoft.com/en-us/library/jj157191; api/a
*/
-public class ImageHandler extends
ParseSax.HandlerForGeneratedRequestWithResultImage {
+final class ImageHandler extends
ParseSax.HandlerForGeneratedRequestWithResultImage {
+ private String name;
+
/**
* @see a href=http://msdn.microsoft.com/en-us/library/gg441293; api/a
*/
-public class LocationHandler extends
ParseSax.HandlerForGeneratedRequestWithResultLocation {
+final class LocationHandler extends
ParseSax.HandlerForGeneratedRequestWithResultLocation {
+ private
/**
* @see a href=http://msdn.microsoft.com/en-us/library/jj157191; api/a
*/
-public class ImageHandler extends
ParseSax.HandlerForGeneratedRequestWithResultImage {
+final class ImageHandler extends
ParseSax.HandlerForGeneratedRequestWithResultImage {
+ private String name;
+
- } else if (equalsOrSuffix(qName, ServiceName)) {
- builder.name(currentOrNull(currentText));
+ if (qName.equals(DateCreated)) {
+created =
dateService.iso8601SecondsDateParse(currentOrNull(currentText));
+ } else if (qName.equals(DateLastModified))
Only one comment that might need to be looked at now (a field marked
`@Nullable` but with a `checkNotNull`) - the rest can all be ignored and/or
handled later, if desired.
+1 - looks good to me! Thanks for more cleanup, @adriancole!
---
Reply to this email directly or view it on GitHub:
}
- @Override
- public int hashCode() {
- return Objects.hashCode(name);
+ // TODO: Remove from here down with @AutoValue.
+ private Disk(String name, String location, String affinityGroup, String
description, OSType os, URI mediaLink,
+ Integer
[jclouds-labs-pull-requests
#325](https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/325/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/92#issuecomment-59805936
[jclouds » jclouds-labs
#1719](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs/1719/)
SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
+1 btw, what are we waiting on before using autovalue? A specific issue or
feature?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/92#issuecomment-59810657
@ccustine there's a snapshot published to sonatype, but no stable version.
Since we use our own Nullable annotation, auto-value 1.0-rc1 can't work, but
anything after Feb will :)
---
Reply to this email directly or view it on GitHub:
Closed #92.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/92#event-181125888
merged into master. will do 1.8.x once 1.8.1 is cut.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/92#issuecomment-59829753
18 matches
Mail list logo
