[I] [AUTHZ] Check previleges for Paimon's Select [kyuubi]

2024-07-17 Thread via GitHub
promising-forever opened a new issue, #6541: URL: https://github.com/apache/kyuubi/issues/6541 ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) ### Search before asking - [X] I have searc

Re: [PR] [KYUUBI #6523] Support configuration with `--conf` options [kyuubi]

2024-07-17 Thread via GitHub
dnskr commented on code in PR #6530: URL: https://github.com/apache/kyuubi/pull/6530#discussion_r1680616450 ## bin/kyuubi: ## @@ -102,7 +102,7 @@ if [[ -n ${YARN_CONF_DIR} ]]; then KYUUBI_CLASSPATH="${KYUUBI_CLASSPATH}:${YARN_CONF_DIR}" fi -cmd="${RUNNER} ${KYUUBI_JAVA_OPT

Re: [I] [Bug] Modifying kyuubi-defaults.conf does not take effect when starting Spark for the second time [kyuubi]

2024-07-17 Thread via GitHub
A-little-bit-of-data commented on issue #6536: URL: https://github.com/apache/kyuubi/issues/6536#issuecomment-2232711203 > > the content of spark-defaults.conf before the modification is always read. > > this is not expected, how do you make this assertion, can you provide some logs/

Re: [I] [AUTHZ] Check previleges for Paimon's Select [kyuubi]

2024-07-17 Thread via GitHub
pan3793 commented on issue #6541: URL: https://github.com/apache/kyuubi/issues/6541#issuecomment-2232793144 Seems there is nothing we can do on the Kyuubi side. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] [KYUUBI #6534] Fix checkEngineConnectionAlive may throw NPE [kyuubi]

2024-07-17 Thread via GitHub
pan3793 commented on PR #6540: URL: https://github.com/apache/kyuubi/pull/6540#issuecomment-2232796814 @cfmcgrady this one is expected to be included in 1.9.2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [I] [Bug] Modifying kyuubi-defaults.conf does not take effect when starting Spark for the second time [kyuubi]

2024-07-17 Thread via GitHub
pan3793 commented on issue #6536: URL: https://github.com/apache/kyuubi/issues/6536#issuecomment-2232814332 providing original logs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [I] [AUTHZ] Check previleges for Paimon's Select [kyuubi]

2024-07-17 Thread via GitHub
promising-forever commented on issue #6541: URL: https://github.com/apache/kyuubi/issues/6541#issuecomment-2232834395 > Seems there is nothing we can do on the Kyuubi side. We can get database from DataSourceV2Relation#identifier to make up for this. Otherwise, if a user wants to acce

[PR] KyuubiBatchService should wait for HTTP server started before picking jobs [kyuubi]

2024-07-17 Thread via GitHub
pan3793 opened a new pull request, #6542: URL: https://github.com/apache/kyuubi/pull/6542 # :mag: Description This is similar to https://github.com/apache/kyuubi/pull/5310. We need to wait for Jetty Server started before picking jobs, otherwise, it may get the wrong local HTTP

Re: [PR] KyuubiBatchService should wait for HTTP server started before picking jobs [kyuubi]

2024-07-17 Thread via GitHub
pan3793 commented on PR #6542: URL: https://github.com/apache/kyuubi/pull/6542#issuecomment-2232882282 cc @zwangsheng -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [I] [AUTHZ] Check previleges for Paimon's Select [kyuubi]

2024-07-17 Thread via GitHub
pan3793 commented on issue #6541: URL: https://github.com/apache/kyuubi/issues/6541#issuecomment-2232893216 Please go ahead to make a PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] [KYUUBI #6534] Fix checkEngineConnectionAlive may throw NPE [kyuubi]

2024-07-17 Thread via GitHub
cfmcgrady commented on code in PR #6540: URL: https://github.com/apache/kyuubi/pull/6540#discussion_r1680916046 ## kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiSessionImpl.scala: ## @@ -317,7 +317,8 @@ class KyuubiSessionImpl( } def checkEngineConnectionA

Re: [PR] [KYUUBI #6534] Fix checkEngineConnectionAlive may throw NPE [kyuubi]

2024-07-17 Thread via GitHub
pan3793 commented on code in PR #6540: URL: https://github.com/apache/kyuubi/pull/6540#discussion_r1680945143 ## kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiSessionImpl.scala: ## @@ -317,7 +317,8 @@ class KyuubiSessionImpl( } def checkEngineConnectionAli

[PR] WIP Test Kyuubi Shaded 0.4.1 RC0 [kyuubi]

2024-07-17 Thread via GitHub
pan3793 opened a new pull request, #6543: URL: https://github.com/apache/kyuubi/pull/6543 # :mag: Description Test Kyuubi Shaded 0.4.1 RC0 https://lists.apache.org/thread/vr79j175pfosxh7hg30qmzqj3sfw5ph6 ## Types of changes :bookmark: - [ ] Bugfix (non-breaking cha

Re: [I] [Bug] [flink] Interrupting the JDBC connection cannot stop the engine executing SQL. [kyuubi]

2024-07-17 Thread via GitHub
SteNicholas commented on issue #6519: URL: https://github.com/apache/kyuubi/issues/6519#issuecomment-227033 @Pandas886, do you have interest to fix this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] WIP Test Kyuubi Shaded 0.4.1 RC0 [kyuubi]

2024-07-17 Thread via GitHub
codecov-commenter commented on PR #6543: URL: https://github.com/apache/kyuubi/pull/6543#issuecomment-2233382529 ## [Codecov](https://app.codecov.io/gh/apache/kyuubi/pull/6543?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut

Re: [PR] [KYUUBI #6523] Support configuration with `--conf` options [kyuubi]

2024-07-17 Thread via GitHub
pan3793 commented on PR #6530: URL: https://github.com/apache/kyuubi/pull/6530#issuecomment-2233444552 also cc @cxzl25 @cfmcgrady @hddong -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] [KYUUBI #6541] [AUTHZ] Fix DataSourceV2RelationTableExtractor can't get the 'database' attribute if it's a Paimon plan. [kyuubi]

2024-07-17 Thread via GitHub
promising-forever closed pull request #6544: [KYUUBI #6541] [AUTHZ] Fix DataSourceV2RelationTableExtractor can't get the 'database' attribute if it's a Paimon plan. URL: https://github.com/apache/kyuubi/pull/6544 -- This is an automated message from the Apache Git Service. To respond to the

[PR] Deprecate and remove building support for Spark 3.2 [kyuubi]

2024-07-17 Thread via GitHub
pan3793 opened a new pull request, #6545: URL: https://github.com/apache/kyuubi/pull/6545 # :mag: Description This pull request aims to remove building support for Spark 3.2, while still keeping the engine support for Spark 3.2. Mailing list discussion: https://lists.apache.or

Re: [PR] Deprecate and remove building support for Spark 3.2 [kyuubi]

2024-07-17 Thread via GitHub
codecov-commenter commented on PR #6545: URL: https://github.com/apache/kyuubi/pull/6545#issuecomment-2235220112 ## [Codecov](https://app.codecov.io/gh/apache/kyuubi/pull/6545?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut

Re: [I] [Bug] checkEngineConnectionAlive may throw NPE [kyuubi]

2024-07-17 Thread via GitHub
pan3793 closed issue #6534: [Bug] checkEngineConnectionAlive may throw NPE URL: https://github.com/apache/kyuubi/issues/6534 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [KYUUBI #6534] Fix checkEngineConnectionAlive may throw NPE [kyuubi]

2024-07-17 Thread via GitHub
pan3793 closed pull request #6540: [KYUUBI #6534] Fix checkEngineConnectionAlive may throw NPE URL: https://github.com/apache/kyuubi/pull/6540 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] [KYUUBI #6534] Fix checkEngineConnectionAlive may throw NPE [kyuubi]

2024-07-17 Thread via GitHub
pan3793 commented on PR #6540: URL: https://github.com/apache/kyuubi/pull/6540#issuecomment-2235246842 Thanks, merged to master/1.9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [I] [Improvement] Provide Kyuubi configuration properties with cli options [kyuubi]

2024-07-17 Thread via GitHub
pan3793 closed issue #6523: [Improvement] Provide Kyuubi configuration properties with cli options URL: https://github.com/apache/kyuubi/issues/6523 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] [KYUUBI #6523] Support configuration with `--conf` options [kyuubi]

2024-07-17 Thread via GitHub
pan3793 commented on PR #6530: URL: https://github.com/apache/kyuubi/pull/6530#issuecomment-2235247819 Thanks, merged to master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] [KYUUBI #6523] Support configuration with `--conf` options [kyuubi]

2024-07-17 Thread via GitHub
pan3793 closed pull request #6530: [KYUUBI #6523] Support configuration with `--conf` options URL: https://github.com/apache/kyuubi/pull/6530 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] KyuubiBatchService should wait for HTTP server started before picking jobs [kyuubi]

2024-07-17 Thread via GitHub
pan3793 closed pull request #6542: KyuubiBatchService should wait for HTTP server started before picking jobs URL: https://github.com/apache/kyuubi/pull/6542 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] KyuubiBatchService should wait for HTTP server started before picking jobs [kyuubi]

2024-07-17 Thread via GitHub
pan3793 commented on PR #6542: URL: https://github.com/apache/kyuubi/pull/6542#issuecomment-2235257205 Thanks, merged to master/1.9.2/1.8.3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe