[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #2042: [KYUUI #2036] Redirect Issues/PR Notifications to notifications@kyuubi.apache.org

2022-03-05 Thread GitBox
yaooqinn commented on pull request #2042: URL: https://github.com/apache/incubator-kyuubi/pull/2042#issuecomment-1059773720 thanks, merged to master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [incubator-kyuubi] yaooqinn closed issue #2012: [Bug] EventLoggingService creates an incorrect directory

2022-03-05 Thread GitBox
yaooqinn closed issue #2012: URL: https://github.com/apache/incubator-kyuubi/issues/2012 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificat

[GitHub] [incubator-kyuubi] yaooqinn closed pull request #2037: [KYUUBI #2012] rename EventLoggingService and creates an correct directory

2022-03-05 Thread GitBox
yaooqinn closed pull request #2037: URL: https://github.com/apache/incubator-kyuubi/pull/2037 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: noti

[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #2037: [KYUUBI #2012] rename EventLoggingService and creates an correct directory

2022-03-05 Thread GitBox
yaooqinn commented on pull request #2037: URL: https://github.com/apache/incubator-kyuubi/pull/2037#issuecomment-1059784128 thanks, merged to master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [incubator-kyuubi] yaooqinn commented on issue #2036: [INFRA][Improvement] Redirect Issues/PR Notifications to notifications@kyuubi.apache.org

2022-03-05 Thread GitBox
yaooqinn commented on issue #2036: URL: https://github.com/apache/incubator-kyuubi/issues/2036#issuecomment-1059785653 thanks, pr merged -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [incubator-kyuubi] yaooqinn closed issue #2036: [INFRA][Improvement] Redirect Issues/PR Notifications to notifications@kyuubi.apache.org

2022-03-05 Thread GitBox
yaooqinn closed issue #2036: URL: https://github.com/apache/incubator-kyuubi/issues/2036 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificat

[GitHub] [incubator-kyuubi] yaooqinn opened a new issue #2043: [Improvement] https://logging.apache.org/log4j/2.x/changes-report.html#a2.17.2

2022-03-05 Thread GitBox
yaooqinn opened a new issue #2043: URL: https://github.com/apache/incubator-kyuubi/issues/2043 ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) ### Search before asking - [X] I have sear

[GitHub] [incubator-kyuubi] yaooqinn closed issue #1635: [Bug] Document in readme needs update

2022-03-05 Thread GitBox
yaooqinn closed issue #1635: URL: https://github.com/apache/incubator-kyuubi/issues/1635 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificat

[GitHub] [incubator-kyuubi] yaooqinn closed issue #1064: The matching rule for sql classification should be generated automatically not manually

2022-03-05 Thread GitBox
yaooqinn closed issue #1064: URL: https://github.com/apache/incubator-kyuubi/issues/1064 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificat

[GitHub] [incubator-kyuubi] yaooqinn commented on issue #981: [Umbrella] Add more detail stats to kyuubi engine page

2022-03-05 Thread GitBox
yaooqinn commented on issue #981: URL: https://github.com/apache/incubator-kyuubi/issues/981#issuecomment-1059794925 the history server plugin is implemented in v1.5.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [incubator-kyuubi] yaooqinn closed issue #981: [Umbrella] Add more detail stats to kyuubi engine page

2022-03-05 Thread GitBox
yaooqinn closed issue #981: URL: https://github.com/apache/incubator-kyuubi/issues/981 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

[GitHub] [incubator-kyuubi] yaooqinn edited a comment on issue #981: [Umbrella] Add more detail stats to kyuubi engine page

2022-03-05 Thread GitBox
yaooqinn edited a comment on issue #981: URL: https://github.com/apache/incubator-kyuubi/issues/981#issuecomment-1059794925 the history server plugin is implemented in v1.5.0, thanks for the great work -- This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [incubator-kyuubi] turboFei opened a new pull request #2044: remove thread local

2022-03-05 Thread GitBox
turboFei opened a new pull request #2044: URL: https://github.com/apache/incubator-kyuubi/pull/2044 ### _Why are the changes needed?_ ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases

[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #2044: Remove authentication thread local objects to prevent memory leak

2022-03-05 Thread GitBox
codecov-commenter commented on pull request #2044: URL: https://github.com/apache/incubator-kyuubi/pull/2044#issuecomment-1059890377 # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2044?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+co

[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #2044: Remove authentication thread local objects to prevent memory leak

2022-03-05 Thread GitBox
codecov-commenter edited a comment on pull request #2044: URL: https://github.com/apache/incubator-kyuubi/pull/2044#issuecomment-1059890377 # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2044?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaig

[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #2044: Remove authentication thread local objects to prevent memory leak

2022-03-05 Thread GitBox
codecov-commenter edited a comment on pull request #2044: URL: https://github.com/apache/incubator-kyuubi/pull/2044#issuecomment-1059890377 # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2044?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaig

[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #2044: Remove authentication thread local objects to prevent memory leak

2022-03-05 Thread GitBox
codecov-commenter edited a comment on pull request #2044: URL: https://github.com/apache/incubator-kyuubi/pull/2044#issuecomment-1059890377 # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2044?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaig

[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #2044: Remove authentication thread local objects to prevent memory leak

2022-03-05 Thread GitBox
codecov-commenter edited a comment on pull request #2044: URL: https://github.com/apache/incubator-kyuubi/pull/2044#issuecomment-1059890377 # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2044?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaig

[GitHub] [incubator-kyuubi] turboFei commented on a change in pull request #2044: Remove authentication thread local objects to prevent memory leak

2022-03-05 Thread GitBox
turboFei commented on a change in pull request #2044: URL: https://github.com/apache/incubator-kyuubi/pull/2044#discussion_r820188033 ## File path: kyuubi-common/src/main/scala/org/apache/kyuubi/service/authentication/HadoopThriftAuthBridgeServer.scala ## @@ -143,38 +143,44 @@

[GitHub] [incubator-kyuubi] RishiKumarRay commented on issue #2043: [Improvement] Upgrade log4j/2.x/ to 2.17.2

2022-03-06 Thread GitBox
RishiKumarRay commented on issue #2043: URL: https://github.com/apache/incubator-kyuubi/issues/2043#issuecomment-1059964680 Do we just have to update the version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [incubator-kyuubi] yaooqinn commented on issue #2043: [Improvement] Upgrade log4j/2.x/ to 2.17.2

2022-03-06 Thread GitBox
yaooqinn commented on issue #2043: URL: https://github.com/apache/incubator-kyuubi/issues/2043#issuecomment-1059965649 Yes, we only need to update the version and `build/dependency.sh --replace` to re-generate to dependency checker if nothing breaks in log4j-2.17.2. -- This is an automa

[GitHub] [incubator-kyuubi] yaooqinn opened a new pull request #2045: Preparing v1.6.0-SNAPSHOT

2022-03-06 Thread GitBox
yaooqinn opened a new pull request #2045: URL: https://github.com/apache/incubator-kyuubi/pull/2045 ### _Why are the changes needed?_ Preparing v1.6.0-SNAPSHOT with branch-1.5 cut ### _How was this patch tested?_ - [ ] Add some test cases that check the changes t

[GitHub] [incubator-kyuubi] yaooqinn commented on issue #1215: [DOC] Document support incremental collection

2022-03-06 Thread GitBox
yaooqinn commented on issue #1215: URL: https://github.com/apache/incubator-kyuubi/issues/1215#issuecomment-1059966934 any update on this, I think this doc needs to be updated in 1.5.0-incubating -- This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [incubator-kyuubi] pan3793 commented on issue #1215: [DOC] Document support incremental collection

2022-03-06 Thread GitBox
pan3793 commented on issue #1215: URL: https://github.com/apache/incubator-kyuubi/issues/1215#issuecomment-1059967456 Will add the document soon -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [incubator-kyuubi] yaooqinn commented on issue #1866: [SUB-TASK][KPIP-2] Document Flink SQL engine user guide

2022-03-06 Thread GitBox
yaooqinn commented on issue #1866: URL: https://github.com/apache/incubator-kyuubi/issues/1866#issuecomment-1059967561 Hi branch 1.5's been cut. Any update on this? I think we need at least a quick start at the doc side for flink engine. -- This is an automated message from the Apache G

[GitHub] [incubator-kyuubi] yaooqinn commented on issue #950: [Umbrella][KPIP-1] Support RESTful API for Kyuubi

2022-03-06 Thread GitBox
yaooqinn commented on issue #950: URL: https://github.com/apache/incubator-kyuubi/issues/950#issuecomment-1059968647 ping @yanghua @simon824, branch-1.5's been cut. Does anything more need to be fixed in this ticket? Otherwise, we shall mark this work as completed. BTW, I notice tha

[GitHub] [incubator-kyuubi] RishiKumarRay opened a new pull request #2046: [KYUUBI ##2043] Upgrade log4j/2.x/ to 2.17.2

2022-03-06 Thread GitBox
RishiKumarRay opened a new pull request #2046: URL: https://github.com/apache/incubator-kyuubi/pull/2046 ### _Why are the changes needed?_ [Improvement] Upgrade log4j/2.x/ to 2.17.2 ### _How was this patch tested?_ - [ ] Add some test cases that check the changes tho

[GitHub] [incubator-kyuubi] RishiKumarRay commented on issue #2043: [Improvement] Upgrade log4j/2.x/ to 2.17.2

2022-03-06 Thread GitBox
RishiKumarRay commented on issue #2043: URL: https://github.com/apache/incubator-kyuubi/issues/2043#issuecomment-1059970003 @yaooqinn please review PR #2046 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #1604: [KYUUBI #1564] fix Server connectionUrl force to hostname

2022-03-06 Thread GitBox
yaooqinn commented on pull request #1604: URL: https://github.com/apache/incubator-kyuubi/pull/1604#issuecomment-1059971047 this is fixed, i will close this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [incubator-kyuubi] yaooqinn closed pull request #1604: [KYUUBI #1564] fix Server connectionUrl force to hostname

2022-03-06 Thread GitBox
yaooqinn closed pull request #1604: URL: https://github.com/apache/incubator-kyuubi/pull/1604 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: noti

[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #2045: Preparing v1.6.0-SNAPSHOT

2022-03-06 Thread GitBox
yaooqinn commented on pull request #2045: URL: https://github.com/apache/incubator-kyuubi/pull/2045#issuecomment-1059971404 the style ci is not related to this change, just because the snapshot is not in the repo, I'd merge this to fix this instead of bringing a heavy install to fix this.

[GitHub] [incubator-kyuubi] yaooqinn closed pull request #2045: Preparing v1.6.0-SNAPSHOT

2022-03-06 Thread GitBox
yaooqinn closed pull request #2045: URL: https://github.com/apache/incubator-kyuubi/pull/2045 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: noti

[GitHub] [incubator-kyuubi] yaooqinn closed issue #850: Make threshold that trigger when to dump data into file configurable

2022-03-06 Thread GitBox
yaooqinn closed issue #850: URL: https://github.com/apache/incubator-kyuubi/issues/850 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

[GitHub] [incubator-kyuubi] yaooqinn closed issue #851: Thread safe consider: for statementInfo, jobInfo and stageInfo

2022-03-06 Thread GitBox
yaooqinn closed issue #851: URL: https://github.com/apache/incubator-kyuubi/issues/851 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

[GitHub] [incubator-kyuubi] yaooqinn closed issue #860: Make queue's capacity that store the event tracking data in mem configurable

2022-03-06 Thread GitBox
yaooqinn closed issue #860: URL: https://github.com/apache/incubator-kyuubi/issues/860 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

[GitHub] [incubator-kyuubi] yaooqinn closed issue #1564: [Bug] Server connectionUrl shall respect user's setting first

2022-03-06 Thread GitBox
yaooqinn closed issue #1564: URL: https://github.com/apache/incubator-kyuubi/issues/1564 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificat

[GitHub] [incubator-kyuubi] cxzl25 opened a new issue #2047: [FEATURE]

2022-03-06 Thread GitBox
cxzl25 opened a new issue #2047: URL: https://github.com/apache/incubator-kyuubi/issues/2047 ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) ### Search before asking - [X] I have search

[GitHub] [incubator-kyuubi] cxzl25 opened a new pull request #2048: [KYUUBI #2047] Support more MySQL JDBC driver versions

2022-03-06 Thread GitBox
cxzl25 opened a new pull request #2048: URL: https://github.com/apache/incubator-kyuubi/pull/2048 ### _Why are the changes needed?_ Support more MySQL JDBC driver versions. The user may use the 5.x mysql driver to connect to the kyuubi server. ### _How was this patch tested?

[GitHub] [incubator-kyuubi] cxzl25 commented on pull request #2048: [KYUUBI #2047] Support more MySQL JDBC driver versions

2022-03-06 Thread GitBox
cxzl25 commented on pull request #2048: URL: https://github.com/apache/incubator-kyuubi/pull/2048#issuecomment-1059977036 [mysql_init_select.sql.txt](https://github.com/apache/incubator-kyuubi/files/8192825/mysql_init_select.sql.txt) Grab the initialization sql of mysql-connecto

[GitHub] [incubator-kyuubi] cxzl25 commented on pull request #2048: [KYUUBI #2047] Support more MySQL JDBC driver versions

2022-03-06 Thread GitBox
cxzl25 commented on pull request #2048: URL: https://github.com/apache/incubator-kyuubi/pull/2048#issuecomment-1059977304 > The current approach is fragile, it should be replaced by antlr based SQL parser eventually. Yes, I tried to use the mysql protocol on Friday and encountered t

[GitHub] [incubator-kyuubi] cxzl25 commented on pull request #2046: [KYUUBI ##2043] Upgrade log4j/2.x/ to 2.17.2

2022-03-06 Thread GitBox
cxzl25 commented on pull request #2046: URL: https://github.com/apache/incubator-kyuubi/pull/2046#issuecomment-1059977535 nit: title repeats a `#` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #2046: [KYUUBI #2043] Upgrade log4j/2.x/ to 2.17.2

2022-03-06 Thread GitBox
yaooqinn commented on pull request #2046: URL: https://github.com/apache/incubator-kyuubi/pull/2046#issuecomment-1059977769 > nit: title repeats a `#` nice catch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [incubator-kyuubi] pan3793 commented on pull request #2048: [KYUUBI #2047] Support more MySQL JDBC driver versions

2022-03-06 Thread GitBox
pan3793 commented on pull request #2048: URL: https://github.com/apache/incubator-kyuubi/pull/2048#issuecomment-1059978289 Kyuubi will introduce Antlr eventually, we have a prototype discussion previously, we'd like to introduce some Kyuubi defined SQL-like grammer, e.g. `SHOW ENGINES [LI

[GitHub] [incubator-kyuubi] cxzl25 commented on pull request #2048: [KYUUBI #2047] Support more MySQL JDBC driver versions

2022-03-06 Thread GitBox
cxzl25 commented on pull request #2048: URL: https://github.com/apache/incubator-kyuubi/pull/2048#issuecomment-1059979143 > Kyuubi will introduce Antlr eventually, we have a prototype discussion previously, we'd like to introduce some Kyuubi defined SQL-like grammer, e.g. `SHOW ENGINES [L

[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #2041: Bump Zookeeper 3.6.3

2022-03-06 Thread GitBox
yaooqinn commented on pull request #2041: URL: https://github.com/apache/incubator-kyuubi/pull/2041#issuecomment-1059979961 thanks @SteNicholas, this pr seems not ready for review it's blocked by https://github.com/apache/incubator-kyuubi/pull/2040 -- This is an automated message from t

[GitHub] [incubator-kyuubi] pan3793 commented on pull request #2048: [KYUUBI #2047] Support more MySQL JDBC driver versions

2022-03-06 Thread GitBox
pan3793 commented on pull request #2048: URL: https://github.com/apache/incubator-kyuubi/pull/2048#issuecomment-1059980949 > May be I missed the previous discussion. Sorry, it happened in offline discussion. Don't hesitate if you think we need to introduce antlr deps, even now

[GitHub] [incubator-kyuubi] pan3793 edited a comment on pull request #2048: [KYUUBI #2047] Support more MySQL JDBC driver versions

2022-03-06 Thread GitBox
pan3793 edited a comment on pull request #2048: URL: https://github.com/apache/incubator-kyuubi/pull/2048#issuecomment-1059980949 > May be I missed the previous discussion. Sorry, it happened in offline discussion. Don't hesitate if you think we need to introduce antlr deps, e

[GitHub] [incubator-kyuubi] pan3793 edited a comment on pull request #2048: [KYUUBI #2047] Support more MySQL JDBC driver versions

2022-03-06 Thread GitBox
pan3793 edited a comment on pull request #2048: URL: https://github.com/apache/incubator-kyuubi/pull/2048#issuecomment-1059980949 > May be I missed the previous discussion. Sorry, it happened in an offline discussion. Don't hesitate if you think we need to introduce antlr deps

[GitHub] [incubator-kyuubi] pan3793 commented on pull request #2041: Bump Zookeeper 3.6.3

2022-03-06 Thread GitBox
pan3793 commented on pull request #2041: URL: https://github.com/apache/incubator-kyuubi/pull/2041#issuecomment-1059981752 > thanks @SteNicholas, this pr seems not ready for review it's blocked by #2040 Yea, marked this one as draft for now, I will address #2040 ASAP. -- This is

[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #2048: [KYUUBI #2047] Support more MySQL JDBC driver versions

2022-03-06 Thread GitBox
codecov-commenter commented on pull request #2048: URL: https://github.com/apache/incubator-kyuubi/pull/2048#issuecomment-1059983386 # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2048?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+co

[GitHub] [incubator-kyuubi] cxzl25 commented on pull request #2048: [KYUUBI #2047] Support more MySQL JDBC driver versions

2022-03-06 Thread GitBox
cxzl25 commented on pull request #2048: URL: https://github.com/apache/incubator-kyuubi/pull/2048#issuecomment-1059989695 > Could not find artifact org.apache.kyuubi:kyuubi-XXX_2.12:jar:1.6.0-SNAPSHOT in apache.snapshots apache snapshot does not have deploy 1.6 version, causing UT t

[GitHub] [incubator-kyuubi] cxzl25 commented on pull request #2048: [KYUUBI #2047] Support more MySQL JDBC driver versions

2022-03-06 Thread GitBox
cxzl25 commented on pull request #2048: URL: https://github.com/apache/incubator-kyuubi/pull/2048#issuecomment-1059990134 > Don't hesitate if you think we need to introduce antlr deps, even now we don't have detail design of the Kyuubi dialect SQL grammar, but I'm sure we need some intuit

[GitHub] [incubator-kyuubi] hddong closed pull request #2040: [TEST] Add Zookeeper 3.4 integration test

2022-03-06 Thread GitBox
hddong closed pull request #2040: URL: https://github.com/apache/incubator-kyuubi/pull/2040 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifi

[GitHub] [incubator-kyuubi] hddong commented on pull request #2040: [TEST] Add Zookeeper 3.4 integration test

2022-03-06 Thread GitBox
hddong commented on pull request #2040: URL: https://github.com/apache/incubator-kyuubi/pull/2040#issuecomment-1060103798 > If we can build it individually to test all the apis between the kyuubi-ha(client) module and kyuubi-zookeeper(server), it will be much specific, complete and.resoue

[GitHub] [incubator-kyuubi] pan3793 opened a new pull request #2040: [TEST] Add Zookeeper 3.4 integration test

2022-03-06 Thread GitBox
pan3793 opened a new pull request #2040: URL: https://github.com/apache/incubator-kyuubi/pull/2040 ### _Why are the changes needed?_ This PR proposes to add Testcontainers based Zookeeper 3.4 integration test, we need it to verify the compatibility if we upgrade Zookeeper cli

[GitHub] [incubator-kyuubi] hddong removed a comment on pull request #2040: [TEST] Add Zookeeper 3.4 integration test

2022-03-06 Thread GitBox
hddong removed a comment on pull request #2040: URL: https://github.com/apache/incubator-kyuubi/pull/2040#issuecomment-1060103798 > If we can build it individually to test all the apis between the kyuubi-ha(client) module and kyuubi-zookeeper(server), it will be much specific, complete an

[GitHub] [incubator-kyuubi] hddong commented on pull request #2040: [TEST] Add Zookeeper 3.4 integration test

2022-03-06 Thread GitBox
hddong commented on pull request #2040: URL: https://github.com/apache/incubator-kyuubi/pull/2040#issuecomment-1060105323 Sorry for wrong close. `test all the apis` seems more friendly. We can try it after #1989. -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [incubator-kyuubi] turboFei opened a new pull request #2049: [KYUUBI #1978] Support NEGOTIATE/BASIC authorization for restful frontend service

2022-03-06 Thread GitBox
turboFei opened a new pull request #2049: URL: https://github.com/apache/incubator-kyuubi/pull/2049 ### _Why are the changes needed?_ ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases

[GitHub] [incubator-kyuubi] simon824 commented on issue #950: [Umbrella][KPIP-1] Support RESTful API for Kyuubi

2022-03-06 Thread GitBox
simon824 commented on issue #950: URL: https://github.com/apache/incubator-kyuubi/issues/950#issuecomment-1060118379 > ping @yanghua @simon824, branch-1.5's been cut. Does anything more need to be fixed in this ticket? Otherwise, we shall mark this work as completed. > > BTW, I noti

[GitHub] [incubator-kyuubi] pan3793 commented on pull request #2048: [KYUUBI #2047] Support more MySQL JDBC driver versions

2022-03-06 Thread GitBox
pan3793 commented on pull request #2048: URL: https://github.com/apache/incubator-kyuubi/pull/2048#issuecomment-1060127797 Thanks, merging to master/1.5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [incubator-kyuubi] pan3793 closed issue #2047: [FEATURE] Support more MySQL JDBC driver versions

2022-03-06 Thread GitBox
pan3793 closed issue #2047: URL: https://github.com/apache/incubator-kyuubi/issues/2047 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificati

[GitHub] [incubator-kyuubi] pan3793 closed pull request #2048: [KYUUBI #2047] Support more MySQL JDBC driver versions

2022-03-06 Thread GitBox
pan3793 closed pull request #2048: URL: https://github.com/apache/incubator-kyuubi/pull/2048 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notif

[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #2046: [KYUUBI #2043] Upgrade log4j/2.x/ to 2.17.2

2022-03-06 Thread GitBox
yaooqinn commented on pull request #2046: URL: https://github.com/apache/incubator-kyuubi/pull/2046#issuecomment-1060157779 SQLOperationListenerSuite hangs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [incubator-kyuubi] yaooqinn opened a new pull request #2050: [DONOTMERGE] Pr 2046

2022-03-06 Thread GitBox
yaooqinn opened a new pull request #2050: URL: https://github.com/apache/incubator-kyuubi/pull/2050 ### _Why are the changes needed?_ ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases

[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #1991: [KYUUBI #1989] Decouple curator from other modules

2022-03-06 Thread GitBox
pan3793 commented on a change in pull request #1991: URL: https://github.com/apache/incubator-kyuubi/pull/1991#discussion_r820363021 ## File path: kyuubi-ha/src/main/scala/org/apache/kyuubi/ha/client/zookeeper/DiscoveryClient.scala ## @@ -0,0 +1,198 @@ +/* + * Licensed to the

[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #2041: Bump Zookeeper 3.6.3

2022-03-06 Thread GitBox
codecov-commenter edited a comment on pull request #2041: URL: https://github.com/apache/incubator-kyuubi/pull/2041#issuecomment-1059735368 # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2041?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaig

[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #2041: Bump Zookeeper 3.6.3

2022-03-06 Thread GitBox
codecov-commenter edited a comment on pull request #2041: URL: https://github.com/apache/incubator-kyuubi/pull/2041#issuecomment-1059735368 # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2041?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaig

[GitHub] [incubator-kyuubi] yaooqinn opened a new pull request #2051: [KYUUBI #1955] Add CI for branch-1.5 & 1.4 SNAPSHOTS

2022-03-06 Thread GitBox
yaooqinn opened a new pull request #2051: URL: https://github.com/apache/incubator-kyuubi/pull/2051 ### _Why are the changes needed?_ branch-1.5 & 1.4 snapshots are missing ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroug

[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #2051: [KYUUBI #1955] Add CI for branch-1.5 & 1.4 SNAPSHOTS

2022-03-06 Thread GitBox
codecov-commenter commented on pull request #2051: URL: https://github.com/apache/incubator-kyuubi/pull/2051#issuecomment-1060206515 # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2051?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+co

[GitHub] [incubator-kyuubi] SteNicholas opened a new pull request #2052: [KYUUBI-886] Add HTTP transport mode support to KYUUBI

2022-03-06 Thread GitBox
SteNicholas opened a new pull request #2052: URL: https://github.com/apache/incubator-kyuubi/pull/2052 ### _Why are the changes needed?_ Add HTTP transport mode support to KYUUBI. ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoro

[GitHub] [incubator-kyuubi] SteNicholas commented on issue #2010: [Umbrella] Add Hive Backend Engine Support

2022-03-06 Thread GitBox
SteNicholas commented on issue #2010: URL: https://github.com/apache/incubator-kyuubi/issues/2010#issuecomment-1060211216 @yaooqinn, I have interest to support Hive backend engine. Could you please firstly assign the `engine Runtime` module tickets to me? -- This is an automated message

[GitHub] [incubator-kyuubi] yaooqinn commented on issue #2010: [Umbrella] Add Hive Backend Engine Support

2022-03-06 Thread GitBox
yaooqinn commented on issue #2010: URL: https://github.com/apache/incubator-kyuubi/issues/2010#issuecomment-1060221626 @SteNicholas, thanks for interesting in this feature. You need to leave a comment there, so I can find you in the dropbox of assignees. Or you just simply leave 'I am wor

[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #2052: [KYUUBI-886] Add HTTP transport mode support to KYUUBI

2022-03-06 Thread GitBox
codecov-commenter commented on pull request #2052: URL: https://github.com/apache/incubator-kyuubi/pull/2052#issuecomment-106078 # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2052?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+co

[GitHub] [incubator-kyuubi] SteNicholas commented on issue #2011: [Subtask] HiveSQLEngine with execute statement support

2022-03-06 Thread GitBox
SteNicholas commented on issue #2011: URL: https://github.com/apache/incubator-kyuubi/issues/2011#issuecomment-1060227523 @yaooqinn, could you please assign this ticket to me? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-kyuubi] SteNicholas commented on issue #2016: [Subtask] Hive Backend Engine - GetTables Operation

2022-03-06 Thread GitBox
SteNicholas commented on issue #2016: URL: https://github.com/apache/incubator-kyuubi/issues/2016#issuecomment-1060227801 @yaooqinn, could you please assign this ticket to me? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-kyuubi] SteNicholas commented on issue #2015: [Subtask] Hive Backend Engine - GetSchemas Operation

2022-03-06 Thread GitBox
SteNicholas commented on issue #2015: URL: https://github.com/apache/incubator-kyuubi/issues/2015#issuecomment-1060227766 @yaooqinn, could you please assign this ticket to me? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-kyuubi] SteNicholas commented on issue #2014: [Subtask] Hive Backend Engine - GetCatalog Operation

2022-03-06 Thread GitBox
SteNicholas commented on issue #2014: URL: https://github.com/apache/incubator-kyuubi/issues/2014#issuecomment-1060227736 @yaooqinn, could you please assign this ticket to me? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-kyuubi] SteNicholas commented on issue #2017: [Subtask] Hive Backend Engine -GetColumns Operation

2022-03-06 Thread GitBox
SteNicholas commented on issue #2017: URL: https://github.com/apache/incubator-kyuubi/issues/2017#issuecomment-1060227838 @yaooqinn, could you please assign this ticket to me? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-kyuubi] SteNicholas commented on issue #2018: [Subtask] Hive Backend Engine - GetFunctions Operation

2022-03-06 Thread GitBox
SteNicholas commented on issue #2018: URL: https://github.com/apache/incubator-kyuubi/issues/2018#issuecomment-1060227899 @yaooqinn, could you please assign this ticket to me? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-kyuubi] SteNicholas commented on issue #2019: [Subtask] Hive Backend Engine - GetTableTypes Operation

2022-03-06 Thread GitBox
SteNicholas commented on issue #2019: URL: https://github.com/apache/incubator-kyuubi/issues/2019#issuecomment-1060227936 @yaooqinn, could you please assign this ticket to me? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-kyuubi] SteNicholas commented on issue #2019: [Subtask] Hive Backend Engine - GetTableTypes Operation

2022-03-06 Thread GitBox
SteNicholas commented on issue #2019: URL: https://github.com/apache/incubator-kyuubi/issues/2019#issuecomment-1060228072 @yaooqinn, could you please assign this ticket to me? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-kyuubi] SteNicholas commented on issue #2033: [Subtask] Hive Backend Engine - GetCrossReference

2022-03-06 Thread GitBox
SteNicholas commented on issue #2033: URL: https://github.com/apache/incubator-kyuubi/issues/2033#issuecomment-1060228038 @yaooqinn, could you please assign this ticket to me? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-kyuubi] SteNicholas removed a comment on issue #2019: [Subtask] Hive Backend Engine - GetTableTypes Operation

2022-03-06 Thread GitBox
SteNicholas removed a comment on issue #2019: URL: https://github.com/apache/incubator-kyuubi/issues/2019#issuecomment-1060228072 @yaooqinn, could you please assign this ticket to me? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #2052: [KYUUBI-886] Add HTTP transport mode support to KYUUBI

2022-03-06 Thread GitBox
pan3793 commented on a change in pull request #2052: URL: https://github.com/apache/incubator-kyuubi/pull/2052#discussion_r820405768 ## File path: pom.xml ## @@ -857,15 +857,6 @@ org.eclipse.jetty jetty-server ${jetty.version}

[GitHub] [incubator-kyuubi] SteNicholas commented on issue #2034: [Subtask] Hive Backend Engine - GetPrimaryKeys

2022-03-06 Thread GitBox
SteNicholas commented on issue #2034: URL: https://github.com/apache/incubator-kyuubi/issues/2034#issuecomment-1060228171 @yaooqinn, could you please assign this ticket to me? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-kyuubi] SteNicholas commented on a change in pull request #2052: [KYUUBI-886] Add HTTP transport mode support to KYUUBI

2022-03-06 Thread GitBox
SteNicholas commented on a change in pull request #2052: URL: https://github.com/apache/incubator-kyuubi/pull/2052#discussion_r820406894 ## File path: pom.xml ## @@ -857,15 +857,6 @@ org.eclipse.jetty jetty-server ${jetty.versi

[GitHub] [incubator-kyuubi] yaooqinn commented on issue #2011: [Subtask] HiveSQLEngine with execute statement support

2022-03-06 Thread GitBox
yaooqinn commented on issue #2011: URL: https://github.com/apache/incubator-kyuubi/issues/2011#issuecomment-1060230384 #2013 is ready for review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [incubator-kyuubi] SteNicholas commented on a change in pull request #2052: [KYUUBI-886] Add HTTP transport mode support to KYUUBI

2022-03-06 Thread GitBox
SteNicholas commented on a change in pull request #2052: URL: https://github.com/apache/incubator-kyuubi/pull/2052#discussion_r820406894 ## File path: pom.xml ## @@ -857,15 +857,6 @@ org.eclipse.jetty jetty-server ${jetty.versi

[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #2052: [KYUUBI-886] Add HTTP transport mode support to KYUUBI

2022-03-06 Thread GitBox
codecov-commenter edited a comment on pull request #2052: URL: https://github.com/apache/incubator-kyuubi/pull/2052#issuecomment-106078 # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2052?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaig

[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #2052: [KYUUBI-886] Add HTTP transport mode support to KYUUBI

2022-03-06 Thread GitBox
pan3793 commented on a change in pull request #2052: URL: https://github.com/apache/incubator-kyuubi/pull/2052#discussion_r820414802 ## File path: pom.xml ## @@ -857,15 +857,6 @@ org.eclipse.jetty jetty-server ${jetty.version}

[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #2052: [KYUUBI-886] Add HTTP transport mode support to KYUUBI

2022-03-06 Thread GitBox
codecov-commenter edited a comment on pull request #2052: URL: https://github.com/apache/incubator-kyuubi/pull/2052#issuecomment-106078 # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2052?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaig

[GitHub] [incubator-kyuubi] SteNicholas opened a new pull request #2054: [KYUUBI-1819] Support closing Flink SQL engine process

2022-03-06 Thread GitBox
SteNicholas opened a new pull request #2054: URL: https://github.com/apache/incubator-kyuubi/pull/2054 ### _Why are the changes needed?_ Support closing Flink SQL engine process. ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thorou

[GitHub] [incubator-kyuubi] SteNicholas commented on pull request #2054: [KYUUBI-1819] Support closing Flink SQL engine process

2022-03-06 Thread GitBox
SteNicholas commented on pull request #2054: URL: https://github.com/apache/incubator-kyuubi/pull/2054#issuecomment-1060280166 @yaooqinn @pan3793 @yanghua, could you please help to review? -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-kyuubi] SteNicholas commented on pull request #2046: [KYUUBI #2043] Upgrade log4j/2.x/ to 2.17.2

2022-03-06 Thread GitBox
SteNicholas commented on pull request #2046: URL: https://github.com/apache/incubator-kyuubi/pull/2046#issuecomment-1060282643 @RishiKumarRay, could you please take a look at the CI for `SQLOperationListenerSuite` hanging. -- This is an automated message from the Apache Git Service. To

[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #2052: [KYUUBI-886] Add HTTP transport mode support to KYUUBI

2022-03-06 Thread GitBox
yaooqinn commented on a change in pull request #2052: URL: https://github.com/apache/incubator-kyuubi/pull/2052#discussion_r820443232 ## File path: kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala ## @@ -294,20 +296,28 @@ object KyuubiConf { .versi

[GitHub] [incubator-kyuubi] SteNicholas commented on a change in pull request #2052: [KYUUBI-886] Add HTTP transport mode support to KYUUBI

2022-03-06 Thread GitBox
SteNicholas commented on a change in pull request #2052: URL: https://github.com/apache/incubator-kyuubi/pull/2052#discussion_r820454031 ## File path: kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala ## @@ -294,20 +296,28 @@ object KyuubiConf { .ve

[GitHub] [incubator-kyuubi] SteNicholas commented on a change in pull request #2052: [KYUUBI-886] Add HTTP transport mode support to KYUUBI

2022-03-07 Thread GitBox
SteNicholas commented on a change in pull request #2052: URL: https://github.com/apache/incubator-kyuubi/pull/2052#discussion_r820455869 ## File path: kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala ## @@ -364,6 +374,41 @@ object KyuubiConf { .ver

[GitHub] [incubator-kyuubi] SteNicholas commented on a change in pull request #2052: [KYUUBI-886] Add HTTP transport mode support to KYUUBI

2022-03-07 Thread GitBox
SteNicholas commented on a change in pull request #2052: URL: https://github.com/apache/incubator-kyuubi/pull/2052#discussion_r820455869 ## File path: kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala ## @@ -364,6 +374,41 @@ object KyuubiConf { .ver

[GitHub] [incubator-kyuubi] SteNicholas removed a comment on pull request #2054: [KYUUBI-1819] Support closing Flink SQL engine process

2022-03-07 Thread GitBox
SteNicholas removed a comment on pull request #2054: URL: https://github.com/apache/incubator-kyuubi/pull/2054#issuecomment-1060280166 @yaooqinn @pan3793 @yanghua, could you please help to review? -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [incubator-kyuubi] SteNicholas commented on pull request #2054: [KYUUBI-1819] Support closing Flink SQL engine process

2022-03-07 Thread GitBox
SteNicholas commented on pull request #2054: URL: https://github.com/apache/incubator-kyuubi/pull/2054#issuecomment-1060305342 @yaooqinn @pan3793 @yanghua[](https://github.com/SteNicholas), could you please help to review? -- This is an automated message from the Apache Git Service. To

  1   2   3   4   5   6   7   8   9   10   >