[jira] [Commented] (LOG4J2-1721) Composite configuration using log4jConfiguration context parameter

[ https://issues.apache.org/jira/browse/LOG4J2-1721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16510165#comment-16510165 ] ASF GitHub Bot commented on LOG4J2-1721: Github user fluxroot commented on the issue:

[GitHub] logging-log4j2 issue #176: [LOG4J2-1721] Allow composite configuration for c...

Github user fluxroot commented on the issue: https://github.com/apache/logging-log4j2/pull/176 That was my initial thought as well. However, there have been a couple of issues which made me copy the functionality from Configurator.initialize() over to

[jira] [Commented] (LOG4J2-2351) AbstractLogEvent.instant should be protected, not private

[ https://issues.apache.org/jira/browse/LOG4J2-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509966#comment-16509966 ] Carter Kozak commented on LOG4J2-2351: -- > Have you considered adding a protected

[jira] [Updated] (LOG4J2-2351) AbstractLogEvent.instant should be protected, not private

[ https://issues.apache.org/jira/browse/LOG4J2-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carter Kozak updated LOG4J2-2351: - Priority: Trivial (was: Major) > AbstractLogEvent.instant should be protected, not private >

Build failed in Jenkins: Log4j 2 2.x #3496

See -- Started by upstream project "Log4j 2 3.x" build number 95 originally caused by: Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on H34

[jira] [Commented] (LOG4J2-2351) AbstractLogEvent.instant should be protected, not private

[ https://issues.apache.org/jira/browse/LOG4J2-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509904#comment-16509904 ] Gary Gregory commented on LOG4J2-2351: -- Have you considered adding a protected getMutableInstant()

Build failed in Jenkins: Log4j 2 2.x #3495

See Changes: [ckozak] Apply ThreadContextRule to Log4j1XmlLayoutTest -- [...truncated 460.72 KB...] ExecutionException Error creating properties files for forking

[jira] [Commented] (LOG4J2-2351) AbstractLogEvent.instant should be protected, not private

[ https://issues.apache.org/jira/browse/LOG4J2-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509879#comment-16509879 ] Carter Kozak commented on LOG4J2-2351: -- That is correct, my goal is to allow classes extending

[GitHub] logging-log4j2 pull request #182: Apply ThreadContextRule to Log4j1XmlLayout...

Github user cakofony closed the pull request at: https://github.com/apache/logging-log4j2/pull/182 ---

[GitHub] logging-log4j2 issue #182: Apply ThreadContextRule to Log4j1XmlLayoutTest

Github user cakofony commented on the issue: https://github.com/apache/logging-log4j2/pull/182 merged ---

[jira] [Commented] (LOG4J2-2351) AbstractLogEvent.instant should be protected, not private

[ https://issues.apache.org/jira/browse/LOG4J2-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509836#comment-16509836 ] Ralph Goers commented on LOG4J2-2351: - I see. Since in your patch it is changed to protected only

[GitHub] logging-log4j2 pull request #182: Apply ThreadContextRule to Log4j1XmlLayout...

GitHub user cakofony opened a pull request: https://github.com/apache/logging-log4j2/pull/182 Apply ThreadContextRule to Log4j1XmlLayoutTest NDC value is leaking into the test intermittently causing a comparison to fail. You can merge this pull request into a Git repository by

[jira] [Commented] (LOG4J2-2352) Reusable event message mementos should be cached

[ https://issues.apache.org/jira/browse/LOG4J2-2352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509771#comment-16509771 ] ASF GitHub Bot commented on LOG4J2-2352: GitHub user cakofony opened a pull request:

[GitHub] logging-log4j2 pull request #181: [LOG4J2-2352] Reusable event message memen...

GitHub user cakofony opened a pull request: https://github.com/apache/logging-log4j2/pull/181 [LOG4J2-2352] Reusable event message mementos are memoized Fixed RingBufferLogEvent.memento which returned a ParameterizedMessage rather than a MememntoMessage. You can merge this pull

[jira] [Commented] (LOG4J2-2351) AbstractLogEvent.instant should be protected, not private

[ https://issues.apache.org/jira/browse/LOG4J2-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509744#comment-16509744 ] Carter Kozak commented on LOG4J2-2351: -- I agree that the variable could be final so it cannot be

[jira] [Commented] (LOG4J2-2351) AbstractLogEvent.instant should be protected, not private

[ https://issues.apache.org/jira/browse/LOG4J2-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509735#comment-16509735 ] Ralph Goers commented on LOG4J2-2351: - I don't understand the problem being solved here. Why is it a

[jira] [Comment Edited] (LOG4J2-2351) AbstractLogEvent.instant should be protected, not private

[ https://issues.apache.org/jira/browse/LOG4J2-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509735#comment-16509735 ] Ralph Goers edited comment on LOG4J2-2351 at 6/12/18 3:13 PM: -- I don't

[jira] [Assigned] (LOG4J2-2352) Reusable event message mementos should be cached

[ https://issues.apache.org/jira/browse/LOG4J2-2352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carter Kozak reassigned LOG4J2-2352: Assignee: Carter Kozak > Reusable event message mementos should be cached >

[GitHub] logging-log4j2 pull request #180: [LOG4J2-2351] AbstractLogEvent.instant is ...

GitHub user cakofony opened a pull request: https://github.com/apache/logging-log4j2/pull/180 [LOG4J2-2351] AbstractLogEvent.instant is protected, not private The MutableInstant may be modified by classes extending AbstractLogEvent. You can merge this pull request into a Git

[jira] [Assigned] (LOG4J2-2351) AbstractLogEvent.instant should be protected, not private

[ https://issues.apache.org/jira/browse/LOG4J2-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carter Kozak reassigned LOG4J2-2351: Assignee: Carter Kozak > AbstractLogEvent.instant should be protected, not private >

[jira] [Commented] (LOG4J2-2351) AbstractLogEvent.instant should be protected, not private

[ https://issues.apache.org/jira/browse/LOG4J2-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509695#comment-16509695 ] ASF GitHub Bot commented on LOG4J2-2351: GitHub user cakofony opened a pull request:

[jira] [Created] (LOG4J2-2351) AbstractLogEvent.instant should be protected, not private

Carter Kozak created LOG4J2-2351: Summary: AbstractLogEvent.instant should be protected, not private Key: LOG4J2-2351 URL: https://issues.apache.org/jira/browse/LOG4J2-2351 Project: Log4j 2

Jenkins build is back to stable : Log4j 2 2.x #3493

See

[GitHub] logging-log4j2 issue #179: AsyncLoggerConfig optimization

Github user cakofony commented on the issue: https://github.com/apache/logging-log4j2/pull/179 Thanks for the review! ---

[GitHub] logging-log4j2 issue #179: AsyncLoggerConfig optimization

Github user remkop commented on the issue: https://github.com/apache/logging-log4j2/pull/179 Thanks for the clarification. No objections from me! ---