[GitHub] [logging-log4j2] srdo commented on pull request #644: LOG4J2-3259: Limit max recursion depth when interpolating strings.

2021-12-19 Thread GitBox
srdo commented on pull request #644: URL: https://github.com/apache/logging-log4j2/pull/644#issuecomment-997681581 @quaff I don't think that fixes the same thing? This fix is trying to limit recursion depth in all cases, the fix you are linking disables recursion in some cases. -- This

[jira] [Commented] (LOGCXX-544) Please embedd library version in a header

2021-12-19 Thread Tobias Frost (Jira)
[ https://issues.apache.org/jira/browse/LOGCXX-544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17462427#comment-17462427 ] Tobias Frost commented on LOGCXX-544: - Yeah, PR #76 will help. For the build failure, here is the

[GitHub] [logging-log4j2] quaff commented on pull request #617: LOG4J2-3204 - Correct SpringLookup package name in Interpolator

2021-12-19 Thread GitBox
quaff commented on pull request #617: URL: https://github.com/apache/logging-log4j2/pull/617#issuecomment-997667402 @rgoers , Please take a look at this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [logging-log4j2] quaff commented on pull request #644: LOG4J2-3259: Limit max recursion depth when interpolating strings.

2021-12-19 Thread GitBox
quaff commented on pull request #644: URL: https://github.com/apache/logging-log4j2/pull/644#issuecomment-997665780 @srdo , I think your PR should be closed, `isRecursiveEvaluationAllowed()` is introduced by

[jira] [Updated] (LOG4J2-3258) RollingFile fileName containing variables does not work on 2.17.0

2021-12-19 Thread Konstantinos Liakos (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantinos Liakos updated LOG4J2-3258: Description: A configuration like the below has stopped working since 2.17.0. The

[jira] [Updated] (LOG4J2-3258) RollingFile fileName containing variables does not work on 2.17.0

2021-12-19 Thread Konstantinos Liakos (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantinos Liakos updated LOG4J2-3258: Description: A configuration like the below has stopped working since 2.17.0. The

[jira] [Updated] (LOG4J2-3260) Missing branch protection settings on log4j2 repo

2021-12-19 Thread Abhishek Arya (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhishek Arya updated LOG4J2-3260: -- Description: The branch protection setting is missing on

[jira] [Commented] (LOG4J2-3258) RollingFile fileName containing variables does not work on 2.17.0

2021-12-19 Thread Konstantinos Liakos (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17462413#comment-17462413 ] Konstantinos Liakos commented on LOG4J2-3258: - Hi [~rgoers] , please find below the full XML

[jira] [Comment Edited] (LOG4J2-3258) RollingFile fileName containing variables does not work on 2.17.0

2021-12-19 Thread Konstantinos Liakos (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17462413#comment-17462413 ] Konstantinos Liakos edited comment on LOG4J2-3258 at 12/20/21, 7:00 AM:

[jira] [Updated] (LOG4J2-3260) Missing branch protection settings on log4j2 repo

2021-12-19 Thread Abhishek Arya (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhishek Arya updated LOG4J2-3260: -- Description: Please check

[jira] [Updated] (LOG4J2-3260) Missing branch protection settings on log4j2 repo

2021-12-19 Thread Abhishek Arya (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhishek Arya updated LOG4J2-3260: -- Description: Please check

[jira] [Created] (LOG4J2-3260) Missing branch protection settings on log4j2 repo

2021-12-19 Thread Abhishek Arya (Jira)
Abhishek Arya created LOG4J2-3260: - Summary: Missing branch protection settings on log4j2 repo Key: LOG4J2-3260 URL: https://issues.apache.org/jira/browse/LOG4J2-3260 Project: Log4j 2 Issue

[jira] [Commented] (LOG4J2-3198) Message lookups should be disabled by default

2021-12-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17462404#comment-17462404 ] ASF subversion and git services commented on LOG4J2-3198: - Commit

[jira] [Commented] (LOG4J2-3242) Limit JNDI to the java protocol only

2021-12-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17462359#comment-17462359 ] ASF subversion and git services commented on LOG4J2-3242: - Commit

[GitHub] [logging-log4j2] remkop commented on pull request #608: Restrict LDAP access via JNDI

2021-12-19 Thread GitBox
remkop commented on pull request #608: URL: https://github.com/apache/logging-log4j2/pull/608#issuecomment-997537941 @quaff Thanks for noticing this! The Log4j [security page](https://logging.apache.org/log4j/2.x/security.html) has already been updated to reflect this. I believe

[GitHub] [logging-log4j2] quaff commented on pull request #608: Restrict LDAP access via JNDI

2021-12-19 Thread GitBox
quaff commented on pull request #608: URL: https://github.com/apache/logging-log4j2/pull/608#issuecomment-997530030 > @remkop Description of `CVE-2021-45046` is not accurate, could you verify and update security page? > > > Thread Context Map pattern (%X, %mdc, or %MDC) > > I

[jira] [Commented] (LOG4J2-3250) Consider remove recursive replace for lookups

2021-12-19 Thread Yanming Zhou (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17462348#comment-17462348 ] Yanming Zhou commented on LOG4J2-3250: -- Confirm fixed in 2.17.0, please close it. > Consider

[jira] [Closed] (LOG4J2-3250) Consider remove recursive replace for lookups

2021-12-19 Thread Yanming Zhou (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yanming Zhou closed LOG4J2-3250. Resolution: Fixed > Consider remove recursive replace for lookups >

[jira] [Updated] (LOG4J2-3250) Consider remove recursive replace for lookups

2021-12-19 Thread Yanming Zhou (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yanming Zhou updated LOG4J2-3250: - Fix Version/s: 2.17.0 > Consider remove recursive replace for lookups >

[jira] [Updated] (LOG4J2-2819) Add support for specifying an SSL configuration for SmtpAppender

2021-12-19 Thread Remko Popma (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma updated LOG4J2-2819: Fix Version/s: 2.12.3 > Add support for specifying an SSL configuration for SmtpAppender >

[jira] [Commented] (LOG4J2-3242) Limit JNDI to the java protocol only

2021-12-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17462337#comment-17462337 ] ASF subversion and git services commented on LOG4J2-3242: - Commit

[jira] [Commented] (LOG4J2-3258) RollingFile fileName containing variables does not work on 2.17.0

2021-12-19 Thread Ralph Goers (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17462333#comment-17462333 ] Ralph Goers commented on LOG4J2-3258: - I'm misunderstanding something. You say that properties that

[jira] [Comment Edited] (LOG4J2-3258) RollingFile fileName containing variables does not work on 2.17.0

2021-12-19 Thread Ralph Goers (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17462333#comment-17462333 ] Ralph Goers edited comment on LOG4J2-3258 at 12/19/21, 10:54 PM: - I'm

[jira] [Commented] (LOG4J2-3257) MDC class in 2.17.0 has multiple "put" methods

2021-12-19 Thread Ralph Goers (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17462311#comment-17462311 ] Ralph Goers commented on LOG4J2-3257: - Yeah, your exception is telling you that the put(String key,

[GitHub] [logging-log4j2] srdo commented on pull request #644: LOG4J2-3259: Limit max recursion depth when interpolating strings.

2021-12-19 Thread GitBox
srdo commented on pull request #644: URL: https://github.com/apache/logging-log4j2/pull/644#issuecomment-997469084 Sorry, I should have asked more clearly. What I meant was "How are you ensuring that this fix will also be applied to master, is it by cherry-pick or by merging 2.x into

[GitHub] [logging-log4j2] garydgregory edited a comment on pull request #644: LOG4J2-3259: Limit max recursion depth when interpolating strings.

2021-12-19 Thread GitBox
garydgregory edited a comment on pull request #644: URL: https://github.com/apache/logging-log4j2/pull/644#issuecomment-997464275 > @garydgregory Thanks, will close this and move it to another branch. I assume you cherry-pick/merge forward on this project then? Yes, just a plain

[GitHub] [logging-log4j2] garydgregory edited a comment on pull request #644: LOG4J2-3259: Limit max recursion depth when interpolating strings.

2021-12-19 Thread GitBox
garydgregory edited a comment on pull request #644: URL: https://github.com/apache/logging-log4j2/pull/644#issuecomment-997464275 > @garydgregory Thanks, will close this and move it to another branch. I assume you cherry-pick/merge forward on this project then? Yes, just a plain

[GitHub] [logging-log4j2] garydgregory commented on pull request #644: LOG4J2-3259: Limit max recursion depth when interpolating strings.

2021-12-19 Thread GitBox
garydgregory commented on pull request #644: URL: https://github.com/apache/logging-log4j2/pull/644#issuecomment-997464275 > @garydgregory Thanks, will close this and move it to another branch. I assume you cherry-pick/merge forward on this project then? No, just a plain merge from

[GitHub] [logging-log4j2] srdo commented on pull request #644: LOG4J2-3259: Limit max recursion depth when interpolating strings.

2021-12-19 Thread GitBox
srdo commented on pull request #644: URL: https://github.com/apache/logging-log4j2/pull/644#issuecomment-997462128 @garydgregory Thanks, will close this and move it to another branch. I assume you cherry-pick/merge forward on this project then? -- This is an automated message from the

[GitHub] [logging-log4j2] srdo closed pull request #644: LOG4J2-3259: Limit max recursion depth when interpolating strings.

2021-12-19 Thread GitBox
srdo closed pull request #644: URL: https://github.com/apache/logging-log4j2/pull/644 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [logging-log4j2] garydgregory commented on pull request #644: LOG4J2-3259: Limit max recursion depth when interpolating strings.

2021-12-19 Thread GitBox
garydgregory commented on pull request #644: URL: https://github.com/apache/logging-log4j2/pull/644#issuecomment-997461971 Hi @srdo Wrong branch: You want to target `release-2.x`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [logging-log4j2] srdo commented on pull request #644: LOG4J2-3259: Limit max recursion depth when interpolating strings.

2021-12-19 Thread GitBox
srdo commented on pull request #644: URL: https://github.com/apache/logging-log4j2/pull/644#issuecomment-997461040 Jira https://issues.apache.org/jira/browse/LOG4J2-3259 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [logging-log4j2] srdo opened a new pull request #644: LOG4J2-3259: Limit max recursion depth when interpolating strings.

2021-12-19 Thread GitBox
srdo opened a new pull request #644: URL: https://github.com/apache/logging-log4j2/pull/644 I've hard coded the limit to 10. If you feel the limit needs to be configurable (via system property or the log4j config?), let me know and I'll adjust. I couldn't find a good way to keep

[jira] [Created] (LOG4J2-3259) Limit string interpolation recursion level.

2021-12-19 Thread Jira
Stig Rohde Døssing created LOG4J2-3259: -- Summary: Limit string interpolation recursion level. Key: LOG4J2-3259 URL: https://issues.apache.org/jira/browse/LOG4J2-3259 Project: Log4j 2

[GitHub] [logging-log4j2] dpsenner opened a new pull request #643: Improve mailing list wording on the website

2021-12-19 Thread GitBox
dpsenner opened a new pull request #643: URL: https://github.com/apache/logging-log4j2/pull/643 This PR adds a sentence that explains users what to do before posting messages to a mailing list. -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Created] (LOG4J2-3258) RollingFile fileName containing variables does not work on 2.17.0

2021-12-19 Thread Konstantinos Liakos (Jira)
Konstantinos Liakos created LOG4J2-3258: --- Summary: RollingFile fileName containing variables does not work on 2.17.0 Key: LOG4J2-3258 URL: https://issues.apache.org/jira/browse/LOG4J2-3258

[jira] [Commented] (LOG4J2-3257) MDC class in 2.17.0 has multiple "put" methods

2021-12-19 Thread Mike (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1746#comment-1746 ] Mike commented on LOG4J2-3257: -- I can certainly look - however, I've upgraded to 15, then 16, and now 17 in

[jira] [Commented] (LOG4J2-3257) MDC class in 2.17.0 has multiple "put" methods

2021-12-19 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17462218#comment-17462218 ] Gary D. Gregory commented on LOG4J2-3257: - This class has not changed its API signature in our

[jira] [Updated] (LOG4J2-3257) MDC class in 2.17.0 has multiple "put" methods

2021-12-19 Thread Mike (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike updated LOG4J2-3257: - Description: We use MDC.put for a variety of things.  With the 2.17 version, it appears there is a bug. When

[jira] [Updated] (LOG4J2-3257) MDC class in 2.17.0 has multiple "put" methods

2021-12-19 Thread Mike (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike updated LOG4J2-3257: - Description: We use MDC.put for a variety of things.  With the 2.17 version it appears there is a bug. When

[jira] [Created] (LOG4J2-3257) MDC class in 2.17.0 has multiple "put" methods

2021-12-19 Thread Mike (Jira)
Mike created LOG4J2-3257: Summary: MDC class in 2.17.0 has multiple "put" methods Key: LOG4J2-3257 URL: https://issues.apache.org/jira/browse/LOG4J2-3257 Project: Log4j 2 Issue Type: Bug

[GitHub] [logging-log4cxx] Sadboipoor commented on a change in pull request #75: Add "f" as the short filename

2021-12-19 Thread GitBox
Sadboipoor commented on a change in pull request #75: URL: https://github.com/apache/logging-log4cxx/pull/75#discussion_r771956556 ## File path: src/main/cpp/locationinfo.cpp ## @@ -102,6 +120,14 @@ const char* LocationInfo::getFileName() const return fileName; }

[GitHub] [logging-log4cxx] Sadboipoor commented on pull request #82: LOGCXX-537 avoid deadlock if socket fails

2021-12-19 Thread GitBox
Sadboipoor commented on pull request #82: URL: https://github.com/apache/logging-log4cxx/pull/82#issuecomment-997399720 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [logging-log4j2] KristjanESPERANTO opened a new pull request #642: Add Link to Release History

2021-12-19 Thread GitBox
KristjanESPERANTO opened a new pull request #642: URL: https://github.com/apache/logging-log4j2/pull/642 It's a minor detail, but I didn't find any reference to the release history in the repository. -- This is an automated message from the Apache Git Service. To respond to the message,