Re: [PR] Bump co.elastic.clients:elasticsearch-java from 8.17.0 to 8.17.2 in /log4j-layout-template-json-test (logging-log4j2)

2025-02-18 Thread via GitHub
ppkarwasz commented on PR #3460: URL: https://github.com/apache/logging-log4j2/pull/3460#issuecomment-2667832774 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Bump mongodb.version from 5.2.1 to 5.3.1 in /log4j-mongodb (logging-log4j2)

2025-02-18 Thread via GitHub
ppkarwasz commented on PR #3409: URL: https://github.com/apache/logging-log4j2/pull/3409#issuecomment-2667830213 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Add `collectionName` and `databaseName` attributes to `MongoDbProvider` (logging-log4j2)

2025-02-18 Thread via GitHub
ppkarwasz commented on PR #3467: URL: https://github.com/apache/logging-log4j2/pull/3467#issuecomment-2667731055 > @vy Just did a new clone of the full repo, into a new directory. Verified that it's the 2.x branch. Running `./mvnw install -DskipTests` produced the following errror. >

Re: [PR] Bump com.palantir.javaformat:palantir-java-format from 2.51.0 to 2.52.0 [logging-parent]

2025-02-18 Thread via GitHub
ppkarwasz merged PR #329: URL: https://github.com/apache/logging-parent/pull/329 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr.

Re: [PR] Bump dependabot/fetch-metadata from 2.2.0 to 2.3.0 [logging-parent]

2025-02-18 Thread via GitHub
ppkarwasz merged PR #322: URL: https://github.com/apache/logging-parent/pull/322 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr.

[PR] Expand `url` in POM file [logging-parent]

2025-02-18 Thread via GitHub
ppkarwasz opened a new pull request, #330: URL: https://github.com/apache/logging-parent/pull/330 Since the `flatten-bom` removes the `child.project.url.inherit.append.path` attribute from the parent POM, we need to expand the `url` element in children. Otherwise we get fake URLs like `htt

Re: [PR] Add `collectionName` and `databaseName` attributes to `MongoDbProvider` (logging-log4j2)

2025-02-18 Thread via GitHub
jesmith17 commented on PR #3467: URL: https://github.com/apache/logging-log4j2/pull/3467#issuecomment-2667316817 @vy Just did a new clone of the full repo, into a new directory. Verified that it's the 2.x branch. Running `./mvnw install -DskipTests` produced the following errror. `

Re: [PR] Bump commons-logging:commons-logging from 1.3.4 to 1.3.5 (logging-log4j2)

2025-02-18 Thread via GitHub
github-actions[bot] merged PR #3444: URL: https://github.com/apache/logging-log4j2/pull/3444 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Bump org.apache.commons:commons-csv from 1.12.0 to 1.13.0 (logging-log4j2)

2025-02-18 Thread via GitHub
github-actions[bot] merged PR #3386: URL: https://github.com/apache/logging-log4j2/pull/3386 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Bump cassandra.version from 3.11.18 to 3.11.19 in /log4j-parent (logging-log4j2)

2025-02-18 Thread via GitHub
github-actions[bot] merged PR #3440: URL: https://github.com/apache/logging-log4j2/pull/3440 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Bump org.apache.commons:commons-csv from 1.12.0 to 1.13.0 (logging-log4j2)

2025-02-18 Thread via GitHub
ppkarwasz commented on PR #3386: URL: https://github.com/apache/logging-log4j2/pull/3386#issuecomment-2667115439 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[I] Remove Error Prone workaround after `logging-parent` version `12.0.1` upgrade (logging-log4j2)

2025-02-18 Thread via GitHub
ppkarwasz opened a new issue, #3471: URL: https://github.com/apache/logging-log4j2/issues/3471 This issue is to remember to remove the Error Prone workaround from `log4j-parent/pom.xml`, once the fix is integrated into `logging-parent`. -- This is an automated message from the Apache

Re: [PR] Run reproducibility check after each deployment (logging-log4j2)

2025-02-18 Thread via GitHub
ppkarwasz merged PR #3101: URL: https://github.com/apache/logging-log4j2/pull/3101 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [PR] Bump org.apache.logging:logging-parent from 11.3.0 to 12.0.0 in /log4j-parent (logging-log4j2)

2025-02-18 Thread via GitHub
ppkarwasz merged PR #3452: URL: https://github.com/apache/logging-log4j2/pull/3452 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [PR] Run integration tests after each deployment (logging-log4j2)

2025-02-18 Thread via GitHub
ppkarwasz merged PR #3105: URL: https://github.com/apache/logging-log4j2/pull/3105 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [PR] Fix formatting of `s` pattern (logging-log4j2)

2025-02-18 Thread via GitHub
ppkarwasz commented on code in PR #3469: URL: https://github.com/apache/logging-log4j2/pull/3469#discussion_r1960624210 ## log4j-core/src/main/java/org/apache/logging/log4j/core/util/internal/instant/InstantPatternDynamicFormatter.java: ## @@ -239,7 +239,11 @@ private static Lis

Re: [PR] Publish build scans to develocity.apache.org (logging-log4j2)

2025-02-18 Thread via GitHub
ppkarwasz merged PR #3396: URL: https://github.com/apache/logging-log4j2/pull/3396 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [PR] Add `collectionName` and `databaseName` attributes to `MongoDbProvider` (logging-log4j2)

2025-02-18 Thread via GitHub
ppkarwasz commented on code in PR #3467: URL: https://github.com/apache/logging-log4j2/pull/3467#discussion_r1960356099 ## log4j-mongodb4/src/main/java/org/apache/logging/log4j/mongodb4/MongoDb4Connection.java: ## @@ -67,21 +67,23 @@ public MongoDb4Connection( final

Re: [PR] Add `collectionName` and `databaseName` attributes to `MongoDbProvider` (logging-log4j2)

2025-02-18 Thread via GitHub
vy commented on PR #3467: URL: https://github.com/apache/logging-log4j2/pull/3467#issuecomment-2665989919 You’re right, we can and should indeed improve on this. Op di 18 feb 2025 om 14:24 schreef Josh Smith ***@***.***> > ***@***. commented on this pull request. > --

Re: [PR] Add `collectionName` and `databaseName` attributes to `MongoDbProvider` (logging-log4j2)

2025-02-18 Thread via GitHub
vy commented on PR #3467: URL: https://github.com/apache/logging-log4j2/pull/3467#issuecomment-2665920675 We use mvnw both locally and in CI over several platforms, including macOS. Could you make sure you have a clean checkout of the source repository and if it is still failing, share

Re: [PR] Add `collectionName` and `databaseName` attributes to `MongoDbProvider` (logging-log4j2)

2025-02-18 Thread via GitHub
garydgregory commented on code in PR #3467: URL: https://github.com/apache/logging-log4j2/pull/3467#discussion_r1959789232 ## log4j-mongodb4/src/main/java/org/apache/logging/log4j/mongodb4/MongoDb4Connection.java: ## @@ -67,21 +67,23 @@ public MongoDb4Connection( fi

Re: [PR] Add `collectionName` and `databaseName` attributes to `MongoDbProvider` (logging-log4j2)

2025-02-18 Thread via GitHub
jesmith17 commented on code in PR #3467: URL: https://github.com/apache/logging-log4j2/pull/3467#discussion_r1959779986 ## log4j-mongodb4/src/main/java/org/apache/logging/log4j/mongodb4/MongoDb4Connection.java: ## @@ -67,21 +67,23 @@ public MongoDb4Connection( final

Re: [PR] Add `collectionName` and `databaseName` attributes to `MongoDbProvider` (logging-log4j2)

2025-02-18 Thread via GitHub
garydgregory commented on code in PR #3467: URL: https://github.com/apache/logging-log4j2/pull/3467#discussion_r1959779457 ## log4j-mongodb4/src/main/java/org/apache/logging/log4j/mongodb4/MongoDb4Connection.java: ## @@ -67,21 +67,23 @@ public MongoDb4Connection( fi

Re: [PR] Add `collectionName` and `databaseName` attributes to `MongoDbProvider` (logging-log4j2)

2025-02-18 Thread via GitHub
jesmith17 commented on code in PR #3467: URL: https://github.com/apache/logging-log4j2/pull/3467#discussion_r1959741448 ## log4j-mongodb4/src/main/java/org/apache/logging/log4j/mongodb4/MongoDb4Provider.java: ## @@ -60,14 +61,47 @@ public static class Builder> extends AbstractF

Re: [PR] Add `collectionName` and `databaseName` attributes to `MongoDbProvider` (logging-log4j2)

2025-02-18 Thread via GitHub
vy commented on code in PR #3467: URL: https://github.com/apache/logging-log4j2/pull/3467#discussion_r1959659783 ## log4j-mongodb4/src/main/java/org/apache/logging/log4j/mongodb4/MongoDb4Provider.java: ## @@ -60,14 +61,47 @@ public static class Builder> extends AbstractFilterab

Re: [PR] Add `collectionName` and `databaseName` attributes to `MongoDbProvider` (logging-log4j2)

2025-02-18 Thread via GitHub
vy commented on code in PR #3467: URL: https://github.com/apache/logging-log4j2/pull/3467#discussion_r1959551727 ## log4j-mongodb4/src/main/java/org/apache/logging/log4j/mongodb4/MongoDb4Connection.java: ## @@ -67,21 +67,23 @@ public MongoDb4Connection( final Connec

Re: [PR] Add `collectionName` and `databaseName` attributes to `MongoDbProvider` (logging-log4j2)

2025-02-18 Thread via GitHub
vy commented on code in PR #3467: URL: https://github.com/apache/logging-log4j2/pull/3467#discussion_r1959503982 ## log4j-mongodb4/src/main/java/org/apache/logging/log4j/mongodb4/MongoDb4Connection.java: ## @@ -119,4 +121,12 @@ public String toString() { "Mongo4

Re: [I] Add GraalVM native compilation support (logging-log4j2)

2025-02-18 Thread via GitHub
chia7712 commented on issue #1539: URL: https://github.com/apache/logging-log4j2/issues/1539#issuecomment-2665248901 @ppkarwasz thanks for all your response. > You can extract the appropriate reflect-config.json file from the 2.25.0 snapshots and add it to your application. Y

Re: [PR] Add `collectionName` and `databaseName` attributes to `MongoDbProvider` (logging-log4j2)

2025-02-18 Thread via GitHub
ppkarwasz commented on code in PR #3467: URL: https://github.com/apache/logging-log4j2/pull/3467#discussion_r1959435894 ## log4j-mongodb4/src/main/java/org/apache/logging/log4j/mongodb4/MongoDb4Provider.java: ## @@ -60,14 +61,47 @@ public static class Builder> extends AbstractF

Re: [I] Add GraalVM native compilation support (logging-log4j2)

2025-02-18 Thread via GitHub
ppkarwasz commented on issue #1539: URL: https://github.com/apache/logging-log4j2/issues/1539#issuecomment-2665140425 @chia7712, > Pardon me, does "log4j2 2.25.0-SNAPSHOT" indicate that log4j2 can be used with GraalVM without requiring any modifications to the user code? To be

Re: [PR] Only set default configuration name if none has been previously set (… (logging-log4j2)

2025-02-18 Thread via GitHub
github-actions[bot] commented on PR #3454: URL: https://github.com/apache/logging-log4j2/pull/3454#issuecomment-2665113892 Job Requested goals Build Tool Version Build Outcome Build Scan® build-

Re: [PR] Fix typo in LoggerConfig.RootLogger.Builder#withtFilter (#3369) (logging-log4j2)

2025-02-18 Thread via GitHub
ppkarwasz commented on code in PR #3372: URL: https://github.com/apache/logging-log4j2/pull/3372#discussion_r1959377828 ## log4j-core/src/main/java/org/apache/logging/log4j/core/config/LoggerConfig.java: ## @@ -945,11 +944,20 @@ public Filter getFilter() { retur

Re: [I] `PropertiesConfigurationBuilder` throws instead of returning `null` (logging-log4j2)

2025-02-18 Thread via GitHub
ppkarwasz commented on issue #3088: URL: https://github.com/apache/logging-log4j2/issues/3088#issuecomment-2665067171 If you are referring to: https://github.com/apache/logging-log4j2/blob/8c0e3c6c4f32ba97985efc05286e5425bfe36742/log4j-core/src/main/java/org/apache/logging/log4j/core

Re: [I] Expunge stale entries in `InternalLoggerRegistry` (logging-log4j2)

2025-02-18 Thread via GitHub
vy commented on issue #3430: URL: https://github.com/apache/logging-log4j2/issues/3430#issuecomment-2664878829 > I will try my best with the test cases but where do I put the test case file? And is there any example I can refer to? @Suvrat1629, try searching for `InternalLoggerRegist