[GitHub] logging-log4j2 issue #141: LOG4J2-2190 support writing JSON object in messag...

Github user mikaelstaldal commented on the issue: https://github.com/apache/logging-log4j2/pull/141 You should update documentation in `layouts.xml.vm`. ---

[GitHub] logging-log4j2 issue #137: PatternFormatter avoids identityToString until co...

Github user mikaelstaldal commented on the issue: https://github.com/apache/logging-log4j2/pull/137 Have you made any performance testing on this? ---

[GitHub] logging-log4j2 issue #138: POC: declarative runtime null-checks

Github user mikaelstaldal commented on the issue: https://github.com/apache/logging-log4j2/pull/138 I do like the general idea in principle. And I do like the work made by Jetbrains in this area. But I don't think it would be wise to depend on Jetbrains specific annota

[GitHub] logging-log4j2 issue #107: Mark FileRenameAction as successful when using al...

Github user mikaelstaldal commented on the issue: https://github.com/apache/logging-log4j2/pull/107 What is the status of this PR @garydgregory ? ---

[GitHub] logging-log4j2 issue #111: LOG4J2-1216: Nested pattern layout options broken

Github user mikaelstaldal commented on the issue: https://github.com/apache/logging-log4j2/pull/111 Is this PR still relevant? @garydgregory ? ---

[GitHub] logging-log4j2 issue #131: [LOG4J2-2118] Modify MutableLogEvent to preserve ...

Github user mikaelstaldal commented on the issue: https://github.com/apache/logging-log4j2/pull/131 Is this PR still relevant? @remkop ? ---

[GitHub] logging-log4j2 issue #134: Remove unnecessary threadlocal in MdcPatternConve...

Github user mikaelstaldal commented on the issue: https://github.com/apache/logging-log4j2/pull/134 @remkop what do you think? You added this `ThreadLocal`. ---

[GitHub] logging-log4j2 issue #130: How can I use CachedClock

Github user mikaelstaldal commented on the issue: https://github.com/apache/logging-log4j2/pull/130 GitHub Pull Requests is not an appropriate way to ask questions. Try the [`log4j-user`](https://logging.apache.org/log4j/2.x/mail-lists.html) mailing list. ---

[GitHub] logging-log4j2 issue #127: LOG4J2-2109: Added "log4j.formatMsgNoLookups" glo...

Github user mikaelstaldal commented on the issue: https://github.com/apache/logging-log4j2/pull/127 Please update documentation in `configuration.xml.vm`. ---

[GitHub] logging-log4j2 issue #113: ClassLoaderContextSelector more resilient to mult...

Github user mikaelstaldal commented on the issue: https://github.com/apache/logging-log4j2/pull/113 It would be nice to have a JIRA issue for this. ---

[GitHub] logging-log4j2 pull request #124: LOG4J2-2101: MapMessage correctly handles ...

Github user mikaelstaldal commented on a diff in the pull request: https://github.com/apache/logging-log4j2/pull/124#discussion_r149195504 --- Diff: log4j-api/src/test/java/org/apache/logging/log4j/message/MapMessageTest.java --- @@ -99,4 +102,29 @@ public void testMutableByDesign

[GitHub] logging-log4j2 issue #125: LOG4J2-2102: MapMessage Json encoding escapes key...

Github user mikaelstaldal commented on the issue: https://github.com/apache/logging-log4j2/pull/125 We should do the same for the XML format, you can use the new XML format in `EncodingPatternConverter` for that (pull from master). Good to place that in a shared utility class. ---

[GitHub] logging-log4j2 issue #121: (doc) Remove wrong xml tag ""

Github user mikaelstaldal commented on the issue: https://github.com/apache/logging-log4j2/pull/121 @dr0i I would suggest you post to the [log4j-user mailing list](http://logging.apache.org/log4j/2.x/mail-lists.html) for support. Do you have a configuration with a

[GitHub] logging-log4j2 issue #121: (doc) Remove wrong xml tag ""

Github user mikaelstaldal commented on the issue: https://github.com/apache/logging-log4j2/pull/121 This is not a problem, the documentation is correct as it is. ---

[GitHub] logging-log4j2 issue #117: Feature/log4 j2 2062 lookup

Github user mikaelstaldal commented on the issue: https://github.com/apache/logging-log4j2/pull/117 For https://issues.apache.org/jira/browse/LOG4J2-2062 ---