[GitHub] [logging-log4j2] jvz commented on a diff in pull request #1194: Migrate Recycler API to log4j-api

jvz commented on code in PR #1194: URL: https://github.com/apache/logging-log4j2/pull/1194#discussion_r1084344191 ## log4j-api/src/main/java/org/apache/logging/log4j/message/ReusableMessageFactory.java: ## @@ -89,9 +83,21 @@ public static void release(final Message message) { //

[GitHub] [logging-log4j2] jvz commented on a diff in pull request #1194: Migrate Recycler API to log4j-api

jvz commented on code in PR #1194: URL: https://github.com/apache/logging-log4j2/pull/1194#discussion_r1084343619 ## log4j-core/src/main/java/org/apache/logging/log4j/core/layout/AbstractStringLayout.java: ## @@ -270,9 +265,10 @@ protected String serializeToString(final Serializ

[GitHub] [logging-log4j2] jvz commented on a diff in pull request #1194: Migrate Recycler API to log4j-api

jvz commented on code in PR #1194: URL: https://github.com/apache/logging-log4j2/pull/1194#discussion_r1084342459 ## log4j-api/src/main/java/org/apache/logging/log4j/spi/RecyclerFactory.java: ## @@ -0,0 +1,82 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [logging-log4j2] jvz commented on a diff in pull request #1194: Migrate Recycler API to log4j-api

jvz commented on code in PR #1194: URL: https://github.com/apache/logging-log4j2/pull/1194#discussion_r1083550342 ## log4j-api-test/src/test/java/org/apache/logging/log4j/spi/ThreadLocalRecyclerFactoryTest.java: ## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [logging-log4j2] jvz commented on a diff in pull request #1194: Migrate Recycler API to log4j-api

jvz commented on code in PR #1194: URL: https://github.com/apache/logging-log4j2/pull/1194#discussion_r1083550302 ## log4j-api/src/main/java/org/apache/logging/log4j/spi/ThreadLocalRecyclerFactory.java: ## @@ -0,0 +1,95 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [logging-log4j2] jvz commented on a diff in pull request #1194: Migrate Recycler API to log4j-api

jvz commented on code in PR #1194: URL: https://github.com/apache/logging-log4j2/pull/1194#discussion_r1083550106 ## log4j-api/src/main/java/org/apache/logging/log4j/message/ReusableParameterizedMessage.java: ## @@ -43,12 +45,25 @@ public class ReusableParameterizedMessage imple

[GitHub] [logging-log4j2] jvz commented on a diff in pull request #1194: Migrate Recycler API to log4j-api

jvz commented on code in PR #1194: URL: https://github.com/apache/logging-log4j2/pull/1194#discussion_r1083543253 ## log4j-api/src/main/java/org/apache/logging/log4j/util/Queues.java: ## @@ -0,0 +1,214 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [logging-log4j2] jvz commented on a diff in pull request #1194: Migrate Recycler API to log4j-api

jvz commented on code in PR #1194: URL: https://github.com/apache/logging-log4j2/pull/1194#discussion_r1083176186 ## log4j-core/src/main/java/org/apache/logging/log4j/core/layout/AbstractStringLayout.java: ## @@ -235,9 +228,8 @@ public Serializer getHeaderSerializer() {

[GitHub] [logging-log4j2] jvz commented on a diff in pull request #1194: Migrate Recycler API to log4j-api

jvz commented on code in PR #1194: URL: https://github.com/apache/logging-log4j2/pull/1194#discussion_r1083175122 ## log4j-api/src/main/java/org/apache/logging/log4j/util/Queues.java: ## @@ -0,0 +1,214 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [logging-log4j2] jvz commented on a diff in pull request #1194: Migrate Recycler API to log4j-api

jvz commented on code in PR #1194: URL: https://github.com/apache/logging-log4j2/pull/1194#discussion_r1083174440 ## log4j-api/src/main/java/org/apache/logging/log4j/util/Queues.java: ## @@ -0,0 +1,214 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [logging-log4j2] jvz commented on a diff in pull request #1194: Migrate Recycler API to log4j-api

jvz commented on code in PR #1194: URL: https://github.com/apache/logging-log4j2/pull/1194#discussion_r1083173630 ## log4j-api/src/main/java/org/apache/logging/log4j/spi/RecyclerFactory.java: ## @@ -0,0 +1,82 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [logging-log4j2] jvz commented on a diff in pull request #1194: Migrate Recycler API to log4j-api

jvz commented on code in PR #1194: URL: https://github.com/apache/logging-log4j2/pull/1194#discussion_r1083173063 ## log4j-api/src/main/java/org/apache/logging/log4j/spi/ThreadLocalRecyclerFactory.java: ## @@ -0,0 +1,95 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [logging-log4j2] jvz commented on a diff in pull request #1194: Migrate Recycler API to log4j-api

jvz commented on code in PR #1194: URL: https://github.com/apache/logging-log4j2/pull/1194#discussion_r1083171871 ## log4j-api/src/main/java/org/apache/logging/log4j/message/ReusableMessageFactory.java: ## @@ -89,9 +83,21 @@ public static void release(final Message message) { //

[GitHub] [logging-log4j2] jvz commented on a diff in pull request #1194: Migrate Recycler API to log4j-api

jvz commented on code in PR #1194: URL: https://github.com/apache/logging-log4j2/pull/1194#discussion_r1083170062 ## log4j-core/src/main/java/org/apache/logging/log4j/core/async/AsyncLogger.java: ## @@ -492,24 +493,24 @@ public void actualAsyncLog(final RingBufferLogEvent event

[GitHub] [logging-log4j2] jvz commented on a diff in pull request #1194: Migrate Recycler API to log4j-api

jvz commented on code in PR #1194: URL: https://github.com/apache/logging-log4j2/pull/1194#discussion_r1071590544 ## log4j-core/src/main/java/org/apache/logging/log4j/core/layout/GelfLayout.java: ## @@ -690,22 +726,17 @@ static CharSequence formatTimestamp(final long timeMillis

[GitHub] [logging-log4j2] jvz commented on a diff in pull request #1194: Migrate Recycler API to log4j-api

jvz commented on code in PR #1194: URL: https://github.com/apache/logging-log4j2/pull/1194#discussion_r1071590262 ## log4j-core/src/main/java/org/apache/logging/log4j/core/layout/GelfLayout.java: ## @@ -598,12 +636,22 @@ private StringBuilder toText(final LogEvent event, final