[ 
https://issues.apache.org/jira/browse/LOG4J2-2760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17033721#comment-17033721
 ] 

Ralph Goers edited comment on LOG4J2-2760 at 2/10/20 4:15 PM:
--------------------------------------------------------------

I modified how headers are written. Your unit test now passes along with all 
other tests. The failing test was RollingAppenderOnStartupTest. To be honest, 
that test looks off to me. Many of the times I ran it it didn't perform a 
rollover. But when it did roll over the test would fail. From what I could 
tell, the change you made would cause the header to be written twice in some 
cases.


was (Author: ralph.go...@dslextreme.com):
I modified how headers are written. Your unit test now passes along with all 
other tests.

> RollingFileAppender with DirectWriteRolloverStrategy does not work with 
> HtmlLayout
> ----------------------------------------------------------------------------------
>
>                 Key: LOG4J2-2760
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-2760
>             Project: Log4j 2
>          Issue Type: Bug
>          Components: Appenders
>            Reporter: Christoph Kaser
>            Priority: Major
>             Fix For: 2.13.1
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> When I try to use the RollingFileAppender with a DirectWriteRolloverStrategy 
> and a HtmlLayout, I encountered a bug: The first file that is written does 
> not start with the header from the layout.
> If I try to specify append=false to work around that issue, I encountered a 
> NullPointerException instead:
> {noformat}
> java.lang.NullPointerException
>  at java.io.File.<init>(File.java:277)
>  at 
> org.apache.logging.log4j.core.appender.FileManager.createOutputStream(FileManager.java:140)
>  at 
> org.apache.logging.log4j.core.appender.OutputStreamManager.getOutputStream(OutputStreamManager.java:166)
>  at 
> org.apache.logging.log4j.core.appender.OutputStreamManager.<init>(OutputStreamManager.java:95)
>  at 
> org.apache.logging.log4j.core.appender.FileManager.<init>(FileManager.java:72)
>  at 
> org.apache.logging.log4j.core.appender.rolling.RollingFileManager.<init>(RollingFileManager.java:98)
>  at 
> org.apache.logging.log4j.core.appender.rolling.RollingFileManager$RollingFileManagerFactory.createManager(RollingFileManager.java:627)
>  at 
> org.apache.logging.log4j.core.appender.rolling.RollingFileManager$RollingFileManagerFactory.createManager(RollingFileManager.java:588)
>  at 
> org.apache.logging.log4j.core.appender.AbstractManager.getManager(AbstractManager.java:113)
>  at 
> org.apache.logging.log4j.core.appender.OutputStreamManager.getManager(OutputStreamManager.java:114)
>  at 
> org.apache.logging.log4j.core.appender.rolling.RollingFileManager.getFileManager(RollingFileManager.java:163)
>  at 
> org.apache.logging.log4j.core.appender.RollingFileAppender$Builder.build(RollingFileAppender.java:142){noformat}
> I will create a PR in github with a TestCase and a fix and attach it to this 
> bug report.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to