vy opened a new pull request, #2275:
URL: https://github.com/apache/logging-log4j2/pull/2275
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
ppkarwasz commented on code in PR #2275:
URL: https://github.com/apache/logging-log4j2/pull/2275#discussion_r1484206125
##
log4j-api/src/main/java/org/apache/logging/log4j/message/ReusableParameterizedMessage.java:
##
@@ -32,10 +33,18 @@
@PerformanceSensitive("allocation")
dependabot[bot] opened a new pull request, #115:
URL: https://github.com/apache/logging-parent/pull/115
Bumps [commons-codec:commons-codec](https://github.com/apache/commons-codec)
from 1.16.0 to 1.16.1.
Changelog
Sourced from
github-actions[bot] merged PR #115:
URL: https://github.com/apache/logging-parent/pull/115
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
github-actions[bot] closed pull request #2276: Bump commons-codec:commons-codec
from 1.16.0 to 1.16.1
URL: https://github.com/apache/logging-log4j2/pull/2276
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
fluffynuts opened a new issue, #107:
URL: https://github.com/apache/logging-log4net/issues/107
Log4Net can log to multiple backends, including multiple database backends.
I've seen a situation before where a patch to improve performance for
postgresql negatively impacted mssql users
paulonicolau-rj commented on issue #2274:
URL:
https://github.com/apache/logging-log4j2/issues/2274#issuecomment-1935867284
> Switch the order of `` and ``:
>
> ```
>
>
>${sys:catalina.home}/logs
>
>
>
>
>
>
>
fluffynuts opened a new issue, #108:
URL: https://github.com/apache/logging-log4net/issues/108
The
[RELEASING.md](https://github.com/apache/logging-log4net/blob/master/doc/RELEASING.md)
document attempts to layout each and every step, in order, that is required to
get log4net updates to
ppkarwasz commented on issue #2274:
URL:
https://github.com/apache/logging-log4j2/issues/2274#issuecomment-1935935069
Use:
```xml
```
Unlike XML attributes, the content of the `` element is not
interpolated. This might actually be a bug:
fluffynuts opened a new issue, #109:
URL: https://github.com/apache/logging-log4net/issues/109
If you run `npm run run-dotnet-core-tests`, the test assembly should be run
with `dotnet` instead of the nunit runner. This should be used to verify that
cross-framework code works as expected.
fluffynuts opened a new issue, #111:
URL: https://github.com/apache/logging-log4net/issues/111
Log4net supports a lot of really old runtimes, including net2.0 and net3.5
_CE_ (Compact Edition) which can be notoriously difficult to install on windows
(I've been lucky and unlucky - today, it
paulonicolau-rj commented on issue #2274:
URL:
https://github.com/apache/logging-log4j2/issues/2274#issuecomment-1935967538
So, it worked fully. But, I consider the first report a bug too.
Thanks friend!
--
This is an automated message from the Apache Git Service.
To respond to the
fluffynuts opened a new issue, #106:
URL: https://github.com/apache/logging-log4net/issues/106
It would be highly beneficial to the project to have automatic test runs
(`npm test`) for every commit. To this end, a GitHub action that (eventually)
invokes `npm test` would be fantastic.
--
fluffynuts opened a new issue, #110:
URL: https://github.com/apache/logging-log4net/issues/110
Beta nuget packages have a version appendage, eg `-r1`, or the more
descriptive `-{datestamp}-{commit_sha}`; `zarro` already supports generating
packages in this format, so actually producing the
fluffynuts closed pull request #102: ⬆️ Bump xml2js and zarro
URL: https://github.com/apache/logging-log4net/pull/102
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
fluffynuts commented on PR #102:
URL: https://github.com/apache/logging-log4net/pull/102#issuecomment-1935909177
I've updated zarro to latest, invalidating this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
rm5248 closed issue #344: FMT macros fail to build with no arguments
URL: https://github.com/apache/logging-log4cxx/issues/344
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
rm5248 merged PR #346:
URL: https://github.com/apache/logging-log4cxx/pull/346
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
swebb2066 commented on issue #347:
URL:
https://github.com/apache/logging-log4cxx/issues/347#issuecomment-1936895018
On Windows, the benchmark comparisons using a lock (old) and without locking
(new) in `AppenderAttachableImpl::appendLoopOnAppenders` are:
| Benchmark | Time | CPU |
ppkarwasz commented on code in PR #102:
URL:
https://github.com/apache/logging-log4j-tools/pull/102#discussion_r1484531862
##
log4j-docgen/src/main/java/org/apache/logging/log4j/docgen/processor/DocGenProcessor.java:
##
@@ -0,0 +1,692 @@
+/*
+ * Licensed to the Apache Software
ppkarwasz commented on code in PR #102:
URL:
https://github.com/apache/logging-log4j-tools/pull/102#discussion_r1484532155
##
log4j-docgen/src/test/java/org/apache/logging/log4j/docgen/processor/DocGenProcessorTest.java:
##
Review Comment:
Done
--
This is an automated
ppkarwasz closed issue #1344: JMX integration should be split into its own
module
URL: https://github.com/apache/logging-log4j2/issues/1344
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
ppkarwasz commented on issue #1344:
URL:
https://github.com/apache/logging-log4j2/issues/1344#issuecomment-1936237656
Closing this, since JMX has been removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
[
https://issues.apache.org/jira/browse/LOG4J2-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Piotr Karwasz resolved LOG4J2-1514.
---
Resolution: Won't Fix
Closing this, since Zookeeper moved to SLF4J + Logback instead.
>
nmck257 opened a new pull request, #8:
URL: https://github.com/apache/logging-log4j-jmx-gui/pull/8
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
paulonicolau-rj commented on issue #2274:
URL:
https://github.com/apache/logging-log4j2/issues/2274#issuecomment-1936259956
I can´t see this message in stdout, but what I can see is the System
property catalina.home is initilize before the container and so, it is store
the log files in
ppkarwasz commented on PR #8:
URL:
https://github.com/apache/logging-log4j-jmx-gui/pull/8#issuecomment-1936271232
@nmck257,
License information is inherited from the parent POM. This projects inherits
it from its grandparent
ppkarwasz commented on code in PR #102:
URL:
https://github.com/apache/logging-log4j-tools/pull/102#discussion_r1484530747
##
log4j-docgen/src/main/java/org/apache/logging/log4j/docgen/processor/DocGenProcessor.java:
##
@@ -0,0 +1,692 @@
+/*
+ * Licensed to the Apache Software
ppkarwasz commented on PR #102:
URL:
https://github.com/apache/logging-log4j-tools/pull/102#issuecomment-1936210952
I have:
- replace references to annotation classes with `AnnotationMirror`. This way
the code should not fail if they are not present,
- decreased the JDK
github-actions[bot] merged PR #120:
URL: https://github.com/apache/logging-log4j-audit/pull/120
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ppkarwasz closed issue #2238: Avoid a slow exception catch in
JdkMapAdapterStringMap constructor
URL: https://github.com/apache/logging-log4j2/issues/2238
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
[
https://issues.apache.org/jira/browse/LOG4J2-3416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Piotr Karwasz resolved LOG4J2-3416.
---
Resolution: Not A Problem
Closing this since Tomcat 8.0.33 did not support multi-release
nmck257 commented on PR #8:
URL:
https://github.com/apache/logging-log4j-jmx-gui/pull/8#issuecomment-1936296683
@ppkarwasz -- yeah, you're right. That's my mistake.
Thanks for the speedy feedback!
--
This is an automated message from the Apache Git Service.
To respond to the message,
nmck257 closed pull request #8: adding license element to pom.xml, matching
LICENSE in repo root
URL: https://github.com/apache/logging-log4j-jmx-gui/pull/8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
ppkarwasz closed issue #1956: Extract configuration metadata from source code
URL: https://github.com/apache/logging-log4j2/issues/1956
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
ppkarwasz merged PR #102:
URL: https://github.com/apache/logging-log4j-tools/pull/102
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ppkarwasz commented on issue #1283:
URL:
https://github.com/apache/logging-log4j2/issues/1283#issuecomment-1936243610
@smalljunHw,
Should we replace the `ERROR` message with a more appropriate `WARN` message?
--
This is an automated message from the Apache Git Service.
To respond
dependabot[bot] opened a new pull request, #120:
URL: https://github.com/apache/logging-log4j-audit/pull/120
Bumps [commons-codec:commons-codec](https://github.com/apache/commons-codec)
from 1.16.0 to 1.16.1.
Changelog
Sourced from
ppkarwasz commented on issue #2274:
URL:
https://github.com/apache/logging-log4j2/issues/2274#issuecomment-1936202143
@paulonicolau-rj,
When you add other elements before `` you get a ""Properties
declaration must be the first element in the configuration" error message on
your
rocketraman commented on PR #65:
URL:
https://github.com/apache/logging-log4j-kotlin/pull/65#issuecomment-1936213971
> You need to look at the end of the BND report:
@ppkarwasz Thank you, my brain was confused between MAJOR/MINOR so I was
looking at the wrong place in the report.
ppkarwasz closed issue #2234: `RingBufferLogEvent` does not `clear()` the
`threadName`
URL: https://github.com/apache/logging-log4j2/issues/2234
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
ppkarwasz closed issue #2221: Update `StatusLogger` to avoid using
`PropertiesUtil` and service loading
URL: https://github.com/apache/logging-log4j2/issues/2221
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
[
https://issues.apache.org/jira/browse/LOG4J2-3412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Piotr Karwasz resolved LOG4J2-3412.
---
Resolution: Fixed
Closing this, since documentation will be generated in
FreeAndNil commented on issue #111:
URL:
https://github.com/apache/logging-log4net/issues/111#issuecomment-1936525782
+1 from me.
I think supporting net462 & netstandard2.0 is enough for everyone who is
able and willing to upgrade their depencies to newer versions.
--
This is an
FreeAndNil merged PR #105:
URL: https://github.com/apache/logging-log4net/pull/105
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
vy commented on code in PR #2275:
URL: https://github.com/apache/logging-log4j2/pull/2275#discussion_r1484765710
##
log4j-api/src/main/java/org/apache/logging/log4j/message/ReusableParameterizedMessage.java:
##
@@ -32,10 +33,18 @@
@PerformanceSensitive("allocation")
public
vy commented on PR #2275:
URL: https://github.com/apache/logging-log4j2/pull/2275#issuecomment-1936545986
> I would prefer a fix with the minimal amount of LOCs required.
You are right. I have changed the implementation as you suggested and it
indeed looks better. :100: Thanks for
ppkarwasz commented on PR #2271:
URL: https://github.com/apache/logging-log4j2/pull/2271#issuecomment-1936563269
I am the one that submitted the PR to JeroMQ that adds a real module
descriptor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
vy commented on code in PR #65:
URL:
https://github.com/apache/logging-log4j-kotlin/pull/65#discussion_r1484758241
##
src/changelog/1.5.0/add-coroutine-context-convenience-functions.xml:
##
Review Comment:
This files needs to go into `.1.x.x` folder containing the
ppkarwasz commented on PR #2271:
URL: https://github.com/apache/logging-log4j2/pull/2271#issuecomment-1936550171
The change in module name was addressed here:
090123c64f111455da55f944314f6055b9694007
--
This is an automated message from the Apache Git Service.
To respond to the message,
vy commented on PR #2271:
URL: https://github.com/apache/logging-log4j2/pull/2271#issuecomment-1936554699
> The change in module name was addressed here:
090123c64f111455da55f944314f6055b9694007
How did you notice the change?
--
This is an automated message from the Apache
ppkarwasz opened a new pull request, #2278:
URL: https://github.com/apache/logging-log4j2/pull/2278
Until now the `` element had to be the first child of
``. In the current architecture this restriction is no longer
necessary and can be lifted.
This is related to #2274.
--
rocketraman commented on code in PR #65:
URL:
https://github.com/apache/logging-log4j-kotlin/pull/65#discussion_r1484888098
##
src/changelog/1.5.0/.release.xml:
##
Review Comment:
That's what I thought but when I pushed to the branch without it, the build
failed. I feel
53 matches
Mail list logo