[PR] Fix `StringBuilder` cache corruption on recursive access (logging-log4j2)

2024-02-09 Thread via GitHub
vy opened a new pull request, #2275: URL: https://github.com/apache/logging-log4j2/pull/2275 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] Fix `StringBuilder` cache corruption on recursive access (logging-log4j2)

2024-02-09 Thread via GitHub
ppkarwasz commented on code in PR #2275: URL: https://github.com/apache/logging-log4j2/pull/2275#discussion_r1484206125 ## log4j-api/src/main/java/org/apache/logging/log4j/message/ReusableParameterizedMessage.java: ## @@ -32,10 +33,18 @@ @PerformanceSensitive("allocation")

[PR] Bump commons-codec:commons-codec from 1.16.0 to 1.16.1 [logging-parent]

2024-02-09 Thread via GitHub
dependabot[bot] opened a new pull request, #115: URL: https://github.com/apache/logging-parent/pull/115 Bumps [commons-codec:commons-codec](https://github.com/apache/commons-codec) from 1.16.0 to 1.16.1. Changelog Sourced from

Re: [PR] Bump commons-codec:commons-codec from 1.16.0 to 1.16.1 [logging-parent]

2024-02-09 Thread via GitHub
github-actions[bot] merged PR #115: URL: https://github.com/apache/logging-parent/pull/115 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Bump commons-codec:commons-codec from 1.16.0 to 1.16.1 (logging-log4j2)

2024-02-09 Thread via GitHub
github-actions[bot] closed pull request #2276: Bump commons-codec:commons-codec from 1.16.0 to 1.16.1 URL: https://github.com/apache/logging-log4j2/pull/2276 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[I] Cross-database testing [logging-log4net]

2024-02-09 Thread via GitHub
fluffynuts opened a new issue, #107: URL: https://github.com/apache/logging-log4net/issues/107 Log4Net can log to multiple backends, including multiple database backends. I've seen a situation before where a patch to improve performance for postgresql negatively impacted mssql users

Re: [I] Custom Level and Properties does not work together (logging-log4j2)

2024-02-09 Thread via GitHub
paulonicolau-rj commented on issue #2274: URL: https://github.com/apache/logging-log4j2/issues/2274#issuecomment-1935867284 > Switch the order of `` and ``: > > ``` > > >${sys:catalina.home}/logs > > > > > > >

[I] Release automation (for the most part) [logging-log4net]

2024-02-09 Thread via GitHub
fluffynuts opened a new issue, #108: URL: https://github.com/apache/logging-log4net/issues/108 The [RELEASING.md](https://github.com/apache/logging-log4net/blob/master/doc/RELEASING.md) document attempts to layout each and every step, in order, that is required to get log4net updates to

Re: [I] Custom Level and Properties does not work together (logging-log4j2)

2024-02-09 Thread via GitHub
ppkarwasz commented on issue #2274: URL: https://github.com/apache/logging-log4j2/issues/2274#issuecomment-1935935069 Use: ```xml ``` Unlike XML attributes, the content of the `` element is not interpolated. This might actually be a bug:

[I] Fix dotnet (ie not netfx) test run [logging-log4net]

2024-02-09 Thread via GitHub
fluffynuts opened a new issue, #109: URL: https://github.com/apache/logging-log4net/issues/109 If you run `npm run run-dotnet-core-tests`, the test assembly should be run with `dotnet` instead of the nunit runner. This should be used to verify that cross-framework code works as expected.

[I] Dropping support for older runtimes [logging-log4net]

2024-02-09 Thread via GitHub
fluffynuts opened a new issue, #111: URL: https://github.com/apache/logging-log4net/issues/111 Log4net supports a lot of really old runtimes, including net2.0 and net3.5 _CE_ (Compact Edition) which can be notoriously difficult to install on windows (I've been lucky and unlucky - today, it

Re: [I] Custom Level and Properties does not work together (logging-log4j2)

2024-02-09 Thread via GitHub
paulonicolau-rj commented on issue #2274: URL: https://github.com/apache/logging-log4j2/issues/2274#issuecomment-1935967538 So, it worked fully. But, I consider the first report a bug too. Thanks friend! -- This is an automated message from the Apache Git Service. To respond to the

[I] Enable automatic test runs on commit [logging-log4net]

2024-02-09 Thread via GitHub
fluffynuts opened a new issue, #106: URL: https://github.com/apache/logging-log4net/issues/106 It would be highly beneficial to the project to have automatic test runs (`npm test`) for every commit. To this end, a GitHub action that (eventually) invokes `npm test` would be fantastic. --

[I] NPM script to generate beta packages [logging-log4net]

2024-02-09 Thread via GitHub
fluffynuts opened a new issue, #110: URL: https://github.com/apache/logging-log4net/issues/110 Beta nuget packages have a version appendage, eg `-r1`, or the more descriptive `-{datestamp}-{commit_sha}`; `zarro` already supports generating packages in this format, so actually producing the

Re: [PR] ⬆️ Bump xml2js and zarro [logging-log4net]

2024-02-09 Thread via GitHub
fluffynuts closed pull request #102: ⬆️ Bump xml2js and zarro URL: https://github.com/apache/logging-log4net/pull/102 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] ⬆️ Bump xml2js and zarro [logging-log4net]

2024-02-09 Thread via GitHub
fluffynuts commented on PR #102: URL: https://github.com/apache/logging-log4net/pull/102#issuecomment-1935909177 I've updated zarro to latest, invalidating this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [I] FMT macros fail to build with no arguments [logging-log4cxx]

2024-02-09 Thread via GitHub
rm5248 closed issue #344: FMT macros fail to build with no arguments URL: https://github.com/apache/logging-log4cxx/issues/344 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Guard LOG4CXX_FMT_VA_ARG so users can override if needed [logging-log4cxx]

2024-02-09 Thread via GitHub
rm5248 merged PR #346: URL: https://github.com/apache/logging-log4cxx/pull/346 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] Logging overhead due to unnecessary pessimism [logging-log4cxx]

2024-02-09 Thread via GitHub
swebb2066 commented on issue #347: URL: https://github.com/apache/logging-log4cxx/issues/347#issuecomment-1936895018 On Windows, the benchmark comparisons using a lock (old) and without locking (new) in `AppenderAttachableImpl::appendLoopOnAppenders` are: | Benchmark | Time | CPU |

Re: [PR] Add annotation processor to generate documentation [logging-log4j-tools]

2024-02-09 Thread via GitHub
ppkarwasz commented on code in PR #102: URL: https://github.com/apache/logging-log4j-tools/pull/102#discussion_r1484531862 ## log4j-docgen/src/main/java/org/apache/logging/log4j/docgen/processor/DocGenProcessor.java: ## @@ -0,0 +1,692 @@ +/* + * Licensed to the Apache Software

Re: [PR] Add annotation processor to generate documentation [logging-log4j-tools]

2024-02-09 Thread via GitHub
ppkarwasz commented on code in PR #102: URL: https://github.com/apache/logging-log4j-tools/pull/102#discussion_r1484532155 ## log4j-docgen/src/test/java/org/apache/logging/log4j/docgen/processor/DocGenProcessorTest.java: ## Review Comment: Done -- This is an automated

Re: [I] JMX integration should be split into its own module (logging-log4j2)

2024-02-09 Thread via GitHub
ppkarwasz closed issue #1344: JMX integration should be split into its own module URL: https://github.com/apache/logging-log4j2/issues/1344 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] JMX integration should be split into its own module (logging-log4j2)

2024-02-09 Thread via GitHub
ppkarwasz commented on issue #1344: URL: https://github.com/apache/logging-log4j2/issues/1344#issuecomment-1936237656 Closing this, since JMX has been removed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Resolved] (LOG4J2-1514) Help Apache Zookeeper project to upgrade from Log4j 1.x to 2.x

2024-02-09 Thread Piotr Karwasz (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Karwasz resolved LOG4J2-1514. --- Resolution: Won't Fix Closing this, since Zookeeper moved to SLF4J + Logback instead. >

[PR] adding license element to pom.xml, matching LICENSE in repo root [logging-log4j-jmx-gui]

2024-02-09 Thread via GitHub
nmck257 opened a new pull request, #8: URL: https://github.com/apache/logging-log4j-jmx-gui/pull/8 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [I] Custom Level and Properties does not work together (logging-log4j2)

2024-02-09 Thread via GitHub
paulonicolau-rj commented on issue #2274: URL: https://github.com/apache/logging-log4j2/issues/2274#issuecomment-1936259956 I can´t see this message in stdout, but what I can see is the System property catalina.home is initilize before the container and so, it is store the log files in

Re: [PR] adding license element to pom.xml, matching LICENSE in repo root [logging-log4j-jmx-gui]

2024-02-09 Thread via GitHub
ppkarwasz commented on PR #8: URL: https://github.com/apache/logging-log4j-jmx-gui/pull/8#issuecomment-1936271232 @nmck257, License information is inherited from the parent POM. This projects inherits it from its grandparent

Re: [PR] Add annotation processor to generate documentation [logging-log4j-tools]

2024-02-09 Thread via GitHub
ppkarwasz commented on code in PR #102: URL: https://github.com/apache/logging-log4j-tools/pull/102#discussion_r1484530747 ## log4j-docgen/src/main/java/org/apache/logging/log4j/docgen/processor/DocGenProcessor.java: ## @@ -0,0 +1,692 @@ +/* + * Licensed to the Apache Software

Re: [PR] Add annotation processor to generate documentation [logging-log4j-tools]

2024-02-09 Thread via GitHub
ppkarwasz commented on PR #102: URL: https://github.com/apache/logging-log4j-tools/pull/102#issuecomment-1936210952 I have: - replace references to annotation classes with `AnnotationMirror`. This way the code should not fail if they are not present, - decreased the JDK

Re: [PR] Bump commons-codec:commons-codec from 1.16.0 to 1.16.1 [logging-log4j-audit]

2024-02-09 Thread via GitHub
github-actions[bot] merged PR #120: URL: https://github.com/apache/logging-log4j-audit/pull/120 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] Avoid a slow exception catch in JdkMapAdapterStringMap constructor (logging-log4j2)

2024-02-09 Thread via GitHub
ppkarwasz closed issue #2238: Avoid a slow exception catch in JdkMapAdapterStringMap constructor URL: https://github.com/apache/logging-log4j2/issues/2238 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Resolved] (LOG4J2-3416) Line Number Not getting printed in log file

2024-02-09 Thread Piotr Karwasz (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Karwasz resolved LOG4J2-3416. --- Resolution: Not A Problem Closing this since Tomcat 8.0.33 did not support multi-release

Re: [PR] adding license element to pom.xml, matching LICENSE in repo root [logging-log4j-jmx-gui]

2024-02-09 Thread via GitHub
nmck257 commented on PR #8: URL: https://github.com/apache/logging-log4j-jmx-gui/pull/8#issuecomment-1936296683 @ppkarwasz -- yeah, you're right. That's my mistake. Thanks for the speedy feedback! -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] adding license element to pom.xml, matching LICENSE in repo root [logging-log4j-jmx-gui]

2024-02-09 Thread via GitHub
nmck257 closed pull request #8: adding license element to pom.xml, matching LICENSE in repo root URL: https://github.com/apache/logging-log4j-jmx-gui/pull/8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [I] Extract configuration metadata from source code (logging-log4j2)

2024-02-09 Thread via GitHub
ppkarwasz closed issue #1956: Extract configuration metadata from source code URL: https://github.com/apache/logging-log4j2/issues/1956 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Add annotation processor to generate documentation [logging-log4j-tools]

2024-02-09 Thread via GitHub
ppkarwasz merged PR #102: URL: https://github.com/apache/logging-log4j-tools/pull/102 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] Hide PosixViewAttribute related error info in Windows (logging-log4j2)

2024-02-09 Thread via GitHub
ppkarwasz commented on issue #1283: URL: https://github.com/apache/logging-log4j2/issues/1283#issuecomment-1936243610 @smalljunHw, Should we replace the `ERROR` message with a more appropriate `WARN` message? -- This is an automated message from the Apache Git Service. To respond

[PR] Bump commons-codec:commons-codec from 1.16.0 to 1.16.1 [logging-log4j-audit]

2024-02-09 Thread via GitHub
dependabot[bot] opened a new pull request, #120: URL: https://github.com/apache/logging-log4j-audit/pull/120 Bumps [commons-codec:commons-codec](https://github.com/apache/commons-codec) from 1.16.0 to 1.16.1. Changelog Sourced from

Re: [I] Custom Level and Properties does not work together (logging-log4j2)

2024-02-09 Thread via GitHub
ppkarwasz commented on issue #2274: URL: https://github.com/apache/logging-log4j2/issues/2274#issuecomment-1936202143 @paulonicolau-rj, When you add other elements before `` you get a ""Properties declaration must be the first element in the configuration" error message on your

Re: [PR] Logging context convenience functions for coroutines [logging-log4j-kotlin]

2024-02-09 Thread via GitHub
rocketraman commented on PR #65: URL: https://github.com/apache/logging-log4j-kotlin/pull/65#issuecomment-1936213971 > You need to look at the end of the BND report: @ppkarwasz Thank you, my brain was confused between MAJOR/MINOR so I was looking at the wrong place in the report.

Re: [I] `RingBufferLogEvent` does not `clear()` the `threadName` (logging-log4j2)

2024-02-09 Thread via GitHub
ppkarwasz closed issue #2234: `RingBufferLogEvent` does not `clear()` the `threadName` URL: https://github.com/apache/logging-log4j2/issues/2234 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] Update `StatusLogger` to avoid using `PropertiesUtil` and service loading (logging-log4j2)

2024-02-09 Thread via GitHub
ppkarwasz closed issue #2221: Update `StatusLogger` to avoid using `PropertiesUtil` and service loading URL: https://github.com/apache/logging-log4j2/issues/2221 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Resolved] (LOG4J2-3412) Rolling file does not work with new version of log4j2 2.16 and 2.17.1 versions

2024-02-09 Thread Piotr Karwasz (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Karwasz resolved LOG4J2-3412. --- Resolution: Fixed Closing this, since documentation will be generated in

Re: [I] Dropping support for older runtimes (logging-log4net)

2024-02-09 Thread via GitHub
FreeAndNil commented on issue #111: URL: https://github.com/apache/logging-log4net/issues/111#issuecomment-1936525782 +1 from me. I think supporting net462 & netstandard2.0 is enough for everyone who is able and willing to upgrade their depencies to newer versions. -- This is an

Re: [PR] Fix CodeQL Password in configuration file Rule False Positives (logging-log4net)

2024-02-09 Thread via GitHub
FreeAndNil merged PR #105: URL: https://github.com/apache/logging-log4net/pull/105 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Fix `StringBuilder` cache corruption on recursive access (logging-log4j2)

2024-02-09 Thread via GitHub
vy commented on code in PR #2275: URL: https://github.com/apache/logging-log4j2/pull/2275#discussion_r1484765710 ## log4j-api/src/main/java/org/apache/logging/log4j/message/ReusableParameterizedMessage.java: ## @@ -32,10 +33,18 @@ @PerformanceSensitive("allocation") public

Re: [PR] Fix `StringBuilder` cache corruption on recursive access (logging-log4j2)

2024-02-09 Thread via GitHub
vy commented on PR #2275: URL: https://github.com/apache/logging-log4j2/pull/2275#issuecomment-1936545986 > I would prefer a fix with the minimal amount of LOCs required. You are right. I have changed the implementation as you suggested and it indeed looks better. :100: Thanks for

Re: [PR] Bump org.zeromq:jeromq from 0.5.4 to 0.6.0 (logging-log4j2)

2024-02-09 Thread via GitHub
ppkarwasz commented on PR #2271: URL: https://github.com/apache/logging-log4j2/pull/2271#issuecomment-1936563269 I am the one that submitted the PR to JeroMQ that adds a real module descriptor. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] Logging context convenience functions for coroutines [logging-log4j-kotlin]

2024-02-09 Thread via GitHub
vy commented on code in PR #65: URL: https://github.com/apache/logging-log4j-kotlin/pull/65#discussion_r1484758241 ## src/changelog/1.5.0/add-coroutine-context-convenience-functions.xml: ## Review Comment: This files needs to go into `.1.x.x` folder containing the

Re: [PR] Bump org.zeromq:jeromq from 0.5.4 to 0.6.0 (logging-log4j2)

2024-02-09 Thread via GitHub
ppkarwasz commented on PR #2271: URL: https://github.com/apache/logging-log4j2/pull/2271#issuecomment-1936550171 The change in module name was addressed here: 090123c64f111455da55f944314f6055b9694007 -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Bump org.zeromq:jeromq from 0.5.4 to 0.6.0 (logging-log4j2)

2024-02-09 Thread via GitHub
vy commented on PR #2271: URL: https://github.com/apache/logging-log4j2/pull/2271#issuecomment-1936554699 > The change in module name was addressed here: 090123c64f111455da55f944314f6055b9694007 How did you notice the change? -- This is an automated message from the Apache

[PR] Allow arbitrary position of `` element (logging-log4j2)

2024-02-09 Thread via GitHub
ppkarwasz opened a new pull request, #2278: URL: https://github.com/apache/logging-log4j2/pull/2278 Until now the `` element had to be the first child of ``. In the current architecture this restriction is no longer necessary and can be lifted. This is related to #2274. --

Re: [PR] Logging context convenience functions for coroutines [logging-log4j-kotlin]

2024-02-09 Thread via GitHub
rocketraman commented on code in PR #65: URL: https://github.com/apache/logging-log4j-kotlin/pull/65#discussion_r1484888098 ## src/changelog/1.5.0/.release.xml: ## Review Comment: That's what I thought but when I pushed to the branch without it, the build failed. I feel