[jira] [Commented] (LOG4J2-2123) logger filter in composite logger not combined properly

2017-12-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16285544#comment-16285544 ] ASF GitHub Bot commented on LOG4J2-2123: Github user asfgit closed the pull reque

[GitHub] logging-log4j2 pull request #135: [LOG4J2-2123] DefaultMergeStrategy did not...

2017-12-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/logging-log4j2/pull/135 ---

[jira] [Resolved] (LOG4J2-2123) logger filter in composite logger not combined properly

2017-12-10 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ralph Goers resolved LOG4J2-2123. - Resolution: Fixed Fix Version/s: 2.10.1 Patch applied - Please verify and close. > logger

[jira] [Commented] (LOG4J2-2123) logger filter in composite logger not combined properly

2017-12-10 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16285530#comment-16285530 ] ASF subversion and git services commented on LOG4J2-2123: - Commit

[jira] [Commented] (LOG4J2-2123) logger filter in composite logger not combined properly

2017-12-10 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16285531#comment-16285531 ] ASF subversion and git services commented on LOG4J2-2123: - Commit

[GitHub] logging-log4j2 issue #138: POC: declarative runtime null-checks

2017-12-10 Thread denis-zhdanov
Github user denis-zhdanov commented on the issue: https://github.com/apache/logging-log4j2/pull/138 Makes sense, thanks. This PR can be closed then as *Traute* is a *javac* plugin and that *API* is available since *javac8* ---

[GitHub] logging-log4j2 pull request #138: POC: declarative runtime null-checks

2017-12-10 Thread denis-zhdanov
Github user denis-zhdanov closed the pull request at: https://github.com/apache/logging-log4j2/pull/138 ---

[GitHub] logging-log4j2 issue #138: POC: declarative runtime null-checks

2017-12-10 Thread remkop
Github user remkop commented on the issue: https://github.com/apache/logging-log4j2/pull/138 @denis-zhdanov The 1.8 javac compiler will recognize and reject new language constructs like lambdas, but it cannot check at the API (library) level. For example `Files.readAllLines(

[GitHub] logging-log4j2 issue #138: POC: declarative runtime null-checks

2017-12-10 Thread denis-zhdanov
Github user denis-zhdanov commented on the issue: https://github.com/apache/logging-log4j2/pull/138 Sorry, re-checked *javac* documentation and the right argument is *-source*. E.g. here is what I get on attempt to compile a source below: ```java package org;

[GitHub] logging-log4j2 issue #138: POC: declarative runtime null-checks

2017-12-10 Thread garydgregory
Github user garydgregory commented on the issue: https://github.com/apache/logging-log4j2/pull/138 javac -target 1.7 just tells the compiler to generate 1.7 byte codes; it does nothing to avoid calling Java 8, 9 or 10 APIs. ---

[GitHub] logging-log4j2 issue #138: POC: declarative runtime null-checks

2017-12-10 Thread denis-zhdanov
Github user denis-zhdanov commented on the issue: https://github.com/apache/logging-log4j2/pull/138 But *javac -target 1.7* provides that level of confidence, doesn't it? ---

[GitHub] logging-log4j2 issue #138: POC: declarative runtime null-checks

2017-12-10 Thread rgoers
Github user rgoers commented on the issue: https://github.com/apache/logging-log4j2/pull/138 To be 100% certain that we didn't reference anything from Java 8 by accident. ---

[GitHub] logging-log4j2 issue #138: POC: declarative runtime null-checks

2017-12-10 Thread denis-zhdanov
Github user denis-zhdanov commented on the issue: https://github.com/apache/logging-log4j2/pull/138 Wow, just curious, why not using javac8? ---

[GitHub] logging-log4j2 issue #138: POC: declarative runtime null-checks

2017-12-10 Thread rgoers
Github user rgoers commented on the issue: https://github.com/apache/logging-log4j2/pull/138 All release builds are done with the Java 7 compiler. ---

[GitHub] logging-log4j2 issue #138: POC: declarative runtime null-checks

2017-12-10 Thread denis-zhdanov
Github user denis-zhdanov commented on the issue: https://github.com/apache/logging-log4j2/pull/138 Hey guys, Thanks for the feedback, a couple of notes: * as [mentioned in the Traute documentation](http://traute.oss.harmonysoft.tech/#3-alternatives), Lombok has a couple

[GitHub] logging-log4j2 issue #138: POC: declarative runtime null-checks

2017-12-10 Thread mikaelstaldal
Github user mikaelstaldal commented on the issue: https://github.com/apache/logging-log4j2/pull/138 I do like the general idea in principle. And I do like the work made by Jetbrains in this area. But I don't think it would be wise to depend on Jetbrains specific annotations i

[GitHub] logging-log4j2 issue #138: POC: declarative runtime null-checks

2017-12-10 Thread garydgregory
Github user garydgregory commented on the issue: https://github.com/apache/logging-log4j2/pull/138 I am -1: If we want something like this, we should use Project Lombok which is well known and feature rich https://projectlombok.org/features/NonNull ---

[GitHub] logging-log4j2 pull request #138: POC: declarative runtime null-checks

2017-12-10 Thread denis-zhdanov
GitHub user denis-zhdanov opened a pull request: https://github.com/apache/logging-log4j2/pull/138 POC: declarative runtime null-checks Hello, I'd like to contribute to log4j by replacing explicit *Objects.requireNonNull()* checks by parameter's *NotNull* annotation and *j

[jira] [Updated] (LOG4NET-584) MaxSizeRollBackups can not works

2017-12-10 Thread sun lixiang (JIRA)
[ https://issues.apache.org/jira/browse/LOG4NET-584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sun lixiang updated LOG4NET-584: Docs Text: when set the ,the can not works. The issus is caused by func. RollingFileA

[jira] [Updated] (LOG4NET-584) MaxSizeRollBackups can not works

2017-12-10 Thread sun lixiang (JIRA)
[ https://issues.apache.org/jira/browse/LOG4NET-584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sun lixiang updated LOG4NET-584: Docs Text: when set the ,the can not works. The issus is caused by func. RollingFileA

[jira] [Updated] (LOG4NET-584) MaxSizeRollBackups can not works

2017-12-10 Thread sun lixiang (JIRA)
[ https://issues.apache.org/jira/browse/LOG4NET-584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sun lixiang updated LOG4NET-584: Docs Text: when set the ,the can not works. The issus is caused by func. RollingFileA

[jira] [Created] (LOG4NET-584) MaxSizeRollBackups can not works

2017-12-10 Thread sun lixiang (JIRA)
sun lixiang created LOG4NET-584: --- Summary: MaxSizeRollBackups can not works Key: LOG4NET-584 URL: https://issues.apache.org/jira/browse/LOG4NET-584 Project: Log4net Issue Type: Bug Co