[jira] [Closed] (LOG4J2-2301) gc-free mixed async loging loses parameter values after the first appender
[ https://issues.apache.org/jira/browse/LOG4J2-2301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carter Kozak closed LOG4J2-2301. > gc-free mixed async loging loses parameter values after the first appender > -- > > Key: LOG4J2-2301 > URL: https://issues.apache.org/jira/browse/LOG4J2-2301 > Project: Log4j 2 > Issue Type: Bug > Components: Core >Affects Versions: 2.11.0 >Reporter: Carter Kozak >Assignee: Carter Kozak >Priority: Major > Fix For: 3.0.0, 2.11.1 > > > When gc-free logging is used with mixed synchronous/asynchronous loggers, > parameter values are replaced with "null" after the first AsyncLoggerConfig. > The message format is still present, as well as the parameter count, however > all values are nulls. > It appears that Log4jEventWrapperHandler.onEvent invokes > MutableLogEvent.clear, which nulls out the parameter array. > I have constructed a failing test (which I need to clean up and deduplicate > some code from the fix for LOG4J2-2299): > https://github.com/cakofony/logging-log4j2/commit/b9c03f5c6881bfe778f8e2d75d046ce6e021c4f1 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (LOG4J2-2301) gc-free mixed async loging loses parameter values after the first appender
[ https://issues.apache.org/jira/browse/LOG4J2-2301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459387#comment-16459387 ] ASF subversion and git services commented on LOG4J2-2301: - Commit b34d8cc585368db51cc84e916a257d55de44e8d0 in logging-log4j2's branch refs/heads/release-2.x from [~ckozak] [ https://git-wip-us.apache.org/repos/asf?p=logging-log4j2.git;h=b34d8cc ] [LOG4J2-2301] Mixed async loggers no longer forget parameter values Previously each AsyncLoggerConfig would individually enqueue an event on the async delegate disruptor. In practice this caused us to trade reusable message parameters away at the first AsyncLoggerConfig in our path, causing the rest to get an array of nulls. Now we begin by traversing the configuration and logging to all synchronous loggers first, then enqueue the event to the highest level asynchronous logger allowing the asynchronous loggers to be traversed on the background thread. > gc-free mixed async loging loses parameter values after the first appender > -- > > Key: LOG4J2-2301 > URL: https://issues.apache.org/jira/browse/LOG4J2-2301 > Project: Log4j 2 > Issue Type: Bug > Components: Core >Affects Versions: 2.11.0 >Reporter: Carter Kozak >Assignee: Carter Kozak >Priority: Major > Fix For: 3.0.0, 2.11.1 > > > When gc-free logging is used with mixed synchronous/asynchronous loggers, > parameter values are replaced with "null" after the first AsyncLoggerConfig. > The message format is still present, as well as the parameter count, however > all values are nulls. > It appears that Log4jEventWrapperHandler.onEvent invokes > MutableLogEvent.clear, which nulls out the parameter array. > I have constructed a failing test (which I need to clean up and deduplicate > some code from the fix for LOG4J2-2299): > https://github.com/cakofony/logging-log4j2/commit/b9c03f5c6881bfe778f8e2d75d046ce6e021c4f1 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (LOG4J2-2301) gc-free mixed async loging loses parameter values after the first appender
[ https://issues.apache.org/jira/browse/LOG4J2-2301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carter Kozak resolved LOG4J2-2301. -- Resolution: Fixed > gc-free mixed async loging loses parameter values after the first appender > -- > > Key: LOG4J2-2301 > URL: https://issues.apache.org/jira/browse/LOG4J2-2301 > Project: Log4j 2 > Issue Type: Bug > Components: Core >Affects Versions: 2.11.0 >Reporter: Carter Kozak >Assignee: Carter Kozak >Priority: Major > Fix For: 3.0.0, 2.11.1 > > > When gc-free logging is used with mixed synchronous/asynchronous loggers, > parameter values are replaced with "null" after the first AsyncLoggerConfig. > The message format is still present, as well as the parameter count, however > all values are nulls. > It appears that Log4jEventWrapperHandler.onEvent invokes > MutableLogEvent.clear, which nulls out the parameter array. > I have constructed a failing test (which I need to clean up and deduplicate > some code from the fix for LOG4J2-2299): > https://github.com/cakofony/logging-log4j2/commit/b9c03f5c6881bfe778f8e2d75d046ce6e021c4f1 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (LOG4J2-2301) gc-free mixed async loging loses parameter values after the first appender
[ https://issues.apache.org/jira/browse/LOG4J2-2301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459386#comment-16459386 ] ASF subversion and git services commented on LOG4J2-2301: - Commit fb453229457fb70467576002d8cb96f21143ea77 in logging-log4j2's branch refs/heads/release-2.x from [~ckozak] [ https://git-wip-us.apache.org/repos/asf?p=logging-log4j2.git;h=fb45322 ] Add an ignored failing test for LOG4J2-2301 > gc-free mixed async loging loses parameter values after the first appender > -- > > Key: LOG4J2-2301 > URL: https://issues.apache.org/jira/browse/LOG4J2-2301 > Project: Log4j 2 > Issue Type: Bug > Components: Core >Affects Versions: 2.11.0 >Reporter: Carter Kozak >Assignee: Carter Kozak >Priority: Major > Fix For: 3.0.0, 2.11.1 > > > When gc-free logging is used with mixed synchronous/asynchronous loggers, > parameter values are replaced with "null" after the first AsyncLoggerConfig. > The message format is still present, as well as the parameter count, however > all values are nulls. > It appears that Log4jEventWrapperHandler.onEvent invokes > MutableLogEvent.clear, which nulls out the parameter array. > I have constructed a failing test (which I need to clean up and deduplicate > some code from the fix for LOG4J2-2299): > https://github.com/cakofony/logging-log4j2/commit/b9c03f5c6881bfe778f8e2d75d046ce6e021c4f1 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (LOG4J2-2301) gc-free mixed async loging loses parameter values after the first appender
[ https://issues.apache.org/jira/browse/LOG4J2-2301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carter Kozak updated LOG4J2-2301: - Fix Version/s: 2.11.1 3.0.0 > gc-free mixed async loging loses parameter values after the first appender > -- > > Key: LOG4J2-2301 > URL: https://issues.apache.org/jira/browse/LOG4J2-2301 > Project: Log4j 2 > Issue Type: Bug > Components: Core >Affects Versions: 2.11.0 >Reporter: Carter Kozak >Assignee: Carter Kozak >Priority: Major > Fix For: 3.0.0, 2.11.1 > > > When gc-free logging is used with mixed synchronous/asynchronous loggers, > parameter values are replaced with "null" after the first AsyncLoggerConfig. > The message format is still present, as well as the parameter count, however > all values are nulls. > It appears that Log4jEventWrapperHandler.onEvent invokes > MutableLogEvent.clear, which nulls out the parameter array. > I have constructed a failing test (which I need to clean up and deduplicate > some code from the fix for LOG4J2-2299): > https://github.com/cakofony/logging-log4j2/commit/b9c03f5c6881bfe778f8e2d75d046ce6e021c4f1 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (LOG4J2-2301) gc-free mixed async loging loses parameter values after the first appender
[ https://issues.apache.org/jira/browse/LOG4J2-2301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459376#comment-16459376 ] Carter Kozak commented on LOG4J2-2301: -- Wonderful, thanks Remko! > gc-free mixed async loging loses parameter values after the first appender > -- > > Key: LOG4J2-2301 > URL: https://issues.apache.org/jira/browse/LOG4J2-2301 > Project: Log4j 2 > Issue Type: Bug > Components: Core >Affects Versions: 2.11.0 >Reporter: Carter Kozak >Assignee: Carter Kozak >Priority: Major > Fix For: 3.0.0, 2.11.1 > > > When gc-free logging is used with mixed synchronous/asynchronous loggers, > parameter values are replaced with "null" after the first AsyncLoggerConfig. > The message format is still present, as well as the parameter count, however > all values are nulls. > It appears that Log4jEventWrapperHandler.onEvent invokes > MutableLogEvent.clear, which nulls out the parameter array. > I have constructed a failing test (which I need to clean up and deduplicate > some code from the fix for LOG4J2-2299): > https://github.com/cakofony/logging-log4j2/commit/b9c03f5c6881bfe778f8e2d75d046ce6e021c4f1 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (LOG4J2-2301) gc-free mixed async loging loses parameter values after the first appender
[ https://issues.apache.org/jira/browse/LOG4J2-2301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459375#comment-16459375 ] ASF subversion and git services commented on LOG4J2-2301: - Commit d3744807daf27638e1eb0a8f0d41bb7ff1061dde in logging-log4j2's branch refs/heads/master from [~ckozak] [ https://git-wip-us.apache.org/repos/asf?p=logging-log4j2.git;h=d374480 ] [LOG4J2-2301] Mixed async loggers no longer forget parameter values Previously each AsyncLoggerConfig would individually enqueue an event on the async delegate disruptor. In practice this caused us to trade reusable message parameters away at the first AsyncLoggerConfig in our path, causing the rest to get an array of nulls. Now we begin by traversing the configuration and logging to all synchronous loggers first, then enqueue the event to the highest level asynchronous logger allowing the asynchronous loggers to be traversed on the background thread. > gc-free mixed async loging loses parameter values after the first appender > -- > > Key: LOG4J2-2301 > URL: https://issues.apache.org/jira/browse/LOG4J2-2301 > Project: Log4j 2 > Issue Type: Bug > Components: Core >Affects Versions: 2.11.0 >Reporter: Carter Kozak >Assignee: Carter Kozak >Priority: Major > > When gc-free logging is used with mixed synchronous/asynchronous loggers, > parameter values are replaced with "null" after the first AsyncLoggerConfig. > The message format is still present, as well as the parameter count, however > all values are nulls. > It appears that Log4jEventWrapperHandler.onEvent invokes > MutableLogEvent.clear, which nulls out the parameter array. > I have constructed a failing test (which I need to clean up and deduplicate > some code from the fix for LOG4J2-2299): > https://github.com/cakofony/logging-log4j2/commit/b9c03f5c6881bfe778f8e2d75d046ce6e021c4f1 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (LOG4J2-2301) gc-free mixed async loging loses parameter values after the first appender
[ https://issues.apache.org/jira/browse/LOG4J2-2301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459364#comment-16459364 ] Remko Popma commented on LOG4J2-2301: - I had another look and I have no objections. Nice work! > gc-free mixed async loging loses parameter values after the first appender > -- > > Key: LOG4J2-2301 > URL: https://issues.apache.org/jira/browse/LOG4J2-2301 > Project: Log4j 2 > Issue Type: Bug > Components: Core >Affects Versions: 2.11.0 >Reporter: Carter Kozak >Assignee: Carter Kozak >Priority: Major > > When gc-free logging is used with mixed synchronous/asynchronous loggers, > parameter values are replaced with "null" after the first AsyncLoggerConfig. > The message format is still present, as well as the parameter count, however > all values are nulls. > It appears that Log4jEventWrapperHandler.onEvent invokes > MutableLogEvent.clear, which nulls out the parameter array. > I have constructed a failing test (which I need to clean up and deduplicate > some code from the fix for LOG4J2-2299): > https://github.com/cakofony/logging-log4j2/commit/b9c03f5c6881bfe778f8e2d75d046ce6e021c4f1 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (LOG4J2-2301) gc-free mixed async loging loses parameter values after the first appender
[ https://issues.apache.org/jira/browse/LOG4J2-2301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459149#comment-16459149 ] Carter Kozak commented on LOG4J2-2301: -- Curious if there are outstanding thoughts or concerns with this change. I'm more than happy to hold off merging if folks prefer, otherwise I'll plan to merge the change tomorrow. > gc-free mixed async loging loses parameter values after the first appender > -- > > Key: LOG4J2-2301 > URL: https://issues.apache.org/jira/browse/LOG4J2-2301 > Project: Log4j 2 > Issue Type: Bug > Components: Core >Affects Versions: 2.11.0 >Reporter: Carter Kozak >Assignee: Carter Kozak >Priority: Major > > When gc-free logging is used with mixed synchronous/asynchronous loggers, > parameter values are replaced with "null" after the first AsyncLoggerConfig. > The message format is still present, as well as the parameter count, however > all values are nulls. > It appears that Log4jEventWrapperHandler.onEvent invokes > MutableLogEvent.clear, which nulls out the parameter array. > I have constructed a failing test (which I need to clean up and deduplicate > some code from the fix for LOG4J2-2299): > https://github.com/cakofony/logging-log4j2/commit/b9c03f5c6881bfe778f8e2d75d046ce6e021c4f1 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (LOG4J2-2329) Fix dependency in log4j-slf4j-impl to slf4j due to CVE-2018-8088
[ https://issues.apache.org/jira/browse/LOG4J2-2329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458983#comment-16458983 ] Gary Gregory commented on LOG4J2-2329: -- What happens when you do a build with the new dependency? > Fix dependency in log4j-slf4j-impl to slf4j due to CVE-2018-8088 > > > Key: LOG4J2-2329 > URL: https://issues.apache.org/jira/browse/LOG4J2-2329 > Project: Log4j 2 > Issue Type: Bug > Components: SLF4J Bridge >Affects Versions: 2.11.0 >Reporter: Sven Kubiak >Priority: Major > > Latest version of log4j-slf4j-impl has a dependency to slf4j-api version > 1.8.0-Alpha2. All version before 1.8.0-Beta2 have vulnerable due to > CVE-2018-8088. > [https://nvd.nist.gov/vuln/detail/CVE-2018-8088] > Can we update to at least 1.8.0-Beta2? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (LOG4J2-2329) Fix dependency in log4j-slf4j-impl to slf4j due to CVE-2018-8088
Sven Kubiak created LOG4J2-2329: --- Summary: Fix dependency in log4j-slf4j-impl to slf4j due to CVE-2018-8088 Key: LOG4J2-2329 URL: https://issues.apache.org/jira/browse/LOG4J2-2329 Project: Log4j 2 Issue Type: Bug Components: SLF4J Bridge Affects Versions: 2.11.0 Reporter: Sven Kubiak Latest version of log4j-slf4j-impl has a dependency to slf4j-api version 1.8.0-Alpha2. All version before 1.8.0-Beta2 have vulnerable due to CVE-2018-8088. [https://nvd.nist.gov/vuln/detail/CVE-2018-8088] Can we update to at least 1.8.0-Beta2? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (LOG4J2-2237) Move Jackson-based layouts to their own modules: JSON, XML, and YAML
[
https://issues.apache.org/jira/browse/LOG4J2-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458392#comment-16458392
]
Mikhail Khludnev commented on LOG4J2-2237:
--
Hello, [~garydgregory]. I've discovered some leftover from this issue. Please
check LOG4J2-2285
> Move Jackson-based layouts to their own modules: JSON, XML, and YAML
>
>
> Key: LOG4J2-2237
> URL: https://issues.apache.org/jira/browse/LOG4J2-2237
> Project: Log4j 2
> Issue Type: Improvement
> Components: Core, Layouts
>Reporter: Gary Gregory
>Assignee: Gary Gregory
>Priority: Major
> Fix For: 3.0.0
>
>
> This is part of removing dependencies from {{log4j-core}} so that we only
> depend on Java 9's {{java.base}} in {{log4j-core}}.
> Move Jackson-based layouts to their own modules:
> * {{log4j-layout-jackson}}
> * {{log4j-layout-jackson-json}}
> * {{log4j-layout-jackson-xml}} brings in XML specific Jackson jar(s)
> * {{log4j-layout-jackson-yaml}} brings in YAML specific Jackson jar(s)
> The module that holds commons Jackson bits is {{log4j-layout-jackson}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
