[jira] [Commented] (LOG4J2-2351) AbstractLogEvent.instant should be protected, not private

2018-06-13 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16511030#comment-16511030 ] ASF subversion and git services commented on LOG4J2-2351: - Commit

[jira] [Commented] (LOG4J2-2351) AbstractLogEvent.instant should be protected, not private

2018-06-13 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16511028#comment-16511028 ] ASF subversion and git services commented on LOG4J2-2351: - Commit

[jira] [Commented] (LOG4J2-2351) AbstractLogEvent.instant should be protected, not private

2018-06-12 Thread Carter Kozak (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509966#comment-16509966 ] Carter Kozak commented on LOG4J2-2351: -- > Have you considered adding a protected

[jira] [Commented] (LOG4J2-2351) AbstractLogEvent.instant should be protected, not private

2018-06-12 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509904#comment-16509904 ] Gary Gregory commented on LOG4J2-2351: -- Have you considered adding a protected getMutableInstant()

[jira] [Commented] (LOG4J2-2351) AbstractLogEvent.instant should be protected, not private

2018-06-12 Thread Carter Kozak (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509879#comment-16509879 ] Carter Kozak commented on LOG4J2-2351: -- That is correct, my goal is to allow classes extending

[jira] [Commented] (LOG4J2-2351) AbstractLogEvent.instant should be protected, not private

2018-06-12 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509836#comment-16509836 ] Ralph Goers commented on LOG4J2-2351: - I see. Since in your patch it is changed to protected only

[jira] [Commented] (LOG4J2-2351) AbstractLogEvent.instant should be protected, not private

2018-06-12 Thread Carter Kozak (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509744#comment-16509744 ] Carter Kozak commented on LOG4J2-2351: -- I agree that the variable could be final so it cannot be

[jira] [Commented] (LOG4J2-2351) AbstractLogEvent.instant should be protected, not private

2018-06-12 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509735#comment-16509735 ] Ralph Goers commented on LOG4J2-2351: - I don't understand the problem being solved here. Why is it a

[jira] [Commented] (LOG4J2-2351) AbstractLogEvent.instant should be protected, not private

2018-06-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509695#comment-16509695 ] ASF GitHub Bot commented on LOG4J2-2351: GitHub user cakofony opened a pull request: