[GitHub] geertjanw commented on issue #432: [NETBEANS-411] remove Xylophone sample with potentially problematic l?

geertjanw commented on issue #432: [NETBEANS-411] remove Xylophone sample with potentially problematic l? URL: https://github.com/apache/incubator-netbeans/pull/432#issuecomment-366869724 They work fine in 8.2, I just tried the Xylophone sample there, no problems. Will take a look as

[GitHub] matthiasblaesing commented on issue #376: [NETBEANS-135] Fix HeapTest on lib.profiler.

matthiasblaesing commented on issue #376: [NETBEANS-135] Fix HeapTest on lib.profiler. URL: https://github.com/apache/incubator-netbeans/pull/376#issuecomment-366811629 I merged this via: https://github.com/apache/incubator-netbeans/commit/accf3e41c77ba23dbfbeacca624038550639da82

[GitHub] cowwoc commented on issue #429: [NETBEANS-402] ClassCastException at org.netbeans.lib.profiler.server?

cowwoc commented on issue #429: [NETBEANS-402] ClassCastException at org.netbeans.lib.profiler.server? URL: https://github.com/apache/incubator-netbeans/pull/429#issuecomment-366803922 @jlahoda How do I request reviews for PR? I noticed you did so in another issue. Does it require

[GitHub] matthiasblaesing commented on issue #432: [NETBEANS-411] remove Xylophone sample with potentially problematic l?

matthiasblaesing commented on issue #432: [NETBEANS-411] remove Xylophone sample with potentially problematic l? URL: https://github.com/apache/incubator-netbeans/pull/432#issuecomment-366793664 I'm fine with removing all the JavaFX samples, as they don't work (neither in 8.2 nor in 9),

[GitHub] Chris2011 commented on issue #431: Make sure the JavaScript coloring prevails inside of Java strings

Chris2011 commented on issue #431: Make sure the JavaScript coloring prevails inside of Java strings URL: https://github.com/apache/incubator-netbeans/pull/431#issuecomment-366715463 @ppisl if there is already such "simple" solution or way, that would be better.

[GitHub] Chris2011 commented on issue #431: Make sure the JavaScript coloring prevails inside of Java strings

Chris2011 commented on issue #431: Make sure the JavaScript coloring prevails inside of Java strings URL: https://github.com/apache/incubator-netbeans/pull/431#issuecomment-366715115 @JaroslavTulach @neilcsmith-net Back to topic, for me it seems okish for the first time. When the next

[GitHub] Chris2011 commented on issue #431: Make sure the JavaScript coloring prevails inside of Java strings

Chris2011 commented on issue #431: Make sure the JavaScript coloring prevails inside of Java strings URL: https://github.com/apache/incubator-netbeans/pull/431#issuecomment-366715115 Back to topic, for me it seems okish for the first time. When the next EmbeddingProvider is coming, we

[GitHub] JaroslavTulach closed pull request #421: Providing exact steps used to rebuild the Equinox JAR

JaroslavTulach closed pull request #421: Providing exact steps used to rebuild the Equinox JAR URL: https://github.com/apache/incubator-netbeans/pull/421 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] neilcsmith-net commented on issue #431: Make sure the JavaScript coloring prevails inside of Java strings

neilcsmith-net commented on issue #431: Make sure the JavaScript coloring prevails inside of Java strings URL: https://github.com/apache/incubator-netbeans/pull/431#issuecomment-366706333 @Chris2011 Bugzilla, not JIRA? That would be a good one to make sure comes across. I'd personally