[GitHub] geertjanw commented on issue #1052: [NETBEANS-1671] Donation 3 - Include installer sources

geertjanw commented on issue #1052: [NETBEANS-1671] Donation 3 - Include installer sources URL: https://github.com/apache/incubator-netbeans/pull/1052#issuecomment-450803634 Good question. What's the license of AdoptOpenJDK? Well, here you can see it is based on OpenJDK, which is GPL, so

[GitHub] peterremote1980 commented on issue #1065: add a search in the "customize toolbar" dialog

peterremote1980 commented on issue #1065: add a search in the "customize toolbar" dialog URL: https://github.com/apache/incubator-netbeans/pull/1065#issuecomment-450795344 > PS: I see GitHub complaining that there are some 'Conflicting files'. So, make sure you also rebase your code

[GitHub] asfgit closed pull request #1063: Updating to Felix 6.0.1

asfgit closed pull request #1063: Updating to Felix 6.0.1 URL: https://github.com/apache/incubator-netbeans/pull/1063 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] jtulach commented on a change in pull request #1064: Snapshot of APIs as of release 10.0

jtulach commented on a change in pull request #1064: Snapshot of APIs as of release 10.0 URL: https://github.com/apache/incubator-netbeans/pull/1064#discussion_r244659441 ## File path: nbbuild/build.xml ## @@ -1776,22 +1776,15 @@ It is possible to use -Ddebug.port=3234

[GitHub] jtulach commented on issue #1067: [NETBEANS-731] Rename AutoHidingMenuBarManualTest to fix test failure

jtulach commented on issue #1067: [NETBEANS-731] Rename AutoHidingMenuBarManualTest to fix test failure URL: https://github.com/apache/incubator-netbeans/pull/1067#issuecomment-450781281 Thanks. The failing test is gone since [build

[GitHub] jtulach commented on issue #1060: [NETBEANS-731] Making the test class a JUnit test

jtulach commented on issue #1060: [NETBEANS-731] Making the test class a JUnit test URL: https://github.com/apache/incubator-netbeans/pull/1060#issuecomment-450781253 Thanks. The failing test is gone since [build

[GitHub] eirikbakke closed pull request #1067: [NETBEANS-731] Rename AutoHidingMenuBarManualTest to fix test failure

eirikbakke closed pull request #1067: [NETBEANS-731] Rename AutoHidingMenuBarManualTest to fix test failure URL: https://github.com/apache/incubator-netbeans/pull/1067 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] eirikbakke commented on issue #1067: [NETBEANS-731] Rename AutoHidingMenuBarManualTest to fix test failure

eirikbakke commented on issue #1067: [NETBEANS-731] Rename AutoHidingMenuBarManualTest to fix test failure URL: https://github.com/apache/incubator-netbeans/pull/1067#issuecomment-450769668 The Travis build succeeded, and the patch fixes the test locally on my machine, so I will now

[GitHub] eirikbakke closed pull request #1060: [NETBEANS-731] Making the test class a JUnit test

eirikbakke closed pull request #1060: [NETBEANS-731] Making the test class a JUnit test URL: https://github.com/apache/incubator-netbeans/pull/1060 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] eirikbakke commented on issue #1060: [NETBEANS-731] Making the test class a JUnit test

eirikbakke commented on issue #1060: [NETBEANS-731] Making the test class a JUnit test URL: https://github.com/apache/incubator-netbeans/pull/1060#issuecomment-450767936 I've prepared the proposed change at https://github.com/apache/incubator-netbeans/pull/1067 ; closing this PR as

[GitHub] eirikbakke opened a new pull request #1067: [NETBEANS-731] Rename AutoHidingMenuBarManualTest to fix test failure

eirikbakke opened a new pull request #1067: [NETBEANS-731] Rename AutoHidingMenuBarManualTest to fix test failure URL: https://github.com/apache/incubator-netbeans/pull/1067 This avoids a "No runnable methods" error while running tests in the core.windows package, due to the

[GitHub] dulaman commented on issue #1052: [NETBEANS-1671] Donation 3 - Include installer sources

dulaman commented on issue #1052: [NETBEANS-1671] Donation 3 - Include installer sources URL: https://github.com/apache/incubator-netbeans/pull/1052#issuecomment-450761602 Will be possible to create installer with AdoptOpenJDK builds?

[GitHub] lkishalmi edited a comment on issue #1061: [NETBEANS-168] Simple least intrustive patch prevent IDE to burn CPU on broken symlinks.

lkishalmi edited a comment on issue #1061: [NETBEANS-168] Simple least intrustive patch prevent IDE to burn CPU on broken symlinks. URL: https://github.com/apache/incubator-netbeans/pull/1061#issuecomment-450760325 Well, I do not really mind if you discuss this issue with @JaroslavTulach

[GitHub] lkishalmi commented on issue #1061: [NETBEANS-168] Simple least intrustive patch prevent IDE to burn CPU on broken symlinks.

lkishalmi commented on issue #1061: [NETBEANS-168] Simple least intrustive patch prevent IDE to burn CPU on broken symlinks. URL: https://github.com/apache/incubator-netbeans/pull/1061#issuecomment-450760325 Well, I do not really mind if you discuss this issue with @JaroslavTulach and or

[GitHub] arsi-apli commented on issue #1061: [NETBEANS-168] Simple least intrustive patch prevent IDE to burn CPU on broken symlinks.

arsi-apli commented on issue #1061: [NETBEANS-168] Simple least intrustive patch prevent IDE to burn CPU on broken symlinks. URL: https://github.com/apache/incubator-netbeans/pull/1061#issuecomment-450758770 The author of the masterfs module did not know that the file.exists() returns

[GitHub] matthiasblaesing commented on issue #1034: NETBEANS-1499 - change package.json icon

matthiasblaesing commented on issue #1034: NETBEANS-1499 - change package.json icon URL: https://github.com/apache/incubator-netbeans/pull/1034#issuecomment-450755017 From a technical perspective I think this is good to go. I ran the build and found, that the new icon is present in the

[GitHub] lkishalmi commented on issue #1061: [NETBEANS-168] Simple least intrustive patch prevent IDE to burn CPU on broken symlinks.

lkishalmi commented on issue #1061: [NETBEANS-168] Simple least intrustive patch prevent IDE to burn CPU on broken symlinks. URL: https://github.com/apache/incubator-netbeans/pull/1061#issuecomment-450754458 Well, this patch is based on [Ivan Friedländer comments on

[GitHub] jlahoda commented on issue #1066: Test change.

jlahoda commented on issue #1066: Test change. URL: https://github.com/apache/incubator-netbeans/pull/1066#issuecomment-450753115 Sorry, wrong repository. This is an automated message from the Apache Git Service. To respond

[GitHub] jlahoda opened a new pull request #1066: Test change.

jlahoda opened a new pull request #1066: Test change. URL: https://github.com/apache/incubator-netbeans/pull/1066 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and

[GitHub] jlahoda closed pull request #1066: Test change.

jlahoda closed pull request #1066: Test change. URL: https://github.com/apache/incubator-netbeans/pull/1066 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from

[GitHub] jlahoda opened a new pull request #1066: Test change.

jlahoda opened a new pull request #1066: Test change. URL: https://github.com/apache/incubator-netbeans/pull/1066 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and

[GitHub] matthiasblaesing commented on issue #1065: add a search in the "customize toolbar" dialog

matthiasblaesing commented on issue #1065: add a search in the "customize toolbar" dialog URL: https://github.com/apache/incubator-netbeans/pull/1065#issuecomment-450750107 I have two formal replies: - this changeset is based on a _very_ old version (hence the conflicts) - the base of

[GitHub] emilianbold commented on issue #1065: add a search in the "customize toolbar" dialog

emilianbold commented on issue #1065: add a search in the "customize toolbar" dialog URL: https://github.com/apache/incubator-netbeans/pull/1065#issuecomment-450745445 PS: I see GitHub complaining that there are some 'Conflicting files'. So, make sure you also rebase your code perhaps?

[GitHub] emilianbold commented on a change in pull request #1065: add a search in the "customize toolbar" dialog

emilianbold commented on a change in pull request #1065: add a search in the "customize toolbar" dialog URL: https://github.com/apache/incubator-netbeans/pull/1065#discussion_r244643389 ## File path:

[GitHub] emilianbold commented on issue #1065: add a search in the "customize toolbar" dialog

emilianbold commented on issue #1065: add a search in the "customize toolbar" dialog URL: https://github.com/apache/incubator-netbeans/pull/1065#issuecomment-450745265 > so should i close this and re-submit the PR? No, you can just (force) push the changes to your peterremote1980

[GitHub] peterremote1980 commented on issue #1065: add a search in the "customize toolbar" dialog

peterremote1980 commented on issue #1065: add a search in the "customize toolbar" dialog URL: https://github.com/apache/incubator-netbeans/pull/1065#issuecomment-450744970 so should i close this and re-submit the PR? This

[GitHub] peterremote1980 commented on a change in pull request #1065: add a search in the "customize toolbar" dialog

peterremote1980 commented on a change in pull request #1065: add a search in the "customize toolbar" dialog URL: https://github.com/apache/incubator-netbeans/pull/1065#discussion_r244643219 ## File path:

[GitHub] peterremote1980 commented on a change in pull request #1065: add a search in the "customize toolbar" dialog

peterremote1980 commented on a change in pull request #1065: add a search in the "customize toolbar" dialog URL: https://github.com/apache/incubator-netbeans/pull/1065#discussion_r244643222 ## File path:

[GitHub] peterremote1980 commented on a change in pull request #1065: add a search in the "customize toolbar" dialog

peterremote1980 commented on a change in pull request #1065: add a search in the "customize toolbar" dialog URL: https://github.com/apache/incubator-netbeans/pull/1065#discussion_r244643215 ## File path:

[GitHub] emilianbold commented on issue #1061: [NETBEANS-168] Simple least intrustive patch prevent IDE to burn CPU on broken symlinks.

emilianbold commented on issue #1061: [NETBEANS-168] Simple least intrustive patch prevent IDE to burn CPU on broken symlinks. URL: https://github.com/apache/incubator-netbeans/pull/1061#issuecomment-450744711 How is this related to the nb-android work here

[GitHub] emilianbold commented on a change in pull request #1065: add a search in the "customize toolbar" dialog

emilianbold commented on a change in pull request #1065: add a search in the "customize toolbar" dialog URL: https://github.com/apache/incubator-netbeans/pull/1065#discussion_r244642616 ## File path:

[GitHub] emilianbold commented on a change in pull request #1065: add a search in the "customize toolbar" dialog

emilianbold commented on a change in pull request #1065: add a search in the "customize toolbar" dialog URL: https://github.com/apache/incubator-netbeans/pull/1065#discussion_r244642626 ## File path:

[GitHub] emilianbold commented on a change in pull request #1065: add a search in the "customize toolbar" dialog

emilianbold commented on a change in pull request #1065: add a search in the "customize toolbar" dialog URL: https://github.com/apache/incubator-netbeans/pull/1065#discussion_r244642643 ## File path:

[GitHub] emilianbold commented on a change in pull request #1065: add a search in the "customize toolbar" dialog

emilianbold commented on a change in pull request #1065: add a search in the "customize toolbar" dialog URL: https://github.com/apache/incubator-netbeans/pull/1065#discussion_r244642623 ## File path:

[GitHub] matthiasblaesing commented on issue #1058: [NETBEANS-1834] Fix possible race condition enabling actions in explorer

matthiasblaesing commented on issue #1058: [NETBEANS-1834] Fix possible race condition enabling actions in explorer URL: https://github.com/apache/incubator-netbeans/pull/1058#issuecomment-450743323 The change looks sane and from my POV will work. The unittests that fail after the patch,

[GitHub] juneau001 commented on issue #1065: add a search in the "customize toolbar" dialog

juneau001 commented on issue #1065: add a search in the "customize toolbar" dialog URL: https://github.com/apache/incubator-netbeans/pull/1065#issuecomment-450739616 Thanks for the PR. It looks like the license headers were removed. I believe that those should be added back before this

[GitHub] peterremote1980 opened a new pull request #1065: add a search in the "customize toolbar" dialog

peterremote1980 opened a new pull request #1065: add a search in the "customize toolbar" dialog URL: https://github.com/apache/incubator-netbeans/pull/1065 add a search in the "customize toolbar" dialog This is an automated