[GitHub] jlahoda commented on issue #1068: Improve building of platform on JDK11

jlahoda commented on issue #1068: Improve building of platform on JDK11 URL: https://github.com/apache/incubator-netbeans/pull/1068#issuecomment-451073652 Not sure why you are seeing that fallback (of specifically test.nbjdk.home, nbjdk.home sometimes falls back to ${java.home}), but

[GitHub] lkishalmi commented on issue #1064: Snapshot of APIs as of release 10.0

lkishalmi commented on issue #1064: Snapshot of APIs as of release 10.0 URL: https://github.com/apache/incubator-netbeans/pull/1064#issuecomment-451057038 Well, it seems the method how this was done is documented. i see no reason not to integrate this into master. So I approve this

[GitHub] jtulach commented on issue #1064: Snapshot of APIs as of release 10.0

jtulach commented on issue #1064: Snapshot of APIs as of release 10.0 URL: https://github.com/apache/incubator-netbeans/pull/1064#issuecomment-451052382 Can I get some approvals, please? Although these checks were already in for the NetBeans Platform and nobody found a problem, The

[GitHub] jtulach commented on issue #1068: Improve building of platform on JDK11

jtulach commented on issue #1068: Improve building of platform on JDK11 URL: https://github.com/apache/incubator-netbeans/pull/1068#issuecomment-451050192 The job run [#10](https://builds.apache.org/job/incubator-netbeans-linux-jdk11/10) finished with 110 failed tests. Anyone who cares

[GitHub] jtulach commented on issue #1068: Improve building of platform on JDK11

jtulach commented on issue #1068: Improve building of platform on JDK11 URL: https://github.com/apache/incubator-netbeans/pull/1068#issuecomment-451049983 The problem is that without specifying test.nbjdk.home the tests fallback to JAVA_HOME and not to nbjdk.home. I found that confusing.

[GitHub] oyarzun closed pull request #91: Fix nmb-maven-plugin docs url

oyarzun closed pull request #91: Fix nmb-maven-plugin docs url URL: https://github.com/apache/incubator-netbeans-website/pull/91 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] mcdonnell-john closed pull request #1054: [NETBEANS-1803] Don't list ALv2 licensed files in LICENSE file

mcdonnell-john closed pull request #1054: [NETBEANS-1803] Don't list ALv2 licensed files in LICENSE file URL: https://github.com/apache/incubator-netbeans/pull/1054 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] jlahoda commented on issue #1068: Improve building of platform on JDK11

jlahoda commented on issue #1068: Improve building of platform on JDK11 URL: https://github.com/apache/incubator-netbeans/pull/1068#issuecomment-450958470 Feel free to make test.nbjdk.home fallback to to nbjdk.home, although I am not quite sure if there's a point. The launcher used to run

[GitHub] jtulach commented on issue #1068: Improve building of platform on JDK11

jtulach commented on issue #1068: Improve building of platform on JDK11 URL: https://github.com/apache/incubator-netbeans/pull/1068#issuecomment-450945725 Why isn't `test.nbjdk.home` derived from value of `nbjdk.home`? This

[GitHub] arsi-apli commented on issue #1061: [NETBEANS-168] Simple least intrustive patch prevent IDE to burn CPU on broken symlinks.

arsi-apli commented on issue #1061: [NETBEANS-168] Simple least intrustive patch prevent IDE to burn CPU on broken symlinks. URL: https://github.com/apache/incubator-netbeans/pull/1061#issuecomment-450927092 I found the best place to patch the file event system. Look at the last

[GitHub] jlahoda commented on a change in pull request #1068: Improve building of platform on JDK11

jlahoda commented on a change in pull request #1068: Improve building of platform on JDK11 URL: https://github.com/apache/incubator-netbeans/pull/1068#discussion_r244792126 ## File path: nbbuild/build.xml ## @@ -460,6 +465,8 @@ Hg ID:${hg.id}

[GitHub] srdo opened a new pull request #1069: NETBEANS-1744: Support Run/Debug Focused Test Method for @Nested JUni…

srdo opened a new pull request #1069: NETBEANS-1744: Support Run/Debug Focused Test Method for @Nested JUni… URL: https://github.com/apache/incubator-netbeans/pull/1069 …t 5 test classes in Maven projects The reason this doesn't work currently is that Netbeans assumes all test

[GitHub] gilbertoca edited a comment on issue #1065: add a search in the "customize toolbar" dialog

gilbertoca edited a comment on issue #1065: add a search in the "customize toolbar" dialog URL: https://github.com/apache/incubator-netbeans/pull/1065#issuecomment-450854735 > This branch is 2 commits ahead, 969 commits behind apache:master. Your fork is very old. You have two

[GitHub] gilbertoca commented on issue #1065: add a search in the "customize toolbar" dialog

gilbertoca commented on issue #1065: add a search in the "customize toolbar" dialog URL: https://github.com/apache/incubator-netbeans/pull/1065#issuecomment-450854735 > This branch is 2 commits ahead, 969 commits behind apache:master. Your fork is very old.

[GitHub] asfgit closed pull request #1068: Improve building of platform on JDK11

asfgit closed pull request #1068: Improve building of platform on JDK11 URL: https://github.com/apache/incubator-netbeans/pull/1068 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] jtulach commented on issue #1068: Improve building of platform on JDK11

jtulach commented on issue #1068: Improve building of platform on JDK11 URL: https://github.com/apache/incubator-netbeans/pull/1068#issuecomment-450849691 I've created new [jenkins job](https://builds.apache.org/job/incubator-netbeans-linux-jdk11/) to test platform on JDK11. Once this PR

[GitHub] jtulach opened a new pull request #1068: Improve building of platform on JDK11

jtulach opened a new pull request #1068: Improve building of platform on JDK11 URL: https://github.com/apache/incubator-netbeans/pull/1068 Make sure one can build with: ```bash incubator-netbeans$ ant build-platform -Dnbjdk.home=$HOME/bin/jdk-11/ ```